cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 05:00:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Stops Starlight Condensation from runtiming to hell and back (+ cleans up the code a bit) [MDB IGNORE] (#9993)

Browse Source 
* Stops Starlight Condensation from runtiming to hell and back (+ cleans up the code a bit)  (#63300)

* Stops Starlight Condensation from runtiming to hell and back (+ cleans up the code a bit)

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
This commit is contained in:
SkyratBot
2021-12-10 06:52:00 -05:00
committed by GitHub
co-authored by MrMelbert
parent f25ff9fb74
commit e6ca5c698e
1 changed files with 30 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/diseases/advance/symptoms/heal.dm
+30 -10
View File
@@ -85,24 +85,44 @@
var/area/area_to_check = get_area(turf_to_check)
var/levels_of_glass = 0 // Since starlight condensation only works 2 tiles to the side anyways, it shouldn't work with like 100 z-levels of glass
while(levels_of_glass <= STARLIGHT_MAX_RANGE)
if(isspaceturf(turf_to_check) || (area_to_check.outdoors && direction == ZTRAIT_DOWN)) // Outdoors covers lavaland and unroofed areas but with tiles under, while space covers normal space and those caused by explosions, if there is a floor tile when checking above, that means a roof exists so the outdoors should only work downwards
// Outdoors covers lavaland and unroofed areas but with tiles under,
// while space covers normal space and those caused by explosions,
// if there is a floor tile when checking above, that means
// a roof exists so the outdoors should only work downwards
if(isspaceturf(turf_to_check) || (area_to_check.outdoors && direction == ZTRAIT_DOWN))
if (levels_of_glass)
return STARLIGHT_CAN_HEAL_WITH_PENALTY // glass gives penalty
return STARLIGHT_CAN_HEAL // if can heal fully
return STARLIGHT_CAN_HEAL_WITH_PENALTY // Glass gives a penalty.
return STARLIGHT_CAN_HEAL // No glass = can heal fully.
// Our turf is transparent, but it's NOT openspace - it's something like glass which reduces power
if(istransparentturf(turf_to_check) && !(istype(turf_to_check, /turf/open/openspace)))
levels_of_glass += 1
// Our turf is transparent OR openspace - we can check higher or lower z-levels
if(istransparentturf(turf_to_check) || istype(turf_to_check, /turf/open/openspace))
// Check above or below us
if(direction == ZTRAIT_UP)
turf_to_check = turf_to_check.above()
else
turf_to_check = turf_to_check.below()
if(!turf_to_check && (direction == ZTRAIT_DOWN || (direction == ZTRAIT_UP && area_to_check.outdoors))) // if does not exist, assume its space since space station if below, however when checking upwards, only assume that its space if the area is outdoors
if(levels_of_glass)
return STARLIGHT_CAN_HEAL_WITH_PENALTY
return STARLIGHT_CAN_HEAL
area_to_check = get_area(turf_to_check)
continue
return STARLIGHT_CANNOT_HEAL // hit a non-space non-transparent turf
// If we found a turf above or below us,
// then we can rerun the loop on the newly found turf / area
// (Probably, with +1 to levels_of_glass)
if(turf_to_check)
area_to_check = get_area(turf_to_check)
continue
// If we didn't find a turf above or below us -
// Checking below, we assume that space is below us (as we're standing on station)
// Checking above, we check that the area is "outdoors" before assuming if it is space or not.
else
if(direction == ZTRAIT_DOWN || (direction == ZTRAIT_UP && area_to_check.outdoors))
if (levels_of_glass)
return STARLIGHT_CAN_HEAL_WITH_PENALTY
return STARLIGHT_CAN_HEAL
return STARLIGHT_CANNOT_HEAL // Hit a non-space, Non-transparent turf - no healsies
/datum/symptom/heal/starlight/proc/CanTileHeal(turf/original_turf, satisfied_with_penalty)
var/current_heal_level = CanTileHealDirectional(original_turf, ZTRAIT_DOWN)