Captain office access can't magically grant you AA anymore (#1615)

## About The Pull Request

See name, you can no longer give yourself ID modification access just by
having captain access

## Why It's Good For The Game

This is unintended behaviour, and results in certain roles abusing it to
grant themselves access without going through the respective heads of
staff.

This was already discussed in the team and with staff before. We
concluded it wasn't needed then and boiled it down to a specific player
issue. But since it keeps resurfacing repeatedly and shouldn't happen in
the first place, it is to be killed.

## Changelog

🆑
fix: Captain office access can't magically grant you AA anymore
/🆑
This commit is contained in:
Waterpig
2024-06-28 10:17:21 +00:00
committed by GitHub
parent b727f60789
commit e8c275927a
@@ -59,6 +59,10 @@
for(var/access_as_text in managers)
var/list/info = managers[access_as_text]
var/access = access_as_text
// BUBBER EDIT START - No weird captain bypass
if(access == ACCESS_CAPTAIN)
continue
// BUBBER EDIT END
if((access in auth_card.access) && ((target_dept in info["regions"]) || !target_dept))
region_access |= info["regions"]
job_templates |= info["templates"]