Fixes sdql2 applying comparison operators to lists incorrectly (#22627)

* Fixes sdql2 applying comparison operators to lists incorrectly

* Add a comment to prevent future reverts

Just in case

* Removes oranges comment

I'm fucking sick and tired of this shit where people touch code they don't understand.

By adding the comment, you imply that every bit of code thats the same without the same comment is safe to change, but thats not true.

These landmines are important for teaching new coders not to fuck with shit they don't understand.

When you see something and go "why is it doing it that way". the answer is not to go "fuck it, it seems to still work when i change it" the answer is to leave it the fuck alone until it doing it that way is actually an issue.

How many god damn bugs have we had this last year from non-changes like that. I'm sick of them.
This commit is contained in:
Kyle Spier-Swenson
2017-01-04 10:11:36 +13:00
committed by oranges
parent 6b66430958
commit e9b7bfb389
+7 -7
View File
@@ -304,19 +304,19 @@
if(op != "")
switch(op)
if("+")
result += val
result = (result + val)
if("-")
result -= val
result = (result - val)
if("*")
result *= val
result = (result * val)
if("/")
result /= val
result = (result / val)
if("&")
result &= val
result = (result & val)
if("|")
result |= val
result = (result | val)
if("^")
result ^= val
result = (result ^ val)
if("=", "==")
result = (result == val)
if("!=", "<>")