cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-30 08:37:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improves the PR announcement message grammar (#91509)

Browse Source 
## About The Pull Request

This makes it so the PR announcements have better grammar: they'll
actually say "Pull Request merged by [user]: ..." instead of the current
"Pull Request merged [user]: ..."

also got rid of a weird extra space

i've barely coded C# in a while so this prolly sucks, sorry.

## Why It's Good For The Game

because "Pull Request merged Absolucy" annoys me.

## Changelog
🆑
spellcheck: PR announcements should now say "X merged by Y: ..." instead
of "X merged Y: ..."
/🆑
This commit is contained in:
Lucy
2025-06-07 12:12:29 -04:00
committed by GitHub
parent ac20c39834
commit efbd35d2f0
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/Tgstation.PRAnnouncer/PRAnnounceQuery.cs
+7 -1
View File
@@ -46,7 +46,13 @@ namespace Tgstation.PRAnnouncer
PullRequest = new PRAnnouncePayloadPullRequest(pullRequestEvent.PullRequest),
};
announce = $"[{pullRequestEvent.PullRequest.Base.Repo.FullName}] Pull Request {(pullRequestEvent.PullRequest.Merged == true ? "merged" : (pullRequestEvent.Action ?? "(NULL ACTION)"))} {HtmlEncoder.Default.Encode(pullRequestEvent.Sender?.Login ?? "(NULL)")}: <a href=\"{pullRequestEvent.PullRequest.HtmlUrl}\"> #{pullRequestEvent.PullRequest.Number} {HtmlEncoder.Default.Encode($"{pullRequestEvent.PullRequest.User.Login} - {pullRequestEvent.PullRequest.Title}")}";
var action = pullRequestEvent.PullRequest.Merged == true ? "merged" : pullRequestEvent.Action;
if (action != null && pullRequestEvent.Sender?.Login != null)
{
action += $" by {HtmlEncoder.Default.Encode(pullRequestEvent.Sender.Login)}";
}
announce = $"[{pullRequestEvent.PullRequest.Base.Repo.FullName}] Pull Request {action ?? "(NULL ACTION)"}: <a href=\"{pullRequestEvent.PullRequest.HtmlUrl}\">#{pullRequestEvent.PullRequest.Number} {HtmlEncoder.Default.Encode($"{pullRequestEvent.PullRequest.User.Login} - {pullRequestEvent.PullRequest.Title}")}</a>";
}
/// <summary>