cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-20 12:35:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix my fix (#44750)

Browse Source 
I messed up #44748 minorly. I check for a string in a list of a numbers because I don't convert it again (job is a if scoped var in the above if)
This commit is contained in:
Kyle Spier-Swenson
2019-06-22 13:59:43 -07:00
committed by oranges
parent 2522037c8e
commit efec302bfd
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/client/client_procs.dm
+5 -4
View File
@@ -37,12 +37,13 @@ GLOBAL_LIST_INIT(blacklisted_builds, list(
return
// asset_cache
var/asset_cache_job
if(href_list["asset_cache_confirm_arrival"])
var/job = round(text2num(href_list["asset_cache_confirm_arrival"]))
asset_cache_job = round(text2num(href_list["asset_cache_confirm_arrival"]))
//because we skip the limiter, we have to make sure this is a valid arrival and not somebody tricking us
// into letting append to a list without limit.
if (job > 0 && job <= last_asset_job && !(job in completed_asset_jobs))
completed_asset_jobs += job
if (asset_cache_job > 0 && asset_cache_job <= last_asset_job && !(asset_cache_job in completed_asset_jobs))
completed_asset_jobs += asset_cache_job
return
var/mtl = CONFIG_GET(number/minute_topic_limit)
@@ -82,7 +83,7 @@ GLOBAL_LIST_INIT(blacklisted_builds, list(
log_href("[src] (usr:[usr]\[[COORD(usr)]\]) : [hsrc ? "[hsrc] " : ""][href]")
//byond bug ID:2256651
if (href_list["asset_cache_confirm_arrival"] && href_list["asset_cache_confirm_arrival"] in completed_asset_jobs)
if (asset_cache_job && asset_cache_job in completed_asset_jobs)
to_chat(src, "<span class='danger'>An error has been detected in how your client is receiving resources. Attempting to correct.... (If you keep seeing these messages you might want to close byond and reconnect)</span>")
src << browse("...", "window=asset_cache_browser")