cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-20 20:45:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix station trait buttons on square viewport (#93953)

Browse Source 
## About The Pull Request

Fixes #93887 by checking the client's viewport when positioning the
station trait buttons.

## Why It's Good For The Game

Fixes bug.

## Changelog

🆑 LT3
fix: Station trait buttons display correctly on non-widescreen clients
/🆑
This commit is contained in:
LT3
2025-11-15 08:58:04 -08:00
committed by GitHub
parent 1da86cb8d0
commit f4657828c1
1 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/_onclick/hud/new_player.dm
+17 -5
View File
@@ -2,6 +2,10 @@
#define SHUTTER_WAIT_DURATION 0.2 SECONDS
/// Maximum number of station trait buttons we will display, please think hard before creating scenarios where there are more than this
#define MAX_STATION_TRAIT_BUTTONS_VERTICAL 3
#define TRAIT_BUTTON_Y_ORIGIN 397
#define TRAIT_BUTTON_X_ORIGIN 233
#define TRAIT_BUTTON_OFFSET 27
#define SQUARE_VIEWPORT_OFFSET 64
/datum/hud/new_player
///Whether the menu is currently on the client's screen or not
@@ -33,6 +37,7 @@
static_inventory += start_button
start_button.RegisterSignal(src, COMSIG_HUD_LOBBY_COLLAPSED, TYPE_PROC_REF(/atom/movable/screen/lobby, collapse_button))
start_button.RegisterSignal(src, COMSIG_HUD_LOBBY_EXPANDED, TYPE_PROC_REF(/atom/movable/screen/lobby, expand_button))
RegisterSignal(mymob, COMSIG_VIEWDATA_UPDATE, PROC_REF(place_station_trait_buttons))
/// Load and then display the buttons for relevant station traits
/datum/hud/new_player/proc/show_station_trait_buttons()
@@ -54,14 +59,17 @@
/// Display the buttosn for relevant station traits.
/datum/hud/new_player/proc/place_station_trait_buttons()
SIGNAL_HANDLER
if(hud_version != HUD_STYLE_STANDARD || !mymob?.client)
return
var/y_offset = 397
var/x_offset = 233
var/y_button_offset = 27
var/x_button_offset = -27
var/y_offset = TRAIT_BUTTON_Y_ORIGIN
var/x_offset = TRAIT_BUTTON_X_ORIGIN
var/y_button_offset = TRAIT_BUTTON_OFFSET
var/x_button_offset = -TRAIT_BUTTON_OFFSET
var/iteration = 0
if(mymob.client.view == SQUARE_VIEWPORT_SIZE)
x_offset -= SQUARE_VIEWPORT_OFFSET
for(var/trait in shown_station_trait_buttons)
var/atom/movable/screen/lobby/button/sign_up/sign_up_button = shown_station_trait_buttons[trait]
iteration++
@@ -69,7 +77,7 @@
mymob.client.screen |= sign_up_button
if (iteration >= MAX_STATION_TRAIT_BUTTONS_VERTICAL)
iteration = 0
y_offset = 397
y_offset = TRAIT_BUTTON_Y_ORIGIN
x_offset += x_button_offset
else
y_offset += y_button_offset
@@ -806,3 +814,7 @@
#undef SHUTTER_MOVEMENT_DURATION
#undef SHUTTER_WAIT_DURATION
#undef MAX_STATION_TRAIT_BUTTONS_VERTICAL
#undef TRAIT_BUTTON_Y_ORIGIN
#undef TRAIT_BUTTON_X_ORIGIN
#undef TRAIT_BUTTON_OFFSET
#undef SQUARE_VIEWPORT_OFFSET