cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-22 04:30:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Completely Redoes Underground Outpost 45 Atmospherics (#76244)

Browse Source 
Merging this is required for #76245

## About The Pull Request

Hey there,

Every time this away mission got loaded, we got some really wacky
runtimes like the following:

```txt
[2023-06-22 04:38:37.613] RUNTIME: runtime error: list index out of bounds
 - proc name: set pipenet (/obj/machinery/atmospherics/components/set_pipenet)
 -   source file: components_base.dm,167
 -   usr: null
 -   src: UO45 Mining omni air scrubber ... (/obj/machinery/atmospherics/components/unary/vent_scrubber/on)
 -   src.loc: the floor (136,101,12) (/turf/open/floor/iron)
 -   call stack:
 - UO45 Mining omni air scrubber ... (/obj/machinery/atmospherics/components/unary/vent_scrubber/on): set pipenet(/datum/pipeline (/datum/pipeline), the red scrubbers pipe (/obj/machinery/atmospherics/pipe/smart/manifold4w/scrubbers/hidden))
 - /datum/pipeline (/datum/pipeline): build pipeline blocking(UO45 Gateway omni air scrubber... (/obj/machinery/atmospherics/components/unary/vent_scrubber/on))
 - Atmospherics (/datum/controller/subsystem/air): setup pipenets()
 - Atmospherics (/datum/controller/subsystem/air): Initialize()
 - Master (/datum/controller/master): init subsystem(Atmospherics (/datum/controller/subsystem/air))
 - Master (/datum/controller/master): Initialize(10, 0, 1)
 - 
[2023-06-22 04:38:37.637] RUNTIME: runtime error: addMachineryMember: Nonexistent (empty list) or null machinery gasmix added to pipeline datum from �UO45 Mining omni air scrubber T2AiT which is of type /obj/machinery/atmospherics/components/unary/vent_scrubber/on. Nearby: (136, 101, 12) (code/modules/atmospherics/machinery/datum_pipeline.dm:134)
 - proc name:  stack trace (/proc/_stack_trace)
 -   source file: stack_trace.dm,4
 -   usr: (src)
 -   src: null
 -   call stack:
 -  stack trace("addMachineryMember: Nonexisten...", "code/modules/atmospherics/mach...", 134)
 - /datum/pipeline (/datum/pipeline): add machinery member(UO45 Mining omni air scrubber ... (/obj/machinery/atmospherics/components/unary/vent_scrubber/on))
 - /datum/pipeline (/datum/pipeline): build pipeline blocking(UO45 Gateway omni air scrubber... (/obj/machinery/atmospherics/components/unary/vent_scrubber/on))
 - Atmospherics (/datum/controller/subsystem/air): setup pipenets()
 - Atmospherics (/datum/controller/subsystem/air): Initialize()
 - Master (/datum/controller/master): init subsystem(Atmospherics (/datum/controller/subsystem/air))
 - Master (/datum/controller/master): Initialize(10, 0, 1)
```

I'm going to chalk it up to how absolutely goreifying the old UO45
atmospherics was, so I just redid it to modern standards. Should be a
lot cleaner now, may have missed a few things so let me know.
## Why It's Good For The Game

Looks way cleaner, actual modern mapping standards for a map that hasn't
been touched in a _long_ while, less runtimes!!!
## Changelog
man does anyone even like this away mission? it's not player changing
enough i fear

lmk if i missed something, but it stopped generating runtimes so i'm
calling it epic swag
This commit is contained in:
san7890
2023-07-02 09:09:27 -07:00
committed by GitHub
parent 0a09910555
commit f5a5e6ecd7
1 changed files with 1549 additions and 2960 deletions
Download Patch File Download Diff File Expand all files Collapse all files
_maps/RandomZLevels/undergroundoutpost45.dmm
+1549 -2960
View File
File diff suppressed because it is too large Load Diff