[NO GBP] Fixes the venomous element for projectiles, invisible arrows and something off with envenomable casings. (#76565)

## About The Pull Request
See #76551. The on hit effect component was treating the `hit_limb` arg
of the projectile on_hit signals as if it were a bodypart item rather
than a string. This wasn't my fault.
Also, invisible arrows because I forgot to set up their definition of
update_icon_state() and base icon state var.
Lastly, the envenomable casing registering a signal on the wrong atom,
and the arrow bullet subtype being defined twice.

## Why It's Good For The Game
This will close #76551.

## Changelog

🆑
fix: Fixes venomous projectiles for real, and invisible arrow sprites.
/🆑
This commit is contained in:
Ghom
2023-07-10 14:00:01 +02:00
committed by GitHub
parent aefc25579a
commit f5bfff758d
3 changed files with 10 additions and 15 deletions
@@ -4,6 +4,7 @@
desc = "Stabby Stabman!"
icon = 'icons/obj/weapons/guns/bows/arrows.dmi'
icon_state = "arrow"
base_icon_state = "arrow"
inhand_icon_state = "arrow"
projectile_type = /obj/projectile/bullet/arrow
flags_1 = NONE
@@ -18,17 +19,11 @@
AddElement(/datum/element/envenomable_casing)
AddElement(/datum/element/caseless, reusable)
///base arrow projectile
/obj/projectile/bullet/arrow
name = "arrow"
desc = "Ow! Get it out of me!"
icon = 'icons/obj/weapons/guns/bows/arrows.dmi'
icon_state = "arrow_projectile"
damage = 50
speed = 1
range = 25
/obj/item/ammo_casing/arrow/update_icon_state()
. = ..()
icon_state = "[base_icon_state]"
///*sigh* NON-REUSABLE base arrow projectile. In the future: let's componentize the reusable subtype, jesus
///base arrow projectile
/obj/projectile/bullet/arrow
name = "arrow"
desc = "Ow! Get it out of me!"