cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-18 03:26:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Moves space initialization check to unit test - Saves 0.065s of init time [MDB IGNORE] (#18126)

Browse Source 
* Moves space initialization check to unit test - Saves 0.065s of init time (#71796)

This hasn't been hit in a long time and this is an extremely hot proc,
doing these checks in unit tests should catch any cases, though
unlikely.

This has zero cost at runtime because `if (FALSE)` statically compiles
out.

* Moves space initialization check to unit test - Saves 0.065s of init time

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
This commit is contained in:
SkyratBot
2022-12-14 05:59:00 +01:00
committed by GitHub
parent 3d15f0e83f
commit fbc214d26a
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/game/turfs/open/space/space.dm
+3 -2
View File
@@ -55,8 +55,9 @@
icon_state = SPACE_ICON_STATE(x, y, z)
air = space_gas
if(flags_1 & INITIALIZED_1)
stack_trace("Warning: [src]([type]) initialized multiple times!")
if (PERFORM_ALL_TESTS(focus_only/multiple_space_initialization))
if(flags_1 & INITIALIZED_1)
stack_trace("Warning: [src]([type]) initialized multiple times!")
flags_1 |= INITIALIZED_1
code/modules/unit_tests/focus_only_tests.dm
+3
View File
@@ -15,5 +15,8 @@
/// Checks that every icon sent to vending machines is valid
/datum/unit_test/focus_only/invalid_vending_machine_icon_states
/// Checks that space does not initialize multiple times
/datum/unit_test/focus_only/multiple_space_initialization
/// Checks that smoothing_groups and canSmoothWith are properly sorted in /atom/Initialize
/datum/unit_test/focus_only/sorted_smoothing_groups