cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-25 22:19:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make PDAs Able to Punch GAP Cards, Buff Payout to 150cr (#2465)

Browse Source 
## About The Pull Request

Tin, doesn't remove the puncher from code because I don't feel like
removing it from maps (if it exists), also gives the option for bussing
I suppose.

Requires head access to puch GAP cards. Not much else to comment on,
really.

## Why It's Good For The Game

GAP cards are almost never used, and heads ditch the stamp like it's
hot. Let's just clear up some of the head clutter and instead make it
PDA bound.

Also let's make it worth 150cr, cause 100cr seems a little cheap. This
makes the max possible payout now 900 instead of 600.

## Proof Of Testing
<details>
<summary>Screenshots/Videos</summary>



https://github.com/user-attachments/assets/6f67b09e-6706-4e40-9720-868fedf73b06


</details>

## Changelog
🆑
add: Added new mechanics or gameplay changes
add: Added more things
del: Heads no longer start with GAP punchers.
qol: Heads (anyone with command access) can now use their PDA to stamp
GAP cards.
balance: Good Assistant Point cards now pay out 150cr per stamp.
/🆑
This commit is contained in:
Rimi Nosha
2024-11-18 19:30:49 +00:00
committed by GitHub
parent 4d22f29b6e
commit ff028fadc0
1 changed files with 13 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modular_skyrat/modules/cargo/code/items/gbp_punchcard.dm
+13 -47
View File
@@ -1,4 +1,4 @@
#define GBP_PUNCH_REWARD 100
#define GBP_PUNCH_REWARD 150
/obj/item/card/id
COOLDOWN_DECLARE(gbp_redeem_cooldown)
@@ -6,7 +6,7 @@
/obj/item/gbp_punchcard
name = "Good Assistant Points punchcard"
desc = "The Good Assistant Points program is designed to supplement the income of otherwise unemployed or unpaid individuals on board Nanotrasen vessels and colonies.<br>\
Simply get your punchcard stamped by a Head of Staff to earn 100 credits per punch upon turn-in at a Good Assistant Point machine!<br>\
Simply get your punchcard stamped by a Head of Staff's PDA to earn 150 credits per punch upon turn-in at a Good Assistant Point machine!<br>\
Maximum of six punches per any given card. Card replaced upon redemption of existing card. Do not lose your punchcard."
icon = 'modular_skyrat/modules/cargo/icons/punchcard.dmi'
icon_state = "punchcard_0"
@@ -18,12 +18,21 @@
/obj/item/gbp_punchcard/starting
icon_state = "punchcard_1"
punches = 1 // GBP_PUNCH_REWARD credits by default
req_access = list(ACCESS_COMMAND)
/obj/item/gbp_punchcard/attackby(obj/item/attacking_item, mob/user, params)
. = ..()
if(istype(attacking_item, /obj/item/gbp_puncher))
var/is_valid_item = istype(attacking_item, /obj/item/gbp_puncher)
if(!is_valid_item && istype(attacking_item, /obj/item/modular_computer/pda))
var/obj/item/modular_computer/pda/pda = attacking_item
is_valid_item = check_access(pda.computer_id_slot)
if (!is_valid_item)
balloon_alert(user, "no access!")
if(is_valid_item)
if(!COOLDOWN_FINISHED(src, gbp_punch_cooldown))
balloon_alert(user, "cooldown! [DisplayTimeText(COOLDOWN_TIMELEFT(src, gbp_punch_cooldown))]")
balloon_alert(user, "cooldown! ([DisplayTimeText(COOLDOWN_TIMELEFT(src, gbp_punch_cooldown))])")
return
if(punches < max_punches)
punches++
@@ -123,49 +132,6 @@
req_components = list(
/datum/stock_part/servo = 1)
/datum/outfit/job/rd/pre_equip(mob/living/carbon/human/human, visualsOnly)
. = ..()
backpack_contents += list(
/obj/item/gbp_puncher = 1
)
/datum/outfit/job/hos/pre_equip(mob/living/carbon/human/human, visualsOnly)
. = ..()
backpack_contents += list(
/obj/item/gbp_puncher = 1,
)
/datum/outfit/job/hop/pre_equip(mob/living/carbon/human/human, visualsOnly)
. = ..()
backpack_contents += list(
/obj/item/gbp_puncher = 1,
)
/datum/outfit/job/ce/pre_equip(mob/living/carbon/human/human, visualsOnly)
. = ..()
backpack_contents += list(
/obj/item/gbp_puncher = 1,
)
/datum/outfit/job/cmo/pre_equip(mob/living/carbon/human/human, visualsOnly)
. = ..()
backpack_contents += list(
/obj/item/gbp_puncher = 1,
)
/datum/outfit/job/captain/pre_equip(mob/living/carbon/human/human, visualsOnly)
. = ..()
backpack_contents += list(
/obj/item/gbp_puncher = 1,
)
/datum/outfit/job/quartermaster/pre_equip(mob/living/carbon/human/human, visualsOnly)
. = ..()
backpack_contents += list(
/obj/item/gbp_puncher = 1,
)
/datum/outfit/job/assistant/pre_equip(mob/living/carbon/human/human, visualsOnly)
. = ..()
backpack_contents += list(/obj/item/gbp_punchcard/starting)