Commit Graph

33004 Commits

Author SHA1 Message Date
ShadeAware
02aa2a94fb Good. (#1909) 2020-11-28 21:43:48 +00:00
ShadeAware
f02b02dfa9 [Modular] Ports over our old chemicals. (#1864)
* Get fucked, cobbychem.

* Click-Clack

* C u m .

* Update readme.md

* Update oldchem_medicines.dm

* Update oldchem_reactions.dm

* Update code/modules/reagents/reagent_containers/borghydro.dm

Co-authored-by: Gandalf <jzo123@hotmail.com>

* Fucking there

* Unga

you people have skin made of tissue paper

Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-11-28 21:42:19 +00:00
Azarak
491d9f48a2 aaa (#1910) 2020-11-28 17:18:33 +00:00
Azarak
e1935c5cb9 Revert "Panicbunker fixes (#1838)" (#1911)
This reverts commit 930ed8a4db.
2020-11-28 17:13:54 +00:00
IrkallaEpsilon
9a77148734 Bombards Split personality with an antigrain warhead (#1878)
* Bombards Split personality with an antigrain warhead

* Update split_personality.dm

* Meh Personality

Insert catgirl erp descriptor as argument.

* Update personality_commune.dm

* Update split_personality.dm

* Update split_personality.dm

* Update personality_commune.dm
2020-11-28 15:07:25 +01:00
SkyratBot
f969ce5e59 [MIRROR] Fixing robot upgrades not being removed from lists all times. (#1906)
* Fixing robot upgrades sometimes not being removed from lists. (#54842)

* Fixing robot upgrades not being removed from lists all times.

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2020-11-28 13:03:13 +01:00
SkyratBot
03d99de80c [MIRROR] Fixes Issues Regarding Finding Spider and Swarmer Spawns (#1905)
* Fixes Issues Regarding Finding Spider and Swarmer Spawns (#55054)

This PR fixes the issue where people couldn't teleport to spider egg clusters using the notification.

It also adds both the swarmer beacon and spider egg clusters to the ghost orbit menu. This should make it easier to find instances of both in cases where a player might miss the initial notification.

* Fixes Issues Regarding Finding Spider and Swarmer Spawns

Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com>
2020-11-28 13:02:10 +01:00
SkyratBot
a92fdde30e [MIRROR] Remove duplicate definitions of /obj/effect/ex_act, explicitly noop it (#1904)
* Remove duplicate definitions of /obj/effect/ex_act, explicitly noop it (#55076)

/obj/effect/ex_act had several different re-definitions to make it a noop. The original definition would randomly delete it, which is bad news when a lot of /obj/effects are just that--effects, that shouldn't be blown up.

The ones that actually do want to be blown up (like decals) already have their own implementations. The one in place was never ran, and nobody had problems with it.

* Remove duplicate definitions of /obj/effect/ex_act, explicitly noop it

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-11-28 12:59:11 +01:00
SkyratBot
c222cfa4c5 [MIRROR] Hauberoach's now properly give correct feedback if you're immune to their headspike. (#1903)
* Hauberoach's now properly give correct feedback if you're immune to their headspike. (#55079)

Hauberoaches now give a different, clearer line of dialog when stepped on by a pierce immune carbon mob.

* Hauberoach's now properly give correct feedback if you're immune to their headspike.

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2020-11-28 12:58:30 +01:00
SkyratBot
948ef10e89 [MIRROR] taming improvements (#1902)
* taming improvements (#55086)

tame var is now set to true on the tamed proc, not right before the tamed proc in feeding proc so if an admin atom proc calls tamed the mob is tamed
vatbeast no longer overrides its faction to neutral because it already sets the action to the tamer's

* taming improvements

Co-authored-by: Fikou <piotrbryla@onet.pl>
2020-11-28 12:58:04 +01:00
SkyratBot
0f5e079807 [MIRROR] Mech Ammo now properly respects ammo for custom materials. (#1901)
* Mech Ammo now properly respects ammo for custom materials. (#55095)

Mech code now does a basic check for the amount of remaining ammo to adjust the amount of custom materials of an ammo container based on the remaining ammo against the original amount of ammo.
When the ammo runs out, it's hard-set to 2000 iron as that's the value of the sheet of iron that it gets set to by the end.

* Mech Ammo now properly respects ammo for custom materials.

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2020-11-28 12:57:35 +01:00
SkyratBot
2f20342aa2 [MIRROR] recolored skeleton sprites (#1898)
* recolored skeleton sprites (#55185)

skeletons no longer have eye sprites
i recolored skeleton sprites a bit

* recolored skeleton sprites

Co-authored-by: Fikou <piotrbryla@onet.pl>
2020-11-28 12:56:01 +01:00
SkyratBot
64c0ecb13f [MIRROR] Changes grenade proc names to be more clear (#1897)
* Changes grenade proc names to be more clear (#55181)

Grenades have, for the longest time, used the proc name preprime() to refer to arming a timed grenade so that it will boom in a few seconds, and prime() to refer to the grenade actually going boom (or releasing foam or anything else grenades do when they go off). This was very confusing, so now these two procs are called arm_grenade() and detonate().

* Changes grenade proc names to be more clear

Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
2020-11-28 12:55:30 +01:00
SkyratBot
473c05abd6 [MIRROR] Proto Nitrate reaction fix (#1896)
* Proto Nitrate reaction fix (#55188)

Fix runtime with proto_nitrate reaction with trit

* Proto Nitrate reaction fix

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
2020-11-28 12:55:20 +01:00
SkyratBot
8fb53f8c6c [MIRROR] HFR runtime fix (#1894)
* HFR runtime fix (#55189)

* HFR runtime fix

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
2020-11-28 12:54:33 +01:00
SkyratBot
3f897ebca0 [MIRROR] Makes swarmers and morphs ghost-visible in the orbit menu (#1891)
* Makes swarmers and morphs ghost-visible in the orbit menu (#55191)

Makes Morphs and Swarmers have their own part of the orbit menu, like other visible antagonists. Given pretty much every other ghost-obvious antagonist is, it's more of an oversight that you couldn't.

* Makes swarmers and morphs ghost-visible in the orbit menu

Co-authored-by: Coffee <CoffeeDragon16@gmail.com>
2020-11-28 12:52:44 +01:00
SkyratBot
926c5f519b [MIRROR] Fixes incapacitating sleep test failure, general test touch ups. (#1890)
* Fixes incapacitating sleep test failure, general test touch ups. (#55196)

Fixes the random incapacitating sleep test failure
Tests now provide the option to use a custom turf, by default uses plasteel tiles instead of space
Tests now reserve turf instead of just using a corner in CentCom (which had unaccounted for tiles)

* Fixes incapacitating sleep test failure, general test touch ups.

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-11-28 12:52:18 +01:00
Azarak
6a48466d4c Update alcohol_reagents.dm (#1888) 2020-11-28 09:57:45 +00:00
Azarak
10c21321ef Fixes excitable stopping wags (#1887)
* Update carbon_defense.dm

* Update carbon_defense.dm
2020-11-28 09:57:34 +00:00
Azarak
afc5281601 Update examine.dm (#1886) 2020-11-28 09:57:13 +00:00
Gandalf
930ed8a4db Panicbunker fixes (#1838)
* Update client_procs.dm

* aa

* Update client_procs.dm

* Update client_procs.dm
2020-11-27 21:24:30 -06:00
Azarak
0b4911e03c aaa (#1879) 2020-11-27 23:15:04 +00:00
SkyratBot
3bef35bcc1 [MIRROR] Updated strip menus (#1882)
* Updated strip menus (#55094)

Partiallyfixes #34369

Modified xenomorph, monkey, dog, and parrot strip menu UI to be like humanoids'. Also fixed an issue with parrot strip menu where it wouldn't refresh once you removed its headset, and fixed an inconsistency where human handcuff/legcuff removal buttons were different.

* Updated strip menus

Co-authored-by: tattlemothe <66640614+dragomagol@users.noreply.github.com>
2020-11-27 23:14:01 +00:00
SkyratBot
e7b9972087 [MIRROR] tgui: Stacking Machine Console and Safe UI fix (#1866)
* tgui: Stacking Machine Console and Safe UI fix

* frds

Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-11-27 07:51:37 +00:00
NotRanged
fdb46c7616 [Semi-modular] Ports pouches, changes engi-vend prices, atmos techs get their access back (#1860)
* AAA

* fixes prices

* Update code/modules/jobs/job_types/atmospheric_technician.dm

Co-authored-by: Gandalf <jzo123@hotmail.com>

Co-authored-by: Ranged <nickvanderkroon@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-11-27 07:49:30 +00:00
SkyratBot
18bdebef43 Merge type variable fixes and unit test (#1867)
Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-11-27 07:46:43 +00:00
NotRanged
39e888f854 [Not modular] 'Dangerous' SM setups can now be used to farm anom cores (#1861)
* Core generation

* Update code/modules/power/supermatter/supermatter.dm

Co-authored-by: Gandalf <jzo123@hotmail.com>

Co-authored-by: Ranged <nickvanderkroon@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-11-27 07:46:15 +00:00
SkyratBot
0a9c361f6f [MIRROR] Fixes male underwear/shirts poking through clothes (#1872)
* Fixes male underwear/shirts poking through clothes (#55139)

While investigating a strange intermittent issue with skirts and such randomly losing a pixel in the crotch they weren't supposed to, I found another underwear/undershirt issue. Female characters and plural characters with a female bodytype wearing mens underwear and a fitted outfit would have an errant pixel from the undershirt/underwear show through the crotch/armpits where the outfit lost pixels due to fitting. Underwear and undershirts now undergo the same pixel fitting as other clothes to ensure this doesn't happen.

* Fixes male underwear/shirts poking through clothes

Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
2020-11-27 07:45:25 +00:00
SkyratBot
f6d60b49f4 [MIRROR] Removes a source of ian harddels, restores soul (#1871)
* Removes a source of ian harddels, keeps mcgruffs bed discription from getting overwritten at roundstart, moves the bed claiming feature to just the dogbed typepath, none of the subtypes, this applies to buckling too (#55158)

Removes a source of ian harddels, keeps mcgruff's bed description from getting overwritten at roundstart, moves the bed claiming feature to just the dogbed typepath, blacklisting subtypes. This applies to buckling too.

This means that a dogbed can only ever belong to one dog. Fuck you.
Remake of #54892, github doesn't like force pushes, not sure why

* Removes a source of ian harddels, restores soul

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2020-11-27 07:45:11 +00:00
SkyratBot
3bf844af89 [MIRROR] Fixes cyborgs in general replenishing stack modules from external sources (#1846)
* Fixes cyborgs in general replenishing stack modules from external sources (#54935)

* Cyborg stack fix

- Makes cyborgs capable of recycling floor tiles again

* Touches up module code

- Makes module code slightly more OOP-compliant
- Speeds up module creation by an imperceptable amount
- Reworks how borg modules handle stacks

* Fixes cyborgs in general replenishing stack modules from external sources

* Update robot_modules.dm

Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-11-27 07:28:50 +00:00
SkyratBot
7e41bd29be [MIRROR] Fixes picked up bees, again (#1859)
* Fixes picked up bees, again (#55053)

Bees don't actually have a set icon state, their entire existence is their mutable appearance. This creates problems when something checks for the bee's icon state, like mob_holders. So, this PR sets their icon_state to the corresponding base bee icon on initialization. Visually identical to before, because the overlays / mutable appearance covers it, but their icon_state is no longer null.

* Fixes picked up bees, again

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2020-11-26 23:18:50 +00:00
SkyratBot
e976ff3a3d [MIRROR] Fixes an adminPM dead end eating replies (#1857)
* Fixes an adminPM dead end eating replies (#55127)

If you tried to reply to an admin that had deadminned while you were typing you would get an error and your message was eaten. Now sends to MessageNoRecipient if theres an open ticket, or prints a warning and the message in chat if there isn't.

* Fixes an adminPM dead end eating replies

Co-authored-by: skoglol <33292112+kriskog@users.noreply.github.com>
2020-11-26 23:18:22 +00:00
SkyratBot
f6044946d7 [MIRROR] Accidental Consumption post-food refactor cleanup (#1856)
* Accidental Consumption post-food refactor cleanup (#55152)

    Renames a bunch of vars to be more descriptive
    Removes old references to snacks
    Updates some code slightly

* Accidental Consumption post-food refactor cleanup

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2020-11-26 23:18:09 +00:00
SkyratBot
1abb29c714 [MIRROR] Fixes forced speech nanite oversight (#1855)
* Fixes forced speech nanite oversight (#55164)

All of the stunning emotes were blacklisted from the forced speech program. However, *faint was not added this to the list, and this is an oversight. This is a simple one line fix to add it to the blacklist.

* Fixes forced speech nanite oversight

Co-authored-by: Coffee <CoffeeDragon16@gmail.com>
2020-11-26 23:17:59 +00:00
SkyratBot
d4100f9387 [MIRROR] Fixing non-wiz phased mobs. (#1854)
* Fixing non wiz phased mobs. (#55162)

Wrong proc path, also qdel ref issue for shadow walk holder.
This will close #55141 and close #55142
fix: Nightmares and some other critters no longer delete themselves once they stop phasing.

* Fixing non-wiz phased mobs.

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2020-11-26 23:17:51 +00:00
SkyratBot
89a21458b5 [MIRROR] Replace tgalert with tgui_alert, a new TGUI-based alert system (#1833)
* Replace tgalert with tgui_alert, a new TGUI-based alert system

* a

* a

Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-11-26 08:05:45 +00:00
SkyratBot
38b8791e27 [MIRROR] Fixes issue with mecha drills failing to gib most simplemobs. (#1837)
* Feex (#55144)

For whatever reason we hardcoded the health value for drills at 200 brute damage before they can gib. 200 brute damage was picked as it was double the max health of /mob/living/carbon/whatever and double the max health was like, the cap on brute damage when someone is really, really, really, really dead.

Enter simplemobs. Their max health is regularly under 100, which means a hardcoded value of 200 brute damage to trigger gibbing effects is bad. Not that it matters anyway, because simplemobs also brute damage cap at maxHealth instead of maxHealth * 2 so the only simplemobs that could be gibbed by mech drills are those with 200 or more health.

This has been changed. Simplemobs now cap out at maxHealth * 2 damage, in line with all other /mob/living while drill code has been changed to check for maxHealth * 2 when gibbing instead of a hardcoded 200.

* Fixes issue with mecha drills failing to gib most simplemobs.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2020-11-26 00:18:57 +00:00
Azarak
307229bf3b aaa (#1827) 2020-11-25 13:29:42 +00:00
SkyratBot
e6879819ea [MIRROR] CanUseTopic() refactor. (#1829)
* CanUseTopic() refactor. (#54747)

* CanUseTopic() refactor.

* Forgot about default_can_use_topic. Tested and working.

* Update bin.dm

* no-nonsense.

* CanUseTopic() refactor.

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2020-11-25 13:56:56 +01:00
SkyratBot
a25041431b [MIRROR] Humans have more complicated body temperatures (#1825)
* Humans have more complicated body temperatures (#54550)

This changes how carbon/humans stabilize body temperature, and changes how damage and wounds are applied based on temperature.

Humans now have a core body temperature along with body temperature. The core temperature is used for natural stabilization and what viruses like fever and shivers target by raising or lowing the core temperature of the mob.
The standard body temperature still exists and acts exactly the same for most items at this time but is now treated as surface temperature in humans.

Damage from body temperature for humans is now based on the core temperature instead of body temperature now.
Humans will now receive burn wounds when the body (surface) temperature is to high for to long.

This causes you to see alerts for the area temperature before you take damage in most cases improving visibility of dangerous situations.

* Humans have more complicated body temperatures

Co-authored-by: NightRed <nightred@gmail.com>
2020-11-25 13:56:04 +01:00
SkyratBot
65368300d2 [MIRROR] Refactors Pastries into newfood. (#1824)
* Refactors Pastries into newfood. (#54996)

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@ users.noreply.github.com>
Co-authored-by: Floyd <Floydje123@ hotmail.com>

* Refactors Pastries into newfood.

* Update collars.dm

Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@ users.noreply.github.com>
Co-authored-by: Floyd <Floydje123@ hotmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-11-25 01:02:00 +00:00
SkyratBot
2a0cc258ee [MIRROR] Fixes #55112 - Swapping items no longer eats things (#1823)
* Fixes #55112 - Swapping items no longer eats things (#55122)

Quick swapping items no longer hides them in the mobs contents

* Fixes #55112 - Swapping items no longer eats things

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-11-25 00:01:00 +00:00
SkyratBot
d6c12e331d [MIRROR] Fixes lightbulb injections (#1821)
* Fixes lightbulb injections (#55132)

Co-authored-by: itseasytosee <55666666+itseasytosee@ users.noreply.github.com>
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@ users.noreply.github.com>

* Fixes lightbulb injections

Co-authored-by: Coffee <CoffeeDragon16@gmail.com>
Co-authored-by: itseasytosee <55666666+itseasytosee@ users.noreply.github.com>
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@ users.noreply.github.com>
2020-11-25 00:00:09 +00:00
SkyratBot
ed9698068b [MIRROR] tgui: Safe (#1818)
* tgui: Safe

* 0

* Update tgui.bundle.js

Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-11-24 23:59:06 +00:00
SkyratBot
fde1463b4b [MIRROR] Prevents mecha drills from stacking do_afters on the same target. (#1817)
* Prevents mecha drills from stacking do_afters on the same target. (#55145)

* Feex

* Feex 2.0 Feexlectric Feexaloo

* Whitespace purge

* Prevents mecha drills from stacking do_afters on the same target.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2020-11-24 17:26:06 +00:00
SkyratBot
550ba54c0c [MIRROR] Make sure slowdown effects get removed when items are unequipped from a mob (#1813)
* make sure slowdown effects get removed when items are unequipped (#54947)

* Make sure slowdown effects get removed when items are unequipped from a mob

Co-authored-by: Yenwodyah <yenwodyah@gmail.com>
2020-11-24 11:37:57 +01:00
SkyratBot
6a83de709c [MIRROR] Fix misleading examine messages on the head without body (#1811)
* Detect if ghost reentered the brain (#54975)

* Fix misleading examine messages on the head without body

Co-authored-by: antropod <antropod@gmail.com>
2020-11-24 11:37:08 +01:00
SkyratBot
7e9a03c216 [MIRROR] Fixes a xenobio megafauna duplication bug (#1810)
* This makes me sad (#55007)

* Fixes a xenobio megafauna duplication bug

Co-authored-by: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com>
2020-11-24 11:36:06 +01:00
SkyratBot
c226571f01 [MIRROR] Makes APCs not cause runtimes when placed in space (#1809)
* Makes APCs not cause runtimes when placed in space (#55045)

* Makes APCs not cause runtimes when placed in space

Co-authored-by: Bond <58570888+TheBonded@users.noreply.github.com>
2020-11-24 11:35:44 +01:00
SkyratBot
a6895181f2 [MIRROR] Fixes tool implant tools being storable in boxes (#1808)
* Fixes tool implant tools being storable in boxes (#54914)

* Moves storing tool implant items to use the drop hotkey rather than a dropped item event

* de-debugging

* Fixes tool implant tools being storable in boxes

Co-authored-by: zxaber <37497534+zxaber@users.noreply.github.com>
2020-11-24 11:35:16 +01:00