* Startwork.
* Time to break this later
* How do I map lists again
* So close I can almost TASTE ITTTT I GOTTA GET A MOVE ON WITH MY LIIIIFE
* Hey, it almost works!
* Finally actually ready to PR
* Nothing to see here but documentation and dead code
* Take 2.
* Revert "Take 2."
This reverts commit 0882d96a30ba79ebead4b5dd3e6f32e65bbf2a76.
* Cleans up tgui compile errors.
* WIP changes, still not happy with this for now.
* I am satisified.
* Rework that UI
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
* Beaker go splash, plants mutate good
* Hard committing to this for the time being.
* Clean up.
* Not sure what I forget here.
* As yes right, I did do this.
* Avoids chemical conflicy my making it uranium, frost oil, potassium.
* More informational, and uncaps removed genes per cut, at the cost of plant health each time.
* Moved to a more critical node to enable gameplay earlier.
* Committing suggestion.
Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
* Very valid point about iterating down loops, ngl
* Fixes fixes, and other fixes.
* Fixes up documentation, and removes unused code.
* Adjusts Nutridrain to be calculated on the process side.
* Prevents Non-Extractable and Non-Removable genes from being removed, as originally intended.
Co-authored-by: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
* I GOT MINE ON DAY ONE
* I have the oldest xbox known to man
* e
* whee
* shits broke
* lol
* Update code/game/objects/items/toys.dm
Co-Authored-By: Bobbahbrown <bobbahbrown@gmail.com>
Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com>
* monkey cube suicide
* fuck
i used True instead of TRUE
* fixes indentation
it returned early
* adds delay
stops suicide from being instant
* fixes visible_message
it was called on src, which was qdeleted
* removes disfiguration
now everyone can see what you've done
* revises suicide
adds qdeleted checks, switches to do_after, hides cube
* commit suggestion #1
it is what it is
Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>
* commit suggestion #2
i'm just going to assume this works and if travis yells at me that'll be how it goes
Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>
* switches sleep call to timer + callback
splits off the end of the suicide into a finish_suicide proc
* monke
i typed "monkecube" instead of "monkeycube". this fixes that
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
The client variable can be nulled at any point between proc calls during Login(), at the very least between parent calls for sure. That can produce dirty additions to mob lists among other less problematic runtimes.
This attempts to handle it.
Fixes#45284
Some simple pagination for the library visitor console to stop it from hanging the server by trying to retrieve too much data.
The UI hasn't been made any better, I just wanted to stop us needing #49065 to be testmerged indefinitely. I went into this thinking I'd improve the UI and code but that was before I had read any of it and lost my motivation.
Bonus points for this code having allowed unsanitized arbitrary queries for at least 10 years.
* demos (ported from yogstation)
rustg update + write with no format
use external hook for logging
use proper log vars
fix + clarifying comment
don't start the log
release build of rust-g
fix something caught by the lint
Update code/__DEFINES/subsystems.dm
Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>
Update code/controllers/subsystem/demo.dm
Co-Authored-By: JJRcop <jrubcop@gmail.com>
Update code/controllers/subsystem/demo.dm
Co-Authored-By: JJRcop <jrubcop@gmail.com>
moves hooks out of a dedicated file
len = 0 to Cut(), remove semicolons
untyped loop
* updated rust_g
* 513 updates
* Initial work on tgui conversion for DNA Consoles
* Some initial button logic complete
TODO: Scanner Open button should disable while scanner is locked
TODO: Scramble DNA should disable while on cooldown
* Tabs for the tab God
* Dropdown changes, genetic sequencer modifications
* Mutation and genetic sequencer functionality
Almost complete. Need to implement Advanced Injectors still.
* Mostly done, converted most of genetic makeup code
* Tactical pocket linting
* More changes
* Everything except advanced injectors complete
* First complete alpha version
* Fixed debug/testing change
* Removal of more debugging code
* Fix pulse bug
* Bugbusters
* Fix for accidental changes
* Fix broken genetics disk changes, fix list of lists
* Squash tgui tab-key bugs and clean up attackby
* Code documenting, refactoring, bugfixing, spellcheck
* Documentation and misc bug squashes and runtime error fixes
* Fixes, features and tweaks
* Special check for those who have shuffled off this mortal coil
* New interface concept for console storage
* Mini code refactor
* Massive refactoring of DnaConsole interface (WIP)
- De-spaghettifying of LawyerCode
- Fixed the flex-basis bug, and removed ForcedBox since it's no
longer needed.
- Added a Divider component.
* Implemented requested changes.
Removed list() versions of strings.
Removed used TGUI-exclusive constants from data object. Currently unused ones still remain, can be removed if they're no longer necessary.
Fixed other DM data structures to serialise as JS Arrays instead of Objects.
Minor TGUI logic fixes for various edge cases.
Added some comments in DnaConsole.js outlining some minor notes and TODOs.
* Fixes "Save to X" being disabled.
* Included 2px outline CSS
* Additional minor logic patches
Don't want certain buttons active unless the mutation relation to them is also active
* Makes these transforms use a timer
* Fixed transformation race condition and stuff.
* Mutation source defined in DM. Conditional formatting improvements.
* Custom cache directory with BYOND_CACHE env var
* Fix gene cycler on index of -1
* Framework and TODO for next interface element. Cleared TODO list a bit.
* Fix 1px shift in gene cycle buttons
* Pass raw event with GeneCycler
* More robust combining logic
* Fix some cycler bugs, start working on enzymes
* Conditional highlighting for unsolved mutations and X'd genes.
* Lint for the Lint God
* Enzyme UI and more refactoring incoming
* Finish tgui refactoring, enzymes injectors done
* Whack-a-Bug
* Unlinted. Advanced injectors moved and improved. Implemented disk genetic data readout.
* Partial linting
* Assorted bug fixes
* Remove debugging code
* DNA Consoles are now more conversational. Initial state set.
* Final tweaks, implemented mutation combining, complete?
* Fixes tooltop, re-enables delayed enzyme transfer, cleans up some data params
* 10 Fix a bug, 20 make a bug, 30 goto 10
* The definition of irony
* Don't drink and derive, kids || How I learned to stop coding while drunk and rely on stylemistake to Flex on my formatting.
* uniqBy
* Add support for dropdowns with disabilities.
* Cleanup
* Remove current mutation from combinations
* Dividing
* Document BYOND_CACHE env var
* Outline cleanup
* Declare radiation constants since they were removed in DM
* Combine mutations only after checking for null
* Advanced Injectors actually work now.
* Comment cleanup, DMDOC, stard and end processing at appropriate times
* Pressing Ctrl-S occasionally helps things
* Fix enzyme mutator timeout bug, added injector timeout display.
* Rebuild tgui
* Rebuild tgui
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Co-authored-by: spookydonut <github@spooksoftware.com>
* Automatic changelog compile [ci skip]
* Automatic changelog compile [ci skip]
* tablet good
* forgot something
* restoring what was lost
* hoping for the best
expecting the worst
* Why review when you can edit in place?
* Additions and fixes
* Here's hoping
* Why is this still here?
Co-authored-by: Changelogs <action@github.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
About The Pull Request
Fixes resting so you're now not dense - can fit inside containters etc. Projectiles also once again hit resting players, but will pass through corpses. If you're not able to move, use items, or stand, or you're just dead, bullets go over you.
Why It's Good For The Game
Fixes#50332Fixes#50322Fixes#50236Fixes#50076Fixes#50370
Changelog
cl
fix: Fixes resting and projectiles.
/cl
About The Pull Request
It's nothing major, its just fixes a spelling mistake for the taste description. I accidentally put opoid instead of opioid.
Why It's Good For The Game
Just a minor fix, it just fixes a spelling mistake for lean.
Changelog
cl
spellcheck: fixes a spelling mistake in taste description for lean
/cl
About The Pull Request
This PR makes Mining and Service cyborgs use a radial menu to choose their module skin, instead of swimming in the input menu with no preview of how given skin even looks like.
Example image:
RadialMining
Why It's Good For The Game
Better cyborg skin choosing method.
Changelog
cl Arkatos
add: Mining and service borgs now use a radial menu to select their module skins.
/cl
About The Pull Request
Examining someone holding a circled hand from using the *circle emote while next to them can now alert said person, and if you don't act fast, they'll bop you! You'll have a split second to move away before this happens. Losing the circle game to a hulk will result in a very forceful bop.
Bopping someone will award an achievement, "HA, GOTTEM"
Also adds COMSIG_PARENT_EXAMINE to carbon and human's examines, cause they never had that set, and adds TRAIT_HULK to being hulk since I forgot to actually give it its own trait when I added said trait in another PR
Why It's Good For The Game
Enhances pranking. It's honestly amazing to me that this functionality wasn't built in when this was first made.
Changelog
cl Ryll/Shaps
add: The *circle emote now has additional functionality! Go prank your friends!
/cl
* Add remove_specific helper proc to gas_mixture.dm
Removes moles of a specific gas type from a gas mix
* Passive vents use individual partial pressures
* gas_list list operators
* KISS
* Remove unused var
* Remove unneeded holding gas mixutre
* Only gc specific gas_id in remove_specific
* Fix missed structure change
* Add remove_specific comments
* Remove extra spaces
* Add gas_mixture equalize proc
* Change passive vent to use equalize()
* Improve equalize comment
* Fix equalize partial pressure if check
* no magic numbers
* clown op fixes
* description shortening
* fixes the locations of some items
* fuck off, travis
* Update code/modules/uplink/uplink_items.dm
Co-Authored-By: Rohesie <rohesie@gmail.com>
* removes one comma
* web edit web edit
* removes fun
* reduces the number of checks for user.mind
* clown ops can buy chameleon kits again
* Update code/modules/projectiles/pins.dm
Co-Authored-By: Rohesie <rohesie@gmail.com>
* accidentally deleted a comment
Co-authored-by: Rohesie <rohesie@gmail.com>
* Adds RegalRat and Royal Cheese. Initial commit
* I'll come back to you, *someday*
* THE KING HAS ARRIVED
* merge conflict
* How did I screw this up
* Bookkeeping
* Documentation and all that jazz. Rat procs spells.
* Hahah whoops that ain't right.
* Feedback and cleanup.
* Oh right.
* We no longer need coins in-game.
* Rat Rivalry is fixed, polls deadchat.
* Review suggestions.
* Nesting change.
* And fixes merge conflict
* Christ why did I put that on life at all what the hell was I on when I coded that originally like actually
* Works factions out to tags and also adds some examine lines for factions.
* Apply suggestions from code review
More review suggestions
Co-Authored-By: Rohesie <rohesie@gmail.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Fixes carp rifts not spawning in infinite carps upon Space Dragon
completing his objective. Also renders the carp rift above things like
doors, as per request. It not already doing this was an oversight, and
gives Space Dragon winning some weight. Also makes it easier for ghosts
to use the rift if it shares a tile with something else.
* Fixed pointing runtime
* Fixed runtime allowing abductors to speak out loud
* Fixed being able to get two monkeys from each monkey cube
* Fixed being able to use camera consoles with the mech teleporter to teleport further than intended
* Fixed ninja suit never copying data from tech disk
* Fixed being able to tackle things not on a turf
* Rearranged ifs
Makes you fail when attempting to fireman's carry someone when they are
buckled to an object, so that you cannot get the off-hand placeholder
item to enable unintended interactions.
No more long-range body throwing, people teleporting through bluespace
to the individual with the off-hand placeholder to be slammed onto a
table, or tabling without needing to regrab the individual.
* ARCANE HOSPITAL: TRIAGE EDITION: OPEN PLANT HEART SPECIAL
* Quickfix
* Work work please god work work
* HOTFIX COMING AT YOU LIVE
* AND YOU, YOU EVIL LITTLE PROC.
* Sneakin and learnin
About The Pull Request
It annoyed me that we have a perfectly good frag grenade item, and a perfectly good shrapnel component, but no crossover episode between the two. This remedies that, and does a lot, lot more.
dreamseeker_2020-03-30_05-01-13.png
dreamseeker_2020-03-30_05-01-26.png
Big points:
Adds new component: pellet_cloud, which can be used by ammo casings, guns, and landmines to spray shrapnel and display aggregate hit messages ("You're hit by 6 buckshot pellets!" vs "You're hit by the buckshot pellet in the X" x6). All gun ammo that shoot multiple pellets now use this component on firing.
Adds stingbangs, premium less-lethal grenades that shoot off lots of stinger pellets, to cargo. Frag grenades are also reworked to have smaller booms, but shoot off lots of shrapnel shards. You can jump on top of these grenades to absorb a portion of the shrapnel to save those around you! There's an achievement for dying this way, called "Look Out, Sir!"
Projectiles can now embed items/shrapnel. Adds .38 DumDum ammo to cargo that does less damage and has negative armor pen, but can embed in people. This is the only ammo that currently embeds.
Bullets can now ricochet off walls, structures, and machinery (harder surfaces are more likely to ricochet). Only standard .38 and Match Grade .38/.357/L6 ammo can ricochet, with Match Grade being much better at ricocheting. You can buy Match Grade .38 from cargo and Match Grade L6 ammo from the nuke uplink, while Match .357 is admin only.
Armor now protects you from harmful embeds, taking the better of the bullet/bomb armor on the affected limb. Armor penetration can modify this of course, and many blunt embeds like stingbangs and DumDum bullets are significantly worse if you have even 1 armor.
Other misc fixes/changes
Refactored the embed element a bunch and fixed it creating new elements for every instance rather than expected bespoke behavior. There are new /obj/item helpers for modifying and adding embedding.
Fixes#49989: Spears can no longer embed in turfs cause their sprite is annoying to me, it's generally harder for most things to embed in turfs
Fixes#49741: New carbon helpers for removing embedded objects
Fixes#46416: Handles embedded objects getting qdel'd or moved while embedded
Renamed the old shrapnel component for RPG loot to MIRV to avoid confusion
Repathed frag grenades from under minibombs to under base grenades, and added explosion vars to base grenades
Why It's Good For The Game
Fixes a bunch of janky design with embeds, adds lots of new avenues for projectile and grenade variety, ricochets and collateral damage are fun!
Changelog
🆑 Ryll/Shaps
add: Adds stingbangs to cargo (and one in the sec vendor premium), premium less-lethal grenades that shoot off a giant swarm of stingball pellets to help incapacitate swarms of people in tight quarters. You can jump on top of a live one to be a hero and absorb a bunch of shrapnel, same with frag grenades. There's even an achievement for dying to a grenade you jumped on!
add: Projectiles can now embed in people! Or at least grenade shrapnel and the new .38 DumDum ammo, now available in cargo, can. DumDum rounds excel against unarmored targets, but are pricey and do poorly against armored targets.
add: Bullets can now ricochet! Or at least, standard .38 and the new .38/L6 Match Grade ammo can. Match Grade ammo is finely tuned to ricochet easier and seek targets off bounces better, and can be purchased from cargo (for the .38) or nuke ops uplink (for the L6), but standard .38 ammo has a chance to ricochet as well.
tweak: Frag grenades now have smaller explosions but shoot off a bunch of devastating shrapnel, excellent for soft targets!
tweak: Shotguns and other multi-pellet guns now print aggregate messages, so you'll get one "You've been hit by 6 buckshot pellets!" rather than 6 "You've been hit by the buckshot pellet in the X!" messages. Bye bye lag!
balance: Armor can now protect against embedding weapons, taking the best of either the bullet or bomb armor for the limb in question away from the embed chance. Some weapons are better at piercing armor than others!
/🆑
About The Pull Request
Adds a slew of new material datums. Included are bronze, runed metal, sand (made from sand blocks, made by using sand on a sink), sandstone, snow, paper, cardboard, bone and bamboo. Oh, and pizza. Yes, pizza.
newmats
(from left to right: bronze, sandstone, sand, snow, bamboo, paper, cardboard, runed metal, and bone).
PIZZA
PIZZA!
Pizza is a special case: it's edible, and to craft it, you need pepperoni sheetzzas. These are made by using a rolling pin on a pizza slice.
Why It's Good For The Game
More mats datumised, and pizza is a good meme.
Changelog
🆑 EOBGames (Inept)
add: A whole bunch of materials are now datumised! Check out bronze, runed metal, sand, sandstone, snow, paper, cardboard, bone and bamboo. Oh, and pizza. Yes, pizza.
/🆑
Shoutout to skog for helping me fine tune a lot of the ideas for this as well as convincing me to do it anyway. Feel free to send me your adoration and glory (once this is actually balanced and tested out so I can work out the like 1000 little runtimes and bugs this will surely have.)
About The Pull Request
Lets Start with everything that DIDN'T change.
Plants still have all their unique qualities. That includes chems, traits, all that good stuff.
Plant stats have been unchanged, with an exception I'll bring up later.
Cool. Onto everything else.
Changes to hydroponics trays.
Trays now have a new feature that visually you may be very familiar with. By Ctrl Clicking a tray, it activates Autogrow. Autogrow uses a HEAVY amount of power per tray, but in return it automatically maintains the plant contained within, limited nutrient loss, adding a gradual amount of water per process, and keeps pests and weeds at bay. Ideally you would only be using this on high maintenance plants, or if you need to leave your department for a few minutes. Having all your trays on Autogrow is an excellent way to kill your APC cell in a matter of seconds, even on a robust power setup.
Trays no longer use **Nutrient Points.** Instead, each tray has an internal reagent holder that basically holds a beaker for your plant's nutrients. In exchange, the tray now determines the gradual stat changes of plants based on nutrients within that nutrient tank. That's right, no more dumping chemicals into the tray to reach 100 potency in a matter of minutes. You can, however, use reagent mixes in order to improve plant stats in a satisfying way. Still, with each tray having a default of 10 reagents maximum in the tank, it places a greater impetus on upgrading trays if want to really get the most of a specific chemical composition.
If you realize you need to change the nutrients in the tank, you can Alt Click to empty the whole tank at once.
Seed Changes
All plants now have a new stat, Instability. (It was originally titled stability so I'm changing it here but yes it is now called instability) Contrary to the name, the higher the stability of the plant, the more likely that your plant will see radical changes. Plants with a low stability will not see much difference, but as you go higher and higher you will start seeing the plant automatically mutate with harsher ramifications. At 60 Stability, the plant has a chance to automatically mutate it's species. At 80 Stability, assuming you can prevent the plant from mutating beforehand, the plant has a chance to receive random plant traits similar to strange seeds. That's right! You can now be free from the tyranny of the strange seed market!
Plants are now affected differently by pests and weeds. Instead of outright killing plants, they will instead heavily lower a plant's yield and potency instead. This also allows for plants that have been left for a few minutes to outright die far less than they were before, but at the same time encourage using autogrow when AFK within the department.
When growing a plant however, you have something new to consider. Plants will now pollinate adjacent seeds in trays, which will bleed off adjacent stats to other plants. Primarily, this affects your core stats. like potency, yield, also stability. If you have 2 plant with high and low potency, they'll bleed their stats off into each other as they grow. This allows for interesting mechanical gameplay between nutrient choices, stability, and adjacency. Some plants have naturally high stability that can bleed off of other plants (Corn, Wheat, and Weeds), while others have naturally low stability and can help bring plants back into a maintainable stability threshold if you just want to harvest the plant itself.
Pollination at high levels of stability can also cause the adjacent plants to receive chemical traits from each other. This allows for plants to share chemical traits without having an insane level of control afforded by the DNA manipulator. However, careful manipulation of plant reagents is difficult to do perfectly, and should be done carefully, as well as experimentally.
For a more controlled trait experience however, we have Plant Grafts. Plant grafts are obtained by using the new secateurs, or sheers, that comes with the botanist's default kit. When a plant is ready to harvest, you can cut off a plant graft, which carries several of the plant's stats and qualities with it. When transplanted, you can share the unique traits of several plants into a new host. These traits are mostly the physical traits you're most likely familiar with, like bio-luminescence, slippery skin, liquid contents, the works. You can also store plant grafts if there's a specific trait build you'd like to eventually get to. Since you need to fully grow a plant to graft it, the process of obtaining several unique traits for a plant will result in more types of plants needing to be grown as a result.
Alright, this leads up to what you're probably guessing. DNA manipulator for plants is dead. Even if it's really good, being able to Frankenstein a dozen different plants together without even growing half of them is kinda lame, you have to admit. The new trait and chemical controls are a bit more robust overall to compensate for this.
image
Why It's Good For The Game
Chemical dependence hydroponics is dead.
Genefreak maxed out stats plants are dead.
The Tyranny of Pests and Weeds killing plants for cooperating with the station is dead.
Ambrosia Gaia is now no longer the staple plant of hydroponics, as earthblood trays are dead.
Plant mutations are now easier to come by, and can be achieved within 2 plant generations assuming you're not crossbreeding and using readily available chems.
Chefs, and by extension bartenders, get a wider array of plant's each to work with.
Botanists are no longer required to acquire a chem dispenser at shift-start to acquire mutated plants.
Crosspollination, mutation, and grafting allows for a more interesting dynamic in improving plant stats, as opposed to just clicking buttons. It also rewards planning and developing system for growing plants.
Changelog
🆑
add: Plants can now Cross-Pollinate, via adjacency. This causes plant stats of average into each-other.
add: Plants now have a new stat, Instability. Instability allows for gradual mutations to a plant's stats at certain thresholds, and a chance of mutation, or gaining new random traits at even higher thresholds.
add: Plants can be grafted when ready to harvest, and grafts can be applied to plants in order to share unique traits, or share stat changes.
del: The Plant DNA Manipulator is dead. Long Live the DNA manipulator.
tweak: Hydroponics trays now have their own internal beaker for holding chemical reagents. As such, chemical affects on plants are gradual, and slowly alter seed stats over generations.
balance: Several chemicals are adjusted to match the new system. Experiment!
/🆑
