## About The Pull Request
Closes#87222
armrest code doesnt have to be copied thrice if it can be on chairs with
a var to control if its actually used
## Changelog
🆑
fix: Bronze chairs will automatically spin once more
/🆑
## About The Pull Request
made manufacturing machines i/o overlays (the blue and orange lights and
such) rotate with the machine
CTRL SHIFT LMB makes the manulathe dump all mats
manulathes no longer may receive ore: this was not intentional,
processing ore is stuff the smelter does
manulathes now use a matter bin instead of a servo (because it makes
sense because it holds mats): this affects its material capacity being:
bin tier * 50 sheets
## Why It's Good For The Game
bug bad
oversight bad
and you also no longer need to decon the lathe to dump mats
## Changelog
🆑
fix: input output overlays for manufacturing machines actually update
properly when rotated
qol: you may dump materials of a manulathe via CTRL SHIFT LMB
balance: manulathes may not receive ore (not intentional)
balance: manulathes now use a matter bin in their construction, which
now affects their material holding capacity: 50 sheets per tier
/🆑
## About The Pull Request
This more or less ties with my previous PR where I fix some of the
issues I've seen with fishing, because both are the result of some live
playtesting in which I assessed some flaws and nits. So, let's get
started:
Lowered the number of fish to scan for each fish scanning experiment:
This is the most time-gating feature of fishing. As a scientist you're
usually better off doing anything else than this anyway, which is
understandable, but for whoever else that plans to get some nice ocean
fish, this is going to be a huge bummer. From 4, 8, 14, 21 to 3, 7, 11,
17.
Switched the ocean and chasm portal setting: Right now, the ocean portal
has the largest amount of catchable creatures, which can also help
progress the experiments, while the chasm setting only has two and is
only mildly useful for chasm chrabs --> lobstrosities (which suffer a
bit from not having a good enough AI right now). I hope I'll have the
time to add some late fishes to the chasm setting at some point.
Added a premapped fishing portal generator to the common service room of
every map: It takes quite some time to setup fishing. Making a fishing
portal is by far what I consider to be the most tedious part. Also Wawa
and Birdshot were also missing the aquarium kit. On a side-note I
realized some days ago that service jobs receive very good discounts on
the fishing items sold by the good clean vendor.
Added the fish puns speech modifier to fish-infused gills: I forgot to
do it when I made the PR. Shrimple as that.
Mild fish infusion tweaks: Lowered the crawling speed very sightly, but
buffed showers and water healing slightly. Drinking water now wets you
by about 1/4 of what splashing it would do.
Buffed fishing difficulty modifiers for items and chairs a little: For
the time and credits invested, buying a carp costume or whatever to be
slightly better at fishing doesn't seem that profitable, and I reckon I
was being a bit conservative with the values. Fishing is a considerable
time investment already, especially in the initial stage with the setup.
Also idk why sunglasses and thermals buff fishing while fish are
technically cold-blooded creatures so I removed the comp from them.
Added fishing rods and fish cases designs to cargo and science lathes:
Other base fishing designs are shared between the three departments,
while these two are only available for service (and autolathes
obviously).
Fishing skill now affects completion gain and not only completion loss:
Fishing as a feature has a slower pace than most things in the game. It
feels right that by the time you reach about legendary level, you get to
complete the minigame a bit faster.
## Why It's Good For The Game
To put it briefly, the feature feels right as a casual experience,
however time is very much against you and getting something done takes
some effort (especially on tram, where moving to and fro' departments is
almost like playing froggers at times)
## Changelog
🆑
map: Added a premapped fishing portal generator to every map.
balance: Lowered the requirements for fish scanning experiment. Swapped
the rewards of the second and third experiments.
balance: Buffed fishing difficulty modifiers for several items and
chairs.
balance: Fishing skill now affects completion speed of the minigame more
actively.
balance: Mild fish infusion tweaks. Crawling is a smidge slower, but
healing from showers and drank water is a bit better.
qol: Fishing rods and fish cases can now be printed by cargo and science
lathes.
add: Gills now give the fish puns speech modifier.
/🆑
## About The Pull Request
Closes#87140 by making chainsaws use transforming component like all
other sane items. Also cleanup.
## Changelog
🆑
fix: Chainsaws can now be sharpened
code: Chainsaws have received a minor code refactor
/🆑
## About The Pull Request
Fixes self-vore message when you get devoured by an alien.
Fixes some simple attack verbs being continuous
## Why It's Good For The Game
Bug fixes good
## Changelog
🆑
spellcheck: Correct message is shown when YOU get devoured by an alien
spellcheck: Fixed a few typos on some simple attack verbs being
continuous
/🆑
## About The Pull Request
I'm making sure that `update_body_parts()` is properly called when
changing bodypart overlays, so that they actually show up the very
moment they were changed. However, to avoid redundant
`update_body_parts()` calls on init or while changing species, I've
added a living flag that stops `update_body_parts()` from being called
in these situations. I also scoured the codebase for other redundant
`update_body_parts()` to remove and things to clean up a little.
## Why It's Good For The Game
This automates the process of calling `update_body_parts()` a bit.
## Changelog
Mainly backend.
## About The Pull Request
Showering will add negative mood effect to felinids
## Why It's Good For The Game
there was a status effect that drops stamina for felinids on shower but
at the same time it boosts mood i decided to make it better
🆑 Mamaii
add: shower will give felinids negative mood effect
fix: fixed shower hater status effect alert not showing
/🆑
## About The Pull Request
I randomly came across a `var/list/static` in the code, which does not
actually do what was intended, and thought it was silly. A ctrl+f
revealed that this was a fairly common mistake, so I went and fixed all
the instances of it I could find.
~~Including one in lighting code, which it looked like they were trying
to create a global list to cache generated lighting sheet values for
speed, but it was just a normal list that got created each time
pointlessly. Now those values are actually being cached (using a global
var, because a `static` list was not the right thing to use there in the
first place).~~
Nevermind, it seems that this was in fact being cached even if it
shouldn't have been, because byond. Just rearranged it there seeing as
it works either way.
## Why It's Good For The Game
Code that does what it's supposed to
## Changelog
🆑
fix: fixes a bunch of improper static list declarations
/🆑
## About The Pull Request
same sounds as the toolbelt
## Why It's Good For The Game
I think it fits
## Changelog
🆑 grungussuss
sound: medical, jani, soulstone, grenade belts got sounds
/🆑
## About The Pull Request
Added the FOSBURY skillchip, found in hacked toy vendors.
This skillchip allows you to bypass the emote cooldown when flipping or
spinning. However, if used too often, it will lower the chip's
integrity. At first, this is harmless, emitting sparks only, but at a
certain point, your head starts smoking, your brain begins
short-circuiting, and once the chip has lost all integrity your head
will explode in a shower of gore, giving you a cranial fissure!
Added the Chipped quirk. It allows you to spawn with one skillchip. Of
note here is that the only chips you can spawn with are the 'default'
skillchips found in the toy vendor, you can NOT spawn in with the
fosbury chip or with the musical one.
Added the Chip Connector quirk. It contains a new implant, the chip
connector, which allows you to install and take out skillchips at any
time. Being EMPed will cause it to drop one random skillchip, and if you
try using it while it's malfunctioning you'll take out a bit of your
brain instead. It can also be made at the exosuit fabricator after basic
research.
Renamed the organ slots for brain implants and made the connector
implant take the CNS slot.
## Why It's Good For The Game
> Added the FOSBURY skillchip, found in hacked toy vendors.
This skillchip allows you to bypass the emote cooldown when flipping or
spinning. However, if used too often, it will lower the chip's
integrity. At first, this is harmless, emitting sparks only, but at a
certain point, your head starts smoking, your brain begins
short-circuiting, and once the chip has lost all integrity your head
will explode in a shower of gore, giving you a cranial fissure!
During the time flipping was bugged to have no cooldown or delay, it was
really funny seeing people flip at increasingly higher speeds. Many
people miss it, and to be honest, so do I. But everything needs limits
or it stops being funny and ends up being overdone. To this end this
skillchip lets people relive those days of glory, until they go out in a
beautiful explosion. The chip will last a very long while if well taken
care of, and there are plenty of warning signs before it gets too risky
to use, but we know what players are actually gonna do, and I am looking
forward to it.
> Added the Chipped quirk. It allows you to spawn with one skillchip. Of
note here is that the only chips you can spawn with are the 'default'
skillchips found in the toy vendor, you can NOT spawn in with the
fosbury chip or with the musical one.
Chips can be kind of neat sometimes, and I think always having one as
part of your character can make for some fun things as the consistency
of it makes it more likely to stick in your mind to do stuff with.
> 'but can't you just go to the vendor at the start of every shift?'
Sure. But we have loadouts. We have tagger, musician, and many other
things that are 'roundstart bloat', and while that by itself is not an
excuse, it's part of the design of character setup: Minimizing the time
spent running around the station for things your character is supposed
to have for their personality/roleplay/gimmick. They're paying the cost
of quirk points for it, anyways.
> Added the Chip Connector quirk. It contains a new implant, the chip
connector, which allows you to install and take out skillchips at any
time. Being EMPed will cause it to drop one random skillchip, and if you
try using it while it's malfunctioning you'll take out a bit of your
brain instead. It can also be made at the exosuit fabricator after basic
research.
I like the idea of having a gross usb drive on the back of your brain
that you shove chips into and out of, especially if it drops pieces of
your brain when malfunctioning. It also adds a little bit of extra
relevance to skillchips now that you don't need to spend 15 (!!!)
seconds inside a skillstation to add one. The cost is, as stated, quite
literally losing your brain on EMP's and the moderately expensive sum of
4 points.
> Renamed the organ slots for brain implants and made the connector
implant take the CNS slot.
It annoys me that there were organ slots for 'anti drop implant'. Now
they're just slots for anything meant to connect to the
cerebellum/central nervous system, making it less brute forcey and also
adding the start of some fun exclusivity between brain implants.
## Changelog
🆑
add: Added the FOSBURY skillchip, found in hacked toy vendors. This
skillchip allows you to bypass the emote cooldown when flipping or
spinning. However, if used too often, it will lower the chip's integrity
and cause malfunctions.
add: Added the Chipped quirk. It allows you to spawn with one base
skillchip. (not the one above)
add: Added the Chip Connector quirk. It contains a new implant, the chip
connector, which allows you to install and take out skillchips at any
time.
code: Renamed the organ slots for brain implants and made the connector
implant take the CNS slot.
---------
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
## About The Pull Request
Fixes#87129
[This
change](https://github.com/tgstation/tgstation/pull/87073/files#diff-c8ab5fbc20de60e202b839834b039649cbb69a1c4b99b27a5e467f3889442ccd)
added in #87073, passing `invdrop = FALSE` to `doUnEquip`, breaks the
behavior of unequipping dropping your items. Because that's what
`invdrop` does. If you pass it as `FALSE` it prevents other items from
dropping off the mob, intended for like, outfit use / "quick swapping"
an item out
So I reverted it. Drone tools still seem to work I guess. @SyncIt21
## Changelog
🆑 Melbert
fix: Fixes stuff staying on your body after removing your clothes
/🆑
## About The Pull Request
This PR makes it so that the cardboard cutouts can be shaped into the
appearances of: Abductor Agents, Heretics, Changelings, Space Pirates
and Space Ninjas, adding these as outfits alongside the ones currently
implemented.
## Why It's Good For The Game
If the cutouts serve for fooling people, for fun, for causing a little
chaos with fake callouts - why not make them for more than just the
basic few antagonists? I've decided it'd be nice to modernize this with
outfits for the ninja, pirates, abductors etc since it's only fair for
them to be included in the scare-the-ai party.
## Changelog
🆑
add: More cardboard cutout icons (Pirate, ninja, changeling, heretic,
abductor)
/🆑
---------
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Ben10Omintrix <138636438+Ben10Omintrix@users.noreply.github.com>
## About The Pull Request
- Fixes#87071 as in
a) Dropping a drone tool will put it back in the toolbox again
b) You can manually put the tool back in the toolbox via mouse click
c) You cannot dump the contents of the drone toolbox on anything
## Changelog
🆑
fix: you can drop/put drone tools back in the toolbox
fix: you cannot dump the contents of the drone toolbox
/🆑
## About The Pull Request
I'm adding a new infusion ~~(actually four, but two of them are just
holders for specific organs tied to a couple fish traits)~~ to the game.
As the title says, it's about fish.
The infusion is composed of three primary organs, plus another few that
can be gotten from fish with specific traits.
The primary organs are:
- Gills (lungs): Instead of breathing oxygen, you now need to stay wet
or breathe water vapor.
- fish-DNA infused stomach: Can safely eat raw fish.
- fish tail: On its own, it only speeds you up on water turfs, but it
has another effect once past the organ set threshold. It also makes you
waddle and flop like a fish while crawling (I still gotta finish sprites
on this one)
Other organs are:
- semi-aquatic lungs: A subtype of gills from fish with the 'amphibious'
trait, falls back on oxygen if there's no water. Can also be gotten from
frogs, axolotl and crabs.
- fish-DNA infused liver: From fish with the 'toxic' trait. Uses
tetrodotoxin as a healing chem instead of a toxin. Also better tolerance
to alcohol if you want to drink like a fish (ba dum tsh).
- inky tongue: From fish with the 'ink production' trait. Gives mobs the
ability to spit ink on a cooldown, blinding and confusion foes
temporarily.
The main gimmick of this infusion revolves around being drenched in
water to benefit from it, In the case you get the gills organ, this also
becomes a necessity, to not suffocate to death (alternatively, you can
breathe water vapor, without any benefit). To enable the bonus of the
organs set, three organs need to be infused. They can be gills, stomach,
tail and/or liver, while the inky tongue doesn't count towards it.
Once the threshold is reached, the following bonus are enabled:
- Wetness decays a lot slower and resists fire a bit more.
- Ink spit becomes stronger, allowing it to very briefly knock down
foes.
- Fishing bonuses and experience
- Resistance to high pressures
- Slightly expanded FOV
- drinking water and showers mildly heal you over time.
- for felinids: You won't hate getting sprayed by water or taking a
shower.
- While wet:
- - If the fish tail is implanted, crawling speed is boosted.
- - You no longer slip on wet tiles.
- - You also become slippery when lying on the floor.
- - You get a very mild damage resistance and passive stamina
regeneration, and cool down faster.
- - You resist grabs better.
- - get a very weak positive moodlet.
- However, being dry will make you quite squisher, especially against
fire damage, slower and give you a modest negative moodlet.
While working on it, I've also noticed a few things that explained why
tetrodotoxin (TTX) did jackshit at low doses, because livers have a set
toxin tolerance value, below which, any amount of toxin does nothing.
Also I've felt like reagents like multiver & co were a bit too strong
against a reagent that's supposed to work at very low doses, with slow
metabolization, so I've added a couple variables to buff TTX a bit,
making it harder to purge and resistant to liver toxin tolerance (also
added a bit of lungs damage).
## Why It's Good For The Game
I wanted to take a shot at coding a DNA infusion and see how chock-full
I could make it. DNA infusions are like a middle point between "aha,
small visual trinket" and organs with generally ok effects. I seek to
make something a bit more complex ~~(also tied to fishing ofc because
that's more or less the recurrent gag of my recent features)~~ primaly
focused around the unique theme of being strong when wet and weaker when
dry.
EDIT: The PR is now ready, have a set of screenshots of the (fairly mid)
fish tails (and gills, barely visible) on randomly generated spessman
and one consistent joe:
## Changelog
🆑
add: Added a new infusion to the game: Fish. Its main gimmick revolves
around being stronger and slippery when wet while weaker when dry.
balance: Buffed tetrodotoxin a little against liver tolerance and
purging reagents.
/🆑
## About The Pull Request
Adds a new neutral station trait where people are able to bring their
personal pets to show off to the rest of the crew (or to donate to the
chef). Before joining, players will be able to customize their pets
https://github.com/user-attachments/assets/5a5cda18-e551-4f87-b649-67a6940ffc6a
u can set their name, gender, pet carrier color, and teach them give
them a unique dance sequence trick. if players dont wish to opt in, they
also have the choice not to
## Why It's Good For The Game
adds a new station trait which people can RP around, whether its by
competitively comparing pets, or resolving conflicts around pets being
killed/kidnapped. Ive also GAGsified pet carriers, so people can now
have the option to recolor those too
## Changelog
🆑
add: adds a new station trait, "bring your pet to work" day
/🆑
## About The Pull Request
Adds VV header for items, letting quick modification of a few of an
item's combat values..
## Why It's Good For The Game
In testing, I find I tweak these values commonly, to test how effective
an item is vs armor, or how strong a new item should be, etc etc. So
having quick access to these might be cool
I thought about adding a few more like throwforce but I didn't want to
clutter it too much
## Changelog
🆑 Melbert
admin: Items now have a header in VV allowing for quicker editing of
combat properties
/🆑
## About The Pull Request
I'm "cooking" the materials system a bit, specifically the code
responsible for applying and removing effects. My goal is to move most
of the code to the objects-side, split it in smaller procs that can be
more easily overriden or called for object-specific modifiers and
effects, while also revamping things all around to better support items
made from multiple materials (the cleric mace will most likely be one in
this PR, with the handle and tip made of different materials).
PR NO LONGER WIP, TESTED AND ALL, CLERIC MACES CAN NOW BE MADE OF TWO
MATERIALS.
## Why It's Good For The Game
One of the nastiest flaws with the materials system is that it's just
unfeasable to have items made of multiple mats (with effects enabled)
right now, as they easily tend to override each other, where some of the
modifiers and effects should only be applied the main material.
Beside, the system's starting to show signs of its time, from the
several type checks used to apply different effects, the one letter
variables to the the material flags that are still being passed down as
arguments when you can access them from the atom/source arg anyway. It
would be disonhest of me if I went ahead and coded material fishing rods
or whatever fish fuckery with materials without ensuring it won't
further the technical debt the feature currently has.
## Changelog
🆑
refactor: Refactored materials code. report any issue.
add: Cleric maces (The autolathe-printable weapon design from outer
space) can now be made of two different materials.
balance: Buffed cleric maces a little.
fix: toolboxes' stats are now affected by materials again.
/🆑
---------
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>
## About The Pull Request
**1. Qol**
- Adds examines & screentips for screwdriver act, inserting & removing
cell
**2. Code Improvements**
- Autodocs & removes some unused/redundant vars
- Corrects return values of `screwdriver_act()`
**3. Fixes**
- Fixes#85408. Charging is consistent with cell rating & scales for
higher tier cells
- Syndicate inducers now uses super batteries not cells so they have
higher charge
**4. Refactor**
- Moved attack chain to `item_interaction()` & `interact_with_atom()` &
removes a lot of procs to merge with this new attack chain
## Changelog
🆑
qol: adds extra examines & screentips for inducer
fix: inducer charging rate scales with cell rating
fix: syndicate inducers now have correct charge & batteries installed
refactor: inducer attack chain has been improved & redundant vars/procs
have been removed, report bugs on github
/🆑
---------
Co-authored-by: Sealed101 <cool.bullseye@yandex.ru>
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
## About The Pull Request
Adds a new icebox ruin. Below you can see some good pictures of it.
A unique creature that can be found a "hatsune mi-go", a m1911 with a
magazine, santa outfit w/ bag, and a jukebox. this is actually something
I had planned for a torment nexus but chose to forego for an Icebox ruin
instead. The map is 35x35.
## Why It's Good For The Game
Icebox is in need of some ruins, I was originally working on this for
something else but decided to instead add it as a ruin in icebox. I
added a subtype of the christmas tree that doesn't give presents. I felt
like icebox lacked more dangerous ruins so I sprinkled in a few enemies
and as a reward there is some notable stuff.
## Changelog
:cl:ViralMilk22
map: Additional Icebox Ruin has been added "Hunters Lodge".
/🆑
## About The Pull Request
`SSpolling.poll_ghosts_for_target` returns a 0 length list when no
candidates are chosen so it will spawn an AI core without a client, so
instead of `if(isnull(ghost)` we do `if(!ismob(ghost))`.
closes https://github.com/tgstation/tgstation/issues/86976
## Changelog
🆑 grungussuss
fix: fixed a clientless AI spawning when a ghost poll for syndicate
modsuit AI had no volunteers
admin: AI rolebanned players can no longer role for Syndicate modsuit AI
/🆑
## About The Pull Request
Just some readability improvements:
- Personal Lockers now have a 's (no more `John Doe locker`, now it's
`John Doe's locker`)
- Department Locks are now called Job Locks to prevent confusion -
locking it with a Head card will, indeed, only be accessible by that
head (or the Captain ofc)
- Newly renamed Job Lockers now have a 's (same as above, now shown as
`Job Assignment's locker`)
- Flipped the descriptions and minorly rewrote them. Now it's added to
the back of the original closet description and reads hopefully better -
`"It has been (ID/access) locked to (name/job)."`
## Why It's Good For The Game
I'm fairly sure this counts as a spellcheck tag right?
`Greg Bob locker` vs `Greg Bob's locker`? I don't know correct me if the
tag's wrong.
Besides the 's, easier to understand card reader choice and cleaner
descriptions.
## Changelog
🆑
spellcheck: added a 's to Personal/Job lockers created with card
readers, renamed 'Departmental' to 'Job' to prevent confusion, and made
the description easier to read
/🆑
## About The Pull Request
969d7ba1cd/code/game/objects/items/teleportation.dm (L254-L265)
Creating a portal on an active teleporter hub would try to teleport the
portal to the hub's target, but since `do_teleport()` deletes
`/obj/effect`, i.e. portals, the portal pair immediately gets qdel'd.
This happens in the `try_move_adjacent()` in the above code snippet when
the user-side portal is made and is moved in front of the user. They
properly remove themselves from the hand tele's
`active_portal_pairs`(well, they try to, but since they aren't yet added
in that list, they don't get removed), global portal list and whatever
else. However, the next line then adds the new portal pair to the hand
tele's `active_portal_pairs` again, but since we don't actually have
those anymore, they will never get deleted. Not cool.
So this PR ensures that the portals are not qdel'd before assigning them
to the list. If it fails to do so, the hand tele will produce a relevant
message, so hopefully the user won't try to bash their head against the
teleporter hub or similar again.
Also dmdocs some procs/vars with varying degree of helpfulness.
## Why It's Good For The Game
Fixes#67251
## Changelog
🆑
fix: fixed hand tele portals that have been deleted in the process of
opening a new portal pair clogging up hand tele's portal pair list. If
you try to create portals that would end up like this (i.e. on an active
teleporter hub), the hand tele will indicate that.
/🆑
## About The Pull Request
Someone on discord said it didn't work so I've taken at look at it, and
guess what? It's the base type.
## Why It's Good For The Game
Now it should work.
## Changelog
🆑
fix: The pre-emagged fishing portal circuitboard now actually gives you
an emagged fishing portal generator.
/🆑
## About The Pull Request
Returns the original look of the revolver for traitors:
While still giving Nuclear Operatives the red-revolver:
Re-flavors the red revolver to a "Badass Revolver" as well, so that it
helps differentiate it a bit more:
## Why It's Good For The Game
I always thought that the red "Syndicate Revolver" was way too on the
nose and dorky, especially for undercover agents. However, I thought
that dorkiness was a perfect fit for the Nuclear Operatives who love
painting all of their gear to be red and over-the-top badass looking.
## Changelog
🆑
image: Traitors now get the classic Revolver in their uplink. Nuclear
Operatives still keep the red look for their revolvers.
/🆑
## About The Pull Request
Basically goes through and puts some flat objects onto the floor plane.
Also puts blood back on the floor plane, since it seems like it used to
be but may have been moved mistakenly questionmark.
This means they will not be affected by Ambient Occlusion:
## Why It's Good For The Game
A lot of these "flat" things look really out of place because they're
secretly "floating" due to being on the wrong plane
## Changelog
🆑 Melbert
qol: Runes, crayons, and similar decals no longer have shadows
fix: Blood and similar "mess" decals no longer have shadows (again)
/🆑
## About The Pull Request
This pr makes it so reinforced tables can be hooked up to the power
grid, requiring them to be on an open tile with a cable on it much like
grilles, shocking solely people who attempt any of its disassembly
steps.
Insulation obviously still applies.
## Why It's Good For The Game
Saw talk about someone wiring up tables and I think it's funny to have
your table hooked up to the grid.
Allows you to protect your reinforced tables from disassembly, if you're
fine with world's most obvious open cabled tile below your table.
## Changelog
🆑
add: Reinforced tables may now be hooked up directly to the grid much
like grilles, electrocuting people who attempt to disassemble it.
/🆑
## About The Pull Request
- Donk Co. crate previously was unlocked, but the sprite had a lock on
it. Now the lock is removed.
- There's a new secure Donk Co. crate using the old sprite.
- S.E.L.F.'s crate had no lock on it, but it was a secure crate. The
lock overlay was present and it didn't look good. Now the lock is fully
on the sprite.
- There's a new unsecured S.E.L.F. crate using the old sprite. I gave it
a new description since the description mentioned locks.
- Interdyne's freezer was unlocked but had a lock on the sprite. Now the
freezer is secure. No unsecure variant this time.
- The names of the crates now use proper nouns, and the names of
corporations are capitalised.
- All syndicate crates with a lock now require syndicate access by
default.
- The Interdyne blood freezer no longer spawns the same contents as a
normal blood crate (a list of 9 blood packs plus 1-3 extra random
packs), now it spawns 13 random packs of blood.
- Typepaths were moved around to make the crates easier to find in
mapping tools.
- Fixed a dang TYPO in the Donk Co. fridge's description.
## Why It's Good For The Game
Lock issue is solved now. The mismatching sprites didn't look good, and
now they match and look good.
Kept sprites for lockable Donk crate and lockless SELF crates and made
them their own crate types.
Repathed stuff to make it tidier. As a side effect the interdyne blood
crate is no longer a subtype of the regular blood crate, so instead of
copy+pasting the long list of contents it used to have it just has a
bunch of random bloods in it. Feels more on-flavour this way I think.
Access changes are because that makes sense for syndicate crates. Most
of these are going to end up mapped in as syndicate-access crates, makes
sense to make that the default. Can always be overwritten.
yea and I fixed that fuckin typo
## Changelog
🆑
fix: Donk Co. and S.E.L.F. crates now properly display their lock (or
lack therof).
image: New sprites for unlocked Donk Co. crates and locked S.E.L.F.
crates.
spellcheck: The names of syndicate-branded crates now use proper nouns.
spellcheck: Fixed a typo in the description for Donk Co. fridges.
/🆑
## About The Pull Request
Adds the **portable power storage unit** (5 megacells and cable) and the
**power connector** (1 capacitor and cable), a two-part system for power
storage that, together, are functionally identical to a standard SMES
(with the ability to switch out the part that actually holds power).
It's on the same research node as the SMES itself.
Original idea and power connector sprite taken and slightly modified
from vgstation-coders/vgstation13#4555.
**The power connector is useless without the portable SMES and
vice-versa.**
<details><summary>How does it work?</summary>
The **power connector** (on the left) is set up like any other regular
SMES, but is functionally useless without a connected power unit. The
capacitor decides maximum power transfer rate.
The **portable power storage unit** (in the middle) is the part that
actually holds power, taking five megacells (power capacity scales
appropriate to cell capacity). It's functionally useless without a
connected port, as it can't interact with powernets in any way on its
own.
To actually use both of these, after wiring up the power connector
appropriately (as any other SMES), wrench the portable storage unit to
the connector; the connector acts like a regular SMES, charging and
discharging the portable unit in lieu of charging/discharging itself. If
necessary, you can disconnect the portable unit afterwards, and bring it
elsewhere with an assembled power connector.
Disconnecting the portable storage unit in the same way you connected it
(with a wrench) disables input and output on the connector, requiring
the user to re-enable the controls after connecting another portable
storage unit.
</details>
Also breaks up SMES attackby into different tool_acts.
## Why It's Good For The Game
I think it could be neat for things like Lavaland field bases or
player-built mini-stations; instead of building power generation
on-site, you could charge a portable SMES and bring it over. Or you
could set it up as a power reserve in the event engineering explodes.
Sure, you could argue that someone could just build and rebuild a SMES
or switch out the cells in it a bunch, but lugging around a whole thing
feels cooler.
## Changelog
🆑
add: Portable power storage units and power connectors! Under the same
research node as regular power storage units, and not mapped in
anywhere. Build a connector and portable unit, wire the connector like a
regular SMES, wrench the portable unit onto the connector, unwrench as
needed.
code: SMES attackby was broken up into several tool_acts instead of a
big attackby chain. If something stops working in regards to using tools
on SMESes, please file a bug report.
/🆑
---------
Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com>
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
## About The Pull Request
Adds the following new general shuttle events:_
**Hitchhiker**
- 1% chance
- A single assistant in an EVA suit and some PBJs in a suitcase
**Assistant Wave**
- 0.1% chance
- Spawns 10 assistants with internals
- For clarity, they don't get sent to the shuttle, but get launched at
it from space. It's a scuffle of 10 assistants trying to get in without
being spaced or succumbing to the cold/pressure
**Intern Wave**
- Admin only
- Unarmed and armed version
- Spawns centcom interns, with a little announcement to warn they're
coming
I've also fixed projectiles bugging out and admin forced shuttle events
not activating if they were added after the shuttle launched
<details>
<summary>Admin only events added</summary>
**Nukie**
Spawns a single nukie, armed with a shotgun, pistol and edagger.
Basically the deathmatch nukie loadout, you dont want to fight this
**Meaty ores**
Meaty-ores meteors. Have a 4% chance to hit the shuttle, posing a
potential hazard
**3 player controlled fire-sharks**
3 fire sharks controlled by players. Not much to talk about here
**Fireball Wave**
Shoots a wave of fireballs at the shuttle. I think it's cool but
apparently shuttle walls and windows deflect fireballs so it's kind of
moot unless you're outside :/
</details>
## Why It's Good For The Game
The assistant and hitchhiker events are some flavoring that I thought up
a while ago. The Hitchhiker is just intentionally a flavor addition, but
the assistant wave and intern wave can be used by admins to repopulate
or retake the emergency shuttle as well.
## Changelog
🆑
add: Adds an assistant and hitchiker shuttle event, replenishing the
crew mid flight!
admin: Adds two intern wave shuttle events
code: You can now supply shuttle events with outfits!
code: You can now shoot projectiles with the shuttle events!
fix: Fixes projectiles bugging out when fired in shuttle transit space
fix: Fixes admin forced shuttle events not activating when added mid
transit
/🆑
## About The Pull Request
Notable changes:
- Prices have been increased across the board. They're about on par with
the good clean fun vendor now.
- Less of each item. The machine will have to be restocked more often.
- Fake emags and fake hot potatoes are now avaliable.
- The ammo boxes are half-size boxes (20 darts) in the non-syndicate
vendor. Each foam dart costs 5 credits, and every riot dart costs 10
credits. The syndicate vendor sells the old size of boxes (40 darts) for
the same price, getting twice as many darts per credit.
- Syndicate balloon is now in the contraband section. There is only one
of them per vendor and they cost 999 credits.
- Replica space suits come in boxes now, instead of the parts being
bought seperately.
- All toy guns bought from the syndicate vendor are loaded with riot
darts.
- No more discounts for service jobs. Everyone pays the full price.
## Why It's Good For The Game
The current vendor isn't balanced very well, the pricing is a
placeholder and the vast amounts of gear in them make them a
destabilizing element when it makes its way on station. Spawning a lot
of high-end riot dart guns is easy, and the fact that this has 5
syndicate balloons with a value of 20 telecrystals avaliable for
effectively free is simply absurd. Reining it in a little makes it
easier for mappers and admins to put these machines in player-accessible
spots without worrying about it derailing rounds or empowering griefers.
Additionally, this change makes this vendor play nicer with the new
vending restock economy.
None of the pricing changes affect any vending machine that was mapped
in off the station z-level. Lavaland syndicates will continue not to be
charged for using their machine.
## Changelog
🆑
balance: Donksoft vendors now stock slightly more items, slightly less
of each item, and has increased prices across the board.
/🆑
## About The Pull Request
### Ragnarok
- Uncomplicated the arena. The center area's river has been muddied
over, the bonfires have been made dense, the ants on the ground
everywhere have been removed.
- The Warrior's loadout has been simplified, removing any Ash aspects
and making it more concise and understandable.
- The Scribe's loadout has also been simplified, and given an additional
rifle clip. (Yes, it's a clip.) It lost cosmic expansion and the
pacifism mansus, but gained mind gate and some formerly bugged labyrinth
handbooks.
- The Crusader should be able to adjust their nullrod now.
- The Rat'var Apostate's beakers are now named so people other than me
can get the joke.
### Lattice
- Unbreakable lattices are now actually unbreakable and can't be snipped
into nothingness.
- Added true invis walls to the edges.
- Moved spare rods to the pockets.
### Species
- Added no_smoothing to the funny, so it's actually hidden now.
## Why It's Good For The Game
Time playing these ingame has shown some oversights and imbalances.
Ragnarok in particular was far too overcomplicated and indulgent to the
detriment of gameplay. Too many things - ants, rivers, bonfires, spells,
it was cloying. I toned this down a lot here to make the arena more fun.
We still do need a way to pre-bind spells but out of scope.
## Changelog
🆑
balance: - Uncomplicated the Ragnarok arena. The center area's river has
been muddied over, the bonfires have been made dense, the ants on the
ground everywhere have been removed. The Warrior and Scribe have had
their loadouts simplified.
qol: - The Rat'var Apostate's beakers are now named so people other than
me can get the joke.
fix: - Unbreakable lattices are now actually unbreakable and can't be
snipped into nothingness.
fix: - Added true invis walls to the edges of Lattice Battles. Moved
spare rods to the pockets.
fix: - Species Warfare: Added no_smoothing to the funny, so it's
actually hidden now.
/🆑
## About The Pull Request
All usages of world.icon_size in code have been replaced with new
`ICONSIZE_X`, `ICONSIZE_Y` and `ICONSIZE_ALL` defines depending on
context
Replaces some "32" magic numbers with the defines
A few bits of code have been modified to split up x/y math as well
## Why It's Good For The Game
Magic number bad, code more readable, code more flexible and I'm told
there's an access cost to doing world.icon_size so minor performance
gains
## Changelog
🆑 tonty
code: made some code relating to the world's icon size more readable
/🆑
---------
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
## About The Pull Request
Altered the blood loss on teleportation. Instead of silently always
losing ten blood, you now lose ~forty 25% of the time, fitting in with
the teleporter's random design. In practice this usually evens out, but
the immediate side-effects when it does happen will be much more
noticeable. The rest of the time you'll still lose a tiny bit.
Improved the visible effects when using the teleporter. On teleporting,
it causes a tiny blood red wave at the destination, which is slightly
larger and more vibrant red if you lose blood. Telefragging someone now
throws them a random turf away alongside the stun.
Fixed NOBLOOD check missing from non-emergency teleport bloodloss.
## Why It's Good For The Game
> Altered the blood loss on teleportation. Instead of silently always
losing ten blood, you now lose ~15 25% of the time, fitting in with the
teleporter's random design. In practice this usually evens out, but the
immediate side-effects when it does happen will be much more noticeable.
The rest of the time you'll still lose 5.
The design of the teleporter is basically gambling your life away in
exchange for a powerful escape/entry device. I think it's a lot more
fitting if the blood lost is more random with this in mind - you could
use up all the charges without any real damage, or you could suddenly
lose a byunch of. In the end the blood cost is similar but this way
it'll be more visually noticeable the cost of the item.
> Improved the visible effects when using the teleporter. On
teleporting, it causes a tiny blood red wave at the destination, which
is slightly larger and more vibrant red if you lose blood. Telefragging
someone now throws them a random turf away alongside the stun.
Basically just visual polish that I think looks cool. The throwing is
becaue the effect's kinda lame.
## Changelog
🆑
add: Altered the blood loss on teleportation. Instead of silently always
losing ten blood, you now lose ~15 25% of the time, fitting in with the
teleporter's random design. In practice this usually evens out, but the
immediate side-effects when it does happen will be much more noticeable.
The rest of the time you'll still lose 5.
qol: Improved the visible effects when using the teleporter. On
teleporting, it causes a tiny blood red wave at the destination, which
is slightly larger and more vibrant red if you lose blood. Telefragging
someone now throws them a random turf away alongside the stun.
fix: Fixed NOBLOOD check missing from non-emergency teleport bloodloss.
/🆑
## About The Pull Request
This pull request aims to fix the wiki manuals. Currently the wiki
manuals just show "You start skimming through the manual..." because of
a bad link (http://www.tgstation13.org/wiki instead of
http://tgstation13.org/wiki) which is fixed with this PR, but the issue
does not end there. Because BYOND uses trident for its `browse()`
function, a lot of Javascript and HTML elements do not function
properly, disallowing the removal or blocking of hyperlinks which break
the book entirely if they are clicked.
Therefore, as a temporary solution (until BYOND 516 is released with
webview2) when the user opens a book they are prompted with the
following:
Although not the best solution, it makes the books have a function again
and are usable.
Fixes https://github.com/tgstation/tgstation/issues/77315.
## Why It's Good For The Game
Makes books work again so new players can use them to be guided to the
wiki resources.
## Changelog
🆑
fix: fix wiki manuals by making them open wiki page on browser
/🆑
---------
Co-authored-by: san7890 <the@san7890.com>
## About The Pull Request
This pull request does a little bit of cleanup that I came across awhile
ago while looking at #85081, then forgot about, then came back up when I
was looking at some additional cleanup that needed to be done.
Reorganizes the handle_wave_conclusion function such that it can take a
force arg, to force a ore vent to be completed for debug purposes.
This also fixes a minor bug where vents, when successfully completed,
will still show a warning alert that the waves were failed, and that the
vent has closed up.
Grammar fix to the examine of boulder processing machines.
Moves the can-move behavior of boulders on conveyor belts and during
regular stacking to an early return over a late return (Thank you
Goofball for pointing that out).
Artifact boulders will now default to their artifact icon_state whenever
possible.
Finally, adds an additional sanity check to boulder processing to check
for custom material length, to attempt to avoid zero-content boulders
existing and running into the afforementioned #85081
## Why It's Good For The Game
Largely applies cleanup to several aspects of the boulder processing
system, and a handful of (hopefully) performance related rearrangements
to the existing layout of boulder processing code.
I can't for sure say that it'll fix the linked issue, due to the fact
that I could not for some reason re-create the issue in local testing,
but I'm hopeful that it's some kind of nebulous sanity-related issue.
Cleans up grammar in some spots, and provides a useful debug tool for
admin purposes when you just want a vent to flip. Might be a good
justification for a ore-manager admin panel later? 🤷
## Changelog
🆑
fix: Artifact boulders should keep their alien icon even after a first
round of processing.
fix: Boulders are less likely to exist with zero materials after
processing.
fix: Boulders should be slightly less laggy on conveyor belts.
fix: Grammar of refinery/smeltery examine is corrected.
/🆑
