Commit Graph

35386 Commits

Author SHA1 Message Date
candle :)
33f9be2c42 [READY] [MOSTLY MODULAR] Vox sprite fixes, updates, and additions (#7522)
* [DRAFT} Vox sprite fixes, updates.

* spriiiiiiite fiixeeesssss

* sprite name fix

* part one

* PART 2

* modularization moment
2021-08-22 01:40:28 +01:00
Pinta
528dddb1c9 [MOSTLY NON-MODULAR] Hypovials can be printed from ChemMasters and pill presses. (#7601)
* Hypovials are printable via the chem-master

* Hypovials can now be made from factories

* There really isn't a reason for this to be in the autolathe any more.

* linters

fuck
2021-08-21 22:30:13 +01:00
AxieTheAxolotl
897c1f0db3 round2electricboogaloo (#7612) 2021-08-21 22:24:46 +01:00
Useroth
991e756273 Adds a mapping helper that can cycle multiple airlocks regardless of location (#60675) (#7641)
currently cycle helpers only work in straight lines, this limits mapping design for airlocks, i now present to you a new mapping helper where all you do is set a var for the helper, and paste it over airlocks, and those airlocks will now all sync up so only one of them can be open at a time (as of now clicking an airlock to open them wont cycle, but the current cycle helpers dont do it either so its consistent)

Co-authored-by: 小月猫 <alina.r.starkova@gmail.com>
2021-08-21 22:24:00 +01:00
SkyratBot
d844631cb7 Moving aside your mask will no longer make you impervious to disease (#60923) (#7689)
Co-authored-by: MonkeyThatCodes <MonkeyThatCodes@deez.com>

Co-authored-by: AMonkeyThatCodes <20987591+AMonkeyThatCodes@users.noreply.github.com>
Co-authored-by: MonkeyThatCodes <MonkeyThatCodes@deez.com>
2021-08-21 22:15:19 +01:00
SkyratBot
13b9467b9f Runtime fixes batch. (#60946) (#7688)
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>

Co-authored-by: AnturK <AnturK@users.noreply.github.com>
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2021-08-21 22:15:10 +01:00
SkyratBot
f76747d3cc span fixes (#60936) (#7686)
Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
2021-08-21 22:14:57 +01:00
SkyratBot
f1c39adacd Added component manipulation on objects (#60771) (#7682)
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>

Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
2021-08-21 10:20:01 -04:00
SkyratBot
09d2b6d037 Fixes non-clothing mask slot items runtiming breath, also makes gas filtering a defined bitfield like it should be (#60938) (#7680)
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2021-08-21 10:19:19 -04:00
SkyratBot
081c833bc2 Water temperature fix (#60788) (#7670)
* very slight tweak

"The solution freezes up into ice! x542"
BE GONE, THOT!

* comment

commented the change

* Update reagents.dm

Created a define for the melting/freezing point of water

* Update others.dm

changed 274 and 275 limits for water to WATER_MATTERSTATE_CHANGE_TEMP +-0.5

* defined drink dispenser temperature

* Added dispense temp define to service borg shaker

Sets the drink shaker reagents all to 274.5 with a define for future use. There is a 1 degree dead band for the water/ice reaction here, doing this makes it so water stays water and ice stays ice while still inside the shaker.

* Made the beer cold too

Did you know you've been drinking 26C/80F drinks this entire time? Gross.
More importantly, this gets the reagents all the same temperature, so that mixing drinks with the much colder stuff from the soda dispenser doesn't immediately raise the temperature and start things like the ice melt reaction.

* forgot a define in here

I put the define on the emagged borg shaker too, so that any drinks mixed in will not be an off temperature and start the ice melt reaction.

* Update code/__DEFINES/reagents.dm

Co-authored-by: Aki Ito <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>

Co-authored-by: SpookyTheFox <67441715+SpookyTheFox@users.noreply.github.com>
Co-authored-by: Aki Ito <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
2021-08-21 10:17:47 -04:00
jjpark-kb
6dfd617177 fixes some of the issues of the createanddestroy unit test (#7648)
* send help

* polychromic createanddestroy fix
2021-08-20 23:23:23 -04:00
SkyratBot
a2388b9961 Fixes solar stacking (#60799) (#7667)
Co-authored-by: MMMiracles <lolaccount1@hotmail.com>
2021-08-20 18:53:55 +01:00
SkyratBot
75a4f842aa unused proc begone (#60843) (#7666)
Co-authored-by: Colovorat <lolqwert569@gmail.com>

Co-authored-by: Colovorat <35225170+Colovorat@users.noreply.github.com>
Co-authored-by: Colovorat <lolqwert569@gmail.com>
2021-08-20 18:53:46 +01:00
SkyratBot
b4e301d655 Changes the input list in VV add component to tgui_input_list() (#60755) (#7665)
* Changes the input list in VV add component to tgui_input_list

* fuck

Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk>

Co-authored-by: Thunder12345 <Thunder12345@users.noreply.github.com>
Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk>
2021-08-20 18:53:35 +01:00
SkyratBot
5170b9ecda The Failsafe can now recover from an deleted MC (#60846) (#7664)
* The Failsafe can now recover from an deleted MC
Its also more reliable and can handle a situation where its main Loop runtimes and the MC is stuck

* Reset defcon level correctly
Oops left that in from debugging the levels

* Correctly recover SSasset

* Only decrease defcon if MC creation failed
Also add some sort sleep between emergency loops

* Makes the last two emergency actions manual procs
Since they are kinda unstantable its probalby best
if only admins call these manually

Its also more reliable and can handle a situation where its main Loop runtimes and the MC is stuck
You can also now debug Master/New()

While there will most likely never be any situation where the MC is just gone its still good to know that the game can recover from such a situation
For example maybe someone messed up a SDQL query or maybe someone wanted to delete the MC to create a new one hoping the Failsafe would do so for him

Co-authored-by: Gamer025 <33846895+Gamer025@users.noreply.github.com>
2021-08-20 18:53:14 +01:00
SkyratBot
880a681511 Fix crystallizer from getting stuck (#60839) (#7663)
This Pr stops the crystallizer from getting randomly stuck untill the recipe get changed
should fix other minor issues too by limiting the inserted gases by double the recipe amount (overshoot most of the time but is a non issue)

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
2021-08-20 18:53:03 +01:00
SkyratBot
a9775bcae5 honkspam component to element. (#60635) (#7657)
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2021-08-20 18:52:52 +01:00
SkyratBot
93a298569d Adds a qdeleted check to mob equipping. This fixes potential runtimes/harddeletes caused by attempting to add (#60902) (#7651)
stacks to a slot, since stacks will commonly self delete, even if you add them to different slots. This is
because stack code does not respect slots, and I can't figure out a good way to fix that outside of this.

Also fixes like, a 2% chance unit test failure caused by a mob spawner that has a low percent chance to spawn a
miner with cash in both pockets. I hate god.

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2021-08-20 18:52:16 +01:00
SkyratBot
6c58cc757e fixes the admin message when a circuit with admin_only = 0 gets executed (#60921) (#7659)
Co-authored-by: manofpepsi <71612753+manofpepsi@users.noreply.github.com>
2021-08-20 06:41:39 -04:00
SkyratBot
33415afb49 fix secondary error (#60913) (#7654)
Co-authored-by: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
2021-08-20 06:38:13 -04:00
SkyratBot
f9fb0673d4 Minor heretic research fixes (#60908) (#7652)
* Fix stalker/blood siphon unlock

Stalker now unlocks blood siphon instead of rusty. Both rusty and blood siphon are now unlocked by exactly two other knowledges, just like every other side path in the research tree.

* Flame birth description fix

Flame birth's research's description now describes flame birth and not what I assume to be touch of madness.

* Curse of corrosion description fix

Curse of corrosion's description no longer states the ritual requires a pair of hands.

* Further corrosion description edit

I missed that there was one more mistake in the curse of corrosion description, so I changed that as well.

Co-authored-by: ViktorKoL <44502667+ViktorKoL@users.noreply.github.com>
2021-08-20 06:36:39 -04:00
SkyratBot
a7239ffc60 Fix thermomachine temperature abuse (#60841) (#7650)
* no more abuse

* derp

* some changes

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
2021-08-20 06:34:29 -04:00
SkyratBot
84dfef16da Fix fire exploit being extinguished by pAIs, borgs, and simple animals (#60852) (#7649)
* Fix fire being extinguished by pAIs, borgs, and simple animals

* Add trait TRAIT_NOFIRE_SPREAD

* Add NOFIRE_SPREAD traits to simple and silicon mob types

* Refactor spreadFire proc to use check TRAIT_NOFIRE_SPREAD

Co-authored-by: Tim <timothymtorres@gmail.com>
2021-08-20 06:33:59 -04:00
SkyratBot
5217a99d88 we hate jannies (#60883) (#7647)
Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com>
2021-08-19 19:39:51 -04:00
SkyratBot
ad35f582a9 i have moved some bible exorcism functionality to a signal on soulstones (#60768) (#7622)
moves functionality of exorcising soulstones to soulstones themselves

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
2021-08-19 14:27:31 -04:00
SkyratBot
b95cc44e35 Fix mulebot movement while controlled by a player (#60909) (#7636)
Co-authored-by: Tim <timothymtorres@gmail.com>
2021-08-19 14:25:08 -04:00
GoldenAlpharex
67c0375d0b Removes what I added due to wrong order (#7640)
Didn't have time to propose the changes on the PR but oh well.
2021-08-19 12:00:32 -04:00
SkyratBot
40c5a53613 puts chem mass spectrometer inline with other machines (#60896) (#7634)
Co-authored-by: manofpepsi <71612753+manofpepsi@users.noreply.github.com>
2021-08-19 11:44:53 -04:00
SkyratBot
af632bec7f fix ntnet circuit components (#60917) (#7633)
* fix ntnet

* fix typos and switcheroos

* whoops, tracked a test circuit json.

Co-authored-by: Gurkenglas <gurkenglas@hotmail.de>
2021-08-19 11:44:07 -04:00
SkyratBot
d8436f2d9f Fixed duplicator (#60912) (#7632)
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>

Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
2021-08-19 11:42:52 -04:00
SkyratBot
6857b80531 Lazy fix for wizards spawning without a spellbook when they roll the die of fate and missing a limb (#60506) (#7631)
Co-authored-by: jughu <melvin2626@live.nl>
2021-08-19 11:41:59 -04:00
SkyratBot
58d1efe477 Hahaha, Johnathan, you GAGS'ified my beret (#60884) (#7630)
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-08-19 11:41:10 -04:00
SkyratBot
c9f906c1cc Fix picture metadata storing json strings inside json. (#60911) (#7629)
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
2021-08-19 11:40:19 -04:00
GoldenAlpharex
77d5f9cb43 [SEMI-MODULAR] Adds an override to allow the use of icon2html RARELY when we need it, fixing in the same swoop the in-game GAGS coloring screen (#7615)
* Adds an override to allow the use of icon2html in rare cases

* That should've been properly documented as SKYRAT EDIT, whoops
2021-08-18 02:29:25 +01:00
Gandalf
e845d444d0 Kills a few hardels we created. (#7614)
* a

* Update liquid_effect.dm

* Update create_and_destroy.dm

* Update create_and_destroy.dm

* Update kink_collars.dm

* Update pillow.dm

* Update zombie.dm
2021-08-18 00:21:00 +01:00
SkyratBot
169c42a262 [MIRROR] Refactors connect_loc_behalf into a component (#7613)
* Refactors connect_loc_behalf into a component (#60678)

See title. Also refactors caltrops into a component because they use connect_loc_behalf which requires them to hold the state.

This also fixes COMPONENT_DUPE_SELECTIVE from just outright not working.

connect_loc_behalf doesn't make sense as an element because it tries to hold states. There is also no way to maintain current behaviour and not have the states that it needs.
Due to the fact that it tries to hold states, it means the code itself is a lot more buggy because it's a lot harder to successfully manage these states without runtimes or bugs. 

On metastation, there is only 2519 connect_loc_behalf components at roundstart. MrStonedOne has told me that datums take up this much space:
image

If we do the (oversimplified) math, there are only ever 5 variables that'll likely be changed on most connect_loc_behalf components at runtime:
connections,
tracked,
signal_atom,
parent,
signal_procs

This means that on metastation at roundstart, we take up this amount: (24 + 16 * 5) * 2519 = 261.97600 kilobytes
This is not really significant and the benefits of moving this to a component greatly outweighs the memory cost.

(Basically the memory cost is outweighed by the maint cost of tracking down issues with the thing. It's too buggy to be viable longterm basically)

* Update glass.dm

Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-08-17 20:29:11 +01:00
SkyratBot
cae8396538 [MIRROR] tgui maintenance chores (#7597)
* tgui maintenance chores

* AAAAAA

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-08-17 19:15:40 +01:00
SkyratBot
8ff0b49bc6 [MIRROR] Extends suspicious login logging to players with a banned account in their connection history. (#7590)
* Extra loog (#60869)

* Extends suspicious login logging to players with a banned account in their connection history.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2021-08-17 18:59:30 +01:00
SkyratBot
b0c01e40af [MIRROR] Del The World: Unit testing for hard deletes (#7589)
* Del The World: Unit testing for hard deletes (#59612)

Co-authored-by: SteelSlayer <42044220+SteelSlayer@ users.noreply.github.com>

* Del The World: Unit testing for hard deletes

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: SteelSlayer <42044220+SteelSlayer@ users.noreply.github.com>
2021-08-17 18:58:57 +01:00
death and coding
313a941538 [modular][ready]transfers the old cowboy poncho to the neckslot and adds obj sprites for mantles (#7586)
* [modular][ready]transfers the old cowboy poncho to the neckslot

* blood b gone

* Update cloaks.dm

* FINALLY

* AAAAAAAAAAAAAAAAAAAAA FIXES

* Update neck.dmi

Co-authored-by: louiseedwardstuart <bonniefluff>
2021-08-17 13:46:05 -04:00
Gandalf
a43b8c5fc4 Nanotrasen Fleet Command Expansion (#7418)
* A

* Update centcom_computers.dm

* a

* Update CommandReportConsole.js

* commandreporter

* Update command_report_computer.dm

* a

* FEET COMMAND

* a

* e

* e

* Update departments.dm

* F

* a

* a

* Update new_player.dm

* Update new_player.dm

* AAAAAA

* Update zombie.dm

* Update zombie.dm

* aaaaaaa

* 0

* a

* Update CentCom_skyrat.dmm

* aa

* Update nsstitan.dmm

* A

* Update station_goal_computer.dm

* Update station_goal_computer.dm

* Update bridge_officer.dm

* Update CentCom_skyrat.dmm

* Update pda.dm

* Revert "Update pda.dm"

This reverts commit fbe1823726f9edb7f7c3ba03c2d34b08b46ae294.

* logic

* cargo system

* 0

* Update import_console.dm

* Update cargo_skyrat.dmm

* noob coder

* Update cargo_shuttle_console.dm

* a

* Update deck_crew.dm

* Update export_console.dm

* Update deck_crew.dm

* 0

* Update CentCom_skyrat_z2.dmm

* AAAA

* 0

* Update CentCom_skyrat_z2.dmm

* Update cargo_shuttle_console.dm

* Update CentCom_skyrat_z2.dmm

* a

* SELLING CREW IS BAD.

* a

* Update supply.dm

* Update CentCom_skyrat_z2.dmm

* Update supply.dm

* A

* a

* a

* Update zombie.dm

* Update modular_skyrat/modules/central_command_module/code/jobs/fleetmaster.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-08-17 18:43:19 +01:00
GoldenAlpharex
1ed7db16bb Minor beret fixes (#7587) 2021-08-17 18:42:18 +01:00
SkyratBot
0d66c3ef14 [MIRROR] Fix a bad to_chat call (#7611)
* Fix a bad to_chat call (#60893)

* Fix a bad to_chat call

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
2021-08-17 13:35:50 -04:00
SkyratBot
37268abb23 [MIRROR] Fixes NTNet Transmitters not working (#7592)
* Fixes NTNet Transmitters not working  (#60871)

* Fixes NTNet Transmitters not working

Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
2021-08-17 13:29:49 -04:00
jjpark-kb
4fc56175f2 small warning (#7606) 2021-08-17 16:13:30 +12:00
SkyratBot
8794b3bcff [MIRROR] Fixes right click on circuit controller (#7584)
* Fixes right click on circuit controller (#60840)

Co-authored-by: Colovorat <lolqwert569@ gmail.com>

* Fixes right click on circuit controller

Co-authored-by: Colovorat <35225170+Colovorat@users.noreply.github.com>
Co-authored-by: Colovorat <lolqwert569@ gmail.com>
2021-08-15 23:53:21 +01:00
SkyratBot
7a1d3700bb [MIRROR] Drugs of the 26th century. Three new hella rad drugs, one less lame drug and more! (#7481)
* Drugs of the 26th century. Three new hella rad drugs, one less lame drug and more!

* Update traits.dm

* Update maint_loot_trash.dm

Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-08-15 23:52:58 +01:00
SkyratBot
1b4eb35853 [MIRROR] Fixes new ticket ahelp message double sanitizing (#7561)
* Fixes new ticket ahelp message double sanitizing

* Update adminhelp.dm

Co-authored-by: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-08-15 23:45:48 +01:00
SkyratBot
40cb513cfd [MIRROR] Mindshielding now sends a signal, and is dealt by the antagonist (#7573)
* Mindshielding now sends a signal, and is dealt by the antagonist (#60850)

Mindshielding people isn't hardcoded to the mindshield's implanting anymore, instead sending a signal, which I find better in the long run (especially for downstreams).

* Mindshielding now sends a signal, and is dealt by the antagonist

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2021-08-15 23:44:03 +01:00
Gandalf
c46a2a7ac9 Ports pollution from Horizon - Original PR: https://github.com/hrzntal/horizon/pull/468 (Made by Azarak) (#7453)
* AAAAAAAAAAA

* pollution scrubbbies

* fires cause smoke, right? Also NSS journey has scrubbies

* washing things removes the smell!

* what the fuck were you doing last night

* Update temporary_pollution_emission_component.dm

* space turfs shouldn't have pollution

* Fix air now fixes smoke

* Update pollution.dm

* Update pollution.dm

* Update bonfire.dm
2021-08-15 23:41:20 +01:00