Commit Graph

5124 Commits

Author SHA1 Message Date
Emmett Gaines
2cf7728494 Removes the bitflag helpers (#49106) 2020-02-03 16:26:00 -05:00
AnturK
33e3622f27 Add basic sanity to keybindings (#49116)
Not a fan adding another wrapper here but alternative is copypasta 
everyone will forget.
2020-02-02 19:51:39 -08:00
RaveRadbury
8b19d797ca [Ready] Prisoner role (#48819)
About The Pull Request

I observed someone request to be perma'd round start and then they just chilled in perma the whole shift. Security isn't always going to be up for putting people in perma and players who have been placed in perma tend to go catatonic. This allows players who are interested in having a chill shift doing the stuff in perma and acting like they've done crimes the opportunity to do that.
Why It's Good For The Game

Crew content. I'm not saying it's mindblowing but if we add it in as a role it will open the door for people to look at perma and what could be done with prisoners.

Prisoners spawn with a prison ID, a jumpsuit, and shoes. They are also currently spawning with a backpack and I'm uncertain about whether or not I want to do anything with that.

This is ready for a testmerge and worked for me locally.

Thanks to Tralezab for assistance with merge conflicts.
Thanks to EOBGames for the plasmaman prisoner sprites.
Thanks to Quill-Weave for encouragement.

Feedback is of course welcome, and I'd appreciate suggestions re: balancing this role. Maybe they should be roundstart pacified or something.
Changelog

cl
add: Adds prisoner role
/cl
2020-02-03 09:54:03 +13:00
Swept
2a14ee03d6 Fixes typo in sleeping_carp.dm (#49107)
Fixes #49100 

Changes wording of the "Sleeping Carp Wrist Wrench" from

"Your wrist is grabbed by [A] while simultaneously wrenched it to the side!"

to

"Your wrist is grabbed and simultaneously wrenched to the side by [A]!"
2020-02-02 21:17:15 +01:00
MrPerson
12eecfd181 Makes raw HTML and browser datum popups UTF-8 aware (#49066)
* Makes raw HTML and browser datum popups UTF-8 aware

Admin menus specifically really shouldn't break just because you named some guy "☺s the Clown"

* Fixed new_player.dm

* Fucking filing cabinets
2020-02-01 22:14:31 +01:00
Time-Green
8ecbacc002 fixes item reactions breaking plumbing (#49088)
🆑
fix: fixes reaction chamber breaking with flour-like reactions
/🆑
2020-02-01 20:49:34 +13:00
Rob Bailey
62d1a3941c tgui-next ntos card console (#48938)
About The Pull Request

A PR now several weeks in the making that spiraled ridiculously out of control for something not many even use.
What else is new in NTOS hell?
I spent several days doing nothing but playing escape from tarkov so this took longer than expected I valiantly spent all night and day working on this, and barely finished it before The Deadline
the card ntos program was split into three programs, manifest, job management, and id card modification. It didn't make much sense for them all to be the same program imo, and made the project a bit more managable.

Airlock electronics saw some improvements as well since it uses this new access control section as well.

Yet again some new functionality and improvements to core components. Buttons now have an "altSelected" feature where instead of changing the color it adds a small white marker, among some other things.

There were a couple of small changes in inconsequential ways in other places, and datacore was refactored a tiny bit. Probably some other stuff I don't remember.

I would replace the old card console with a modular computer right now, but I know a few people actually use this program and want a bit of time to iron out bugs and inconsistencies before replacing the main job console with it.
Changelog

🆑
add: tgui-next NTOS card console, job manager, and crew manifest
tweak: airlock electronics interface is a little fancier

/🆑
2020-02-01 20:47:36 +13:00
blessedmulligan
54dc879f19 Cyborg spin throwing now depends on intent (#48891)
Trying this again. When *spin-ing as a cyborg, the way mobs are thrown off you depends on your intent. On help intent, they will be thrown a shorter distance from you and will never be damaged or stunned (they will still be knocked down). On harm intent, they will be thrown the current distance and will be damaged and stunned if they hit a wall or another person.

WHAT THIS ACTUALLY CHANGES:
Currently, whether or not *spin-ing will actually hurt/stun someone depends on whether or not the *spin-ing borg is emagged. This PR also reduces the range of the help intent throw, but since the knockdown happens whether or not the thrown mob hits something this is in most circumstances a cosmetic change. So, in summary, if you are a non-emagged borg in help intent the only thing this changes is you will chuck people a slightly shorter distance.
Why It's Good For The Game

This isn't exactly the most important change, but a borg should be able to control their behavior. Having damage/stun from throwing determined solely by emag-ness seems more like a hacky kludge than a legitimate design choice. Also, having the behavior of borg-throwing determined in the code for carbons is messy.
Changelog

🆑
add: The behavior of cyborg's *spin emote now changes with intent; on harm intent, it will throw its passenger farther and damage and stun them if they hit a wall or another person.
/🆑
2020-02-01 20:30:57 +13:00
81Denton
0a7e819b07 Merge pull request #48882 from XDTM/BepisProgramsPartOne
[Ready][Ready]Adds the Nanite Replication Protocols node to BEPIS
2020-02-01 08:05:00 +01:00
81Denton
14abd06e81 Merge pull request #48779 from Fikou/patch-94
you can only slice aggressive grabs or higher now
2020-02-01 07:58:51 +01:00
Mickyan
4ec3f952f0 proper fix 2020-01-30 20:26:48 +01:00
Mickyan
54edfc27cd sanity fix 2020-01-30 19:43:02 +01:00
skoglol
d33b46bb37 Light step quirk rebalance (#49059)
* Light step rebalance

* null check

* Reduced cost back to 1
2020-01-29 13:46:51 -05:00
oranges
077d450fd2 Merge pull request #49036 from AnturK/hypnoregex
Fixes hypnosis regex.
2020-01-29 13:02:01 +13:00
fluffe9911
00043330a0 New King Goat Lavaland Boss! (#48823)
About The Pull Request

This pr adds in a new lavaland boss in a seperate z level arena also included are goat plushies that ram into people and goat skins which you get by butchering goats and can wear on your head, a goat gun that shoots goats and finally multiple tweaks/fixes generally involving possible ways to teleport out of noteleport area and or cheese the king goat.
Why It's Good For The Game

Lavaland has not seen any new bosses for a long bloody time and although the boss may be a bit silly I feel more hardcore players will enjoy the challenge it brings since this is meant to be a very hard boss also new goat related items are always neat.

🆑 Fluffe9911 for porting/making most of it, Monster and Sabiran for the King Goat!
add: A new king goat lavaland boss!
add: Goats now drop skin which you can wear on your head! (coder sprite)
add: Goat themed plushies that ram people! (realistic version sprite by identification code by karma)
/🆑

goat

This is ported over from my work on yogstation with minor changes mostly to make things work there is more goat content I made but didnt wanna do too much at once and dont know if tg would like it
2020-01-29 11:50:27 +13:00
ma44
a338b0a584 Refactors the crafting component (#48765)
About The Pull Request

Allows the crafting component to not be limited to just mobs but also able to be put on just about any atom, in addition it also gives a bit more settings to play around with like increasing the range of the ingredients search or choosing what to do with an item before it's placed anywhere.
Why It's Good For The Game

Enables greater functionality and may be a precursor PR before implementing automatic crafting machinery as this PR would allow machines to be able to do such a thing.
Changelog

🆑 ma44
refactor: Crafting has now been refactored and allows non mobs to have the ability to craft, at least that's what would come out of it if someone further developed the idea.
/🆑
2020-01-29 11:44:21 +13:00
vuonojenmustaturska
40657c9ccd removes a bunch of unused/bad helpers (#48969)
* a commit

* Update code/controllers/subsystem/persistence.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* Update code/__HELPERS/text.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* Update advance.dm

* Update security_officer.dm

* Update text.dm

* Update unsorted.dm

Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
2020-01-28 16:22:20 +01:00
AnturK
b7aa7ef4b4 Saves a bit of memory per decal (#48985) 2020-01-27 16:28:23 -05:00
AnturK
3b53192d46 Merge pull request #49011 from AutomaticFrenzy/patch/docslink
Fix docs link in components readme
2020-01-27 13:33:16 +01:00
Tlaltecuhtli
812a3ab0e8 foxes #48898 chem tongue bug (#49002)
🆑
fix: chem tongue is now only available by combo'ing
/🆑
2020-01-27 11:38:00 +01:00
Time-Green
d7db7c0605 Fixes plumbing ducts appearing disconnected (#48924)
* fixes ducts appearing disconnected

* adds comment to remove connects

* adds newlines for comments and fixes an autodoc typo
2020-01-27 11:25:32 +01:00
AnturK
fa4297dbbe Fixes hypnosis regex. 2020-01-27 08:07:41 +01:00
spookydonut
01b4d9e811 Fix cast() parameters (#48997)
About The Pull Request

Working on detecting type mismatches of parameters for SpacemanDMM and discovered these.

I also checked by hand that all uses of cast() provide a list as the first argument.
2020-01-27 09:48:42 +13:00
Tad Hardesty
906e912a8e Fix docs link in components readme 2020-01-25 15:53:09 -08:00
Rohesie
7bef84f009 Mass-replacement of stat to machine_stat (#48758)
Living and machine stat vars are pretty different, one uses flags and other number-defines.
This should make some other mass-replacements and searches a bit easier.
2020-01-24 12:37:17 +13:00
ArcaneMusic
b62d105228 Adds the Wood Datum Material, giving it to items made from wood. (#48820)
* Initial commit, wood datum mat. Works on my machine.

* Wait this makes baseball bats worthless nevermind

* Review changes, uses the define now, just don't know how bitflags work well enough for that other bit

* Adds the material dependance check

* FINE
2020-01-23 17:36:10 -05:00
QualityVan
03f74c5d0e fixed addiction getting reassigned mid deletion (#48942) 2020-01-23 12:51:31 -05:00
ArcaneMusic
d9a0cad8ca SOUTH BRONX PARADISE BABY!!! (New Contraband Candy Bar) (#48855)
* SOUTH BRONX PARADISE BABY!!!

* Rejiggered chemical values.

* Now with 200% more infectious insects.

* With Grammarly, you too can write professional quality letters, for a small fee!

* Clean up, keeps message spam to a minimum.

* Tral had a brilliant idea

* Review comments and review changes
2020-01-22 23:22:28 -08:00
skoglol
d61239fa14 Merge pull request #48921 from itseasytosee/Beergoggles
Separates beer googles into science glasses and beer goggles. Sprites for each!
2020-01-23 03:41:31 +01:00
skoglol
b735d25cb6 Swaps boh and ooc confirm dialog button positions (#48905)
* Swaps boh confirm dialog button positions

* and the ooc alert
2020-01-22 12:52:17 -05:00
Flint
c7e7e2ac97 The separation 2020-01-21 16:48:31 -06:00
tralezab
b5e60140c9 webbing production works now, fixes some grammar (#48922)
* fixes :^(

* whom niggas be like
2020-01-21 08:16:11 +01:00
skoglol
38f5a94715 Merge pull request #48670 from ExcessiveUseOfCobblestone/the-man-who-has-it-all
The Janitor Strikes Back: Scrubbing (Cleaning) Skill / `remove_any` proc granularity change
2020-01-20 10:17:28 +01:00
tralezab
4a48f2b9d9 adds genetic powers (theres a new one since you last looked) (#48665)
* relic file

* Revert "Merge branch 'master' of https://github.com/tralezab/tgstation"

This reverts commit 826916d87b421dbb0ebcfce7fad96e456b6d3674, reversing
changes made to a0f476d874.

* tongue spike, chem spike

* oh god github desktop is shitting and farting

* ahhhh so broken bros

* final commit before recreation

* readds sprites, makes it work and compile

* webs

* sprite readded

* web icon

* cooldown fix

* compile dammit

* review done

* early return
2020-01-19 18:29:18 -05:00
XDTM
69f19900bc updates 2020-01-19 14:01:52 +01:00
XDTM
c3ad4282a5 Adds a nanite node to BEPIS 2020-01-19 03:34:17 +01:00
MrPerson
f7eb2c905b Unicode awareness Part 2 -- copytext() (#48512)
* Unicode support Part 2 -- copytext()

This is the transition of all copytext() calls to be unicode aware and also some nearby calls in the same functions. Most things are just replacing copytext() with copytext_char() as a terrible character limiter but a few others were slightly more involved.

I replaced a ton of
````
var/something = sanitize(input())
something = copytext(something, 1, MAX_MESSAGE_LEN)
````

with a single stripped_input() call. stripped_input() already calls html_encode(), trim(), and some other sanitization so there shouldn't be any major issues there.

This is still VERY rough btw; DNA is a mess, the status displays are complete ass, there's a copytext() in code\datums\shuttles.dm that I'm not sure what to do with, and I didn't touch anything in the tools folder. I haven't tested this much at all yet, I only got it to compile earlier this morning. There's also likely to be weird bugs until I get around to fixing length(), findtext(), and the rest of the string procs.

* Makes the code functional

* Assume color hex strings are always # followed by ascii.
Properly encodes and decodes the stuff in mob_helpers.dm which fixes some issues there.

* Removes ninjaspeak since it's unused
2020-01-18 13:07:22 +13:00
skoglol
feecf28fa5 Merge pull request #48616 from cacogen/wayfindingpinpointers
Fixes wayfinder dispenser sprite/lowers amount of pinpointers from it/adds pinpointer recycling
2020-01-17 10:58:27 +01:00
AnturK
a630c7a94b Fixes observer alerts (#48793)
* Makes alerts work for observers.

* Basic click sanity.

* lint
2020-01-16 20:40:44 -05:00
cacogen
90fe68763d Less wayfinder pinpointers from dispenser 2020-01-17 12:28:01 +13:00
spookydonut
3195ceaa22 Update SpacemanDMM suite to 1.2 (#48785)
* Update SpacemanDMM suite to 1.2

* Fix new lint errors
2020-01-16 11:49:39 -05:00
AnturK
bca492823a Runtime fixes: Episode 113 (#48814)
* Fixes mood nanite settings

* Fixes yet another quirk runtime.

* Ugly paperplane fix

* Abductor armor runtime.

* cablecutting runtime

* Nukeop death runtime (were those spec deaths meant to fire on gibbing too ? )

* headpike runtime fix

* ERT outfit runtime

* bonfire oxygen runtime

* Rest of nanite updates
2020-01-16 11:16:37 -05:00
Buggy123
5efd5df30d Added cult major loss if Narsie is destroyed. (#48251)
* Added cult major loss if Narsie is destroyed.

* Minor corrections.

* Why did this compile?

* Minor fixes.

* Not bool

* Changed to defines as requested
2020-01-14 18:22:49 -05:00
ExcessiveUseOfCobblestone
0b1ee46427 コメント 2020-01-14 17:25:38 -05:00
ExcessiveUseOfCobblestone
f89ef0af74 Revert "applies citrus"
This reverts commit fb9f229478.
2020-01-14 17:24:22 -05:00
Fikou
1660a962c5 neck slices now dont work on critical/sleeping people 2020-01-14 19:26:30 +01:00
Fikou
9c5cf98ce8 buff 2020-01-14 00:30:53 +01:00
Fikou
72bc98698d you can only slice neck grabs now 2020-01-14 00:10:05 +01:00
Ghom
1e15900f2d Fixes shock paddles being insertable in BoH (#48643)
* Fixes shock paddles being insert able in BoH

* Redundant.
2020-01-12 19:34:20 -08:00
Qustinnus
be23312096 New achievements and achievements icons (#48544)
* sdasd

* fixes

* fixed

* attempt 2

* Update skill_achievements.dm
2020-01-12 18:46:51 -08:00