* Purges two redundant proc calls. (#57421)
Title. dna.species.handle_body() calls remove_overlay(BODY_LAYER) already. I added a comment about the other one.
* Purges two redundant proc calls with human icon updates.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* ID trims no longer apply to cards when visualsOnly is TRUE on equip() (#57436)
* ID trims no longer apply to cards when visualsOnly is TRUE on equip()
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
* Fixes ID trim singletons ignoring config flags. (#57406)
* Fixes ID trim singletons ignoring config flags.
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
* Cayenne can pick up the nuclear authentication disk (#57395)
Co-authored-by: Emmanuel S. <emmanuelssr@ gmail.com>
Co-authored-by: Jordan Brown <Cyberboss@ users.noreply.github.com>
* Cayenne can pick up the nuclear authentication disk
Co-authored-by: Fikou <piotrbryla@onet.pl>
Co-authored-by: Emmanuel S. <emmanuelssr@ gmail.com>
Co-authored-by: Jordan Brown <Cyberboss@ users.noreply.github.com>
* Beauty element fixes for hard-dels and super-beauty (#57396)
* pass correct material amount to on_removed
* skip detach logic in beauty element for objects that don't actually have beauty
* always remove area-sensitive trait when detaching beauty element
* Beauty element fixes for hard-dels and super-beauty
Co-authored-by: William Wallace <me@wiox.me>
* Tweaks cryostylane to use the new reaction mechanics, incorporating stasis iceblocks, freezing, temporary organ decay prevention and surgery speed modifiers.
* Update holder.dm
* Update holder.dm
Co-authored-by: Thalpy <33956696+Thalpy@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
* Weakref docs (#57330)
Adds documentation to weakrefs, as I've been asked quite a few times how they work since existing code is a bit confusing.
* Weakref docs
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Fixes crafted foods not getting reagents from its contents (#57258)
* Fixes crafted foods not getting reagents from its contents
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* Scanner gates now have wires/interact with signalers. (#57195)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Scanner gates now have wires/interact with signalers.
Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Fix stacking of blast doors and shutters from crafting (#57360)
* Fix stacking of blast doors and shutters from crafting
Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
* At first i thought that i was being forced to add a feature 🤮 but then i realized i was being encouraged to refactor 😄. Electrified chair is now a component instead of a failure (#57117)
* At first i thought that i was being forced to add a feature 🤮 but then i realized i was being encouraged to refactor 😄. Electrified chair is now a component instead of a failure
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
* Rework plumbing reaction chamber, purity support (#57071)
Currently does four things:
The reaction chamber now supports purity! It has a yellow (acid) and green (basic) input for buffers, aswell as a setting to automatically dispense either an acidic or alkalic buffer when above/below a certain pH! Now you can make a 100% pure meth factory! The buffer connects are on an alternate layer.
Probably going to be less loved, but I removed the reaction chambers ability to pick reagents from the net. Instead, it will pull untill a set volume is reached. Then it'll start reacting. While this means that players will have to be more creative and use a wider array of machinery.
Also new machine! Buffers! They fill the hole that reagent chambers left. They can be set with a threshold volume and will only start putting out chems when ALL of their neighbouring buffers also are also above this threshold. You might have a lot of one chem and have to wait for a more specialized chem to be produced, and with the cleverness of reaction chambers gone, bufferers can do just that: wait.
I also removed all but two layers. I want to make it obvious what layer the buffer connects are on. Also layers are basically unusable and I'm gonna give them a rework very soon. I'll put the things back in then when they actually have something to contribute
* Reworks plumbing reaction chamber, purity support
Co-authored-by: Time-Green <timkoster1@hotmail.com>
* adds a bitflag for no random pixel shift on dropping, adds turf_flags var to replace usage of flags_1 on turfs (#57263)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* adds a bitflag for no random pixel shift on dropping, adds turf_flags var to replace usage of flags_1 on turfs
Co-authored-by: Fikou <piotrbryla@onet.pl>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Fixes ERT Briefing Officer Outfit pref (#57069)
I was dumb in #56345 and committed a suggestion from a maintainer without actually checking what it did, leading to the part where you select what outfit you want in your preferences to not actually let you select an outfit.
This also removes the can_be_admin_equipped var from outfit datums, apparently it was supposed to be used for outfits that were only supposed to be spawned in certain ways or some nonsense, but nothing actually used it so bye bye
* Fixes ERT Briefing Officer Outfit pref
* Update preferences.dm
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
* Adds unit test for spawned food edibility (#57232)
* Adds unit test for spawned food having reagents
- Adds stack trace for biting food failing due to a lack of reagents
- Adds checks for seed var being set under food/grown's initialize() in grown.dm
- Fixes issue with gondola meat code duplicated for penguin meat slabs resulting in a runtime and being unable to slice penguin meat
- Adds seeds for bombananas
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Adds unit test for spawned food edibility
Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Adds tourist robots that order food and drinks from the bar and cafeteria (#57010)
* Adds Tourism Economy
Co-authored-by: Emmanuel S. <emmanuelssr@ gmail.com>
Co-authored-by: ATH1909 <42606352+ATH1909@ users.noreply.github.com>
Co-authored-by: coiax <yellowbounder@ gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Adds tourist robots that order food and drinks from the bar and cafeteria
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Emmanuel S. <emmanuelssr@ gmail.com>
Co-authored-by: ATH1909 <42606352+ATH1909@ users.noreply.github.com>
Co-authored-by: coiax <yellowbounder@ gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Stop allergy effects while in stasis (#57188)
Allergy sufferers will no longer accumulate histamine and die on the
stasis bed while in stasis.
* Stops histamine and toxin damage from being applied to allergy sufferers while in stasis.
Co-authored-by: prodirus <44090982+prodirus@users.noreply.github.com>
* Combo streaks (not just the hud icons) now reset after half a dozen seconds (amount subject to change). (#57167)
Co-authored-by: Ghommie <425422238+Ghommie@ users.noreply.github.com>
* Combo streaks (not just the hud icons) now reset after half a dozen seconds (amount subject to change).
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: Ghommie <425422238+Ghommie@ users.noreply.github.com>
* Allows ghosts to start messages with asterisks in deadchat again (#57159)
#56519 had noble goals in trying to make emote code more robust for
ghosts, but in doing so it undid #47144, which was made to allow people
to start messages with asterisks in deadchat without getting hassled by
the game thinking you're emoting. This re-limits the emote checker to
the only two emotes ghosts have ever had, *spin and *flip.
* Allows ghosts to start messages with asterisks in deadchat again
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
* Beauty is now an element. Fixing an issue with enter/exit area comsigs. (#57147)
Co-authored-by: Ghommie <425422238+Ghommie@ users.noreply.github.com>
* Beauty is now an element. Fixing an issue with enter/exit area comsigs.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: Ghommie <425422238+Ghommie@ users.noreply.github.com>
* Monkeys no longer rip apart machines from the inside
monkeys only take things if theyre on a turf now...technically this bug made sense cuz the monkey was in the machine with the parts
* Monkeys no longer rip apart machines from the inside
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
