* Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking (#52761)
Adds SIGNAL_HANDLER, a macro that sets SHOULD_NOT_SLEEP(TRUE). This should ideally be required on all new signal callbacks.
Adds BLOCKING_SIGNAL_HANDLER, a macro that does nothing except symbolize "this is an older signal that didn't necessitate a code rewrite". It should not be allowed for new work.
This comes from discussion around #52735, which yields by calling input, and (though it sets the return type beforehand) will not properly return the flag to prevent attack from slapping.
To fix 60% of the yielding cases, WrapAdminProcCall no longer waits for another admin's proc call to finish. I'm not an admin, so I don't know how many behinds this has saved, but if this is problematic for admins I can just make it so that it lets you do it anyway. I'm not sure what the point of this babysitting was anyway.
Requested by @optimumtact.
Changelog
cl
admin: Calling a proc while another admin is calling one will no longer wait for the first to finish. You will simply just have to call it again.
/cl
* Adds SIGNAL_HANDLER and SIGNAL_HANDLER_DOES_SLEEP to prevent signal callbacks from blocking
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
About The Pull Request
Converts every single usage of playsound's vary parameter to use the boolean define instead of 1 or 0. I'm tired of people copypasting the incorrect usage.
Also changes a couple of places where a list was picked from instead of using get_sfx internal calls
This was done via regex:
(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\)) to match 1
(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\)) to match 0
full sed commands:
/(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\))/\1TRUE\2/ 1 to TRUE
/(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\))/\1FALSE\2/ 0 to FALSE
I'm not very good with regex and these could probably be optimized, but they worked.
Why It's Good For The Game
Code usability
* Sepia slime has a timer before activating
* Chilling and recurring
* Rewind camera
* Camera variable to disable customisation
* Removes unnecessary selfieing
* Changes rewind time to 10 seconds
* Simple animal fixes
* properly freezes bots
* Mech timestop
* P -> M
* Gives a warning message
* This should have commited with the last set
* Just screw my line lengths up
* Big changes
Adds pre-move COMSIG
Cuts down on lists in timestop
Adds the overlay to frozen projectiles
Timestopped things have INFINITY move_resist as opposed to being
anchored
Timestop will now unfreeze things that somehow leave it
Cleans up timestop code
mobs in the middle of a walk_to will have their walk stopped by timestop
mobs that are stunned will be stopped mid walk as well
Slimes respect mobility_flags & MOBILITY_MOVE
Slimes no longer automatically regain MOBILITY_MOVE whenever not cold
* Pulling and swapping places respect move_force
* Update code/modules/research/xenobiology/crossbreeding/_misc.dm
Co-Authored-By: 4dplanner <3combined@gmail.com>
* I have no idea if this will work, but hopefully makes stands immune to timestops if their master is.
* That looks better
* Maybe that will work, maybe it will not.
* Checks if the summoner actually exists.
As per review advice from @DaedalusGame.
* Refactors anti-magic into a component
* plenty o stuff, mainly holy and antimagic traits
* fix
* fix2
* moved to components, moved some of the logic to the component
* don't blame me if the code looks copypastey
* right
* Initial commit
* Time is a circus
* Send in the clowns
* i broke something
* Revert "i broke something"
This reverts commit 5a29c40d131b39effe9ebcb6c8c1883693baf07f.
* I think it works?
* cleanup
* define reminders
* Fixes tendrils and such
* sentience_act now moves the mob to AI_OFF state
