Commit Graph

2115 Commits

Author SHA1 Message Date
ShizCalev
4b6500fb67 Makes all anchored changes use setAnchored(), COMSIG_MOVABLE_SETANCHORED now only sent if an AM's anchored var has changed for more reliable usage. (#52254)
* Converts everything to use setAnchored() + other fixes

* Fixed singulo debug

* singulo again

* forgot to move the vv_edit proc

* caught that this time :)

* changes

* Update code/game/atoms_movable.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-21 02:20:26 -03:00
Ryll-Ryll
1f31064c3e Merge remote-tracking branch 'tgstation/master' into who-named-this-damned-proc 2020-07-16 21:43:14 -04:00
Aleksej Komarov
0cf00a2645 tgui 4.0 (#52085)
* tgui 4.0 hyper squash

* Upgrade dependencies
2020-07-16 20:13:04 +02:00
jdawg1290
62676e72a8 Force LF line endings with gitattributes and convert repo (#52266)
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-07-16 03:02:40 +03:00
ShizCalev
254536072e [s] sanity checks vv_edit_var() values (#52255)
cl ShizCalev
fix: Added some sanity checking for varedit values.
/cl
* sanity checks vv_edit_var() values

* this should be an or

* one more fix
2020-07-16 10:20:41 +12:00
ShizCalev
15122bd901 Fixes uncorrupted power cells exploding without plasma (#52213)
* Fixes uncorrupted power cells exploding without plasma

* commentary
2020-07-14 20:10:43 -04:00
LemonInTheDark
94dbb3cdb7 Fixes grounding rods not grounding (#52044)
* Fixes bolts not grounding properly due to a pass by ref

* This should obey the order
2020-07-12 13:28:32 +02:00
Ryll-Ryll
fc0b247738 rename 2020-07-11 23:23:23 -04:00
ShizCalev
90fef217c7 Fixes anchored state mismatch for field generators on delta (#52056) 2020-07-10 20:21:12 +02:00
LemonInTheDark
92209dd23a Sweeps up some rarely used and unbalanced sources of research points (#52012)
About The Pull Request

Removes the research point gen modes from tesla coils and rad collectors.
Someone is gonna take some flak for removing these at some point, may as well be me.
Why It's Good For The Game

THE DESIGN DOC DICTACT-

Nah powergen should be valid on it's own, it shouldn't need to rely on other econs to make it worth the work. We can try that later, but not now.
Changelog

cl
del: Removed the research modes from tesla coils and radiation collectors.
/cl
2020-07-07 11:02:33 +12:00
skoglol
f0f788ea32 Merge pull request #51969 from LemonInTheDark/sm-hugbox-moment
Fixes the sm gaining power when not intended
2020-07-04 18:03:21 +02:00
LemonInTheDark
f402f4e4ba Adds some more safety verbs 2020-07-03 23:59:45 -07:00
LemonInTheDark
365dfe1bec Fixes the sm gaining power when not intended 2020-07-01 21:44:00 -07:00
ShizCalev
411dea9542 Merge pull request #51659 from TaG2e/master
Fixes more missing sprites and adds invisible icon
2020-07-01 11:58:17 -04:00
spookydonut
88d1d36aef Removes some var/const that should be defines (#51461)
* Removes some var/const that should be defines

* change requests

* change requests
2020-06-25 03:00:09 -04:00
ShizCalev
872d4bb507 Fixes SM pulling the wrong mobs 2020-06-22 19:05:40 -04:00
TaG2e
8f72395637 Fixes more item icons, conflicts, and default hidden to false 2020-06-20 19:00:36 -05:00
LemonInTheDark
e5547a8f5c Supermatter variable documentation, cleanup, bugfixes. (#51345)
* Makes the supermatter file smaller.

AHAHAHAHHAHA YOU FOOL YOU HAVE FALLEN FOR MY TRAP CARD

* stable build maybe? sm cleanup begins

* The old ones knew

* lemme atomize actually

* I know how to spell ok? OK?

* braindamage

* That'll do it

* That do it?

* There we go

* Wow I should test things

* test?

* I hope that clears it

* Should fix the formatting trouble

* isolates the opening proc

* Lowercase and fixes messed up proccall
2020-06-19 18:48:06 -03:00
WarlockD
12540c7b30 Fixed cyborgs using multi layer cables. (#51714)
* Fixed cyborgs using multi layer cables.

* I guess human's should work on wires too

* Ugh I need to look more at the mob code some day
2020-06-19 11:55:50 -04:00
nemvar
b87f65d95e Converts ALL typepaths to lowercase (#51642)
* Case of lower

* More changes

* Ruins the nice 420 diff, brainfart when doing the second batch of conversions

* More changes

* Next batch. I think

* Converts even more paths

* Restarts bots

* Capital Free Zone

* Come on travis, do something

* Renames areas

* Bots, please stop dying

* Updates CONTRIBUTING.md and updates a few paths I missed.

* APC recgarftzfvas
/obj/item/computer_hardware/recharger/apc to /obj/item/computer_hardware/recharger/apc_recharger
2020-06-17 20:47:57 -03:00
TaG2e
b9ec327c17 Fixes more missing sprites and adds invisible icon 2020-06-15 01:56:12 -05:00
ShizCalev
cbaf10eea1 Fixes singular cable stacks never showing up properly 2020-06-15 02:07:14 -04:00
MacBlaze1
f28e8e4c3b abusing AIs (#51284) 2020-05-26 14:15:15 -04:00
Timberpoes
8d99381264 Fixes SMES not charging from self-recharging cells. (#51240)
* Check for slime cores and charge based on them

* Spellchack

* Implemented self_rechaging check instead.
2020-05-25 23:34:01 +08:00
nemvar
6ef421be42 Renames a few variables. Also reorders icon fallback order again. (#51060)
* Renames a few variables. Also reorders fallback order again.
Renames item_state to inhand_icon_state
Renames mob_overlay_icon to worn_icon
Renames mob_overlay_state to worn_icon_state
worn_icon_state/mob_overlay_state now never gets used for inhands.

* Fixes some comments

* Fixes map issue

* Restart lints

* Properly resolves conflicts
2020-05-25 06:47:19 +02:00
LemonInTheDark
4328cdcbd1 that'll do it (#50985) 2020-05-25 02:19:26 +08:00
spessman-007
ab84042f94 [READY] Improve spelling (#51134)
* Improve spelling

* Spell isn't, ain't, shouldn't, hasn't, wasn't correctly

Co-authored-by: NewSta <spessman-007@users.noreply.github.com>
2020-05-25 02:13:37 +08:00
LemonInTheDark
1614501d23 Datum view and some other things (#51208)
* Datumizes all uses of change_view

* Cleanup and helper procs

* tweaks values to match the format, hint hint, (value - 0.5) works just fine

* And there's the rest

* woop, braindamage

* and one more

* fuck you menu file

* woops

* we should apply that

* fixes tooltip drift, thank you goon coders

* you can shake but you can't zoom
2020-05-25 01:53:51 +08:00
spessman-007
5ae305ec9f Resolve issues with incorrect usage of a/an (#51095)
Co-authored-by: NewSta <spessman-007@users.noreply.github.com>
2020-05-25 01:34:34 +08:00
AnturK
35ad401ef9 Removes priority overlays (#51018)
* Removes priority overlays

* Fixup
2020-05-24 14:04:35 -03:00
vuonojenmustaturska
5e1f57de77 Speeds up area power usage handling, and apc process(). Cleans up related code (#51002)
About The Pull Request

/area/proc/usage() attempts to give list-like access to a bunch of vars. Why not make it a list instead and avoid all the proc calls? Might be room for followup here, to do something to powered(), use_power() etc.

Some legacy machinery was ignoring the default machinery use_power pulling from the machine's power channel by default

Total power usage was unused, APCs ignored it in favor of calculating it themselves :)

I also renamed the defines because they were in the danger zone of being very common words.
Changelog

cl Naksu
code: optimized area power usage calculations.
/cl
2020-05-11 11:33:56 +12:00
TerraGS
c575761a92 Fix broken potato battery icon (#51015) 2020-05-10 10:30:07 -07:00
LemonInTheDark
860af425c2 Talking about my problems (Adds Psychologist Features) (#50553)
* perfection

* uhhhhhh something something mental help analogy

* This is a test of the emergency github system
Have some music I found :) https://www.youtube.com/watch?v=-RKvpf__N98

* And so spake the fruit

* Adds a overlay type.

* ????

* that'll do for now

* and there's the rest

* we don't need that

* that should work

* shoot me

Co-authored-by: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>

* Wow I didn't understand that

Co-authored-by: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
2020-05-07 20:15:49 -04:00
Iamgoofball
a3aa69701a [READY] Basically, Instant Explosions 2: The Search For More Money: Eternal: A Tail Of Two Kitties: 33 1/3 (#50594)
About The Pull Request

Extools maptick stuff is in the game. Stolen from BeeStation/BeeStation-Hornet#1119, improves performance. Requires ex-tools on the server, though.

Explosions have been refactored to do the actual exploding in a subsystem.

Credit to goon.

Here's some videos!

Why It's Good For The Game
Basically instant max-caps now.
We can now give more of a tick over to the sending of map updates

Changelog

cl Goonstation Coders, Beestation, Extools devs
refactor: Explosions have been heavily optimized.
/cl
2020-04-30 10:27:53 +12:00
LemonInTheDark
006cc4947d An attempt to clean up tesla code (#50530)
* An attempt to clean up tesla code

* macro-op

* there we go
2020-04-24 21:34:40 -03:00
Fikou
564620c14d changes cult sprites + radials (#50620)
* makes cult sexy

* turns cult sprites into sex

* gurgr

* hola

* final commit maybe

* FUCK

* shit

* a

* walla walla bing bong

* man fuck

* i didnt even know you could do this wtf

* new sounds from actioninja

* ahoy spongebob

* yeah

* bazinga

* should be finished

* oops
2020-04-22 11:57:00 -03:00
Ghilker
9532dbd2a8 Hydrogen Gas (#50510)
* new PR no tgui bundle build yet

* tgui bundle built

* atmos.dmi conflict fix 2

* balancing

* tgui bundle fix
2020-04-20 14:47:22 -03:00
actioninja
b5dfd8880d id to component name 2020-04-19 19:36:35 +03:00
LemonInTheDark
483cbf552c Fixes bolt colors being jank (#50462)
Fixes bolt colors being jank, damage bolts should reset
2020-04-18 11:11:43 +12:00
Dennok
13456c32a7 remove hub coloring (#50345)
Remove hub color layer indication
Why It's Good For The Game

i see it redundant after i add cable visualization
2020-04-18 10:59:25 +12:00
LemonInTheDark
86f7cb35ab Revert "Revert "Added H2O support to the SM (#49624)"" (#50032)
This reverts commit 69a9eb0.
About The Pull Request

Fixes the sm producing fusion.
dynamic_heat_modifier and power_transmission_bonus never got a clean reset, and because they are global vars, kept gaining value. I've fixed this and tweaked 1 comment about max heat output.
This was a result of misunderstanding from both ghil and ninja, and is now thankfully fixed.
Why It's Good For The Game

This shit is neat, should actually be in the game rather then in my fixing pile.
Changelog

🆑
add: The h2o interactions have been polished and readded. Fucking global variables.
/🆑
2020-04-17 20:28:26 +12:00
Aleksej Komarov
947b74cdec tgui: Knobs, Sliders and Performance Improvements (#50483)
* Optimize Box

* Some tweaks to vending machines

* Layout debugger, initial work on sliders

* Slider, Knob, docs, refactoring, etc

* Rebuild tgui

* Knobby Canister

* Remove imports
2020-04-17 03:06:24 +08:00
Tad Hardesty
e699211c8a Fix editor icon state of layer 3 cables (#50400) 2020-04-06 16:50:20 +08:00
Dennok
08984765c8 [READY] Multi z and layer power rework (#49773)
* Multi z and layer power rework

* remove some

unfinished code

* some whitespaces

Co-Authored-By: Rohesie <rohesie@gmail.com>

* better bit

Co-Authored-By: Rohesie <rohesie@gmail.com>

* better bit

Co-Authored-By: Rohesie <rohesie@gmail.com>

* up EoL

* glob rad list

* up

* more glob radial lists

* up

* up

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-04-01 17:10:25 -03:00
Tad Hardesty
0c67ccf379 Fix runtime on cable bridge mapload initialization (#50280) 2020-03-30 22:27:46 +08:00
LemonInTheDark
d2726a19dc Fixes sm zap runtime to do with nonexistent turfs (#50200)
Checks to see if the turf we're zapping off exists and has a gasmix
Why It's Good For The Game

Makes things less cringe
Changelog

cl
fix: Fixed a supermatter zap runtime
/cl
2020-03-30 10:05:00 +13:00
wesoda25
8f62bf5405 Ethereals can no longer spam drain power sources//minor powersource drain time tweaks (#50084)
* finally!

* forgot this
2020-03-21 17:15:42 +01:00
LemonInTheDark
8746f42759 BoH modifications [headcoder orders] (#50083)
* Adds a sanity check to boh_tear process

* WHYYYYY
2020-03-21 17:09:36 +01:00
Ghilker
e7a22853f7 Addition of Freon (no removal, no fire) (#49821)
* Just freon addition, no removal nor fire. Maybe unbalanced

* fixes

* material properties addition, removed from the object itself

* added admin and game logging to hot ice

* Typos

* made the component more generic

* other typos, some fixes

* typos and balancing

* better code readability

* dunno

* merge error and travis build errors fixes

* asked changes, fixes and balancing
2020-03-20 19:08:50 -03:00
Whoneedspacee
7a0840fe00 Fixes Singularity Weirdness (#49931)
* objects moved into are now consumed

if the singularity bumps into an object it continues moving in the same direction

* no longer infinitely runs into not destroyed objects
2020-03-20 00:11:46 -07:00