Commit Graph

3549 Commits

Author SHA1 Message Date
Tastyfish
4eefadc8b4 Alternative job titles in the Occupations screen actually used in-game (#9420)
* Added alt jobs names actually doing something.

* Also add late join announcements.

* Fix custom roles showing up first in crew monitor

* Cleanup to match upstream changes

* Updates from review, also improve both tgui manifests

* Compromise for Skyrat edit notes vs JSX vs linter

* Compromise for optimization vs not making a horrible mess of passing client around

* Follow module rules

* Revert no longer true changed to customization readme

* Update dme

* Fixed comments for alt titles
2021-11-27 22:18:45 -05:00
SkyratBot
c1ca55382d [MIRROR] Fixes ghosts' boo ability going on cooldown when the light they tried to flicker didn't flick [MDB IGNORE] (#9672)
* Fixes ghosts' boo ability going on cooldown when the light they tried to flicker didn't flick

* Update code/modules/power/lighting/light.dm

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-11-23 21:35:02 -05:00
SkyratBot
6ac6dae856 [MIRROR] Fix random names breaking preferences [MDB IGNORE] (#9370)
* Fix random names breaking preferences (#62668)

The randomization (specifically from the random names secret) overrode your preferences, this fixes that.

* Fix random names breaking preferences

* Should fix the issue with that damn unit test.

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-11-23 13:36:22 -05:00
SkyratBot
3571a7db8b [MIRROR] Adds additional DB logging for admin help interactions [MDB IGNORE] (#9627)
* Adds additional DB logging for admin help interactions

* fixed conflicts

Co-authored-by: Nick <nick@nfreader.net>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2021-11-23 11:33:38 -05:00
SkyratBot
cda93811e6 [MIRROR] Add admin ckey to known alts panel [MDB IGNORE] (#9649)
* Add admin ckey to known alts panel

* fixed conflicts

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2021-11-23 10:48:21 -05:00
SkyratBot
ea65511447 [MIRROR] Add disabling footstep sounds and parallax to the lag switch panel [MDB IGNORE] (#9645)
* Add disabling footstep sounds and parallax to the lag switch panel (#62999)

At the last Toolbox Tournament, @ MrStonedOne pointed out some big performance consumers. Some are disablable through easy means, but others were not. This adds two easy ones to the mix.

* Add disabling footstep sounds and parallax to the lag switch panel

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-11-23 08:44:29 -05:00
SkyratBot
532ce4e9ef [MIRROR] Proper custom job name support [MDB IGNORE] (#9547)
* Proper custom job name support

* merge (#9552)

Co-authored-by: Tastyfish <crazychris32@gmail.com>
2021-11-20 22:52:42 +01:00
SkyratBot
d6a1ad473f [MIRROR] Allows players to send more visible adminhelps when no admins are on, which'll definitely alert admins [MDB IGNORE] (#9583)
* Allows players to send more visible adminhelps when no admins are on, which'll definitely alert admins

* db portion sorted out

* now it really is

* should work about fine

* one last touch

* well, one more

* also botched comment

Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2021-11-20 22:41:53 +01:00
SkyratBot
2c8a1d7905 [MIRROR] Fix Camera Report verb [MDB IGNORE] (#9525)
* Admin: Fix Camera Report verb (#62866)

There is still the potential for false positives since the way diagonal
cameras were made didn't exactly line up with where their direction was.

However, this brings functionality back to parity with before the
dir-sanity PR.

* Fix Camera Report verb

Co-authored-by: esainane <esainane+github@gmail.com>
2021-11-17 17:29:30 -05:00
SkyratBot
2e0e84a6dd [MIRROR] Antag HUDs will now animate if you have multiple antagonists, and will no longer clear on deconversion [MDB IGNORE] (#9397)
* Antag HUDs will now animate if you have multiple antagonists, and will no longer clear on deconversion (#62718)

About The Pull Request

This is for the admin combo HUD. Players shouldn't notice any difference (except at roundend).
2021-11-09T16-27-26.mp4

Removes the ability to set custom antag HUDs for custom admin teams for complexity, though if there's a large enough demand I can try to bring it back in another PR.

Fixes #59767

TM candidate only so that I can make sure antags aren't getting leaked to people who shouldn't see them.
Changelog

cl
fix: Antag HUDs will no longer clear on deconversion if the player was another antag.
qol: Antag HUDs (as seen by admins and at the round end) will now animate between all antagonists, rather than just choosing the most latest.
/cl

* Antag HUDs will now animate if you have multiple antagonists, and will no longer clear on deconversion

* Update sol_fed.dm

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-11-14 23:27:01 +00:00
SkyratBot
63e373bd95 [MIRROR] Adds debug verbs for grabbing the amount of food and stacks on the station [MDB IGNORE] (#9449)
* Adds debug verbs for grabbing the amount of food and stacks on the station (#62787)

Adds mapping debug verbs that pull info about how many food/stacks are in the world and on the station.
Puts them into happy little html uis to make em easier to read.

A stacks amount is it's actual amount, so the amount of items inside it, rather then the amount of stack groups

* Adds debug verbs for grabbing the amount of food and stacks on the station

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2021-11-14 23:19:45 +00:00
SkyratBot
259b859076 [MIRROR] Ref tracker TLC, makes unit test harddel errors more descriptive [MDB IGNORE] (#9396)
* Ref tracker TLC, makes unit test harddel errors more descriptive (#62725)

* Ref tracker TLC, makes unit test harddel errors more descriptive

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2021-11-11 21:41:11 -05:00
SkyratBot
c9b2d1ab35 [MIRROR] Makes the color matrix editor log all color edits [MDB IGNORE] (#9384)
* makes the color matrix editor log all color edits (#62717)

* Makes the color matrix editor log all color edits

Co-authored-by: Y0SH1M4S73R <legoboyo@earthlink.net>
2021-11-11 11:16:08 -05:00
SkyratBot
db8f7a2059 [MIRROR] Gets rid of the video for bans - Unanimous headmin approval edition [MDB IGNORE] (#9353)
* Removes videos from bans (#62683)

* Gets rid of the video for bans - Unanimous headmin approval edition

Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
2021-11-09 18:26:48 -05:00
SkyratBot
8978adde4a [MIRROR] Add the known alts panel, which prevents suspicious login logs for whitelisted ckeys [MDB IGNORE] (#9306)
* Add the known alts panel, which prevents suspicious login logs for whitelisted ckeys

* fixed

* ops, missed one conflict

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2021-11-08 22:26:02 -05:00
SkyratBot
e598a0dd33 [MIRROR] Beepsky refactor and Bot code improvement [MDB IGNORE] (#9304)
* Beepsky refactor and Bot code improvement

* Feex

* Fixing the maps so they work :)

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-11-08 21:28:35 -05:00
SkyratBot
45ad3f5e6e [MIRROR] Fixes the issues with the ban video by moving the link to ban appeals to after the video. [MDB IGNORE] (#9316)
* Fixes the issues with the ban video by moving the link to ban appeals to after the video. (#62675)

About The Pull Request

See title.
Fixes #62672
Why It's Good For The Game

Allows us to keep the excellent ban video while nullifying the issue raised in #62672
Changelog

cl
admin: The banning video is now shown before the ban appeals link, instead of after, to improve visibility of the ban appeals link.
/cl

* Fixes the issues with the ban video by moving the link to ban appeals to after the video.

Co-authored-by: Iamgoofball <iamgoofball@gmail.com>
2021-11-08 17:25:58 -05:00
SkyratBot
98428cdfb5 [MIRROR] Replaces a portion of C-style for loops with the more commonplace for loops, which are faster. [MDB IGNORE] (#9298)
* Replaces a portion of C-style for loops with the more commonplace for loops, which are faster.

* Update code/modules/projectiles/boxes_magazines/_box_magazine.dm

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
2021-11-08 10:50:29 -05:00
SkyratBot
a2c6f36895 [MIRROR] anonymous names fixes [MDB IGNORE] (#9295)
* anonymous names fixes (#62497)

the "Stations?" theme now properly describes what its extra does

fixes runtimes with anonymous names! i'll point em out

* anonymous names fixes

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
2021-11-07 16:57:53 -05:00
SkyratBot
ec8ac5f18f [MIRROR] Makes maps be able to load correctly again [MDB IGNORE] (#9276)
* Makes maps be able to load correctly again

* Feex

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-11-06 15:27:52 -04:00
SkyratBot
b7b6bd501f [MIRROR] removes double spaces AFTER symbols [MDB IGNORE] (#9226)
* removes double spaces AFTER symbols

* Fixing conflicts

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-11-05 18:15:12 -04:00
SkyratBot
91fd0e9145 [MIRROR] Adds the color matrix editor [MDB IGNORE] (#9265)
* tgui: Color matrix editor (#62413)

* adds the color matrix editor

* weakrefs and add_atom_color

* a little ui polish

* Adds the color matrix editor

Co-authored-by: Y0SH1M4S73R <legoboyo@earthlink.net>
2021-11-05 16:57:04 -04:00
SkyratBot
c5106921a6 [MIRROR] Fix long ban reasons breaking rolebans [MDB IGNORE] (#9169)
* Fix long ban reasons breaking rolebans (#62408)

Fixes long ban reasons breaking rolebans by adding a max length to the ban reason and making sure that the roleban_delimiter is present on a roleban.

* Fix long ban reasons breaking rolebans

Co-authored-by: adamsong <adamsong@users.noreply.github.com>
2021-10-31 20:04:31 -04:00
SkyratBot
7954d664a8 [MIRROR] removes double spaces before symbols [MDB IGNORE] (#9117)
* removes double spaces before symbols (#62397)

This can apparently cause some bugs on occasions, so I thought I might as well try to kill them all.

* removes double spaces before symbols

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
2021-10-29 04:14:00 +01:00
SkyratBot
2f2685e36c [MIRROR] Adds an improved ban UX for the end user also quads ->> [MDB IGNORE] (#9073)
* Adds an improved ban UX for the end user also quads ->> (#62222)

Now a short autoplaying video is included, that will explain to the user why they are no longer able to access tgstation resources.

It may be suitable to host the video on tgstation's cdn instead

* Delete made_you_look.md

* Update Dockerfile

Co-authored-by: oranges <email@oranges.net.nz>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2021-10-27 20:09:39 -04:00
SkyratBot
fad38d8c24 [MIRROR] Adds the ability to soft filter words, also fixes some word filter bugs [MDB IGNORE] (#9062)
* Adds the ability to soft filter words, also fixes some word filter bugs (#62158)

* Adds the ability to soft filter words, also fixes some word filter bugs

* Fixing linters (you're welcome Jake!)

* Punctuation is my passion!1!!111!

Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
Co-authored-by: GoldenAlpharex<jerego1234@hotmail.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-10-27 20:06:23 -04:00
SkyratBot
8cdc9ebcdb [MIRROR] [s] Hotfix notes not belonging to players being shown to players [MDB IGNORE] (#9060)
* [s] Hotfix notes not belonging to players being shown to players

* [s] Hotfix notes not belonging to players being shown to players (#62352)

See title.
Other players will no longer see other player's notes when they connect to the server.
Memos will still be shown to admins.

Things that I have tested in the making of this PR:

    Notes of a player not being shown to other players definitely work
    Notes of a player being shown to a player definitely work.
    Memos are still shown to admins.

Closes #62348

Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-10-27 20:05:59 -04:00
SkyratBot
2fcd127830 [MIRROR] Players now see any notes they may have gotten whilst disconnected when they join the server for the next time [MDB IGNORE] (#9028)
* Players now see any notes they may have gotten whilst disconnected when they join  the server for the next time

* Fixing conflicts

Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-10-27 19:22:19 -04:00
SkyratBot
191533f15e [MIRROR] Fixes 2 issues with the unbanning panel and adds a reban button. [MDB IGNORE] (#8935)
* Fixes 2 issues with the unbanning panel and adds a reban button.

* Long overdue.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: Gandalf <jzo123@hotmail.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
2021-10-26 22:14:36 -04:00
Gandalf
e3c752e06a I am going to blow up 2021-10-26 18:39:57 +01:00
SkyratBot
d02153829c [MIRROR] Fix runtime when editing bans introduced by untrustworthy code ocelot. [MDB IGNORE] (#9046)
* Fix runtime when editing bans introduced by untrustworthy code ocelot. (#62322)

* Fix runtime when editing bans introduced by untrustworthy code ocelot.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2021-10-26 17:28:29 +01:00
SkyratBot
89e54878ed [MIRROR] SDQL spells can have their admin messages suppressed (+a small ui fix) [MDB IGNORE] (#8970)
* adds silent var to sdql spells (#62217)

Adds a suppress_message_admins var to SDQL spells, which makes the query not appear in chat, while still writing it to the game log.

* SDQL spells can have their admin messages suppressed (+a small ui fix)

Co-authored-by: Y0SH1M4S73R <legoboyo@earthlink.net>
2021-10-23 00:24:44 +01:00
Gandalf
0fce808c7d adds a simple admin tool - spawn mob spawner (#8956)
* yes this took me 3 minutes

* day one 50 gig patch

* move dis down to living level for muh events

* Update spawn_nest.dm

* Update simple_animal.dm

* Update simple_animal.dm

* more indepths spawners

* e

* woof

* Update spawn_nest.dm
2021-10-20 22:12:43 +01:00
SkyratBot
7dbc5324f9 [MIRROR] Admins now get a little notice if they start responding to a ticket someone else is already responding to [MDB IGNORE] (#8922)
* Admins now get a little notice if they start responding to a ticket someone else is already responding to

* Fixing a conflict

Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2021-10-19 01:17:42 +01:00
SkyratBot
f0db07b17d [MIRROR] makes it so the sanitize_hexcolors' default is 6 characters rather than 3 and gets rid of color_legacy [MDB IGNORE] (#8840)
* makes it so the sanitize_hexcolors' default is 6 characters rather than 3 and gets rid of color_legacy

* Feex

* Feex some more

* Final feex

* Please no more I'm tired

* <<<<<<< HEAD

Co-authored-by: Seris02 <49109742+Seris02@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-10-17 00:30:28 -04:00
SkyratBot
0d5eb8a0c4 [MIRROR] Add missing SIGNAL_HANDLERs [MDB IGNORE] (#8834)
* Add missing SIGNAL_HANDLERs (#62115)

Add missing SIGNAL_HANDLERs

* Add missing SIGNAL_HANDLERs

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-10-15 12:32:41 -04:00
SkyratBot
1bedcb0714 [MIRROR] The monkey portrait decoration is now a set of random pictures that also act as persistent photo frames. Every station map gets one. [MDB IGNORE] (#8681)
* The monkey portrait decoration is now a set of random pictures that also act as persistent photo frames. Every station map gets one.

* mirrors changes

* Update mothership_astrum.dmm

* Update BlueShift.dmm

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: Kat <evesovereign@hotmail.co.uk>
2021-10-14 06:43:45 +01:00
SkyratBot
fa519bdde3 [MIRROR] cleanup _HELPERS/_lists.dm and all the necessary files [MDB IGNORE] (#8783)
* cleanup _HELPERS/_lists.dm and all the necessary files

* Epbic

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-13 21:07:35 +01:00
SkyratBot
2907da3c65 [MIRROR] toggle random events on/off no longer sends unspanned feedback to user [MDB IGNORE] (#8731)
* toggle random events on/off no longer sends unspanned feedback to user (#61982)

The verb already messages admins and pressing the verb requires you to be an admin. to_chat entirely unneeded!

* toggle random events on/off no longer sends unspanned feedback to user

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
2021-10-11 14:13:23 +13:00
SkyratBot
95ab2d2efb [MIRROR] Adds SHOULD_NOT_SLEEP to Destroy. Why didn't we do this before. [MDB IGNORE] (#8714)
* Adds SHOULD_NOT_SLEEP to Destroy. Why didn't we do this before. (#61943)

* Adds SHOULD_NOT_SLEEP to Destroy. Why didn't we do this before.

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2021-10-09 09:11:52 -04:00
SkyratBot
cc93b11d23 [MIRROR] _HELPERS/unsorted.dm has been sorted [MDB IGNORE] (#8627)
* _HELPERS/unsorted.dm has been sorted

* Feexing conflicts

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2021-10-06 22:07:01 +01:00
SkyratBot
fa55f2bfe9 [MIRROR] [s] Fixes messages with multiple spaces in a row breaking asay [MDB IGNORE] (#8641)
* fixes multiple spaces breaking asay (#61939)

* [s] Fixes messages with multiple spaces in a row breaking asay

Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
2021-10-06 15:38:06 -04:00
SkyratBot
fc29da4e9c [MIRROR] [s] Cleanup escalation unsafe procs [MDB IGNORE] (#8642)
* [s] Cleanup escalation unsafe procs (#61905)

Fixes admins spawning in atoms and datums without the DF_VAR_EDITED flag

* [s] Cleanup escalation unsafe procs

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
2021-10-06 14:36:27 -04:00
SkyratBot
e14ecb4ab4 [MIRROR] Removes a useless but very hilarious define and really I just want to show the rest of you that this used to be here [MDB IGNORE] (#8605)
* Removes a useless but very hilarious define and really I just want to show the rest of you that this used to be here (#61866)

Removes SDQL_qdel_datum and please just click files changed okay

* Removes a useless but very hilarious define and really I just want to show the rest of you that this used to be here

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-10-04 16:00:07 +01:00
SkyratBot
322cff5a78 [MIRROR] Use ckeys instead of keys in key name helper proc and new_player login. [MDB IGNORE] (#8601)
* Use ckeys instead of keys in key name helper proc and new_player login. (#61857)

* Use ckeys instead of keys in key name helper proc and new_player login.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2021-10-03 23:44:26 -04:00
SkyratBot
425c5bb100 [MIRROR] cleanup of _HELPERS/game.dm [MDB IGNORE] (#8593)
* cleanup of _HELPERS/game.dm (#61859)

some more cleanup, game.dm this time

* cleanup of _HELPERS/game.dm

* E

* Update oneclickantag.dm

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-04 00:28:22 +01:00
SkyratBot
09c2297ad1 [MIRROR] Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits [MDB IGNORE] (#8437)
* Secret Gateways: Config loaded Away Missions + Anti-observing Z level traits

* 0

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-04 00:11:28 +01:00
SkyratBot
84d0c39b6b [MIRROR] Add preference to disable deadmin preferences in CentCom [MDB IGNORE] (#8515)
* Add preference to disable deadmin preferences in CentCom (#61751)

* Add preference to disable deadmin preferences in CentCom

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2021-10-01 03:03:48 +01:00
SkyratBot
2198024a73 [MIRROR] You can now use backslashes as an escape character for text modification. [MDB IGNORE] (#8438)
* You can now use backslashes as an escape character for text modification.

* Update ticker.dm

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-10-01 00:11:14 +01:00
SkyratBot
92230e4252 [MIRROR] renames enable debug verbs to enable mapping verbs [MDB IGNORE] (#8460)
* renames enable debug verbs to enable mapping verbs (#61725)

its such a stupid fucking name, the verbs are all mapping related, they are all in the mapping tab, nobody knows about them because its called debug verbs for some reason instead of mapping verbs

* renames enable debug verbs to enable mapping verbs

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
2021-09-28 20:16:05 +01:00