284 Commits

Author	SHA1	Message	Date
SkyratBot	997d9ac093	[MIRROR] [no gbp] Reworked sparks to not be so immensely destructive in benign circumstances (#28321) ... * [no gbp] Reworked sparks to not be so immensely destructive in benign circumstances (#84193) ## About The Pull Request So sparks were laying waste to every department that had sparks as a little pizzazz particle effect, which turned out to be seemingly every single department, and also just a bunch of random shit we had laying around. That wasn't really the goal so I've reworked them, for now, until I'm able to more comprehensively address how we handle things that are combustible vs things that are actually dangerously flammable, which we don't differentiate for now. Sparks now send a signal to whatever thing is touching those sparks. Right now I've specifically made pools of welding fuel, things made of plasma, people covered in flammables, and cigarettes respond to this signal. Sparks that touch objects with reagents in them will heat those reagents marginally (approximately 40kelvin increase from 300 kelvin underneath a popped lightbulb). There is also another signal 'HAZARDOUS_SPARKS' but as of this PR it is not used. If you walk into sparks or get showered by them, the sparks will also interact with any of your visible equipment (outerwear and held items), but to reiterate, nothing besides the above stated items have interactions with sparks... for now... ## Why It's Good For The Game I won't apologize for being hilarious but turning departments into fields of burnt boxes, tables, vegetables, and crates wasn't really the intent. Addresses #84169 and similar ## Changelog 🆑 Bisar balance: Sparks have been heavily adjusted; they only affect items made of plasma, pools of welding fuel, flammable people, cigarettes, and items that contain reagents... for now. Their long-standing behavior of igniting flammable gas has been untouched. /🆑 * [no gbp] Reworked sparks to not be so immensely destructive in benign circumstances --------- Co-authored-by: Joshua Kidder <49173900+Metekillot@users.noreply.github.com>	2024-06-24 09:06:05 +05:30
SkyratBot	2d073c00b4	[MIRROR] [no gbp] Sparks don't ignite furniture (unless you made it out of plasma you fucking lunatic), sparks have a decreasing chance to ignite bigger items, small fix to obj/fire_act() signal (#28272) ... * [no gbp] Sparks don't ignite furniture (unless you made it out of plasma you fucking lunatic), sparks have a decreasing chance to ignite bigger items, small fix to obj/fire_act() signal (#84111) ## About The Pull Request Even though it's hilarious, sparks currently ignite any flammable thing they touch whatsoever; including gigantic wooden/cloth items, or tables and chairs. Turning areas with wooden furnitures into fields of ash wasn't the intent, so I adjusted sparks to not ignite furniture (you can put welding fuel under them if that's your intent) and items bigger than small items have a steadily decreasing chance to get ignited by sparks (normal is 50%, bulky is 20%, bigger than bulky won't ignite only from sparks) ## Why It's Good For The Game Even in a death trap space station of the future, sparks aren't THAT much of a fire hazard. ## Changelog 🆑 fix: Sparks will no longer turn areas with wooden furniture or similar into naught but a field of ashes; they no longer ignite furniture, (unless it's made of plasma(?!)) and have a decreasing chance to ignite items bigger than small size. /🆑 * [no gbp] Sparks don't ignite furniture (unless you made it out of plasma you fucking lunatic), sparks have a decreasing chance to ignite bigger items, small fix to obj/fire_act() signal --------- Co-authored-by: Joshua Kidder <49173900+Metekillot@users.noreply.github.com>	2024-06-20 11:03:23 +05:30
SkyratBot	186a1a724e	[MIRROR] Sparks ignite flammable things (including people), welding fuel pools now ignite in response to more things logically (#28242) ... * Sparks ignite flammable things (including people), welding fuel pools now ignite in response to more things logically (#83673) ## About The Pull Request Currently, sparks only ignite the air in rooms with plasma/tritium/hydrogen in them. This PR changes sparks to ignite flammable things they touch, including mobs covered in flammable liquids. They also marginally heat containers (40K temp increase from a broken light bulb). The initial purpose was to make welding fuel pools more responsive to flaming things being thrown into them. I have also done that. They now respond to hot objects (including flaming mobs) entering their space or being thrown onto them. They are also ignited by sparks. This PR makes sparks a fire hazard. Keep a fire extinguisher handy. ## Why It's Good For The Game Safety hazards are fun. Sparks should, logically, set flammable things on fire, including YOU. Welding fuel pools should be more hazardous. ## Changelog 🆑 Bisar add: Sparks now ignite flammable things. Including you. Keep a fire extinguisher handy or stop dousing yourself in welding fuel! fix: Fixed a few oversights with welding fuel pools not igniting when you throw lit/hot things into them or when you walk into them while on fire. /🆑 * Sparks ignite flammable things (including people), welding fuel pools now ignite in response to more things logically --------- Co-authored-by: Joshua Kidder <49173900+Metekillot@users.noreply.github.com>	2024-06-19 10:02:55 +05:30
Mothblocks	8c4cf753f5	Remove data systems in favor of global datums (#82943)	2024-04-30 05:48:11 +00:00
SpaceLoveSs13	55d1c715e5	Pulls2 (#27514) ... * New docking port sprites (#82729) * Adds text to lootpanel items [no gbp] (#82722) ## About The Pull Request Just some qol, this captures a small portion of the item name and fixes some icon clipping issues I clipped it at 5 because monke   ## Why It's Good For The Game Handy if youre in a rush and won't upgrade byond to fix the issue ## Changelog 🆑 fix: Lootpanel additions: Condensed item names for the quick of draw /🆑 * Fixes tgui alert buttons (#82714) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Been on my mind for a long time I did this while relatively inexperienced (how do I center a div etc) Fixes an issue inherent to our stack implementation where reversing the direction caused strange spacing issues. This effectively reverses the extra margins in css so it looks identically spaced whether reversed/not <details> <summary>before/after</summary> Before (normal buttons)  Before (large buttons)  After (normal buttons)  After (large buttons)  Long buttons (normal)  Long buttons (large buttons (I am 35 and yet still fight the forces of chaos))  </details> <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game Looks better, runs smoother, no clipping <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> 🆑 fix: TGUI Alerts shouldn't have such wonky buttons any more /🆑 <!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com> * MetaStation: Replaces the tools in the Primary Surgery Theatre with filled surgery trays (#82730) ## About The Pull Request Replaces the tools on the tables with 2 surgery trays.  ## Why It's Good For The Game Makes surgery a bit less painful in the surgery theatre, Using tools from a tray is much nicer than having to open the context menu on the piles of tools on the tables. ## Changelog 🆑 qol: Replaced the surgical tools in the Primary Surgery Theatre with 2 Surgery Trays. /🆑 * Fixes smart pipe & cryo gas reallocation (#82701) ## About The Pull Request **1. Smart Pipe Problem** - Fill a pipe with any gas, plasma for e.g. - Unwrench the pipe to deconstruct - The pressure sends you flying but notice plasma is nowhere to be seen from the now destroyed pipe **2. Cryo pipe connector problem** The gas gets reallocated when the object is deleted. We only want this when its deconstructed not deleted to prevent any side effects This PR fixes them ## Changelog 🆑 fix: smart pipes release their gases into the air when unwrenched fix: cryo pipe connector component has no side effects of gas reallocation when deleted /🆑 * Fix Primal Instincts (#82741) ## About The Pull Request #82539 randomly made these two lines switch their AI controllers to idle rather than on, when the intent was for them to wake up immediately to do make the mob attack or fight or do something ## Changelog 🆑 Melbert fix: Primal Instincts and Living Flesh should be a tad more reactive /🆑 * Fix handcuffing (#82760) ## About The Pull Request Changed this to an early return but then didn't invert the condition ## Changelog 🆑 Melbert fix: You can handcuff people with 2 arms and you can no longer handcuff people with 0 arms /🆑 * Gets rid of UNIT_TESTS compiler warning (#82695) ## About The Pull Request Basically every single CI Run is throwing the following warning: ```txt code/modules/unit_tests/lootpanel.dm:24:warning (unused_var): new_box: variable defined but not used ``` You may find an example here: https://github.com/tgstation/tgstation/actions/runs/8698627681/job/23855921813#step:9:24 This is pretty silly but I don't really know why we even have this variable (I assume there's something far more complicated underneath the surface based on what the unit test is asserting), but assuming it is important let's just insert a do-nothing procedure to get rid of the compiler warning while ensuring the unit test is actually operating as it should. I also don't really like the fact that this is a warning instead of an error but let's tackle this problem one step at a time by at least getting rid of the compiler warning in a quick advance PR while I dwell on this issue (is there a way to get the Dreamchecker linter to look at the unit test files? it's caught perfectly fine in the langserver) --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> * Makes dropdowns better (#82697) ## About The Pull Request Kind of a pain to work with, confusing people with its prop names (many such cases!) After recently discovering deathmatch it's very obvious to me how broken it is, so I made it less so (now comes with a complete ui upgrade!) It now scrolls with the selection and to the selection on open, which felt like major QoL <details> <summary>pics/vids</summary> In motion  Deathmatch got some UI facelifts   Fixes #75741  </details> ## Why It's Good For The Game Better UX Bug fixes Potential exploit patched (ui validation for ai voice changer) Fixes #81506 ## Changelog 🆑 fix: Dropdowns received some much-needed QoL, like having the scrollbar follow your selection. fix: AI voice changer now shows its current voice selection. fix: Deathmatch screen has been touched up. fix: Prefs menu has their dropdowns simplified, hopefully fixing issues /🆑 --------- Co-authored-by: san7890 <the@san7890.com> * Fixes the NT SWAT helmet sprite (#82743) * Mass Item Creation (#82455) ## About The Pull Request Have you ever had to click the "Make" button a dozen times for a chef making soup? I've also had it, so with this PR you can press the button and everything will repeat itself as long as possible. ## Why It's Good For The Game Makes life easier for chefs, now they can play chess on their cool smartphone and craft food. (actually you can transfer it to other items as well, see for yourself). * Adds Retain volume flag on the ants reaction (#82718) Fixes #82575 We'd expect feeding ants to always result in more ants I imagine. * Borg movement now has sounds (#82704) ## About The Pull Request adds sound effects to cyborgs when they move Demo: https://imgur.com/a/7Mu98pQ Open to feedback on this sound so please tell me what you think. ## Why It's Good For The Game a hunk of metal moving at you without any sound is frightening ## Changelog 🆑 grungussuss sound: cyborgs now have sounds to indicate they are moving /🆑 * Use cell defined constants for various stuff (#82594) ## About The Pull Request This re writes most cell power usage cases with 2 defines `STANDARD_CELL_CHARGE`(Joules) & `STANDARD_CELL_RATE`(Watts) so changing cell capacity values in the future won't cause discrepancies. ## Changelog 🆑 code: most cell power usages are scaled with defined constants to help adapt to future changes /🆑 * Plumbing machinery power & processing tweaks (#82702) ## About The Pull Request - Plumbing machinery begins processing only when wrenched & ends processing when unwrenched. The machines plumbing component `/datum/component/plumbing/process()` already does this but the underlying machines processing proc for e.g. `/obj/machinery/plumbing/synthesizer/process()` is always processing regardless of its wrenched state or not. We can optimize this & save power when unwrenched - Fixes #82621. This adds plumbing machines `idle_power_usage` on top of its `active_power_usage` ensuring it only uses power when actively doing work, So if your factory is say full of reagents & cannot do any more work it will use less energy i.e almost enter an stand by mode, efficiency - Plumbing grinder chemical will grinds & juice stuff correctly i.e. prefer grinding over juicing most of the time ## Changelog 🆑 fix: plumbing machinery begins processing only when wrenched & ends when unwrenched fix: plumbing machinery uses energy only when wrenched & doing work, will stop/use less energy when idle fix: plumbing grinder chemical will grinds & juice stuff correctly i.e. prefer grinding over juicing for most stuff /🆑 * Carps migrating through the station no longer idle so they don't get stuck after spawning until someone walks by. (#82744) ## About The Pull Request Carps migrating through the station no longer idle so they don't get stuck after spawning until someone walks by. ## Why It's Good For The Game Bugfix for Carp Migrations. ## Changelog 🆑 fix: Carps migrating through the station no longer idle so they don't get stuck after spawning until someone walks by. /🆑 * Alt click no longer conflicts with mech suit [no gbp] (#82758) ## About The Pull Request Get in the gundam shinji!!! Context: Mech users hold ALT to disable strafe, which would trigger the lootpanel to come up while committing war crimes (annoying!) This prevents the panel from appearing and fixes the previous behavior, meaning you can alt click your own mech to disable strafing.  It also makes toggling strafe a balloon alert with sound. Parties for all occupants!! ## Why It's Good For The Game Fixes #82753 ## Changelog 🆑 fix: Mecha pilots are no longer bothered by incessant loot panels while holding ALT for strafe disable. /🆑 --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> * Adds a Wizard-themed map to the deathmatch (#81640) ## About The Pull Request Deathmatch is severely lacking in HIGH IMPACT MAGIC LARPING. So I added a big ass wizard arena. The arena itself is based off the wizard den. Loadouts: **Wizard:** Standard all-rounder. Got magic missile, jaunt, and forcewall. Regular gear. **Pyromancer:** Fire guy. Red robes, fireball, smoke. **Electromancer:** Zappy guy. Lightning and tesla shock. **Necromancer:** Is a skeleton. Has Scream for Me and blink. **LARPer:** Straight from Station & Spessmen. Fake robes and can only throw lightning and repulse. **Chuunibyou:** Classic animage. Got chuuni buff and magic cards. **Battlemage:** Melee fighter. Got some armor and a big hammer with instant summons. **Apprentice:** Underpowered until they find a mystery box. Got charge. **Gunmancer:** Who needs magic when you have guns? Starts with an m1911, lesser gun summons, and knock. **Monkeymancer:** Is a monkey. Can summon monkeys and gorillas. Has a banana. **Chaosmancer:** Jumbled robes. Starts with a chaos rod. Can rod form and summon traps for high chaos. **Funnymancer:** It's just a clown with a banana staff. The map itself is a pretty standard arena with a long sightline in the middle. Each participant spawns in their own room complete with a magic item box. The very southern portion of the ship has a standard mystery gun box. Soon after the round starts, a hostile gelatinous cube in the center of the map will break out and attack whoever it sees. Inside its enclosure is a free death wand. Map has been tested to make sure deathmatch participants can't escape the deathmatch. ## Why It's Good For The Game Deathmatch provides a unique opportunity for people to play with mechanics they will not often get to use. Allowing people to play wizard for a few minutes shouldn't cause too much harm aside from admin logging from explosions, which hopefully a fix is in the pipeline for. ## Changelog :cl:Motho add: Added wizard-themed deathmatch map. add: Added mystery wand box. /🆑 * Makes viewers() defines (#82767) * Fixes Pseudo circuit delay & some missed cell define usages (#82771) ## About The Pull Request - Fixes #82688 If the circuit cost is<= 1% of `STANDARD_CELL_CHARGE` then the delay is 5 seconds, if the circuit cost is >= 50% of `STANDARD_CELL_CHARGE` then delay is 1 minute. All other delay values are interpolated in between these 2. - Pseudo circuits don't use power when used on cooldown - Makes `INSPECTOR_ENERGY_USAGE_*` defines values use standard cell values ## Changelog 🆑 fix: pseudo circuit adapter computes recharge delay durations correctly & won't use power when on cooldown code: uses standard cell defines for N-spect scanner /🆑 * Lava/Plasma River tiles now immerse you in them (#82736) ## About The Pull Request This adds the "immerse" element to lava tiles.  It's a tad hard to see because you're super on-fire, but it still looks nice. ## Why It's Good For The Game Eye candy, pretty... ## Changelog 🆑 Rhials qol: Lava and plasma rivers now immerse you in them. /🆑 * Adds `ALLOW_RESTING` to a bunch of items (#82761) ## About The Pull Request Allows you to alt-click a bunch of items while resting. Fixes #82788 ## Why It's Good For The Game Some of these, such as storage, are bugfixes. You shouldn't need to be standing up to configure a spray can, or change the direction of your bedsheet Others are just sensible changes. ## Changelog 🆑 Melbert fix: You can open bags with alt click while resting again qol: Many items which previously required you to stand to alt-click now don't, such as bedsheets and spray cans /🆑 * Fixes sight range on lootpanel [no gbp] (#82765) ## About The Pull Request When asked to make lootpanel visible at range they did not just mean _any range_ AI alt click was a little weird (still is) but now it works (TM BUG) Fixes #82768 * Adds Omnitools for engineer and medical cyborgs, reducing on inventory clutter. (#82425) [This PR is a bounty requested by Ophaq and worked on by Singul0.](https://tgstation13.org/phpBB/viewtopic.php?f=5&t=36013) All of the following description in this PR is written by Ophaq as to what this PR entails: In this PR, the medical and engineering cyborg's tools are completely reworked and condensed into an arm similar to the implant a carbon would get. The tools are shown in a radial wheel around the character to quick select what is needed instead of looking for it in a cluttered bag of items. There are a few tools such as the blood filter for the medical cyborg, as well as the welder, gas analyzer, and t-ray scanner for the engineering cyborg excluded from the radial wheel. mostly due to their inherent inmodularity   Each cyborg gets two arms in case the player wishes to have one on the side to quick swap to, like having a scalpel in one arm and a hemostat in the other on the hotbar for convenience or just preference. An upgraded version of the tools has been added to each respective cyborg upgrade node with somewhat faster action speed. The upgrade replaces the arms and transforms them into the "advanced" version which is currently the same sprite as the regular but just a faster and more efficient version. The sprites for the surgical arm currently look good but may need replacing later if someone who wishes to resprite them down the line decides to do so. As it currently stands, the medical cyborg's magical bag of gadgets takes up a lot of your screen space and as a player who plays medical A LOT, this was a MUCH NEEDED quality of life feature. The amount of clutter in a medical cyborg's bag makes it in my opinion, hard to see at the bottom of the screen and a nuisance to constantly close compared to other models. My standard set up for playing medical cyborg on the hotbar is 1=med analyzer, 2=usually a secondary surgery tool or injector, and 3=another surgery tool. The flow of gameplay during surgery ends up being surgery tool, hit 3 and drop it, surgery tool, repeat or for efficiency using X to swap between the two surgery tools I need on 2 and 3. This gets tedious especially after so many hours of playing medical cyborg. I know some people may disagree, but I think it would help a lot of help to speed up this flow of gameplay during surgery and declutter. By turning the medical cyborg's toolset into an omni-surgery tool which functions like the surgery arm implant's radial wheel, this would greatly declutter by like an entire row and make things easier on medical cyborg players. Having a secondary in the bag helps with efficiency for those players who like having an extra tool on their hotbar and swapping back and forth would also improve efficiency and make less swapping by hitting Z needed. Additionally with the upgraded version as an optional upgrade in the mediborg tech, this also lets them be on par with players who use advanced tools late game but not at the level of alien tools where players would obviously out compete a mediborg in terms of action speed. Engineering models also benefit from this rework but at a slightly different and lesser way whereas certain tools are excluded such as the welder, due to the way they work on refill and the gas scanner and t-ray scanner not counting as tool components are not included in the arms. Syndicate versions of the engineering and medical cyborg also get these arms, unupgraded. 🆑 add: Adds an omnitoolset for both engineering and medical cyborgs, containing various basic tools qol: Engineer and Medical module inventory space is now significantly decluttered /🆑 --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> * Fixes dropdown displaytext not working for numeric values (#82778) ## About The Pull Request https://github.com/tgstation/tgstation/pull/82697 broke the prefs menu downstream; we have a couple of dropdown choices that are numeric but that make use of `display_names` to map those choices to appropriate strings. The code was assuming that `value` would always be a string when calling `capitalizeFirst(value)`. Basically it should be doing `display_names[value]` when `display_names` are present. ## Why It's Good For The Game Fixes an oversight/bug. ## Changelog 🆑 fix: dropdowns that use display_names as an alias for numeric values will no longer cause tgui bluescreens /🆑 * [NO GBP] HPLC can purify inverted chems (#82727) ## About The Pull Request - Fixes #82725 Inverted chems are now coloured green and classified as clean (like before my general maintenance PR) which means they can be purified again. Only chems that are too impure to use & have an inverted chem value are coloured red in the UI and not when they are just of the inverted type ## Changelog 🆑 fix: HPLC can purify inverted chems and are now coloured green(clean) in the UI /🆑 * Lathes compute their local storage size correctly (#82770) ## About The Pull Request Basically we have to add the material container before we call parent Initialize(which calls `RefreshParts()`), else the container doesn't get initialized early and we skip over computing storage sizes ## Changelog 🆑 fix: off station & round start lathes with local storage don't have infinite storage size. /🆑 * Arcmining QoL: GPS component to scanned vents and vent(pin)pointer (#82724) ## About The Pull Request Scanning ore vents will now tag them on GPS so you can find them easily when you are prepared (and remove them when they are tapped). Also adds special pinpointer to help with finding unscanned vents in a first place. And adds missing uranium overlays for scanned vents. Because why not. <details>   </details> ## Why It's Good For The Game While looking at mineral density to find vents is somewhat fun and entertaining, having some sort of upgrade to make finding them easier adds a bit of a progression. Also re-finding already scanned vents can be a bit annoying. You need to fill your backpacks with GPSs and tag them manually. It is also inconsistent with geysers that are added to positioning after you scan them. And with tendrils, which are always visible. ## Changelog 🆑 add: added ventpointer that points toward nearby ore vents and can be bought with mining points balance: scanned ore vents can now be found with GPS fix: fixed ore vents missing overlay icon for uranium /🆑 * Fix oven tray runtime (#82782) ## About The Pull Request Fixes a lil typo from the interaction refactors that broke the ability to load oven trays from containers ## Why It's Good For The Game squamsh bug ## Changelog 🆑 fix: loading oven trays from serving trays and other containers works again /🆑 * Fix flaky test detection (#82790) - Add missing job pagination. - Fix multiple jobs being able to fail if they aren't in `CONSIDERED_JOBS` * Add utf8 support for state laws button (#82789) ## About The Pull Request Adds UTF-8 support for state laws HTML page. Now it supports more than just English ## Why It's Good For The Game Support for other symbols, such as cyrillic  * Update highest available sound channel (#82780) Current channels are: ``` ``` So, the highest available now is 1013 Updating the thing which everyone forgot for 7 years. Not that many special channels were added either way * Revert "Borg movement now has sounds" (#82795) Reverts tgstation/tgstation#82704 The sound ingame appears much louder than the original author intended. Not to mention that the sound loops stack for every borg moving near you. * Use defines for "General Research" where it's not used (#82785) ## About The Pull Request There is a define for it, so why not use it? ## Why It's Good For The Game Defines good * [READY] the unfuckening of clothing rendering (#79784) refactors clothing visors to use the same system, including masks being toggled and stuff like riot helmets toggling using the same system and welding helmets and such adds a handler that updates all visuals in slots that an item has obscured, each visual proc calls that so you no longer have weird shit happening like having to hardcode a proc for heads where you need to also update hair, mask, glasses everytime you put on an item one thing here i could also do is make check_obscured_slots return the HIDEX flags instead of item slots, because in 99% of cases its hardcoded to be ran against specific slots (like eye code running it against the glasses slot), but maintainers didnt seem to like that :/ fuck this 2003 bullshit theres like several bugs here i fixed but i forgot them all and they are small * Allows vv investigate /appearance + better checking image (#82670) * Fixes Alien Numerical Identifier Transfer System (#82762) ## About The Pull Request Fixes #82756 I'm not sure what the root cause of the issue is or why it broke so recently (this has been a thing since #49150) but I went and cleaned up the code and ensured that we always reset the `name` to the `initial()` value we have for it if we determine that we need to transfer over the `numba` from the old xenomorph. This is done by a new proc which is a lot less convoluted from the old system (always respecting var-edited names and stuff like that) that should make it flow a lot better and make it more hardy against double-addition of the `numba` to the name. ## Why It's Good For The Game Having two numbers in your name is weird, should only have one. [x] I tested this PR ## Changelog 🆑 fix: Evolved aliens should no longer have two numbers in their name. /🆑 * [NO GBP] Fixes runtime in advanced camera console (#82699) ## About The Pull Request We only unset machine if we have a user who has logged in ## Changelog 🆑 fix: Fixes runtime in advanced camera console when power is turned off /🆑 * Refactors how basic ais do their success/failures (#82643) * Rocky DLXIII: Fitness to Athletics, Athletics skill influences Boxing against Boxers, Boxing overhaul, Evil Boxing (#82611) as the only meaningful reward Basically just a rebranding so that it is more broad in its concept. It isn't just about peak physique. It's about how you can apply it too. Reaching Legendary rewards you with the Golden Gloves. I started it in this pr here https://github.com/tgstation/tgstation/pull/80635 But this is a more significant overhaul of boxing from the ground up. Namely, it now is majorly influenced by the Athletics skill, and also more thoroughly aligns with conventional punching in its current state. However, a major component of this is that boxing's breadth of mechanics is only relevant when used against another boxer. Non-boxer targets are only ever going to get smacked by a stamina punch, as it is currently (and more or less the same values too). Additionally, boxers cannot punch someone who is either unconscious or in stamina crit, so it can't be used to maintain stamcrit. - Boxing now has a One-Two Punch mechanic. Swapping between the left and right mouse buttons to punch and maintaining this causes every second punch to do more damage (to boxers). Breaking this chain by punching with the same button twice will cause you to lose damage (against boxers). - Boxing now can have crits occur below 50 stamina damage (against boxers). However, to knock someone out clean, the target must be staggered from a previous crit first. (Or I guess be staggered at all, maybe their shoelaces were tied or something). Crit probabilities are determined by adding your Athletics probability skill bonuses to your unarmed effectiveness, and then reduced by the targets own Athletics skill bonuses. It is hard for two athletes to knock each other out in one blow. It is trivial for a legendary boxer to knock out a novice in a single punch. Cybernetically enhanced boxers are dangerously effective at boxing. - Boxers can block other boxers by using throw mode, but the chances of doing so is based on Athletics skill bonuses. A successful block causes the attacker to take stamina damage (as does the blocker, but less so). - Participating in boxing increases the Athletics skill. Your gains are probably slower than normal training, but you at least get some reward for doing so. Only relevant if your opponent is a boxer. Get a sparring partner! So this is all well and good, but what if you're a scoundrel with no care for the other person in this equation? Well, that's where Evil Boxing comes in. Evil Boxing has absolutely no restrictions at all, and can freely use its boxing abilities against anyone. Even non-boxers. You can even grab people! Wow, what a scumbag. I bet you even king hit people. Thankfully, only an admin can make you into an Evil Boxer. (against boxers) Both mutations have a flimsy increase to instability of 5 because of how incredibly particular the bonus is. Strength now reduces the amount of stamina damage inflicted via exercising by half. Strength also adds a +2 damage bonus on boxing punches while boxing against boxers (this doesn't influence normal unarmed attacks whatsoever, or boxing against nonboxers). Obviously, evil boxers just get this benefit against everyone because they're knaves. Stimmed increases the duration of the exercised status effect by one factor. (That is, if you have no other modifiers, it will double the duration on its own) @Jacquerel was racking their brain trying to come up with an alternative to the skill rewards of Fitness. At the moment, sprite growth is not only a really bad bonus (it does literally nothing but make you big, and thus is actually a detriment due to how intrusive sprite size is with interaction, and plays weird with other sprite changing effects), but isn't really all that interesting for all the effort put in. Problem is, how do you make Fitness meaningful without making it a powergame mechanic? Simple! You make it applicable to a really niche, self-contained but still utilized game mechanic that is engaging to participate in and makes you meaningfully very good in it. AND scratches that power scaling itch that many players have. Boxing is reasonably self-contained as is, but pretty bland due to how old it is. While maintaining that self-contained nature, I hoped to expand the interactivity of boxing a little bit by giving it a small mini-game in of itself. And also introduce ways to simulate the idea of boxing a bit better. The idea of being an Evil Boxer is funny. For every Rocky, there is a [Insert Rocky Villain Here that isn't Creed]. But in this case, it's probably some Syndicate douchebag looking to punch clowns into a coma and inspire the mime to take up shadowboxing in revenge. 🆑 add: Replaces Fitness with Athletics; same skill, but now more specifically applicable to boxing. add: Athletics does not increase sprite size. balance: Overhauls Boxing to add a lot more depth to the interactions. Only applicable to other boxers, however. You can still punch the snot out of non-boxers though. But only up to stamcrit or unconsciousness. No hitting someone who can't fight back! balance: Adds Evil Boxing, which is the evil and fucked up version of boxing that you kill people with and are allowed to flout the sacred rules of boxing as you please. Everyone is a victim! /🆑 * Cargo ui refactor -> TS (#82745) Refactors cargo ui, fixing some visual bugs, just making it look better in general Should be no gameplay effect other than it looking better <details> <summary>pics</summary>     Fixes #81442  Made a type grabber for backend data in case you want to make your own typescript uis `logger.log(getShallowTypes(data))`  Otherwise cargo's data is unreadable </details> Any UI over 500 lines should get broken up to reduce cognitive load ~~Any ui in javascript shouldn't exist~~ Cargo UI is better Typescript 🆑 fix: Cargo's supply console has been upgraded visually. /🆑 --------- Co-authored-by: EricZilla <81941674+EricZilla@users.noreply.github.com> Co-authored-by: Helg2 <93882977+Helg2@users.noreply.github.com> * Makes lavaland stone tiles prevent immersion (#82807) ## About The Pull Request Adds the same trait that lavaproof rods have to the stone tiles, so things can continue being visually outside of the lava ## Why It's Good For The Game this shit looks goofy  ## Changelog 🆑 FlufflesTheDog fix: Stone tiles (and things on them) no longer get immersed in lava /🆑 * Getting up from prone, z movement, and mod de/activation don't do cogwheels (#82794) Adds `hidden` to getting up (from prone), moving up (z-movement), moving down (z-movement), and de/activating MODsuits - Getting up from prone happens very often, makes it a bit hard to differentiate when people are doing actions or just crawling around. - If we want feedback for getting up, should just be a chat message. - Moving up and down is just movement. Only affects using the verbs. - Same as before: If we want feedback, it should just be a chat message. - Other methods of moving up/down (IE, ladders) are untouched / retain their cogwheel. - De/activating modsuits have their own visual feedback and sound effects associated. Both feels unnecessary. 🆑 Melbert qol: Getting up from prone, moving up or down a z-level (not via ladders, naturally. Like flight), and de/activating your modsuit no longer shows cogwheel effect /🆑 * [NO GBP]Inversely scale mechanical favor with STANDARD_CELL_CHARGE. (#82801) ## About The Pull Request Makes the mechanical sect cell sacrifice favor adjustment inversely scale with STANDARD_CELL_CHARGE. This reduces it by a factor of 1,000. ## Why It's Good For The Game So they don't get 1,000 times the favor as intended from a cell. ## Changelog 🆑 fix: Fixes mechanical sect gaining 1,000 times the favor from a cell sacrifice. /🆑 * Fix all types of damage to the head causing brain damage (#82763) ## About The Pull Request 5 months ago when I separated this stuff out to its own proc I forgot a damagetype check. ## Changelog 🆑 Melbert fix: Only brute damage causes brain damage when applied to the forehead, rather than all damage types /🆑 * Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it (#82792) ## About The Pull Request If we say something is a Modal it should actually be a Modal ## Why It's Good For The Game You can now use this system in other windows if you want. Fixed the misnomer. --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> * Higher capacity SMES variant for low maintenance areas; miners can access their maintenance area on mining base, gulag no longer saps all power from the main base (#82713) ## About The Pull Request Creates a higher capacity version of the SMES unit that spawns in with super capacity cells, as well as a full version. Places the full version into all the AI sats (which all have independent grids for the most part), some remote space ruins and the mining base. These SMES units are intended for areas where players aren't expected or cannot reasonably be expected to constantly monitor power usage within the length of a standard round. Miners can access their power stations, telecommunications box and atmospheric station on the mining base. They're really the only people who care, after all. The gulag's SMES (also now upgraded) no longer saps power from the main base due to having its input terminal rigged to the main base power grid, and thus demanding all power from the grid greedily. To revert this in-game is a single power cable placed back east of the SMES unit. ## Why It's Good For The Game The power changes made some of the once largely low-maintenance areas much more likely to run out of power more quickly than you would expect. These aren't areas expected to be maintained or monitored by engineering (probably because they're not easily accessed), and they're just kind of troublesome to deal with on a round-to-round basis. Mining had this problem triple-fold. It had significant drain with no convenient method of installing power generation at all, miners couldn't access what power generation there was without using their 'skeleton key' to open the way (only engineers could, and they aren't expected to come down to mining at all), and even then, there was the gulag SMES just eating all the power anyway. I'm pretty sure that SMES unit was the biggest culprit of them all, but I think this conveniently future proofs these issues for the time being. ## Changelog 🆑 add: Adds a higher capacity SMES unit to lower maintenance areas and maps. fix: Miners can actually access and fix their engineering issues on the lavaland base via the engineering section of the base. fix: The gulag SMES unit is no longer needlessly draining the entire power grid of the main mining base. /🆑 * Revert "Higher capacity SMES variant for low maintenance areas; miners can access their maintenance area on mining base, gulag no longer saps all power from the main base (#82713)" This reverts commit af8d69f889. * New views for mc controller ui (#82769) ## About The Pull Request Lots of qol improvements for controller tgui - Auto sort order based on type - Bar view for items in deciseconds <details> <summary>vids</summary> in a live round  modals  bar view with defaults for decisecond sorts  </details> ## Why It's Good For The Game Better admin tools ## Changelog 🆑 add: Admin tools buffed, check the Controller Overview add: Controller Overview moved to debug tab /🆑 * Revert "Converts ListInputModal to actually be a Modal | Adds ListInputWindow which uses it" (#82841) Reverts tgstation/tgstation#82792 * [no gbp] Fixes cargo express console (#82843) ## About The Pull Request Cargo express console does not send amounts by name Fixed and touched up the express console a bit  ## Why It's Good For The Game Bug fix (no issue yet) ## Changelog 🆑 fix: Cargo express console fixed: No more bluescreen /🆑 * Plumbing & chem reaction chamber patches (#82781) ## About The Pull Request 1. Both Plumbing & Chem reaction chamber will use the beakers `heat_capacity()` proc instead of the formulae `SPECIFIC_HEAT_DEFAULT * reagents.total_volume`. This yields the exact same results as before but will mean in the future if individual reagents heat capacities are changed then the heating effects will be accurately reflected here. It also uses that amount of power for heating 2. Plumbing rection chamber will not use energy when its either 'emptying' or when no reagents are present in its internal buffer 3. You can hit the chem reaction chamber with items like beakers, screwdrivers, crowbars and what not ## Changelog 🆑 fix: plumbing & chem reaction chamber heating effects accurately reflect the beakers heat capacity & power usage fix: plumbing reaction will not use power when emptying or when there are no reagents to heat fix: you can hit the chem reaction chamber with items like beakers, screwdrivers, crowbars and what not /🆑 * fixes brimdemon AI (and some other mobs) (#82831) ## About The Pull Request i noticed brimdemons werent attacking when i tried investigating the problem i saw it extends to other mobs ## Why It's Good For The Game brimdemons, as well as other mobs, will behave normally ## Changelog 🆑 fix: brimdemons (and other mobs) will act normally /🆑 * Implements data systems (#82816) ## About The Pull Request Subsystems currently come in two different flavors: 1. Systems that process at intervals with the master controller 2. Global data containers that do not fire And I think they should be split up... This moves 4 non firing, non init subsytems -> datasystem ## Why It's Good For The Game Clarity in code * fixes ammo_bench data system * [no gbp] express console: Bluescreen on cart (#82844) ## About The Pull Request Truly, ## Why It's Good For The Game Bug fix before you even issue report it * Adds Medieval Pirates (and small assault_pod change) (#82392) ## About The Pull Request (short, slightly outdated video compilation of the pirates) https://youtu.be/j9BNFzcUSjc Adds the **MEDIEVAL WARMONGERS** pirate gang, these pirates are focused on causing chaos directly on the station with the use of melee weaponry and swarming tactics. they are not very smart when it comes to using technology, so they crash in the station in an attempt to dock. the pirates spawn with the NOGUN trait as they have never used guns before but have access to dashing and the unbreakable component(small heal burst upon reaching crit). Warlord spawns with a better version of hulk(isnt removed upon crit and can still do stuff while critted) and gigantism mutation by default because ~~Chad Maximus~~ the other pirates require someone to run to when stuff like flashbangs, batons or lasers are present. The warlord spawns with a boarding axe which is a better axe that is good at destroying things and a meat hook. **there's a total of 5 pirates.** the pirate shuttle has: - thermite barrel and 3 large beakers - single weak claymore - 3 extra military spears - 3 kite shields - 3 heavy bolas - 4 regular bolas - a stack of wood - 2 stacks of mourning poultice (15 uses each) - one burn medkit **shuttle was made by striders18, big thanks to him**  things added: - the new pirate gang - a gamberson jumpsuit - crude armor (good melee and wound protection but lacks on the rest) - warlord armor (extreme protection at the cost of slowdown) - a shortsword(bootleg claymore with 30 block chance and goes on belt instead of back) - military spear (better at throwing, better wounding, deals blunt wounds instead of sharp) - axe with better damage and demolition mod for the warlord - a var to specify the name of the landing zone destination for the assaultpod - an assault pod targeting device item for the medieval shuttle - a thermite barrel - kite shields - new hulk variant that doesnt go away when crit and has tenacity ## Why It's Good For The Game I always liked the chaotic nature of the russian bounty hunters that would come from their extra numbers and lack of tools. i thought something of a similar idea on pirates would be good, a very direct and scary militia rushing in with sword and faith would create some awesome scenarios ## Changelog 🆑 add: New heavy weight pirates, medieval warmongers add: Adds military spear, shortsword, boarding axe, kite shields add: Adds warlord and crude armor add: Adds medieval shuttle (made by striders18) /🆑 --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> * fix for pirate suit * Adds sorting options and a search bar to the crew monitor (#82732) ## About The Pull Request This PR adds buttons in the crew monitor UI to sort by name, position, or vitals, as well as a search bar for searching for specific people. For vitals, people are sorted first by life status (living, crit, dead, etc), then by damage. Also TS-ifies the UI. https://github.com/tgstation/tgstation/assets/42454181/a7c0c262-8ea7-4e9f-8de6-6b9cf7481b23 ## Why It's Good For The Game Currently, finding a specific person, or a person in a specific place, is a pain in the butt with the crew monitor. You have to go through an unsorted list of people grouped only by department. Don't know the person's job? Tough luck, you're going down the list one by one. It is not at all a friendly user experience. With this PR, it becomes a breeze, and makes the crew monitor much easier to use. ## Changelog 🆑 add: The crew monitor now has sorting options and a search bar. /🆑 * Accessing Datasystem Manager from MC controller panel (#82848) * [NO GBP] fixes issues with human rendering fixes (#82852) ## About The Pull Request fixes #82838, forgot to add the attack_self there fixes #82869 fixes the atmos hardhat not using flags_inv and transparent_protection correctly (you could pull off someones glasses through it for example makes modsuits use the new rendering stuff fixes rendering stuff not working correctly with adjustable clothing fixes quick equip dropping the item if you cant equip it ## Why It's Good For The Game waow its awesome ## Changelog 🆑 fix: you can no longer take off someones glasses or mask through atmos hardhat fix: once you adjust a welding helmet or something it no longer makes your cigarette or sunglasses invisible fix: welding gas mask works once again fix: quick equips dont drop the item if you cant equip it /🆑 * fixes erp slots * Redoes how appearance VV works because it scares me (#82851) * [NO GBP] Critical fixes for cyborg omnitools (#82825) ## About The Pull Request Fixes several critical fixes for cyborg omnitools, surgical omnitools in peculiar. Which is: 1. bonesetter omnitool can do compound fracture surgery now 2. omnitool butchering not properly disabled works (why didn't that runtime. fucking dreammaker) 3. omnitool surgery_initiator not properly disabled 4. cautery in offhand not working Fixes #82805 Fixes #82868 Honestly I have now regretted for doing this kind of implementation at the start. with how shoddily coded it is. Planning to refactor cyborg omnitools, admin omnitool and ayys omnitool (all have the same base of implementation) to be less snowflakey. but that's for the future. and will take some time. This is a bandaid fix for now ## Why It's Good For The Game this is cbt ## Changelog 🆑 fix: fixed cyborg bonesetter not working for compound fractures fix: butchering not disabling in cyborg omnitool fix: fixes a bug where if you select the omnitool it would be stuck in surgery initiator mode fix: cautery in off hand for cyborg omnitools not working /🆑 * fixes ai controllers hard deletes (#82861) ## About The Pull Request  i noticed almost all ai controllers were being hard deleted, its because the controller itself was being addedto the behavior_cooldowns list rather than the behavior itself ## Why It's Good For The Game fixes hard deletes ## Changelog 🆑 /🆑 * [no gbp] actually fixes bot access (#82809) ## About The Pull Request real fix to bots having AA. also i forgot to address simple bots in my previous attempt so this fixes them too ## Why It's Good For The Game fixes bots having AA ## Changelog 🆑 fix: all bots have their normal accesses restored /🆑 * [no gbp] Adds silicon interaction flags (#82822) ## About The Pull Request A few items with special silicon interactions did not have the proper flags to permit their use at distance (airlocks for instance) ## Why It's Good For The Game Fixes #82800 ## Changelog 🆑 fix: Restored silicon alt-clicking capability /🆑 * Monkey eyes fix and noticable organ display refactor; AI monkeys no longer catatonic (#82669) ## About The Pull Request It turns out monkeys being catatonic got broken 2 years ago in a PR that was meant to fix something else; also, it turns out monkeys are supposed to have primal eyes when turned into humans, and that got broken too. I fixed both of those things, and while I was at it I did a refactor to make it easier to give noticable organs (or anything else that you'd want correct pronoun and verb tenses) easier to implement. 1) AI controlled mobs now properly display their noticable organs when appropriate 2) Added some macros and a helper proc for replacing appropriate pronouns and verb tenses in text 3) The noticable organ HTML is no longer broken, so you can pass text with spans into it, if you want the text to be pretty or big or whatever 4) Monkeys are no longer catatonic if they have an active AI controller; this goes for any carbon actually but I think monkeys are the only one with AI controllers at the moment ## Why It's Good For The Game Fixes the logic for displaying organs on AI controller mobs (currently monkeys) Makes it easier to add these kind of organs for carbons, AI controlled or not, in the future Look! An actual use-case for split editor:  ## Changelog Humanized monkeys now have their primal eyes again; monkeys with active AI are no longer catatonic. 🆑 Bisar fix: AI controlled monkeys are no longer catatonic, and they have primal eyes again when turned into humans. spellcheck: Noticable organs now have more modular grammar, and their current grammar is fixed. refactor: Refactored the code for displaying the messages for noticable organs. config: Added a documented define of all our pronouns /🆑 --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> * DNA Infusion Refactor: Separates DNA Infusion Behavior from DNA Infuser (#82829) ## About The Pull Request - infuser entries global is now an assoc list type -> singleton. makes it easier to pick specific entries as needed - separated infusion behavior onto both movable level (for machine occupants and things that can potentially be infused) and human level (for the actual infusion into a human) - [x] tested ## Why It's Good For The Game Upcoming plans is to fix up maintenance sect's organ replacement system that just so happens to work a lot like how infusions do with actual infusion mechanics, and that requires this prerequisite. In general outside of that vision I see a lot of potential in alternate infusion sources, from wherever they may be. ## Changelog no player side changes, this is a refactor --------- Co-authored-by: Thunder12345 <Thunder12345@users.noreply.github.com> Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com> Co-authored-by: starrm4nn <139372157+starrm4nn@users.noreply.github.com> Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: san7890 <the@san7890.com> Co-authored-by: Bm0n <92271472+Bm0n@users.noreply.github.com> Co-authored-by: Yaroslav Nurkov <78199449+AnywayFarus@users.noreply.github.com> Co-authored-by: Pink <sightld2@gmail.com> Co-authored-by: Sadboysuss <96586172+Sadboysuss@users.noreply.github.com> Co-authored-by: Iamgoofball <iamgoofball@gmail.com> Co-authored-by: Name <w4rd3nn@gmail.com> Co-authored-by: Rhials <28870487+Rhials@users.noreply.github.com> Co-authored-by: Singul0 <127663818+Singul0@users.noreply.github.com> Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com> Co-authored-by: Iajret <8430839+Iajret@users.noreply.github.com> Co-authored-by: FlufflesTheDog <piecopresident@gmail.com> Co-authored-by: Jordan Dominion <Cyberboss@users.noreply.github.com> Co-authored-by: larentoun <31931237+larentoun@users.noreply.github.com> Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com> Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com> Co-authored-by: EvilDragonfiend <87972842+EvilDragonfiend@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: necromanceranne <40847847+necromanceranne@users.noreply.github.com> Co-authored-by: EricZilla <81941674+EricZilla@users.noreply.github.com> Co-authored-by: Helg2 <93882977+Helg2@users.noreply.github.com> Co-authored-by: Pickle-Coding <58013024+Pickle-Coding@users.noreply.github.com> Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: Ben10Omintrix <138636438+Ben10Omintrix@users.noreply.github.com> Co-authored-by: uaioy <114047053+uaioy@users.noreply.github.com> Co-authored-by: Nick <42454181+Momo8289@users.noreply.github.com> Co-authored-by: Joshua Kidder <49173900+Metekillot@users.noreply.github.com> Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>	2024-04-29 21:15:33 +02:00
SkyratBot	42f6f57dc0	[MIRROR] Replaces even more deciseconds with SECONDS (#27205) ... Replaces even more deciseconds with SECONDS Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: Waterpig <wtryoutube@seznam.cz>	2024-04-16 12:58:35 +02:00
SkyratBot	dcbfa8e6c7	[MIRROR] Atmos resin can cool the floor down directly. (#27266) ... * Atmos resin can cool the floor down directly. (#82553) ## About The Pull Request Makes atmos resin set the floor's temperature to 293.15 Kelvin. ## Why It's Good For The Game The floor can heat the air up. If someone were to extinguish a tritium fire or something ridiculous with halon, then an awkward situation will arise where the halon cools the air down, but when someone breaks the resin open, the floor heats the air back up, triggering the resin to spawn again and again, which can cause quite awkward problems. ## Changelog 🆑 balance: Atmos resin can directly cool the floor. /🆑 * Atmos resin can cool the floor down directly. --------- Co-authored-by: Pickle-Coding <58013024+Pickle-Coding@users.noreply.github.com>	2024-04-15 22:22:26 -04:00
SkyratBot	0b29278fa8	[MIRROR] Fix invalid List.Join() in chemsmoke logging (#27277) ... * Fix invalid List.Join() in chemsmoke logging (#82573) * Fix invalid List.Join() in chemsmoke logging --------- Co-authored-by: Penelope Haze <out.of.p.haze@proton.me>	2024-04-15 22:21:24 -04:00
SkyratBot	8b5912ccd9	[MIRROR] Halon combustion releases resin foam and pluoxium. Halon is formed by electrolysing BZ, and the reaction is much quicker. (#27150) ... * Halon combustion releases resin foam and pluoxium. Halon is formed by electrolysing BZ, and the reaction is much quicker. (#81887) ## About The Pull Request Original PRs: #69196 and #74472 Applies both of those PRs to this PR. Doesn't apply the firefighter backpack halon requirement changes since absolutely no one liked that. Halon combustion will combust into 2.5 moles of pluoxium per mole of halon consumed, and release atmos resin. The resin will not only help choke out fires, but it will also help seal rooms from fires, or seal fires from other rooms. Halon formation now requires electrolysing BZ instead of CO2 and N2O. The electrolysis is much faster. 2 moles of halon and 0.2 moles of oxygen is released with 91.2321kJ of thermal energy per mole of BZ electrolysed. Halon combustion starts at 343.15K instead of 373.15K. Resin foam no longer consumes halon and pluoxium. The resin foam released from halon combustion is a special type that lasts longer to ensure the halon can spread and not block itself when combusting. ## Why It's Good For The Game I have only seen one, maybe two rounds ever where someone created halon, and 0 rounds where it was actually used. The main reason why it (at least I think) isn't used is because it takes a rather large amount of effort and time for something that is only going to be used in a fraction of rounds. Preemptively spending that much effort every round, where most of the time it doesn't get used, will get boring and repetitive for pretty much anyone very quickly. Creating it as a response to a fire is going to take too long because you need to build a special cooling chamber and a contraption to ensure low pressure, and then wait for it to react slowly. This PR tries to resolve this by changing the requirement to BZ, making the electrolysis much quicker and scales with temperature instead of inversely with pressure, and making it combust into pluoxium. BZ is a gas that takes a little effort to make, but is probably the most frequently made gas and is likely already available when there is an emergency. With the BZ requirement combined with electrolysis speed change, creating halon is just a matter of dumping BZ into an electrolyser, turning the electrolyser on then extracting the halon, which can be reasonably done as a response to a plasmaflood or whatever. Halon combusting into pluoxium also makes halon not a dead end on the tree of gases. By letting halon combust into pluoxium, atmospheric technicians may persue halon to create pluoxium, which should let it feel less of a waste of time if someone decides to make it and there's no emergency that calls for the use of it. Halon combustion releasing resin foam conveys a visual effect that it is strong at choking fires. Reducing the temperature allows it to react earlier to a spreading fire, so it can block it before it spreads. ## Changelog 🆑 balance: Halon combustion releases 2.5 moles of pluoxium per mole of halon consumed. balance: Halon combustion no longer releases carbon dioxide. balance: Halon combustion releases resin foam. balance: Halon formation requirements changed to require electrolysing BZ instead of N2O and CO2. balance: Halon formation changed to no longer slow down at higher pressures. It instead accelerates at higher temperatures. It is much faster overall. balance: Halon formation releases 91.2321kJ of thermal energy per mole of halon consumed. /🆑 --------- Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com> * Halon combustion releases resin foam and pluoxium. Halon is formed by electrolysing BZ, and the reaction is much quicker. --------- Co-authored-by: Pickle-Coding <58013024+Pickle-Coding@users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@ users.noreply.github.com>	2024-04-04 21:55:37 +02:00
SkyratBot	37bc259bb0	[MIRROR] Refactor removing unused defines. (#26998) ... * Refactor removing unused defines. (#82115) Refactors a lot of the unused defines. Refactors a lot of the unused defines. Nothing player facing --------- Co-authored-by: san7890 <the@san7890.com> * Oh well. I hope this works fine. --------- Co-authored-by: Bilbo367 <163439532+Bilbo367@users.noreply.github.com> Co-authored-by: san7890 <the@san7890.com> Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>	2024-04-03 03:39:46 +02:00
SkyratBot	41392561a7	[MIRROR] Suppresses excessive logging that results from fights in the deathmatch (#26955) ... * Suppresses excessive logging that results from fights in the deathmatch (#82096) ## About The Pull Request So this is a PR i have had testmerged downstream for like a month now because deathmatch SPAMS the hell out of admin logs. This makes doing admin work kinda annoying when all the useful logs are drowned out by people trying to smoke each other to death endlessly. I don't know how bad the problem is upstream, but I'd imagine TG admins would likely express the same gratitude to have less active logging in game, in the case something important happens that they need to see. This should still keep logging things to the actual log files so the logs will still exist, but this merely suppresses the massive spam of logs that admins actively see. ## Why It's Good For The Game Lets admins do their job a little bit better being able to see when things happen in the logs. Deathmatch logs can be rather disruptive towards admins. ## Changelog 🆑 SomeRandomOwl admin: Deathmatch Bombs, Smoke, and Liquid floods are now suppressed in the logs and will not actively spam admin logs. code: adds a area flag to suppress logging for floods and bombs /🆑 * Suppresses excessive logging that results from fights in the deathmatch --------- Co-authored-by: SomeRandomOwl <2568378+SomeRandomOwl@users.noreply.github.com>	2024-03-20 06:35:55 -04:00
SkyratBot	f8b87b994b	[MIRROR] Overlay Lighting Color/Intensity Pass (#26825) ... Overlay Lighting Color/Intensity Pass Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>	2024-03-11 22:26:46 -04:00
SkyratBot	4f53ec2660	[MIRROR] Fixes complex lights not handling moving well, renames lighting defines (#26484) ... * Fixes complex lights not handling moving well, renames lighting defines (#81423) ## About The Pull Request [Fixes static lights not moving](ffef43c05a) Worked fine when the owner moved, but if the owner was inside something else, it would try and trigger an update on the PARENT's lights, which are obviously not us. [Renames MOVABLE_LIGHT and STATIC_LIGHT to better describe what they do](de73a63bd4) People keep trying to change the lighting system of lamps and it makes me mad. I choose OVERLAY_LIGHT and COMPLEX_LIGHT here, I couldn't figure out a better name for turf matrix lighting. Suggestions welcome ## Why It's Good For The Game Closes #80005 Hopefully improves understanding of lighting at a glance ## Changelog 🆑 fix: Fixes fancy lights not updating their source location when picked up and moved /🆑 * Oh well --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>	2024-02-12 22:25:22 +00:00
SkyratBot	9a3fb5c5c1	[MIRROR] FOV is Dead (Long Live FOV) [MDB IGNORE] (#25600) ... * FOV is Dead (Long Live FOV) * Update _megafauna.dm * Update _vehicle.dm * FOV Hotfix: Actually offsets gameplane render relays * removes redundant visual_shadow * removes GAME_PLANE_UPPER references * Update mob_movement.dm --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com> Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>	2023-12-23 17:47:07 +00:00
SkyratBot	558c466b81	[MIRROR] Splits placeontop proc [MDB IGNORE] (#25103) ... * Splits placeontop proc (#79702) ## About The Pull Request I find the proc hard to read honestly. There's no reason we can't split this into two functions - the secondary functionality is used only once, in reader.dmm. ## Why It's Good For The Game Code improvement Glorious snake case ## Changelog N/A nothing player facing --------- Co-authored-by: san7890 <34697715+san7890@ users.noreply.github.com> * Splits placeontop proc * Update brass_spreader.dm --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: san7890 <34697715+san7890@ users.noreply.github.com> Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>	2023-11-19 10:28:18 -05:00
SkyratBot	1dd5011776	[MIRROR] Adds pathmaps, refactors pathfinding a bit [MDB IGNORE] (#24414) ... * Adds pathmaps, refactors pathfinding a bit (#78684) ## About The Pull Request Implements /datum/pathfind/sssp, which generates /datum/path_map /datum/path_maps allow us to very efficently generate paths to any turf they contain from their central point. We're effectively running the single source shortest paths algorithm. We expand from the center turf, adding turfs as they're found, and then processing them in order of addition. As we go, we remember what turf "found" us first. Reversing this chain gives us the shortest possible path from the center turf to any turf in its range (or the inverse). This isn't all that useful on its own, outside of a few niche cases (Like if we wanted to get the farthest reachable turf from the center) but if we could reuse the map more then once, we'd be able to swarm to/from a point very easily. Reuse is a bit troublesome, reqiures a timeout system and a way to compare different movables trying to get paths. I've implemented it tho. I've refactored CanAStarPass to take a datum, /datum/can_pass_info. This is built from a movable and a list of access, and copies all the properties that would impact pathfinding over onto itself. There is one case where we don't do this, pathing over openspace requires checking if we'd fall through the openspace, and the proc for that takes an atom. So instead we use the weakref to the owner that we hold onto, and hold copies of all the values that would impact the check on the datum. When someone requests a swarmed path their pass info is compared with the pass info of all other path_maps centered on their target turf. If it matches and their requested timeout isn't too short, we just reuse the map. Timeout is a tricky thing because the longer a map exists the more out of date it gets. I've added a few age defines that let you modulate your level of risk here. We default to only allowing maps that are currently being generated, or finished generating in our tick. Hopefully this prevents falling into trouble, but consumers will need to allow "failed" movements. As a part of this datumized pass info, I've refactored pathfinding to use access lists, rather then id cards directly. This also avoids some dumbass harddel oppertunities, and prevents an idcard from changing mid path. Did a few things to the zPass procs, they took args that they did NOT need, and I thought it'd be better to yeet em. If you'd all like I could undo the caching/can_pass_info stuff if you'd all like. I think it's useful generally because it avoids stuff changing mid pathfind attempt, but if it's too clunky I could nuke it. Oh also I added optional args to jps that constricts how it handles diagonals. I've used this to fix bot paths. ## Why It's Good For The Game Much of this is redundant currently. I'm adding it because it could have saved hugglebippers, and because I get the feeling it'll be useful for "grouping" mobs like bees and such. We're doing more basic mob work currently and I want to provide extra tools for that work. https://github.com/tgstation/tgstation/assets/58055496/66aca1f9-c6e7-4173-9c38-c40516d6d853 ## Changelog 🆑 add: Adds swarmed pathfinding, trading accuracy for potential optimization of used correctly fix: Bots will no longer take diagonal paths, preventing weirdo looking path visuals refactor: Refactored bits of pathfinding code, hopefully easier to add new pathfinding strategies now /🆑 * Adds pathmaps, refactors pathfinding a bit --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>	2023-10-18 03:31:21 -04:00
SkyratBot	58c20a99fb	[MIRROR] Basic blob mobs [MDB IGNORE] (#23938) ... * Basic blob mobs * Update blackmesa.dmm * Modular update --------- Co-authored-by: Jacquerel <hnevard@gmail.com> Co-authored-by: Giz <13398309+vinylspiders@users.noreply.github.com>	2023-09-30 00:15:55 -04:00
SkyratBot	3836aaad45	[MIRROR] basicmob clowns [MDB IGNORE] (#23867) ... * basicmob clowns (#78448) ## About The Pull Request this is a mostly 1 to 1 port of simpleanimal clowns to basicmob clowns this means they have 1 more brain cell and they waddle https://github.com/tgstation/tgstation/assets/70376633/0c5f01c7-fea2-4d8c-9fc1-764c1557e1b8 ## Why It's Good For The Game  ## Changelog 🆑 refactor: clowns are basicmobs now /🆑 --------- Co-authored-by: san7890 <the@ san7890.com> Co-authored-by: Jacquerel <hnevard@ gmail.com> * basicmob clowns --------- Co-authored-by: jimmyl <70376633+mc-oofert@users.noreply.github.com> Co-authored-by: san7890 <the@ san7890.com> Co-authored-by: Jacquerel <hnevard@ gmail.com>	2023-09-23 14:37:18 -04:00
SkyratBot	3fd2f8134b	[MIRROR] Optimization pass focused on foam code (saves about 30% of cpu usage I think) [MDB IGNORE] (#22530) ... * Optimization pass focused on foam code (saves about 30% of cpu usage I think) (#76104) ## About The Pull Request Foam is crummy at high load rn, both because it runs on a low priority background subsystem, and because it wastes a bit of time. Let's reduce usage (while speeding up a bunch of other stuff too), and give it more cpu generally. [Optimizes reagent processing somewhat](d409bd4afc) Turns out most of the cost of foam is the reagents it carries, and the varying effects they have I'm doing my best here to optimize them without touching "user space" too much That means doing things like prechecking if we're gonna spawn on top of an existing decal (from glitter, flour, etc), and using that same proc to also avoid spawning on unacceptable turfs (I had to convert inheritance to a bitflag system to make this work, but I think that's ok since we want it imparative anyhow) It's actually nice for code quality too, since it lets me clean up code that was using raw locates and weird var pong. god I wish I had implied types man [Optimizes foam spreading in its most accursed aspect, reagent copying](5cc56a64ad) Holy shit reagent code is a lot. I'm doing a bunch of small things here. istype in init -> typecache, removing procs that are called once and loop over a list we JUST looped over (ph and the caching for reactions in particular) I am mainly trying to optimize copy_to here, since that's what foam spams As a part of this, I removed a pair of update_total and handle_reactions calls that were done on the reagents we are copying FROM I have no god damn idea why you would want to do that, but if anything is relying on the copy proc modifying the source, then that code deserves to break Speaking of, I cleaned up handle_reaction's main filter loop a lot, removed a lot of redundant vars and changed it from a full loop w tracker vars to an early exit pattern This meant using a loop label, which is unfortunate, but this is the fastest method, and it does end up cleaning up the code significantly, Which is nice Oh also I made the required_other var function even if there is no atom attached to the reaction, since I don't see why it wouldn't This last bit is gonna get a bit esoteric so bear with me Failing calls (which are most of them) to handle_reactions are going to be fastest if they need to check as few reactions as possible One reagent in a reaction's required list is marked as the "primary", and thus gets to trigger checking it. We need all the reagents to react anyhow, so we might as well only check if we have one particular one to avoid double checking Anyhow, in order to make most calls the fastest, we want these reactions distributed as evenly as possible across all our reagents. The current way of doing this is just taking the first reagent in the requirements list and using it, which is not ideal Instead of that, lets figure out how many reactions each reagent is in, then divy reactions up based off that and the currently divvied reactions This doubles the reagent index count, and takes the most common reagent, water, from 67 reactions to I think like 22 Does some other general cleaning in reagent code too, etc etc etc [Fixes runtimes from the forced gravity element being applied more then once](941d067611) I feel like this element should take a trait source or something to make them potentially unique, it's too easy to accidentally override one with another [Removes connect_loc usage in atmos_sensitive, replaces it with direct reg/unreg](de1c76029d) I only really used it because I liked the componentization, but it costs like 0.2 seconds off init alone which is really stupid, so let's just do this the very slightly harder way [Micros foam code slightly by inlining a LinkBlockedWithAccess call](744da3694c) This is in the space of like 0.05 seconds kinda save so I can put it back if you'd like, the double loop just felt silly [Changes how foam processes slightly](ee5e633e32) Rather then treating spreading and processing as separate actions, we do both in sync. This makes foam fade faster when spreading, which is good cause the whole spread but unclearing foam thing looks silly. It also avoids the potential bad ending of foam spreading into itself, backwards and forwards. This is better I promise. [Bumps fluid priority closer to heavy eaters, moves it off background](811797f09d) Also fixes a bug where foam would travel under public access airlocks. ## Why It's Good For The Game Saves a lot of cpu just in general, from both init and live. In theory makes foam faster, tho I'd have to test that on live at highpop to see if I've actually succeeded or not. Guess we'll see. * Optimization pass focused on foam code (saves about 30% of cpu usage I think) --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Bloop <vinylspiders@gmail.com>	2023-07-18 16:49:51 -04:00
SkyratBot	6dfe17306c	[MIRROR] Pulls apart the vestiges of components still hanging onto signals [MDB IGNORE] (#21738) ... * Pulls apart the vestiges of components still hanging onto signals * update modular --------- Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>	2023-06-18 13:18:23 +00:00
SkyratBot	02e3251f84	[MIRROR] Makes gasses use defines [MDB IGNORE] (#21492) ... * Makes gasses use defines * Mirror! --------- Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: Funce <funce.973@gmail.com>	2023-06-01 15:24:31 +12:00
SkyratBot	b675b52364	[MIRROR] Fixes a runtime from foam in a weird loc / improves the stack trace (somewhat) [MDB IGNORE] (#21046) ... * Fixes a runtime from foam in a weird loc / improves the stack trace (somewhat) (#75281) ## About The Pull Request - Fixes a runtime from foam being created inside plasmamen, instead of at the plasmamen's loc, from the clown plasmaman suit  - Adds a stack trace for mobs having foam created inside of them - So, in the past foam would runtime if created in a non-turf at all, mobs or otherwise. I changed it so it creates a more helpful stack trace. - While tackling this, however, I realized that we may want to support foam in non-turf, non-mob locs? Like closets? That is to say, if you release a foam reaction while stuck in a locker and it floods the locker, it would stay in the locker until it is opened, and affect other people in the locker itself? Unsure, so I left it as an option, albeit it may not function entirely correctly. - This may also false-positive in some places, such as a mob within mob. I'm unsure if it should have its own case, or of it should act like closets are implied to do above? But that may produce some silent errors. So eh. ## Why It's Good For The Game Less runtimes, more intended code. ## Changelog 🆑 Melbert fix: Fixes a runtime with plasmaman clown suit lube spray /🆑 * Fixes a runtime from foam in a weird loc / improves the stack trace (somewhat) --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>	2023-05-10 00:46:12 +01:00
SkyratBot	9a594755f3	[MIRROR] Renames delta time to be a more obvious name [MDB IGNORE] (#20507) ... * Renames delta time to be a more obvious name * updates to our code --------- Co-authored-by: oranges <email@oranges.net.nz> Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>	2023-04-12 20:45:43 +01:00
SkyratBot	6f3befe233	[MIRROR] Reagent soup / Soup rework / Stoves - A kitchen expansion [MDB IGNORE] (#20410) ... * Reagent soup / Soup rework / Stoves - A kitchen expansion * fixes that stuff * puts the range stove on maps that sohuld have it * fixes some paths that don't exist anymore --------- Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: Paxilmaniac <paxilmaniac@gmail.com>	2023-04-08 13:30:41 -04:00
Gandalf	e4b4d4d3c0	MISSED MIRROR [Lints Against Unmanaged Local Defines] (#20204) ... * https://github.com/tgstation/tgstation/pull/74333 https: //github.com/tgstation/tgstation/pull/74333 Co-Authored-By: tattle <66640614+dragomagol@users.noreply.github.com> * var stuff Co-Authored-By: tattle <66640614+dragomagol@users.noreply.github.com> * vars * Update sol_fed.dm --------- Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com>	2023-04-01 01:15:22 +01:00
SkyratBot	308e211295	[MIRROR] Creates short-lived foam (and applies it to the Scrubber Overflow) [MDB IGNORE] (#18065) ... * Creates short-lived foam (and applies it to the Scrubber Overflow) (#71850) ## About The Pull Request Creates a short-lived foam with a lifetime of 1 SECOND instead of the default 8 SECONDS to address some complaints about the scrubber overflow event overstaying its welcome. ## Why It's Good For The Game Fixes #69689 Fixes #71830 ## Changelog 🆑 Tattle balance: the foam used in the scrubber overflow has a lifetime of 1s instead of 8s /🆑 Co-authored-by: tattle <article.disaster@ gmail.com> * Creates short-lived foam (and applies it to the Scrubber Overflow) Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com> Co-authored-by: tattle <article.disaster@ gmail.com>	2022-12-15 16:15:18 -05:00
Zonespace	f7c26bbf25	515 Compat (#17465) ... * ONLY SKYRAT CHANGES * ACTUALLY SKYRAT CHANGES * yolo, revert later * Update alternate_byond_versions.txt Co-authored-by: AnturK <AnturK@users.noreply.github.com>	2022-11-15 06:59:06 +00:00
SkyratBot	bebe814ebb	[MIRROR] Fixes plenty instances of 1-tile foam [MDB IGNORE] (#17414) ... * Fixes plenty instances of 1-tile foam (#71132) ## About The Pull Request All of these from what i heard were supposed to make all foam with range "4" but most of these ranges were stupidly big so Fixes 1 tile foam that was apparently not fixed after the foam refactor in: AI Upload Foam Dispensers, with a range of "4" Hygienebot death, with a range of "2" Clown cars taking damage, with a range of "4" and 25u of space lube. (henk) Clown plasmaman envirosuits extinguishment, with a range of "4" and 15u of space lube. (hunke) Soap suicide, with a range of "1" Emagged cleanbots wetting the floor and making foam, with a range of "2" Firebots when exposed to an atmos fire, firefighting foam with a range of "3"  ## Why It's Good For The Game Fixes #68441 Makes firebots less ass Also barely-functional code bad, functional code good ## Changelog 🆑 fix: Fixes 1 tile foam in Foam Dispensers,Clown Cars, Hygiene Bots,Firebots, Soap Suicide, Emagged cleanbots, and the clown plasmaman envirosuit /🆑 * Fixes plenty instances of 1-tile foam Co-authored-by: jimmyl <70376633+mc-oofert@users.noreply.github.com>	2022-11-09 02:07:02 +00:00
SkyratBot	ae708cd7b5	[MIRROR] Removes ComponentInitialize() [MDB IGNORE] (#15552) ... * Removes ComponentInitialize() * Fixes a leftover merge conflict marker * Fixes the oversight that came from the upstream merge skew * Fixes all of the instances where we used ComponentInitialize() when we shouldn't've been * Fixes CI being broken because of the HEV suits Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>	2022-08-12 19:05:09 -04:00
SkyratBot	24267f7768	[MIRROR] Readds Alien Vore [MDB IGNORE] (#14967) ... * Readds Alien Vore * Update parts.dm Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>	2022-07-17 03:54:40 -07:00
Gandalf	de8807eee2	TGUI reset and removal of unticked files and ci suite update (#14677) ... * Adds easy to extend custom svg font. (#57717) Just throw in svgs into tgui/packages/tgfont/icons directory and you can use them in tgui with tg- prefix. Co-authored-by: Style Mistake <stylemistake@gmail.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Update build.js * Update build.js * Update build.js * ew * more?? * Update validate_dme.py * Update validate_dme.py * Delete explorer_gear.dm Co-authored-by: AnturK <AnturK@users.noreply.github.com> Co-authored-by: Style Mistake <stylemistake@gmail.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>	2022-07-02 01:16:15 +01:00
SkyratBot	35286f5993	[MIRROR] Improves logging for smoke clouds. [MDB IGNORE] (#14156) ... * Improves logging for smoke clouds. * Update robot_upgrades.dm Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com> Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>	2022-06-08 02:15:29 +01:00
SkyratBot	a3c0819e80	[MIRROR] Removes (in) smoke and foam reactions [MDB IGNORE] (#13963) ... * Removes (in) smoke and foam reactions (#67270) * Removes smoke and foam reactions Turns out when you let reagents react in foam/smoke, people put bombs in them. This behavior was initially added to just smoke, accidentially in (56f7ac0c0a) accidentialy (thalpy tried to make both foam and smoke instant react, but instead made smoke's temporary holder reagent instant instead. hhhhhhh) Assuming this was intentional it was then extended to foam in (1879e2d338) Basically, we're idiots. Anyway lets just walk this all back to instant reaction on smoke/foam formation. Hate you people * Removes another source of gunpowder smoke Temporal told me about this. Gunpowder uses an ex_act signal as a starter, and that also counts for smoke objects. Really don't want instant detonation smoke bombs, so let's just... not shall we? * Removes (in) smoke and foam reactions Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>	2022-05-28 13:54:31 +01:00
SkyratBot	26271d8f69	[MIRROR] Fixes foam spreading through public airlocks and windoors [MDB IGNORE] (#13935) ... * Fixes foam spreading through public airlocks and windoors (#67101) * Fixes foam spreading through public airlocks and windoors * nova * Fixes foam spreading through public airlocks and windoors Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>	2022-05-27 12:45:26 +01:00
SkyratBot	92f9be0898	[MIRROR] Makes smoke react to opening airlocks. [MDB IGNORE] (#13804) ... * Makes smoke react to opening airlocks. (#66963) Makes smoke spread through newly opened airlocks if the cloud has spread past the airlock, but has not completely finished spreading. More intuitive smoke behavior. As funny as it is to open an airlock and see nothing but a wall of smoke it's even funnier to open an airlock and suddenly be inside a wall of smoke. * Makes smoke react to opening airlocks. Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>	2022-05-22 12:14:23 +01:00
SkyratBot	e416c5b573	[MIRROR] [NO GBP] Jetpack and spacedrift: Fixes and niceties [MDB IGNORE] (#13754) ... * [NO GBP] Jetpack and spacedrift: Fixes and niceties (#66628) * Jetpack and spacedrift: Fixes and niceties Ok so when I ported spacemovement onto movement loop, I neglected to port this behavior that existed to support jetpacks. Basically, if something that lets you move while spacedrifing completes a move while you're spacedrifting, the drift should "disable" to let it complete, and then later restart. I neglected to add support for that, so that's what this does. There's some other stuff going on here, mostly things to let jetpacks ignore some of drift's extra behavior, since when a jetpack is not on stablized, we want both to coexist. It's a bit of a mess, I'm sorry about that. Oh and at temporal's suggestion I've moved the visual_delay set from newtonian move to an istype on the drift component, that was a good idea, thanks quiet * Makes dropping a pull while drifting carry the momentum into the pulled thing\ * Adds some extra context to Process_Spacemove, fixes a bunch of stupid space bugs It used to be, if you called Process_Spacemove with a direction, it assumed you were an "action", so a client or mob trying to move in a direction. Unfortuantely for it, I needed to be able to use direction to make mob pull drifting work. So we now actually pass in a second variable called continuous_move, which tracks if this Process_Spacemove is on behalf of a continuous move or not In addition to this, I've added logic to bumping "off" someone to prevent backbumping if that makes sense, since the bump is in the form of a newtonian move that's run before the thing that's bumping actually moves, we need some way to exclude it from holding the other object in place. * Adds a jetpack component, uses it to unify all three versions of jetpacking I hate you fikou There were three copies of the same behavior, which made it hard to fix stuff. Let's just componentize it * Fixes jetpacks stabalizing even without fuel This is mildly hacky. The real fix is to do this with events, but I really don't wanna bend my brain like that. This'll do * Ensures turn_off always has a user) * Shut pu * Bulky drags no longer effect your movespeed in space, fixing a consistency issue between them and all other forms of drags * Removes some redundant code, cleans up some messy stuff * Removes redundant safety checking from jetpack code * see above * Removes redundant signals * [NO GBP] Jetpack and spacedrift: Fixes and niceties Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>	2022-05-20 14:41:47 +01:00
SkyratBot	ef2016732d	[MIRROR] Makes smoke and foam attempt to fill the available space. [MDB IGNORE] (#13407) ... * Makes smoke and foam attempt to fill the available space. * wew * reset * Revert "reset" This reverts commit 75be4f934504793ceb5c9bf2f3774dc24517df5a. Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com> Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>	2022-05-08 04:01:32 +01:00
Useroth	cca7f8ee4c	Some missed mirrors (#13415) ... * Refactors firestacks into status effects (#66573) This PR refactors firestacks into two status effects: fire_stacks, which behave like normal firestacks you have right now, and wet_stacks, which are your negative fire stacks right now. This allows for custom fires with custom behaviors and icons to be made. Some fire related is moved away from species(what the fuck was it even doing there) into these as well. Oh and I fixed the bug where monkeys on fire had a human fire overlay, why wasn't this fixed already, it's like ancient. Also changed some related proc names to be snake_case like everything should be. This allows for custom fire types with custom behaviours, like freezing freon fire or radioactive tritium fire. Removing vars from living and moving them to status effects for modularity is also good. Nothing to argue about since there's nothing player-facing * Hud Image Culling By Z Level: Theft edition (#65189) * makes hud images only apply by z level * makes some of the atom_hud procs have better names * fixes warning with the hud_user list and adds better documentation * better docs for hud_images * removes TODOs * docs for hud_list * adds support for linked z levels so mobs can see lower ones * fixes merge conflict and shittily makes only shocked airlocks get added * adds support for setting images in the hud as active and inactive * gets rid of unatomic spatial grid change * maybe i should actually try COMPILING my changes * fixes merge skew and makes it compile again * fixes huds refusing to remove from users who changed z level * improves z level and registration logic * fixes antag huds not appearing * Fixes antag huds not properly setting. We now use hud_list in init, so it needs to be set before the new call, not after. Not sure why the use of appearance key was split like this, but none else knows either so none can stop me * Ensures that hiding a basic appearance also hides the atom's active list too * Fixes antag huds going poof Ensures that remove_atom_from_hud will return false if the passed atom isn't managed by it This fixes antag huds disappearing randomly, since they assumed that if the parent call of remove_atom_from_hud returned true, we should delete ourselves. This is a safe assumption for them to make, since they should only ever have one atom. Does kinda bork if we call remove_atom_from_hud in a way that is unsure if the passed atom is actually in that list. We were forced into doing this by how atom huds use the qdeleting signal. * makes basic alternate_appearance's only update themselves when setting their hud image to active and makes them not add themselves to the global huds_by_category list * fixes mistake with hud_users list being set non associatively (bad) * as anything in bot path loops * Fixes merge skew problems * Makes bot paths non global This way they can show themselves to only the bot that "owns" them, ya feel me? * Fixes huds not showing up sometimes, cleans up some code Post Kapu's limb refactor, we were calling prepare_huds twice in a human init call chain. What was happening was this: call prepare_huds() // Human I gained a new hud image I set active hud icons to mirror it call prepare_huds() // Living I overwrote the new hud image I attempted to set active hud icons, which failed because it assumes this can never happen *cries* * Renames add_hud_to_atom to show_to My hope is this will make understanding hud code a bit easier, by tying the behavior to a "verb" more closely. Also renamed a few vars * remove_hud_from_mob -> hide_from * Nitpicks a few comments * Whoops/fuck/shit/damn it all/hhhhhhhhhhhh * Moves check down, improves stack trace a bit Co-authored-by: KylerAce <kylerlumpkin1@gmail.com> * small touch-up * this should do it Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: KylerAce <kylerlumpkin1@gmail.com>	2022-05-08 03:59:40 +01:00
SkyratBot	6aebab2146	[MIRROR] MODsuit module update: clamp nerf, replacement of holster and pepper spray modules, some tweaks to suit starting modules [MDB IGNORE] (#12783) ... * MODsuit module update: clamp nerf, replacement of holster and pepper spray modules, some tweaks to suit starting modules * Update mod_control.dm * fixes * fix2 Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com> Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>	2022-04-18 20:34:32 -07:00
SkyratBot	3a9842d237	[MIRROR] you can now stand on top of metal foam below you [MDB IGNORE] (#12771) ... * i want to sleep (#66184) * you can now stand on top of metal foam below you Co-authored-by: capsaicin <84609863+capsaicinz@users.noreply.github.com>	2022-04-16 10:11:00 -04:00
SkyratBot	8bc57acde9	[MIRROR] "Actually on second thought and some testing these really aren't as significant as I thought they were" buffs to smoke and foam. [MDB IGNORE] (#12356) ... * "Actually on second thought and some testing these really aren't as significant as I thought they were" buffs to smoke and foam. (#65155) This PR buffs smoke and foam in two ways. It increases the hardcap on carried reagent volume for smoke to 1000u. This is on par with foam, which also has a reagent multiplying effect that smoke does not have. It permits reactions within both smoke and foam. This could be more dangerous as it could allow for smoke/foam to make more smoke/foam, but these reactions would consume the contents of the smoke and foam so it shouldn't cause too much trouble. What this means for you. In all honesty these changes won't make chemical weapons significantly more powerful than their current state. While you would think that doubling the carrying capacity of smoke would make a significant difference in reality it really doesn't. The vast majority of chemical delivery methods had payload capacities too low to run up against the old hardcap. Of the ones that could only chemical payloads really have the capacity to take full advantage of it and when was the last time you saw an antagonist actually use a chemical payload with smoke? I don't think I ever have. For those still concerned about balance: a smoke mix with a 500u blend of acids optimized for damage deals 52.35 total damage each tick on an unprotected target. The same mix at 1000u deals 53.1 total damage each tick. This is a difference of 1.5%, hardly enough to notice. On the other hand, the change to make foam mixes allow reactions within the foam would be a massive change..... but reactions have already been allowed within smoke for months now. That's probably been the case since #56019 dropped actually. All this PR does it allow them within foam as well. On that note, after some testing foam is significantly less potent than smoke in this manner for a few reasons. Firstly, foam is blocked by a multitude of common objects that smoke simply isn't: tables, lockers, and crates for a start. Secondly, foam divides the reagents used to make the foam by the range* of the foam when it is initially created. As such it is necessary to cram about twice as much reactant into the foam to get the same effect as the same mix (but smoke) with a lower dispersal range. First off, the fact that smoke and foam have carry volume hardcaps at all is not well communicated. To my knowledge it is not mentioned anywhere in game or on the wiki. Essentially the only way to figure out that they exists is either to code dive or to build high density smoke chemical payloads and notice that they are somewhat less effective than they should be. I cannot remove the hardcaps entirely so the next best thing is making sure that both hardcaps are in the same place. Secondarily, I have been enjoying applying delayed-reaction smoke for about a month now and haven't really seen a reason for it to be blocked in foam as well. I would like for other chemists to try to also use delayed-reaction smoke as well because I find it interesting and I'm pretty certain I haven't fully explored what is possible using it. After doing some testing this should not notably effect game balance as foam is significantly less effective than smoke in this manner of application. * "Actually on second thought and some testing these really aren't as significant as I thought they were" buffs to smoke and foam. Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>	2022-03-29 01:25:55 +00:00
SkyratBot	17e4f6ad76	[MIRROR] Converts SFX keys into DEFINES [MDB IGNORE] (#11990) ... * Converts SFX keys into DEFINES * fixes and updates Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com> Co-authored-by: John Doe <gamingskeleton3@gmail.com>	2022-03-11 16:43:39 -07:00
SkyratBot	a74758af0e	[MIRROR] Space drifting fixes and cleanup [MDB IGNORE] (#11801) ... * Space drifting fixes and cleanup (#64915) * Fixes infi pushing off something in space Right now you can just push "into" a dense object forever, and depending on your move rate, just kinda glide We can fix that by checking if we're trying to push "off" something we're moving towards * Makes pushing off something shift it instantly Currently if you kick off something in space it waits the delay of the move to start drifting. Looks dumb, let's not * Updates backup movement to properly account for directional windows. GOD I HATE DIRECTIONAL DENSITY SHOOOOOT MEEEEEEEEEEEEEEEEEEE * Uses range instead of orange so standing on the same tile as a directional counts properly, rather then suddenly entering a drift state. I hate it here * Ensures all args are named, updates implementations of the proc with the new arg * Space drifting fixes and cleanup Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>	2022-03-01 06:48:45 -05:00
SkyratBot	f793ec16b9	[MIRROR] Makes extinguisher sprays look nicer [MDB IGNORE] (#11580) ... * Makes extinguisher sprays look nicer (#64949) Rather then sticking around till their 7 second delay, they dissipate once they finish their movement. This dissipation comes with a fading and such to make things look nicer. I've applied the fading behavior to sprays too, since they could also use the help. I really hate how things look currently, makes me break out in hives * Makes extinguisher sprays look nicer Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>	2022-02-18 23:17:14 +00:00
SkyratBot	b2cc74a77e	[MIRROR] Fixes layering issues brought by the FoV PR. [MDB IGNORE] (#11411) ... * Fixes layering issues brought by the FoV PR. * Update code/__DEFINES/layers.dm * Update code/modules/mob/living/living_defines.dm * Update code/modules/mob/living/simple_animal/hostile/venus_human_trap.dm Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>	2022-02-10 02:51:52 +00:00
SkyratBot	c75f5aa8b1	[MIRROR] Adds locked icons, fixes several other icons, and a few other QoL tweaks to Suit Storage Units [MDB IGNORE] (#11331) ... * Adds locked icons, fixes several other icons, and a few other QoL tweaks to Suit Storage Units (#64639) Broken Super_UV icon (big flashing red overlay), no icon to indicate its locked, and unscrewing it straight up broke the whole icon! That's all fixed, along with some quality of life, including warnings explaining WHY stuff failed... I even made the super_uv ACTUALLY output black smoke, as the description says it does, because its cool. Tidies up something that sees more use now that we have MODsuits (and potentially will get them buildable if that other PR goes thru) The Suit Storage Units now have a Locked indicator on their lights! In exchange, decontamination above safe levels has a slightly different indicator (flashing red/yellow) SSU gives chat warnings as to why it blocks decontamination (no items/safeties on) SSU panel/super-decontamination icons work properly now The SSU super-decontamination also creates a plume of black smoke at the end, as the flavor description said it did. * Adds locked icons, fixes several other icons, and a few other QoL tweaks to Suit Storage Units Co-authored-by: OrionTheFox <76465278+OrionTheFox@users.noreply.github.com>	2022-02-08 01:54:14 +00:00
SkyratBot	cd814c127f	[MIRROR] Adds an option to generate typecaches as zebras. [MDB IGNORE] (#11330) ... * Adds an option to generate typecaches as zebras. * Update energy_ball.dm Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com> Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>	2022-02-08 01:54:04 +00:00
SkyratBot	f401290917	[MIRROR] Fixes foam wall error message [MDB IGNORE] (#11234) ... * Update effects_foam.dm (#64604) * Fixes foam wall error message Co-authored-by: Tom <8881105+tf-4@users.noreply.github.com>	2022-02-02 17:53:09 +00:00
SkyratBot	c9bdba8ae1	[MIRROR] Walls built on metal foam instead of girders revert to metal foam when decon'd [MDB IGNORE] (#11180) ... * Walls built on metal foam instead of girders revert to metal foam when decon'd (#64553) * raises cost of metal from foam * goes with fikou's idea for metal foam girder_type * Walls built on metal foam instead of girders revert to metal foam when decon'd Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>	2022-01-31 23:03:27 +00:00
SkyratBot	5cd52f5028	[MIRROR] Metalfoam structures can now be used as girders to finish building walls. [MDB IGNORE] (#11134) ... * Metalfoam structures can now be used as girders to finish building walls. (#64386) * Foam structures can be used as girders for walls. * Cleaner ifs * RIP non iron walls * Metalfoam structures can now be used as girders to finish building walls. Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>	2022-01-29 23:13:36 -05:00