Commit Graph

32025 Commits

Author SHA1 Message Date
ShizCalev
47e93df584 Cleans up paicard and aicard code (#52575)
* Cleans up paicard and aicard code

* fix

* more fixes
2020-08-01 06:44:21 -03:00
Jared-Fogle
f23dcd2067 Fix pulsing the power wire shocking you repeatedly unless you close tgui (#52541)
* Fixes #52538

* Allow those with insulated gloves to mess with airlocks still

* Fix not being able to interact with insulos

* Fix style qualms

* Add shock immune to should_electrocute
2020-07-30 23:15:12 -03:00
zxaber
215ef5c6f3 Replaces modular computer card eject verbs with UI buttons (#52489)
* Replaces mod-CPU card eject verbs with UI buttons

* ?
2020-07-31 04:18:35 +03:00
EdgeLordExe
ed5745ae44 [READY] HERETICS balancing: makes raw prophets more useful (#52028)
* e

* makes raw prophets more useful

* e

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* E

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* E

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* E

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>

* E

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-30 14:52:00 -03:00
Gamer025
c93c479ff9 Adds useless skillchip adapter (#52577)
* Adds useless skillchip adaptor

* Redo code so that skill_station code doesn't need to be modifed

* Remove helper and return directly instead of setting return code

* Update code/modules/library/skill_learning/skillchip.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Change to bitflag system

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-30 14:49:21 -03:00
NightRed
9c6fbc5847 Meteor shield acts as expected when hacked (#52582)
* emag meteor shield

* removed extra check
2020-07-30 14:44:32 -03:00
Dennok
6625041e68 Fix multitile engine rotating. (#52424)
* Update shuttle_rotate.dm

* set bound

* setDir

* Move multitile border rotate shifting to base proc

* Move borders shifting to atom/movable/shuttleRotate()

* Better code

Co-authored-by: Rohesie <rohesie@gmail.com>

* Better better code

Co-authored-by: Rohesie <rohesie@gmail.com>

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-30 06:31:47 -03:00
Dennok
b4c275e2ce Try to replace light overlay to vis_contents (#52389)
* Try to replace light overlay to vis_contents

* move glowybit creation in Initialize

* ups

* change mutable_appearance to SSvis_overlays

* set right settings
2020-07-30 06:03:52 -03:00
Rohesie
ac64362c11 Admins can respawn (#52567)
* respawn

* changes

* spawn

* R_ADMIN
2020-07-30 02:25:02 -04:00
tralezab
5ca99fc0c3 Mafia Achievements (#52514)
* no brainer!

* hilarious indentation error

* thank you!!

Co-authored-by: trollbreeder <trollbreeder@users.noreply.github.com>

* fixes

* armhulen07/23/2020 someone mute me from this channel i'm going to give all of my organs to Bulgaria if i keep finding these dark truths

Co-authored-by: trollbreeder <trollbreeder@users.noreply.github.com>
2020-07-30 03:13:13 -03:00
ShizCalev
3eeef6c272 Cleans up some unused procs and makes is_blocked_turf a turf proc. (#52482)
* Cleans up some unused procs and makes is_blocked_turf a turf proc.

* Update code/game/turfs/turf.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-30 02:20:35 -03:00
ShizCalev
f79df59305 Merge pull request #52565 from tgstation/revert-52519-centcom
Revert "CentCom Galactic Ban DB"
2020-07-30 01:10:22 -04:00
ShizCalev
8d5a502635 Merge pull request #52580 from Cyberboss/CleanBadVars
Remove instances of `var varname` in dm code
2020-07-30 01:05:37 -04:00
Fikou
14725daf58 repaths neurotoxin + embedding changes in bullets + adds effects when you shoot energy weapons (#52543)
* how

* Update alien_powers.dm

* adds impact effects, makes thinks that shouldnt embed not embed

* rogue pixel moment
2020-07-30 01:33:51 -03:00
Dennok
a190d33cdb Move cable radial menu to attack_self. Move recipe crafting to radial menu chose (#52540)
* Move cable radial menu to attack_self

Move recipe crafting to radial menu chose

* Remove loc check in attack_self
2020-07-30 01:21:11 -03:00
Ryll Ryll
dfcd304dcc Dismemberment wound tweaks, zombies are easy to wound/dismember, tweaks to head vulnerability (#52534)
* adds wound armor to helmets + such, nerfs standard head resist

* dismember + wound species balance, retitle traits
2020-07-30 01:18:57 -03:00
ShizCalev
37a3e79552 Fixes seed mutatelist runtime (#52573) 2020-07-30 00:49:30 -03:00
Couls
27838579e3 Drinks can now carry diseases, Wipe down your glasses with rags bartenders! (#52421)
* Drinks can now infect you, Wipe down your glasses with rags bartenders!

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/datums/components/infective.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/datums/components/infective.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-29 21:08:10 -03:00
Jordan Brown
e6374abd60 Remove instances of var varname in dm code 2020-07-29 11:56:09 -04:00
Dennok
c327c76c13 Remove cable hubs from handcrafting (#52539) 2020-07-29 10:06:02 -03:00
Daniel Hultgren
0741b1977f Cleanable cleanup (#52477)
* Don't initialize the atom_colours list on atoms until it's actually needed

* Moved bloody_hands var to mob/living/carbon/human instead

* Added COMSIG_COMPONENT_CLEAN_RADIATION signal to reduce moms spaghetti

The shower and suit storage unit now calls this signal instead of either doing it manually or doing it via the washed proc

* Cleaned up carbon washing, renamed washed to wash

* The wash proc now doesn't take the washer as first arg because that wasn't used anywhere
* The wash strength is no longer optional
* Carbons now overrides the wash proc instead of using the signal
* Properly check for obscuredness before washing any equipped items
* Properly wash all items and bloody hands etc
* Added clean_lips proc for humans for cleaning any lipstick

* Cleaned up washing. Washy stuff now calls wash instead of calling the clean signal directly

* Renamed is_cleanable to ismopable, gives this category a more fitting purpose. Many things beyond floor decals are cleanable. It is now also determined using the atom layer instead to make it more generic.
* Properly utilize the is_cleanable define
* Added wash override for turfs where they also wash any mopables on the same tile
* Space cleaner and cleaning element etc now simply washes the mob instead of doing its own manual cleaning on ~some~ equipped items

* Non-component washables now simply override wash instead of registering for the clean signal

* Fixed some left over clean signal registers not returning true

* Added clean_strength var to space cleaner

* Moved human wash proc next to the other washing procs

* Also wash glasses and mask if not obscured when washing face

* Fixed attempting to "scoop up" cleanable decals using a rag

* Fixed plasmaman spacehelm icon not updating when washed

Also removed a duplicated worn_overlays proc

* Fixed head icon not updating when washing lipstick

* Moved radioactive clean signal register to where it should be

* Added atom radiate VV verb for debugging

* Redesigned the CLEAN constants into a more sensible flags setup

This makes it more dynamic, cleaning apparatuses can clean more specific than just a cleaning strength.

* CLEAN_TYPE_* flags indicate a specific cleanable, such as blood, fingerprints or disease
* CLEAN_* consts consist of a combination of cleaning types to make cleaning apparatuses have a consistent behaviour on what they clean

* Fixed broken rad removal logic in showers

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>

* Removed unneccesary bool from sink code

* Fixed wrongly named variable in turf wash

* Renamed bloody_hands to blood_in_hands

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-29 09:31:38 -03:00
Rohesie
cb9f81e43c Renames smooth var to smoothing_flags (#52427)
* smooth_flags

* SMOOTH_FALSE

* smooth_flags
2020-07-29 10:19:23 +02:00
AnturK
e5cf3c05b8 Simple skill/skillchip framework (#52314)
* Simple skills framework.

* Map changes.

* Adds skillchips to vendor

* Adds skill stations to the map.

* Circuitboards

* Fix typo

* Some minimal instability

* Fixes,tweaks etc

* Suggest better names or we'll end up with these.

* sharpness thing

* tgui build

* Makes wine from booze synthetizer show to wine tasters.

* Makes wine from dispenser have taste for wine tasters.

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>

* Swaps to carbon var.

* wordy helper proc

* While i'm at it, other relaymoves

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-29 05:13:36 -03:00
Dennok
ae108e51d4 Sheetifier and Vend-a-Tray has proper named circuit boards (#52462)
* Update machine_designs.dm

* up
2020-07-29 03:54:56 -03:00
Jared-Fogle
aaf07de02d Limit how often you can use the emergency shuttle console (#52522)
* Limit how often you can use the emergency shuttle console

* Add QDELETED check
2020-07-29 02:05:22 -03:00
Memedoktor
ff69a8f7a9 Chaplains now enjoy eating the only divine food (#52082)
* god please let this work

* Update melon.dm

* Update code/datums/mood_events/generic_positive_events.dm

spelling errors missed.

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/hydroponics/grown/melon.dm

grammar matters kids

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/hydroponics/grown/melon.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update generic_positive_events.dm

* Update melon.dm

fuckin variable got changed

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-28 20:28:48 -03:00
oranges
9fb883f66d Revert "CentCom Galactic Ban DB (#52519)"
This reverts commit 0f5652bc0b.
2020-07-29 09:11:38 +12:00
ike709
0f5652bc0b CentCom Galactic Ban DB (#52519)
* CentCom Galactic Ban DB

* Sanitize and config

* Apparently TG has a http_request datum

* Tweaks

* An excellent suggestion

* Turns out BYOND is better at JSON parsing than I thought it was

* Fun fact: 4 out of 5 UIs don't bother to do this
2020-07-28 13:11:38 -04:00
Jared-Fogle
2b14436488 Add check timer sources debug command (#52417)
* Add check timer sources command

* Recognize linked list implementation
2020-07-28 12:36:53 +02:00
Rohesie
93a37dfe88 Reference tracking (#52403)
* ref tracking

* legacy

* legacy procs

* fixes

* tweaks

* clarity comments

* wth
2020-07-28 11:56:27 +02:00
ShizCalev
729a834e31 Merge pull request #52423 from nightred/clownops
Fixes for clown op reinforcements
2020-07-27 23:57:59 -04:00
ShizCalev
60c5be4a33 Update code/modules/antagonists/_common/antag_spawner.dm 2020-07-27 23:57:05 -04:00
NightRed
5f448fc24c Dead chat can only see AI law changes when dead (#52441)
* dead check on ai law change readout

* chat notice on deny
2020-07-27 23:18:20 -03:00
MrMelbert
71cf2330ea Fixes another borg runtime + middle click cycling for borgs (#52476)
* zoom

* aight then
2020-07-27 23:15:43 -03:00
Time-Green
f47dc74029 Renames instabitaluri to syntflesh (#52523)
* Renames instabitulari to synthflesh

* Recommits Jared Foggles correction
2020-07-28 00:05:21 +03:00
TemporalOroboros
5b99d66569 Replaces some zero-delay timers with INVOKE_ASYNC (#52434)
* INVOKE_ASYNC

Replaces a zero-delay timer with INVOKE_ASYNC

* More timers

Switches out some more zero-delay timers for `INVOKE_ASYNC`

* lib_codex_gigas

One last switch
2020-07-26 22:09:58 -04:00
skoglol
0b09f1e17e Fixes statues casting spells (#52511) 2020-07-26 22:08:00 -04:00
Jared-Fogle
dd393b27e9 Fix multiple message prefixes being allowed at a time. AKA, you can now start messages with ellipses again. (#52498) 2020-07-26 22:07:41 -04:00
ShizCalev
ea3c805d65 Fixes anchor varedited solar array assemblies having incorrect pixel offset (#52474) 2020-07-26 13:47:09 -04:00
ShizCalev
50d1430859 Supermatter slivers thrown by bombs / mass drivers will now consume a mob if hit by it. (#52473) 2020-07-26 13:46:28 -04:00
ShizCalev
f2a61be00a Fixes keybind up() not checking for can_use() (#52475) 2020-07-26 13:44:13 -04:00
NightRed
c0fae02933 Validate client when rolling guardian (#52472) 2020-07-26 13:43:34 -04:00
ShizCalev
dc16b06577 Smartfridges will now drop boards set to the type of fridge they were when deconstructed (#52497) 2020-07-26 13:42:39 -04:00
Jordan Brown
b3cf611b3c You can now ruin a perfectly good bag of chips by stepping on them (#52484)
* pop

* pop2

* src

* pop!
2020-07-26 13:40:35 -04:00
Ryll Ryll
9fc7865425 Adds unit tests for suffering Wounds (#52491)
* add wound tests

* comment

* clarify

* compromise
2020-07-26 13:38:56 -04:00
Kyle Spier-Swenson
e8ba2038a1 adds pipelining to cross-server comm messages (#52447)
* adds pipelining to cross-server comm messages

One server blocking at the network level should not delay the other servers getting their message.

* Update adminhelp.dm

oh fun.

* try 3?

* Fuck it, string proc refs!

* Update adminhelp.dm

* Update adminhelp.dm
2020-07-26 13:38:16 -04:00
skoglol
560067a64c Merge pull request #52481 from ShizCalev/singularity-pull
move_resist INFINITY items/mobs can no longer be pulled by the singularity
2020-07-26 17:30:47 +02:00
skoglol
fcbaa7b65d Merge pull request #52479 from Wayland-Smithy/runechat_pref_fix
Fixes the "See runechat emotes" pref doing nothing
2020-07-26 17:30:11 +02:00
skoglol
e7b13b4114 Merge pull request #52494 from ShizCalev/fixes-mmi-qdel-message
Fixes failure message being sent to player when an emagged borg is self destructed
2020-07-26 17:21:41 +02:00
skoglol
738f428b18 Merge pull request #52501 from AnturK/chem_mob_react_fix
Fixes mob react recipes blocking other recipes.
2020-07-26 17:19:41 +02:00