Commit Graph

7467 Commits

Author SHA1 Message Date
Tim
51b289d4c8 Change drop_all_held_items to work with cyborgs (#70682)
* Cyborgs now use the same drop_all_held_items that humans do instead of their own snowflake code.
* Fixes Cyborgs not dropping all their modules at the same time,

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
2022-10-26 05:53:02 -04:00
MrMelbert
7e31785057 Fixes some bespoke elements being passed non-static lists. (#70690)
Bespoke keys use references of lists in generation. Non-static lists will create a million instances of the element, not good.
2022-10-26 05:51:15 -04:00
MrMelbert
bfcfa1e3bb Refactors some signal misuse with the stationloving component (#70496)
* Refactors secluded locs

* Tweak

* Use traits instead of signals

* Review

* Type error
2022-10-25 15:00:26 -04:00
Thunder12345
963b9eaad1 People wearing kitty ears can have their tails pulled (#70759)
Extends tail pulling to people wearing kitty ears. If you pull on their fake tail it will tip off and give you a mood debuff for ripping someone's tail off.

Added a new sound cloth_rip.ogg, a shortened version of dimensional_rend.ogg with one ripping noise.
2022-10-25 11:08:17 -07:00
VexingRaven
d5290b5daa Underground mining site ruin no longer has a ceiling (#70710)
* mining_site_below no longer has a ceiling

* Better code docs
2022-10-24 18:34:12 -04:00
MrMelbert
f1952b8d28 Fixes runtime with the infective component on gibs (#70706)
* Fixes runtime with the infective component. streak_diseases is a lazylist and is sometimes not instantiated.

* Lazynull
2022-10-23 15:33:16 -04:00
Tastyfish
c2f124a3d2 Fixes monkey AI runtimes (#70696)
* Fixes monkey combat runtime

* better monkey subtree
2022-10-22 16:10:48 -04:00
MrMelbert
c8bd98098b Fixes minor fleshmend runtime from clearing scars (#70700)
All scars is a lazylist.
2022-10-22 16:07:02 -04:00
MrMelbert
704b81fcd8 Fixes cult dagger grant runtime. (#70703)
Fixes cult dagger grant runtime. Owner is not guaranteed to be non-null.
2022-10-22 16:06:46 -04:00
DannyBoy3642
960a245c7a Allows flasks to be stored in shoe pockets (#70680)
* Added flasks to pocket.dm shoes

Adds flasks to the valid item storage list for jackboots, clown shoes, and other similar shoes

* Added flasks to pockets.dm shoes

Adds flasks to the valid item list for storage inside jackboots, clown shoes, and similar shoes

Co-authored-by: AeronaDF <aeronadf@gmail.com>
2022-10-21 18:10:59 -04:00
Tastyfish
6e2a8fb593 Fixes autodoc for orbit_icon (#70695)
Fixes doc for orbit_icon
2022-10-21 18:04:27 -04:00
tralezab
fc8d84a3ae Splattercasting, an offensive, sanguine equivalent to Lichdom. (#70637)
A spell similar to lichdom, though with different conditions.

Dramatically reduces your cooldowns
Cooldown saved is converted into blood lost
You are now a vampire, drinking blood refills your bloodwell, and you're naturally slowly running out.
New school, Sanguine spells, which aren't affected by splattercasting and generally involve blood.
Species change allowed by @SuperNovaa41
2022-10-21 20:51:38 +01:00
Jeremiah
83c22210c3 Fixes prisoner icon on orbit ui (#70671)
fixes prisoner icon
2022-10-21 00:51:43 -04:00
wixoa
ecc1ee7dd8 Fix an error message in ReadLayerGroup() (#70666) 2022-10-20 19:02:32 -07:00
MrMelbert
f1215a12b4 Changing species now maintains Brain traumas, Cybernetic implants, Liver traits, organ damage, and Heretic Living Heart (#70530)
About The Pull Request

    Implements additional code in before_organ_replacement in additional places, to better maintain cohesion when species changes take place.
        Brain traumas will now carry over on species change
        Having synthetic / cybernetic organs will now carry over on species change
        Liver job traits will also carry over on species change
        Organ damage will, in most cases, carry over on species change (only if the new organ is identical to the old)
        The heretic's Living Heart will attempt to carry over to species change, if it's valid
            Some species will still not, as it will attempt to give heart -> liver or something and be invalid

    Heretic Living Heart is now a cooldown action. Still not really content with the current state of it, it could use some improvements.

Fixes #42308
Fixes #35539
Fixes #69574

Why It's Good For The Game

Removes a lot of exploits involving using forced species change to get rid of stuff like quirks / permanent brain traumas and similar.
2022-10-20 14:57:07 -07:00
Tim
6d12dc69ef Refactor /mob/living/carbon/alien/humanoid to be /mob/living/carbon/alien/adult (#70481) 2022-10-20 08:48:12 -07:00
Kylerace
940d96d5ad fixes _queue_verb() runtiming from /client/Click() thousands of times (#70647)
* fixes _queue_verb() runtiming from /client/Click() and adds info

* Update code/controllers/subsystem/verb_manager.dm

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-19 23:27:41 -04:00
Jeremiah
03f2f3e2b0 Orbit refactor + features part dos: Icons, health bars. (#70580)
* orbit refactor + features

* Via suggestion

Co-Authored-By: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-Authored-By: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>

* cleanup

* readds heatmap optional + bug fix

* fixes bugs

* naming conventions

* what

* indeed

* modular via suggestion

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>

* nice

* pai fix

* misc searching

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2022-10-19 22:23:13 -04:00
Tastyfish
2011c8586d Fixes directional light overlay leaking the lighting mask and not updating direction correctly (#70578)
Fixes light direction/overlays when changing holder of light overlay
2022-10-19 22:18:17 -04:00
LemonInTheDark
a625fc8038 Cleans up the fallout from plane cube (#70235)
* Cleans up the fallout from plane cube

Alright.
Makes cleaning bubbles respect planes
Adds support for updating overlays on move, fixing an issue with pointing at items
Adds better error messages for failing to provide args for mutable_appearance()
Fixes a bug where string overlays were not respecting insertion order

* Adds documentation for offset spokesman and offset_const

* Better stack trace

* Removes some redundant uses of cached MAs

At this scale, attempting to cache MAs like this has 0 impact on anything
And just makes things more messy then they need to be

* ensures fullscreen objects START offset, so things are always proper

* ensures chatmessages always have the right offset

* fixes compile

* whoops, the above lighting plane should actually be ABOVE the lighting plane

* fixes compile, also cleans up the fire overlay a tad

* Adds a unit test for plane masters that are shrunk by multiz being double shrunk

This is slightly hacky because of how I'm handing the plane master
group, but it's not THAT bad, and gives me some real good coverage

* Properly targets the seethrough plane at the game world plate. This fixes unit tests, and also just makes more sense

* whoops

* oh

* adds datum support for allocate(), cleans up a harddel from testing

* Makes camera chunks index at 1, and also makes them support non powers of two sizes, since that was unneeded

* fixes runtime in allocate
2022-10-20 09:00:02 +13:00
GoblinBackwards
5156834f16 Fixes mining modsuit storage breaking after recharging it with plasma (#70558)
* Adds QDELETED check to inserting items to storage
2022-10-19 16:05:12 +02:00
LemonInTheDark
cd3a778915 PKP Mind Virus: Glorfing Cigs edition (#69904)
* PKP Mind Virus: Glorfing Cigs edition

If you glorf while smoking you'll get the cig stuck in your throat, leaving you unable to breath, speak, or eat. Based off the sort of cig you have a random delay before you vomit up the cig. (Pipes last forever don't philoso-larp kids). Other players can help you by using the help action on you while you're hurt, which leads to something imitating the himelich manuver, a broken chest, and a vomited up blockage. Other forms of vomiting will work too, if that's even applicable.

Oh I fixed a bug in vomit code. Because paralyzing you forces you to the ground, thus changing your dir, paralyzing vomits always went down. This is cringe, easy fix tho.

Ah and I added some extra functionality to sound loops too. You can set them to pick and take from the provided list, then refilling it once it's empty. This keeps some variety while preventing the risk of repeat sounds

Oh and I added some new signals. Some misc ones, for force say and a different kind of help then the existing one, which I renamed. One for breathing, which I used to clean up leroxin. I was planning to hook this but didn't need to in the end.

One for vomiting too. and eating. Also added a way to update looping timer delays. Forgot about that, I also added variable delay for sound loops, because I thought it sounded better here.

Features audio courtesy of our very own san7890, and the quake jump sound.
2022-10-19 06:34:45 -04:00
John Willard
364cd38285 [MDB IGNORE] Makes only station areas, station areas. (#70182)
* Makes only station areas part of Statioj

* Makes only subtypes of /area/station be part of the station
* Removes Icemoon and Shuttles as a check for Anomaly placers as they aren't needed anymore, not being part of shuttles.
* Removes a ton of uses of NO_ALERTS where it is no longer needed.
2022-10-19 00:54:29 -07:00
Tim
e710af88f8 Fix item icons for action buttons to be center aligned (#70477) 2022-10-19 00:51:18 -07:00
ShizCalev
66ce1fffe2 Fixes negative value being passed to runechat fade animation timer (#70531) 2022-10-19 00:49:58 -07:00
Tim
09d88b31ee Wizard DLC - Tower of Babel (#69629)
About The Pull Request

This adds a new status effect called - Tower of Babel

Any carbon mob afflicted by the status effect will lose knowledge of every known language and gain a randomized one as a replacement. The affected mob will also be hit with a depressing moodlet that lasts for 15 seconds. Silicons are immune to all effects.

This effect is implemented in several ways:

    Tower of Babel wizard event (all crew on the station z level are affected. The wizard is not and gains mastery of every language to taunt their victims)
    Admin smite option
    Admin secret event (can be reversed)
    Staff of Babel (formerly the Staff of Sapping) will spawn during spawn magic wizard event
    Magicarp will randomly shoot bolts of babel
    Staff of Chaos will randomly shoot bolts of babel
    Overdosing on Mushroom Hallucinogen will temporarily and sporadically acquire the effect

The effect can be blocked or cured in several ways:

    Curators are given immunity
    Reading a book of babel (via lavaland loot) cures and gives immunity
    Reading a language book cures and gives immunity ONLY for that particular language

Note - The Tower of Babel does not allow tongueless, mute, or tongue tied people the ability to speak
2022-10-19 05:17:05 +00:00
san7890
4085e792ab End Of Creating Map Votes with One/Zero Options. (#70340)
Makes it so you can't call a map vote when there is less than two maps to choose from

Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-19 04:47:32 +00:00
san7890
2878345ebb Swaps sleep() to use SECONDS define, changes some sleep(1) to sleep(1 TICKS) (#70452) 2022-10-18 21:25:23 -07:00
MrMelbert
dc8fcf82c9 Silver slime extract created food isn't toxic to jellypeople (#70424) 2022-10-18 21:21:50 -07:00
Dani Glore
f416a517c8 Fix: Blood Deficiency removing more blood than intended (#70563) 2022-10-18 13:56:48 -07:00
Kylerace
53c93c9025 Quickie runechat op (#69137)
reintroduces the intermittent queuing behavior found in #65791 since i can actually recover that part. now after MeasureText() puts us in the player input portion of the tick it will queue a callback for the next tick to resume chat message creation

generate_image() is a highly overtiming proc, now its less so
2022-10-18 02:12:31 +00:00
MrMelbert
629379f524 Fixes contextual bare hand element improperly setting up its element ID (#70538)
Fixes contextual barehanded screentips being inaccurate if only LMB text is set
2022-10-16 21:57:33 -04:00
MrMelbert
b6824fd76c Fixes null thrower runtime with plant backfire element (#70540)
Fixes null thrower runtime
2022-10-16 07:39:33 -04:00
GoblinBackwards
813a20e9a7 Fixes runtime when exporting bounty cubes (#70535)
* Fixes runtime caused by trying to capitalize an object instead of its name, by making it now capitalize the name instead.
2022-10-16 07:29:16 -04:00
lizardqueenlexi
55aab3bc6b Fixed a couple of errors related to lizard tail DNA. (#70532) 2022-10-16 01:57:27 -05:00
san7890
a92438a6cb Checks Filters For Cross-Station Messages (#70273) 2022-10-15 00:19:55 -07:00
GoblinBackwards
99e4f9a59c Carries over carded AIs into crafted intellicards (#70402)
* AIs that are crafted into Intellitater/Lantern is now moved into the new intellicard.
* Allows intellitaters/lanters to be crafted with intellicards that have an AI inside of them.
2022-10-14 07:04:54 -04:00
itseasytosee
bcfd895c14 Functionality for custom human examine messages when possessed by an AI controller. Implements on humans with monkey AI (#70356)
The "They don't appear to be themselves" line on humans that have AI controllers is now controllable by the AI controller, and is only "They don't appear to be themselves" by default.
Monkeized human now have the line
2022-10-13 18:00:32 -07:00
tralezab
1ac2779ef8 Bileworm Health Patch: Evolutionary Leap, Vileworms, Proximity Spawning Rules, Better Loot (#70321)
* bileworm health patch

- bileworms start off easier
- vileworms are how they are now + a little tougher
- fixes bileworms breaking proximity spawn rules
- adds gold to bileworm loot

* ssticker

* diagonals readded to attacks\, map fix

* d-delete this

* Update evolutionary_leap.dm

* DONE
2022-10-12 22:48:41 +02:00
John Willard
41ca4962db Moves cleaning to an atom proc to afterattack signal (#70239)
* Hopefully fixes Cleaning

* Cleaning off window blood is now handled by the Window itself
* Cleanbots now have an advanced mop built into them, I am hoping in the future we can make cleanbots have their mops taken off, but I'm not good at spriting so it isn't a thing yet.
* Adds a pre_clean_callback to replace the should_clean arg (mostly)
* Removes the atom cleaning proc, replaces it with a signal for afterattack on a cleaning tool.

* Fixes and improvements

* adds a new define that allows pre_clean_callback to cancel cleaning entirely, used for mops to check for being wet or attacking buckets and such.
* Fixes cleanbots not properly working, removing their mop and just registering for a signal that bots send instead.
* Changes cleaner component to take proximity into account, that way we don't have to check it on each item's individual afterattacks, that way we don't have to call parent at the end either.
* Improves check_allowed_items a little bit because I hated how it was used for soap.

* Update cleaner.dm

* reviews
2022-10-12 11:22:04 +02:00
ShizCalev
c137b2f270 Fixes shields inhands (#70395)
Fixes #70377

Stobe shield has been broken for.... hell I don't even know how long lmao

cl ShizCalev
fix: Fixed some missing shield inhand icons.
fix: The strobe shield's inhand icon now plays the flashing animation when triggered again.
fix: The strobe shield will no longer blind the person holding it when it deflects a blow.
fix: The light from the strobe shield's flash no longer appears in your held inventory slot.
fix: Fixed the east facing left-handed strobe shield sprite being misaligned by two pixels.
/cl
2022-10-12 14:39:59 +13:00
MrMelbert
f32678fb13 Having very very low sanity will rarely cause hallucintions (#70311)
* Being insane now causes you hallucinations, and hallucination immune has been renamed to RDS immune, since it only works for the quirk.
2022-10-11 11:41:09 -04:00
MrMelbert
ced20c8e63 Converts silent to status effect + small cleanup of can_speak / can_speak_basic / IsVocal, and sign language (#69963)
* Gets rid of a lot of weird vocal checks
- unifies all vocal checks under can_speak and try_speak
- de-spaghettis a bit of sign language stuff
- introduce a silence status effect
2022-10-09 23:46:57 -04:00
Time-Green
6bfaadc6cf Removes inappropriate golden wheelchair usage (#70384) 2022-10-09 13:03:25 -07:00
itseasytosee
e0b706c36c Put clothing on people by clicking on them with clothing inhand + targeting correct area. (#69560)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-08 18:51:29 -07:00
ShizCalev
ec4f44f137 Fixes lighting overlays from an item sometimes showing up on inventory slots / backpack slots instead of from the mob holding them. (#70250)
Fixes lighting overlays sometimes showing in inventory slots / backpack slots instead of the mob holding them
2022-10-08 23:33:56 +02:00
MrMelbert
bc9ba63717 Adds a few (very) basic hallucinations, to keep people on their toes (#70251)
Spoiler alert!

    Adds a few extra "weird" fake body hallucinations.
        These just pop up a weird sprite somewhere in the view of the player.
        Another fun thing: Body hallucinations will appear to be floating if they spawn in nograv areas.
    Adds a "watcher" hallucination, a strange static figure that sticks on your screen until either a few minutes elapse. If you step out of view of it, then return, it will disappear.
    Adds a variant of the "fake death" hallucination which appears as if you were dusted.
    Adds two delusion - One that makes everyone appear to be ghosts, and one that makes everyone appear to be syndicates.
2022-10-07 20:18:21 -07:00
Twaticus
c7dde06668 [MDB Ignore]Hats DMI split (#70060)
Splits head dmi into separate files for both mob and obj icons. Kept similar to suit split categorization + some more. New files include beanie, bio, chaplain, costume, cowboy, default, hats(softcaps, fedoras, head caps, generic hats), helmet(helmets and other armored headgear/hoods), spacehelm, utility(hardhats, mostly work related hats), wizard.
Moves animal/pet head sitting icons to 1 folder, pets_head.dmi
Renames PAI head sitting icon file to pai_head.dmi
2022-10-06 21:37:06 -07:00
Yaroslav Nurkov
04ca99d7e9 NT Pay app. Money send on distance, transaction log! (#70108)
* base

* reasons

* GetToken proc, with a many remarks

* Add a way to change reason in transfer_money proc. Add a reasons.

* Reason to use the app. Commission. Standard application.

* Apply suggestions from code review - Tralezab

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>

* Tralezab & jlsnow301 advices. New format(everywhere)

* Nanotrasen

* Refactor TGUI(not me:( ). Fix useless capitalize

* Update code/modules/economy/account.dm

* Trans transforms in transaction

* coMmission. little autodoc mistalke. Translation != Transaction

* oops

* Merge Conflict

* ...

* back feats

* mistakes bye!

* ну да

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
2022-10-05 18:25:38 -04:00
ShizCalev
1a32f60cf4 [ready] adds unit test for missing inhand icons. fixes a bunch of missing inhand icons (#70037)
fix: Fixed a bunch of missing inhand icons.
fix: Fixed cables in electrical toolboxes not randomizing their colors.
fix: Fixed the wrong colored icon showing when trying to make cable cuffs out of cables.
fix: The collectable SWAT helmet is now using the proper icon again!
refactor: Pipecleaners and power cables now share a unified color system, so they're once again available in ALL the same colors.
imageadd: Updated the screwdriver belt overlay to represent the newer sprite.
imageadd: Added a bunch of new inhand icons. Special thanks to Twaticus for doing the helmets! <3
fix: Wirecutters now have an icon when inside a belt again!
admin: Added a new omnitool subtype that allows you to spawn all items in a typepath!
fix: Explorer gaskmasks now properly reflect their adjusted state when held.
fix: Fixed balaclavas having the wrong icon when pulled up.
fix: Fixed the base energy sword (admin spawn only) being invisible.
fix: The rainbow energy sword is now a little bit more rainbowy!
fix: Fixed an tk exploit with orange handcuffed shoes.
fix: The traitor outfit in the select equipment panel is now actually functional!
2022-10-04 10:20:24 -07:00