* Fixes the issues with the ban video by moving the link to ban appeals to after the video. (#62675)
About The Pull Request
See title.
Fixes#62672
Why It's Good For The Game
Allows us to keep the excellent ban video while nullifying the issue raised in #62672
Changelog
cl
admin: The banning video is now shown before the ban appeals link, instead of after, to improve visibility of the ban appeals link.
/cl
* Fixes the issues with the ban video by moving the link to ban appeals to after the video.
Co-authored-by: Iamgoofball <iamgoofball@gmail.com>
* anonymous names fixes (#62497)
the "Stations?" theme now properly describes what its extra does
fixes runtimes with anonymous names! i'll point em out
* anonymous names fixes
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* tgui: Color matrix editor (#62413)
* adds the color matrix editor
* weakrefs and add_atom_color
* a little ui polish
* Adds the color matrix editor
Co-authored-by: Y0SH1M4S73R <legoboyo@earthlink.net>
* Fix long ban reasons breaking rolebans (#62408)
Fixes long ban reasons breaking rolebans by adding a max length to the ban reason and making sure that the roleban_delimiter is present on a roleban.
* Fix long ban reasons breaking rolebans
Co-authored-by: adamsong <adamsong@users.noreply.github.com>
* removes double spaces before symbols (#62397)
This can apparently cause some bugs on occasions, so I thought I might as well try to kill them all.
* removes double spaces before symbols
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Adds an improved ban UX for the end user also quads ->> (#62222)
Now a short autoplaying video is included, that will explain to the user why they are no longer able to access tgstation resources.
It may be suitable to host the video on tgstation's cdn instead
* Delete made_you_look.md
* Update Dockerfile
Co-authored-by: oranges <email@oranges.net.nz>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
* [s] Hotfix notes not belonging to players being shown to players
* [s] Hotfix notes not belonging to players being shown to players (#62352)
See title.
Other players will no longer see other player's notes when they connect to the server.
Memos will still be shown to admins.
Things that I have tested in the making of this PR:
Notes of a player not being shown to other players definitely work
Notes of a player being shown to a player definitely work.
Memos are still shown to admins.
Closes#62348
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
* adds silent var to sdql spells (#62217)
Adds a suppress_message_admins var to SDQL spells, which makes the query not appear in chat, while still writing it to the game log.
* SDQL spells can have their admin messages suppressed (+a small ui fix)
Co-authored-by: Y0SH1M4S73R <legoboyo@earthlink.net>
* yes this took me 3 minutes
* day one 50 gig patch
* move dis down to living level for muh events
* Update spawn_nest.dm
* Update simple_animal.dm
* Update simple_animal.dm
* more indepths spawners
* e
* woof
* Update spawn_nest.dm
* The monkey portrait decoration is now a set of random pictures that also act as persistent photo frames. Every station map gets one.
* mirrors changes
* Update mothership_astrum.dmm
* Update BlueShift.dmm
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Co-authored-by: Kat <evesovereign@hotmail.co.uk>
* toggle random events on/off no longer sends unspanned feedback to user (#61982)
The verb already messages admins and pressing the verb requires you to be an admin. to_chat entirely unneeded!
* toggle random events on/off no longer sends unspanned feedback to user
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* Adds SHOULD_NOT_SLEEP to Destroy. Why didn't we do this before. (#61943)
* Adds SHOULD_NOT_SLEEP to Destroy. Why didn't we do this before.
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* [s] Cleanup escalation unsafe procs (#61905)
Fixes admins spawning in atoms and datums without the DF_VAR_EDITED flag
* [s] Cleanup escalation unsafe procs
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Removes a useless but very hilarious define and really I just want to show the rest of you that this used to be here (#61866)
Removes SDQL_qdel_datum and please just click files changed okay
* Removes a useless but very hilarious define and really I just want to show the rest of you that this used to be here
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Use ckeys instead of keys in key name helper proc and new_player login. (#61857)
* Use ckeys instead of keys in key name helper proc and new_player login.
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
* renames enable debug verbs to enable mapping verbs (#61725)
its such a stupid fucking name, the verbs are all mapping related, they are all in the mapping tab, nobody knows about them because its called debug verbs for some reason instead of mapping verbs
* renames enable debug verbs to enable mapping verbs
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
* Fixes check AI laws collapsing, making them unreadable (#61724)
Previously, this would be putting (x2) next to the first 3 laws, and it would look like the 2nd cyborg had no laws.
* Fixes check AI laws collapsing, making them unreadable
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Adds pinging to asay (#61712)
I spend a lot of my time adminning the servers alt tabbed when not much is going on, tabbing back in every 5-10 minutes to see what's happening or when I hear a bwoink. Sometimes I miss out on other admins asking me questions or trying to get my attention, and I'll only realize way later when I'm scrolling back up through the chat logs, if at all.
This PR adds the ability to @ other admins in asay by their ckey, which underlines the pinged name, plays a bloop sound (the one when a vote starts) and flashes their window icon if they're not tabbed in.
* Adds pinging to asay
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
* change job slot logging to use job_debug (#61688)
admin topics for updating available jobs weren't logged at all and that was kinda dumb
john willard logged the console to game which i disagree with so i want to move that also
* change job slot logging to use job_debug
Co-authored-by: windarkata <27014495+remove32@users.noreply.github.com>
* Changes a bunch of New()s to Initialize()s (#61626)
* Changes a bunch of New()s to Initialize()s
Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
* Change the word filter configuration to allow providing reasons, fix emotes not working in filters, and implement separate OOC/IC/PDA filters (#61606)
* Change the word filter configuration to allow providing reasons, fix emotes not working in filters, and implement separate OOC/IC/PDA filters
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Fully Immersing someone now reminds them to roleplay correctly (#61657)
Please roleplay correctly!
* Fully Immersing someone now reminds them to roleplay correctly
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* [TM Candidate] Overhauls orbit and POI code to fix part of issue #61508 where players could observe /mob/living/new_player on the lobby.
* E
* Missed merge
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* [s] Fixed admins being able to bypass proccall protections via remote sdql and circuits. (#61482)
About The Pull Request
Admins can bypass IsAdminAdvancedProcCall checks by using these methods of proccall because proccall protection is kinda dumb. This has been tweaked so that there is proper proccall protection for these methods of proccall.
Code is hacky, but there's not much of a choice if we want procs to be properly protected from admin proccalls from any sort of remote source. If anyone has a better idea on how to implement this, feel free to hit me up.
We need a special global mob that handles proccalls from sources that may not have a usr/client to refer back to. IsAdminAdvancedProcCall() relies usr being defined, so if no usr is defined, then this will always return false. This has been adjusted so that proccalls without a usr/client to refer back to will instead set usr to this special mob, which will then let the IsAdminAdvancedProcCall() return true by comparing whether usr == this special global mob.
Why It's Good For The Game
Admins can no longer bypass IsAdminAdvancedProcCall checks.
Changelog
cl
admin: Admins are no longer able to bypass proccall protections using remote methods of proccalling.
/cl
* [s] Fixed admins being able to bypass proccall protections via remote sdql and circuits.
Co-authored-by: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
* tgui Preferences Menu + total rewrite of the preferences backend
* nah, we dont need to ping those people
* trying to remove the funny stuff
* unmodularizing this
* prefs reset
* this may need to be reverted, who knows
* okay, this part
* perhaps
* EEEEEEEEE
* unsanitary
* E
* Stage 1 + loadout system
* more fixes
* E
* I mean, it launches?
* More fixes and reorganisation
* E
* customisation code is spaget.
* disable ERP prefs
* Update erp_preferences.dm
* Update erp_preferences.dm
* E
* Slowly getting there
* It may be time for help :)
* tri...colors... help
* preferences now pass preferences
* Update dna.dm
* Fuck this man
* missing savefile return, set_species works, removed dumb stuff from updateappearance
* https://github.com/Skyrat-SS13/Skyrat-tg/pull/8199
* https://github.com/Skyrat-SS13/Skyrat-tg/pull/8224
* https://github.com/tgstation/tgstation/pull/61519
* https://github.com/Skyrat-SS13/Skyrat-tg/pull/8278
* e
* le butonAZARAK HELLO
* hhh
* Proper recognition where it's due, MrMelbert!
* EEEE
* examine block
* Better gen hit sounds from whitedream
* final loadout touches, more bug fixes im sure to come
* i said there would be bugfixes
* Update LoadoutManager.js
* Missing preferences in the html menu
* LIVE TESTING PHASE BABY
* Update LoadoutManager.js
* EEE
* LAUNCH TEST FIRE
* Update job.dm
* Update new_player.dm
* 50gb DAY ONE PATCH
* EEE
* Update preferences.dm
* buggle fixes
* Update examine.dm
* >LOOC starts on
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
Co-authored-by: Azarak <azarak10@gmail.com>
