Lawyers and Captains spawn by-default with the ability to send mass PDA messages, but the Wirecarp app (so Research Director and Captain) can grant/revoke permission to send PDAs to everyone
About The Pull Request
There's nothing inherently wrong with crossing the tramstation tram track, except it's impossible to guess where it is or if it's approaching you since it's silent. So I added little signal lights.
Green means it's not approaching you or it's so far away it doesn't matter.
Amber means you can safely cross but should do with some vague degree of urgency.
Red means NT isn't liable for what happens if you cross.
More specifically:
If the train's stopped (usually switches to this state when the tram controls unlock):
If the signals are at the same station that the tram is at: they are red, as the tram could start moving at any moment.
Otherwise, they are green.
If the train is moving:
If the tram is moving away from the signal, it is green.
If the tram is moving towards the signal, it is green, amber, or red as per the description at the beginning.
Why It's Good For The Game
So people don't have to guess and get hit by a train on their way to work.
cl
add: Tramstation now has crossing signals to help you not get hit by the tram (or jump in front of it at the last minute for comedy value).
/cl
- Removes friedegg recipie
- Adds a new rawegg grillable into friedegg, obtained by breaking an egg onto a griddle (right-click).
- Changes the double-egg friedeggs sprite to a single-egg. No more eggmancy!
- While we're at it, replaces the raw egg in the fried-egg-and-sausage recipe with a fried egg.
* organizing flora file and icon states, & flags
Changes the typepath for a lot of flora, and adds new paths depending on the amount of icon states the flora had, for better modularization on mappers. Also adds flags to the flora depending on what type it was, instead of 3 bools
* Getting ready to attempt to modularize flora
Moving most vars and procs from ash flora into the normal flora type path, as a general preparation to add more here
* Weighted products & Region Messages
Rewrites flora code so a flora's produced items can be initialized with a weighted list. Also has some improvements, relating to item stacks.
Adds an option via variables to separate 3 messages into 3 possible regions, or the old method where the message changes when the value is exactly the same as the low or high harvest value
* organizing + documentation on procs
* Documentation, Organization & Modularization
(DOMing) yeah, I dom
Gives variables for tools that can harvest flora, a blacklist of them, and modularizes variables a bit.
Retypes the stump to be a subtype of a tree, which just deletes after being harvested
* Adds the ability to uproot flora with a shovel
* added eswords to the list of things that can cut
* ausbush junk
* code review appreciation + changing drag_slowdown
* more code review appreciation
* kirbyplants ComponentInitialize() -> Initialize()
* forgot glob.
Hey there,
That little portion that says (debug verbs required) is not helpful at all to anyone who isn't already familiar with the aforementioned debug verbs. It's a pretty buried feature in the codebase as of this PR, so I think it's best to add some more verbosity on actually getting these debug verbs enabled.
Escaping newlines seems to work with logging without any noted downsides, helps readability if it's not all smashed on that one line.
About The Pull Request
This was doing things component really shouldn't be doing, and now all
of its behaviour is contained onto a datum, as it should've been the
whole time
Why It's Good For The CODEBASE
some things just really shouldn't be components, this was made back when DCS was first implemented and just thrown in because it was the new hot thing i guess, but datumized forensics makes far more sense, AND doesn't use GetComponent
TODO:
More thorough testing to make sure nothing broke
Changelog
🆑
refactor: Turned the forensics component into a datum.
/🆑
refactors the status panel to utilize the tgui/byond communication APIs instead of passing along href data, as well as converts the entirety of it into a datum/tgui_window
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Gives miners the ability to access their department (like the cargo bay) as normal. This is a quick fix to make sure that miners can do their jobs while we wait for the refactor currently in the works to go through. After that is in I will be able to properly manage the accesses and compartmentalize as necessary.
* Makes ridable not work if you cant hold the offhand
Because amount_equipped is 0, and because not being able to insert the riding_offhand only break's, rather than returns FALSE to cancel, it goes on to fireman carry you're not supposed to be able to carry, leading to situations where people are fireman carrying others and is completely unable to drop them.
* adds a block buckle to slime's traits too
About The Pull Request
Rewrites the descriptions for Boritos flavours
Also makes them taste better too like the code comment implied
Why It's Good For The Game
All the descriptions were bland, like plain Boritos
Changelog
cl
spellcheck: Boritos flavours have more flavour!
/cl
This was causing issues with indexing icon slots (the main user of TOBITSHIFT). See BeeStation/BeeStation-Hornet#6842 for more details.
Probably fixes#66197 and fixes#65652. (In all my tests, I could never get anything to show in suit_storage, whereas those bugs are reporting intermittent issues.)
Originally made for BeeStation/BeeStation-Hornet#6842 (which also affects TG).
Removes CPU, Sensors and Identify parts from modulra computers.
This is in effort to simplify how tablets and tablet apps are, while removing barriers to download specific apps. Limiting apps needed for your job, through hardware, is a terrible idea, and just limits departmental stuff to being there roundstart/latejoin, punishing people who job change through the in-game HoP system, devaluing the job as a whole.
* Advanced tools are medium sized now.
* Moves `w_class` 1 line down
* Moves `w_class` MORE DOWN
* Syndie Jaw pocket edition.
* Toolboxes can carry medium items, pocket syndie jaw in desc.
Allows configs to once again change job positions of jobs, and additionally allows them to completely disable some jobs. In the past, Pubby didn't have Lawyers and Curators, I doubt this would be the case in the future, but I find having this as an option for config is still good.
I also properly logged jobs not loading due to removal from mapping config, to be in job debug instead of testing.
Finally, I removed the old config_job, and made all configs use title instead. It was suggested I use typepath instead of title, but I am against doing it for the time being, as I don't expect Mappers to look for typepaths if all they want to do is make mapping stuff, though arguments can be made against that (like how its case sensitive so it's easy to break).
Due to mini-fridges being in the pool for spawning instead of crates/lockers, if there's too many things meant to spawn in said fridge, unit tests will fail because it cannot hold it.
To fix this, I simply added more storage capacity.
Right now there is only 1 source of cloning: pod cloning-- and pod cloning is exceedingly rare. I don't think this warrants its own file anymore with the death of regular cloning a few years back.
Okay, why removing instead of giving it a sprite?
Simply put, those items are all small and there is no reason that you need to quick draw a suture/ointment and if you do, the medical belt can carry 7.
Allowed/exoslot items should be either medium/big/bulky sized items (Syringe gun) to make it worth inventory wise or items that you can quickdraw multiple times (Health Analyzer) to make your life easier.
Medical stacks are neither and would just get in the way if you try to quickly put them into a bag/pocket/belt and instead it goes into your exoslot where you would normally want to carry more valuable things like the syringe gun.
This doesn't feel big enough for a fix, spending 5 seconds making a list alphabetical doesn't few worth of code improvement, I will label this as QoL and if someone say it is a balance change I will follow you in game and keep placing shitty small items in your inventory via reverse pickpocketing.
Makes Cultists get their objectives from their team BEFORE their parent's on_gain runs, giving and triggering their antag UI. This means players no longer have to close and reopen the page to see their actual objectives.
Hey there,
On IceBox, sometimes, ruins could spawn below chasms that we had, or below a ruin that spawned in more openspace chasms. This would cause numerous Active Turfs on initialization, and I've seen the number go up to 150 active turfs. This change should reduce the number by a good margin.
I decided to make the ceiling mineral-rich snow to ensure it had that "buried" appearance, and would hopefully look nice to have that odd chance for a underground ice ruin create a natural bridge that just needs to be excavated.
Lathes and designs now use departmental flags rather than some random misc define that wasn't used anywhere else (which this PR is deleting), this allows us to cross-reference it with job bitflags to check whether or not a job should pay lathe taxes. Nothing else is effected by this change. Important changes are in code/modules/research/machinery/_production.dm if you want to get straight to the point.
