* North Star: Virologists Disposals Route To Space + Spawner Removal (#76138)
* North Star: Virologists Disposals Route To Space + Spawner Removal
---------
Co-authored-by: Cheshify <73589390+Cheshify@users.noreply.github.com>
* Modular machinery computer UI opens again (#76187)
**Problem Reproduction**
1. Find/Make any instance of `/obj/machinery/modular_computer`
2. Try opening its UI
3. Doesn't work
**The Solution**
Assign the processor's `physical` var with the computer that it's inside
in.
* Modular machinery computer UI opens again
---------
Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>
* Hairless hides are created from the entire stack of hides instead of only one item from stack (#75974)
Tanning is barely used because biogens are available everywhere and are
a default source of leather.
This PR makes one of the steps - hairless hide creation - easier, as
before to process 5 hides you had to either click on the stack 5 times
in sequence, or manually separate 1 hide from the stack, throw around
you avoiding their merging, click on each of them and then merge them
back.
Maybe people will use this way of leather creation more often.
* Hairless hides are created from the entire stack of hides instead of only one item from stack
---------
Co-authored-by: Andrew <mt.forspam@gmail.com>
* [MDB IGNORE] Subtypes out kirbyplants, also changes them to said subtypes (#76050)
* [MDB IGNORE] Subtypes out kirbyplants, also changes them to said subtypes
* woow
---------
Co-authored-by: Jolly <70232195+Jolly-66@users.noreply.github.com>
* Lighting object oddities (#76009)
## About The Pull Request
Fire stacks status effect no longer uses a weakref for the mob light, I
am pretty sure there was no real reason to use a weakref there.
Deleted weird luminescent glow dummy, now it just uses the standard
moblight obj.
Put all /obj/effect/dummy/lighting_obj together in a single file and
added a comment explaining why they exist.
(I severely dislike the /obj/effect/dummy typepath, but I am very much
unsure if just replacing all of them with /obj/effect/abstract would
break shit)
## Why It's Good For The Game
Code organization good
* Lighting object oddities
* Update kindle.dm
---------
Co-authored-by: ChungusGamer666 <82850673+ChungusGamer666@users.noreply.github.com>
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
* Standardize Welder Fuel Usage (#76021)
Remove welder fuel usage from all actions except attacking and leaving
it on
most welder tasks require a minimum of 1u of fuel, some longer tasks
require a minimum of 2 or 3u welders now drain 1u every 5 seconds
they're active
## About The Pull Request
Prior to this PR welder fuel usage was random, a lot of tasks didn't use
any welder fuel and welders were basically near infinite so long as you
didn't use them for combat, it took 26 seconds of activity to drain 1u
of fuel, that means an emergency welder alone could run for 5 minutes
straight before needing a refuel
After this PR all welders will drain 1u every 5 seconds instead of every
26 seconds, but welding objects won't require extra fuel anymore, making
the fuel usage much more consistent.
resolves#55018
## Why It's Good For The Game
Actually makes fuel tanks useful and relevant without making it
obnoxious to do repetitive quick tasks like turn rods into plates,
there's actually a reason to upgrade off the emergency welder now since
it lasts 50 seconds rather than 5 minutes
## Changelog
🆑
qol: Welders now have a more consistent fuel usage
/🆑
* Standardize Welder Fuel Usage
---------
Co-authored-by: Couls <coul422@gmail.com>
* Adds the current server name from the config to the world status (#76014)
## About The Pull Request
Adds the server name from the configuration to the world's status topic.
## Why It's Good For The Game
We don't currently expose the server's short name (e.g. `Sybil`,
`Manuel`) anywhere. This fixes that. This is mostly to support external
tools.
* Adds the current server name from the config to the world status
---------
Co-authored-by: Nick <nick@nfreader.net>
* Fix further/MetaStation (#76158)
## About The Pull Request
Typo fixes. Further and fixes MetaStation's default name to match the
JSON.
## Changelog
🆑 LT3
spellcheck: Fixed a few typos
/🆑
* Fix further/MetaStation
---------
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
* Tablet apps are now deleted when necessary & removes console preset. (#75863)
## About The Pull Request
Apps now properly delete themselves when removed, so they don't exist in
nullspace anymore.
Chat client now actually updates the uid, because its New() didn't call
parent.
Deletes the 'console' subtype of modular computer
Updates how downloading and transferring files are handled
Fixes being able to infinitely upload apps to a disk
## Why It's Good For The Game
Fixes some more bugs I found with apps and prevents spamming apps in a
disk.
## Changelog
🆑
fix: Maintenance data disks now properly transfer from PC to disk
fix: Disks can no longer be flooded with the same app repeatedly.
/🆑
* Tablet apps are now deleted when necessary & removes console preset.
* updatepaths
* feex
---------
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: Jolly-66 <70232195+Jolly-66@users.noreply.github.com>
* replaces the weirdly placed engine in the greytide ship with a heater (#76141)
* replaces the weirdly placed engine in the greytide ship with a heater
---------
Co-authored-by: Addust <80979251+Addust@users.noreply.github.com>
* Adds some nodiagonal walls to the Infiltrator docking port (#76139)
* Adds some nodiagonal walls to the Infiltrator docking port
---------
Co-authored-by: Rhials <28870487+Rhials@users.noreply.github.com>
* The Goods
- Adds some vinegar to the Ghost Cafe's kitchen (moths rejoice)
- Updates ovens to ranges in Icebox Interdyne, DS-2, and DS-2 Brig
* shuffling + Regular Interdyne
* Adds some welding fizz to the Cafe
For the beepers :D
* Robust Photocopiers + Adds the Access Request blank (#76048)
## About The Pull Request
Currently, photocopiers parse the `blanks.json` file in `ui_data` and
send the entire thing to the client. Then, the client sends the entire
blank back to the server to commit it into the paper, in raw form. This
is a detriment to server performance. This PR puts paper blanks into a
global associative list that uses the `code` field as an index.
Printer toner color for some reason would check if the charges were
below 10, even though default cartridges only go up to 5. The value has
been changed to 2, which is still a high number. Toner cartridges are
scams.
Also photocopiers now have to hold actual paper and no longer
materialize it out of thin air. It's done similarly to paper bins, where
there is a starting integer value dictating how much paper is inside so
paper is lazily loaded into existence, as well as a paper stack list
that holds newly inserted paper. Photocopier paper starts out at 30 and
can go up to 60.
Additionally, the photocopier copying loop has been refactored to be a
lot more sane. The previous version ~~ab~~used timers for copying,
making a timer for each i interval to num_copies. I changed it to be a
proc that loops from i to num_copies, sleeping for a short amount of
time whilst playing a sound. This is a lot tidier and nicer since we
don't deal with timers, plus we get to play a printing sound too.
`make_thing_copy` now works by returning the copied object, or null if
something went wrong, so we know when to continue or exit.
This PR refactors UI code so entire blanks aren't sent to the client,
instead relying on the IDs for the blanks. Also, photocopiers now store
actual paper and also run out of it instead of materializing some out of
thin air.
Also, while I am already editing `blanks.json`, I added the Access
Request blank because people asked me to.
I can revert the config changes if it's too much of a hassle.
<details>
<summary>Screenshots/Me testing a printer for 5 minutes</summary>
https://github.com/tgstation/tgstation/assets/47710522/11c4b63b-7cfc-4425-96c6-970d4a5f51cahttps://github.com/tgstation/tgstation/assets/47710522/2f7a4a15-3400-49f3-9aca-c4d04c886bechttps://github.com/tgstation/tgstation/assets/47710522/14afe7d9-53ea-4d17-870f-1e90319284eb
</details>
<details>
<summary>Access Request form</summary>
</details>
## Why It's Good For The Game
Speeb. Also having photocopiers relying on an ingame stock of paper is
also very cool.
## Changelog
🆑 distributivgesetz
add: Photocopiers now use actual paper instead of materializing it out
of thin air.
add: Adds the "Access Request" form.
refactor: Greatly improve the reliability and performance of
photocopiers.
qol: Changed the blanks so they look nicer, whilst also fixing the
lawsuit request form.
qol: Nanotrasen's bureaucracy division has ""improved"" the quality of
their printer toner after many complaints from furious customers.
/🆑
* Robust Photocopiers + Adds the Access Request blank
---------
Co-authored-by: distributivgesetz <distributivgesetz93@gmail.com>
* Makes abductor organ surgery consistent with other surgeries (#76124)
## About The Pull Request
Just swaps the Hemo and Retractor steps to make it more in line with
other surgeries
## Why It's Good For The Game
This might just be me but I always forget that the order is different
and it throws off my muscle memory
## Changelog
🆑
qol: Abductor organ surgery steps shifted around to match other
surgeries
/🆑
* Makes abductor organ surgery consistent with other surgeries
---------
Co-authored-by: DaydreamIQ <62606051+DaydreamIQ@users.noreply.github.com>
