Commit Graph

32062 Commits

Author SHA1 Message Date
Jared-Fogle
7df16c595e Confusion will no longer continue to confuse after being cured (#52286)
* Confusion will no longer continue to confuse after being cured

* Grammar comment fix

* Move to status effect

* Remove test per request

* Make confusion a status effect, confusion curing now completely neuters the confusion

* set_confusion changes, get_confusion

* Fix confusion going down twice per tick

* Change strength = to proc

* Move procs to status_procs
2020-08-05 16:36:00 -03:00
Timberpoes
8fc671f942 Implements job skillchip framework as per hackmd.io design document (#52630)
* Shift wire revealing logic to dedicated proc

* Bit of code modification. Framework for roundstart job skillchips.

* Implement roboticist skillchip trait functionality.

* Feex moth feet messup

* Add skill chips to robodrobe inventory

* Code refactor. Add missing skill_stations to Pubby and Delta.

* Implement special flags, changelings inherit skillchip skills

* Additional code refactor. Traitor chameleon skillchip framework.

* Implement traitor skillchip, fix up more code, move job chips to outfit datums

* Modify autosurgeon, create skillchip variant, add to uplink

* Implement chip cooldowns. Add new skillchip for station engineers. Cleanup some code. Add job chips to lockers.

* Feex

* Feex

* Code review implementation

* More feexes, improved chameleon chip code and more.

* Code review and minor refactor

* Additional review fixes, rebuild tgui

* Minor logic fixes

* Final Rohesie review

* Robust code changes, improved slot/complexity system.

* Rebuild tgui

* Code review

* Brain regeneration failsafe

* Lazylist cut fix
2020-08-05 21:21:29 +02:00
ATH1909
4bd605140c redundant (#52682) 2020-08-05 13:30:02 -04:00
Fikou
d9f1310475 removes parent_type on map preloaders (#52703) 2020-08-05 01:45:42 -04:00
NightRed
83d28072c7 issues with ears notify only once (#52599) 2020-08-05 01:41:50 -04:00
Fikou
8b73856f79 makes subtypes of radios blacklisted for black market crafting (#52696) 2020-08-04 23:51:07 -04:00
Timberpoes
50f738ab2c Add a space to stop my eternal triggering (#52697) 2020-08-04 23:50:54 -04:00
ShizCalev
65bde07627 electrified airlock fixes (#52699)
* Airlock zap fixes

* cleanup

* jaws of life

* removed redundant just_zap var, handled by cooldown checks.

* comments

* cleanup healper
2020-08-04 23:50:28 -04:00
Fikou
f12eefd1bd fixes the cat crate cat (#52701) 2020-08-04 23:49:52 -04:00
Fikou
bc574c7564 removes mentions of firefighter in exosuit categories (#52700)
* removes mentions of firefighter in exosuit categories

* Update mecha_construction_paths.dm
2020-08-04 23:49:00 -04:00
Kyle Spier-Swenson
59e666078f Robust savefile versioning (#52549)
tl;dr: savefiles now update all character slots when the version is bumped, and saves the updated savefile to disk. It also backups the pre-update version.  Later on we can look at just using this backed up version if the server's savefile version goes down, indicating a revert.
2020-08-04 19:34:11 +02:00
Rohesie
32ae206794 Fixes seeing audible emotes on runechat while deaf (#52584)
* deaf folk

* no blind
2020-08-04 10:11:10 +02:00
Rohesie
6ff08e1c69 Color standardization, vars moved, and signals (#52574)
Defined all the existing light_color values.
    Moved their definitions to colors.dm
    Made white the default color. It was so already, but that was very obscured.
    Moved the atom light-related variables to the atom definition.
    Wrapped changes to variables such as light_color into procs that report the event through signals.
    Moved the light_on variable to the atom level, also adding a signal for its changing, to represent toggling lights.
    Cleaned up a little bit of code in where new variables were defined before redefinitions.

This is all atomization to reduce changes in #52413
None of this affect gameplay at all, it's all code cleaning and refactoring.

There's more colors to standardize, a search for color = will find lots of targets, and I see little need to have both the LIGHT_COLOR and COLOR patterns, but I don't want to make this PR bigger than it already is.
2020-08-04 13:59:48 +12:00
girl
cb148cc034 Adds shock immunity to rubberneck (#52162)
* Reee why did this not work before

* Update alcohol_reagents.dm
2020-08-03 13:58:47 -04:00
Krysonism
35602ec6d0 [READY]syriniver nerfix / syringe projectile fix + various fixes requested by maintainer (#52019)
* syringe projectile fix

* greenman review

* oversight fix
2020-08-03 13:57:56 -04:00
ShizCalev
cb694e8095 Fixes carbon wash runtime (#52643)
* Fixes carbon wash runtime

* Update code/modules/mob/living/carbon/carbon.dm

Co-authored-by: spookydonut <github@spooksoftware.com>

Co-authored-by: spookydonut <github@spooksoftware.com>
2020-08-04 01:32:00 +08:00
LemonInTheDark
3558dc1f1b Adds a coder override emote so manual custom emotes work properly (#52602)
* Adds a coder override emote to skip dumb shit with me

* I know this sucks, I can't comprehend how to do this cleanly without a full rewrite

* cleaner now
2020-08-03 05:05:07 -03:00
LemonInTheDark
092af76b5d Adds an atmos debugging tool and excited group visualizer (#52395)
* Adds an atmos debugging tool and excited group visualizer

* rebuild moment

* yarn install -> yarn run build

* Sigh

* Fixed UI, did not test, needs a rebuild.

* Proper flexing

* Adds varied colors, improved ui courtusy of stylemistake:

* Fixes a runtime, updates tgui

* added superconductors, cleaned up some shitcode, removed a clashing color

* Woop

* Speed

* rebuild

* Adds a tick count

* begone auto-update

* color defines

* rebuild moment

* color improvements, fixes updating

* adds another preprocesser define to handle showing max shares in the ui

* test of application system?

* patches up some display issues, allows for smooth flowing from one group to another

* overlay-ified

* client testing

* dmi moment

* plane master

* it fucking works

* size change

* passthrough

* rebuild moment

* adresses review concerns, toggles active turf vis on when testing

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-08-03 09:15:08 +02:00
ArcaneMusic
01296ab374 Makes several icon and outfit tweaks/fixes to bounty hunters. (#52668) 2020-08-03 03:57:09 -03:00
ShizCalev
e787d5dadb Improves malf ai overload logging slightly (#52656) 2020-08-03 03:46:40 -03:00
ShizCalev
2eb12fd169 Fixes pets breeding with their own children. (#52669)
* Fixes pets breeding with their own children.

* cached var
2020-08-03 03:46:17 -03:00
ShizCalev
04ff2e7eb5 Ballistic gun icon / overlay / ammo fixes. Adds support for suppressors to extend outside of a gun's 32x32 icon. (#52634)
* Ballistic gun fixes

* More fixes
2020-08-03 03:43:13 -03:00
Krysonism
3eb9f88e35 [READY]Replaces rust wave with entropic plume![REWORKED] (#52287)
* Icon + effect

* goofcone + my shitcode

* correct cone behaviour and visuals

* amok + polish

* Correct icon_state

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Fikou <piotrbryla@onet.pl>

* line endings

* more suggestions from review

* rework I

* Rework

* Readds missing sprites

* fix

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>

* more suggestions from review

* description fix

Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Fikou <piotrbryla@onet.pl>
2020-08-03 03:41:46 -03:00
girl
40bff016e8 Componentizes Surgery-Initiation Devices (#52295)
* meow

* doc moment

* meow
2020-08-03 01:38:32 -03:00
Jordan Brown
765b047152 Update TGS DMAPI to 5.2.3 (#52608) 2020-08-02 23:37:15 +08:00
Arkatos1
a673bf8fbe Drone radial menus (#52618) 2020-08-02 23:36:11 +08:00
tralezab
6471ea7f63 why (#52629) 2020-08-02 23:35:48 +08:00
Ryll Ryll
8567e46830 mmm mmmm moff (#52642) 2020-08-02 23:33:46 +08:00
ArcaneMusic
c1e8d58eb0 Plant crossbreeds can now upgrade reagent %s, seeds can now select if they can mutate early. (#52366)
* Plant Reagent Genes can upgrade themselves via crossbreed, var added to keep cabbage from creating an organ farm

* This will do.

* Nah, NOW it's fine.

* tiny documentation tweak.

* like every var in hydroponics is ONE LETTER ROH

* When did this change

* is this the power of bitflags

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>

* Alright, working as intended.

* Flips to positive defines because I'm a negative lad

* resolves conflict

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-08-01 23:43:37 -03:00
Time-Green
126b559e93 Makes laughter demons revives spawn at laughter demon location (#52622) 2020-08-01 13:53:32 -04:00
KathyRyals
be110228bb Fixes a runtime caused by an improperly affected variable. (#52628)
* Fixes a runtime caused by an improperly affected variable.

* Updated iscleanable()

* Update code/__DEFINES/is_helpers.dm

Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>

Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
2020-08-01 13:50:18 -04:00
Fikou
7c00af5fbb makes it so survival pod stasis beds dont become invisible when you screwdriver them (#52604)
* makes it so survival pod stasis beds dont become invisible when you screwdriver them

* oh you motherfucker
2020-08-01 07:24:20 -03:00
nemvar
bbb5fcdc08 Adds mafia achievement icons to the spritesheet (#52600) 2020-08-01 06:54:44 -03:00
Tlaltecuhtli
abb3049d35 fixes a bounty bug (#52591)
🆑
fix: trashbag bounty works
/🆑
2020-08-01 06:47:02 -03:00
ShizCalev
a873bf72e3 Fixes pill presses not checking for bottles (#52589) 2020-08-01 06:45:59 -03:00
ShizCalev
47e93df584 Cleans up paicard and aicard code (#52575)
* Cleans up paicard and aicard code

* fix

* more fixes
2020-08-01 06:44:21 -03:00
Jared-Fogle
f23dcd2067 Fix pulsing the power wire shocking you repeatedly unless you close tgui (#52541)
* Fixes #52538

* Allow those with insulated gloves to mess with airlocks still

* Fix not being able to interact with insulos

* Fix style qualms

* Add shock immune to should_electrocute
2020-07-30 23:15:12 -03:00
zxaber
215ef5c6f3 Replaces modular computer card eject verbs with UI buttons (#52489)
* Replaces mod-CPU card eject verbs with UI buttons

* ?
2020-07-31 04:18:35 +03:00
EdgeLordExe
ed5745ae44 [READY] HERETICS balancing: makes raw prophets more useful (#52028)
* e

* makes raw prophets more useful

* e

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* E

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* E

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* E

* Update code/modules/antagonists/eldritch_cult/eldritch_magic.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Update code/modules/mob/living/simple_animal/eldritch_demons.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Apply suggestions from code review

Co-authored-by: Rohesie <rohesie@gmail.com>

* E

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-30 14:52:00 -03:00
Gamer025
c93c479ff9 Adds useless skillchip adapter (#52577)
* Adds useless skillchip adaptor

* Redo code so that skill_station code doesn't need to be modifed

* Remove helper and return directly instead of setting return code

* Update code/modules/library/skill_learning/skillchip.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

* Change to bitflag system

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-30 14:49:21 -03:00
NightRed
9c6fbc5847 Meteor shield acts as expected when hacked (#52582)
* emag meteor shield

* removed extra check
2020-07-30 14:44:32 -03:00
Dennok
6625041e68 Fix multitile engine rotating. (#52424)
* Update shuttle_rotate.dm

* set bound

* setDir

* Move multitile border rotate shifting to base proc

* Move borders shifting to atom/movable/shuttleRotate()

* Better code

Co-authored-by: Rohesie <rohesie@gmail.com>

* Better better code

Co-authored-by: Rohesie <rohesie@gmail.com>

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-30 06:31:47 -03:00
Dennok
b4c275e2ce Try to replace light overlay to vis_contents (#52389)
* Try to replace light overlay to vis_contents

* move glowybit creation in Initialize

* ups

* change mutable_appearance to SSvis_overlays

* set right settings
2020-07-30 06:03:52 -03:00
Rohesie
ac64362c11 Admins can respawn (#52567)
* respawn

* changes

* spawn

* R_ADMIN
2020-07-30 02:25:02 -04:00
tralezab
5ca99fc0c3 Mafia Achievements (#52514)
* no brainer!

* hilarious indentation error

* thank you!!

Co-authored-by: trollbreeder <trollbreeder@users.noreply.github.com>

* fixes

* armhulen07/23/2020 someone mute me from this channel i'm going to give all of my organs to Bulgaria if i keep finding these dark truths

Co-authored-by: trollbreeder <trollbreeder@users.noreply.github.com>
2020-07-30 03:13:13 -03:00
ShizCalev
3eeef6c272 Cleans up some unused procs and makes is_blocked_turf a turf proc. (#52482)
* Cleans up some unused procs and makes is_blocked_turf a turf proc.

* Update code/game/turfs/turf.dm

Co-authored-by: Rohesie <rohesie@gmail.com>

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-07-30 02:20:35 -03:00
ShizCalev
f79df59305 Merge pull request #52565 from tgstation/revert-52519-centcom
Revert "CentCom Galactic Ban DB"
2020-07-30 01:10:22 -04:00
ShizCalev
8d5a502635 Merge pull request #52580 from Cyberboss/CleanBadVars
Remove instances of `var varname` in dm code
2020-07-30 01:05:37 -04:00
Fikou
14725daf58 repaths neurotoxin + embedding changes in bullets + adds effects when you shoot energy weapons (#52543)
* how

* Update alien_powers.dm

* adds impact effects, makes thinks that shouldnt embed not embed

* rogue pixel moment
2020-07-30 01:33:51 -03:00
Dennok
a190d33cdb Move cable radial menu to attack_self. Move recipe crafting to radial menu chose (#52540)
* Move cable radial menu to attack_self

Move recipe crafting to radial menu chose

* Remove loc check in attack_self
2020-07-30 01:21:11 -03:00