Commit Graph

69 Commits

Author SHA1 Message Date
SkyratBot
8e2fb2b105 [MIRROR] Adds SEAFOOD foodtype, felinid diet changes (#8343)
* Adds SEAFOOD foodtype, felinid diet changes (#61506)

* Adds SEAFOOD foodtype, felinid diet changes

* Update felinid.dm

Co-authored-by: JosephJomama <60072879+JosephJomama@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-09-24 18:24:33 +01:00
SkyratBot
e8d78089fc [MIRROR] [TM Candidate] Overhauls orbit and POI code to fix part of issue #61508 where players could observe /mob/living/new_player on the lobby. (#8339)
* [TM Candidate] Overhauls orbit and POI code to fix part of issue #61508 where players could observe /mob/living/new_player on the lobby.

* E

* Missed merge

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-09-24 18:16:17 +01:00
SkyratBot
124ddd7cca [MIRROR] tgui Preferences Menu + total rewrite of the preferences backend (#8153)
* tgui Preferences Menu + total rewrite of the preferences backend

* nah, we dont need to ping those people

* trying to remove the funny stuff

* unmodularizing this

* prefs reset

* this may need to be reverted, who knows

* okay, this part

* perhaps

* EEEEEEEEE

* unsanitary

* E

* Stage 1 + loadout system

* more fixes

* E

* I mean, it launches?

* More fixes and reorganisation

* E

* customisation code is spaget.

* disable ERP prefs

* Update erp_preferences.dm

* Update erp_preferences.dm

* E

* Slowly getting there

* It may be time for help :)

* tri...colors... help

* preferences now pass preferences

* Update dna.dm

* Fuck this man

* missing savefile return, set_species works, removed dumb stuff from updateappearance

* https://github.com/Skyrat-SS13/Skyrat-tg/pull/8199

* https://github.com/Skyrat-SS13/Skyrat-tg/pull/8224

* https://github.com/tgstation/tgstation/pull/61519

* https://github.com/Skyrat-SS13/Skyrat-tg/pull/8278

* e

* le butonAZARAK HELLO

* hhh

* Proper recognition where it's due, MrMelbert!

* EEEE

* examine block

* Better gen hit sounds from whitedream

* final loadout touches, more bug fixes im sure to come

* i said there would be bugfixes

* Update LoadoutManager.js

* Missing preferences in the html menu

* LIVE TESTING PHASE BABY

* Update LoadoutManager.js

* EEE

* LAUNCH TEST FIRE

* Update job.dm

* Update new_player.dm

* 50gb DAY ONE PATCH

* EEE

* Update preferences.dm

* buggle fixes

* Update examine.dm

* >LOOC starts on

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2021-09-23 00:40:37 +01:00
SkyratBot
f593849ce5 [MIRROR] makes get_hearers_in_view() faster AGAIN, fixes issue with previous optimization (#6979)
* makes get_hearers_in_view() faster AGAIN, fixes issue with previous optimization

* Mirror!

Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: Funce <funce.973@gmail.com>
2021-07-19 20:15:59 +12:00
SkyratBot
0842c757f9 [MIRROR] makes a bunch of lists that use typecacheof() static. doesnt find out why its overtiming at all but what the hell it helps (#6885)
* makes a bunch of lists that use typecacheof() static. doesnt find out why its overtiming at all but what the hell it helps (#60147)

Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* makes a bunch of lists that use typecacheof() static. doesnt find out why its overtiming at all but what the hell it helps

Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
2021-07-12 22:50:42 +01:00
SkyratBot
70f511a803 [MIRROR] Fix forensic component inheritance inserting null entries into lists and causing to_chat errors. (#6630)
* Fix forensic component inheritance inserting null entries into lists and causing to_chat errors. (#59873)

Fixing the following runtime:

[17:13:04] Runtime in to_chat.dm,88: Empty or null string in to_chat proc call.
  proc name: to chat (/proc/to_chat)
  usr: Cowboy_penis_monster/(Zackary Mason)
  usr.loc: (Telecomms Control Room (105,89,2))
  src: null
  call stack:
  to chat(Zackary Mason (/mob/living/carbon/human), "", null, "", 0, 1, 1, 0)
  the forensic scanner (/obj/item/detective_scanner): add log("", 1)
  the forensic scanner (/obj/item/detective_scanner): scan(Control Room (/obj/machinery/door/airlock/command/glass), Zackary Mason (/mob/living/carbon/human))

Forensic scanner attempting to add "" to the logs, which eventually gets output to_chat.

Tracked error down to forensic component lazylists and the fun of trying to OR two lazylists together.

* Fix forensic component inheritance inserting null entries into lists and causing to_chat errors.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2021-07-01 22:56:49 +01:00
SkyratBot
489d21a4aa [MIRROR] tgui strip panel + strippable element (#4423)
* tgui strip panel + strippable element (#57889)

Completely removes show_inv and replaces it with /datum/element/strippable. It takes a list of instantiated /datum/strippable_item which communicate which slots are available and how to interact with them. This element has been added to humans, alien humanoids, parrots, and corgis.

Co-authored-by: Aleksej Komarov <stylemistake@ gmail.com>

* tgui strip panel + strippable element

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Aleksej Komarov <stylemistake@ gmail.com>
2021-03-26 14:32:30 +00:00
SkyratBot
3b85cf1430 [MIRROR] Addiction rework (#3445)
* Addiction rework

* a

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-17 14:26:44 +00:00
SkyratBot
b332b46b65 [MIRROR] Remove hideous inline tab indentation, and bans it in contributing guidelines (#3394)
* Remove hideous inline tab indentation, and bans it in contributing guidelines

* a

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-15 15:32:02 +00:00
SkyratBot
c430e11d0b [MIRROR] Fixes tags on ordered pizza (#3344)
* Fixes tags on ordered pizza (#56369)

Box tags

    Fixes bug where box tags weren't updating correctly on creation
    Adds box tag flavours for the pizzas without them (i.e. Donk Pocket -> Bangin' Donk, Dank -> Fresh Herb, Sassysage -> Sausage Lovers, Arnold -> 9mm Pepperoni)

Randomised pizza crates

    Pizza crates can now come with any five pizzas, weighted by disruptiveness
    Small chance of getting one pizza bomb in a pizza crate (either armed or not) per shift

Armed pizza bomb

    Adds an armed variant of the bomb pizza box, which has the boxtag "Meat Explosion", contains a meat pizza and explodes 5 seconds after opening
    Makes the pizza party spawner use the armed bomb pizza box, instead of giving whoever a free syndicate pizza bomb they probably aren't allowed to use anyway

Secure kitchen crate

    Adds the secure kitchen crate from my previous PR
    Adds a secure pizza crate variant to KiloStation's cargo warehouse where the freezer crate was, which contains the pizza party and is locked with kitchen access

Ghost examines

    Adds ghost examine messages for pizza boxes with bombs or the nanomachine pizza in them

* Fixes tags on ordered pizza

Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com>
2021-02-13 10:13:43 +00:00
SkyratBot
7da4aa9adf [MIRROR] Reaction rates, pH, purity and more! Brings a heavily improved, less explosive and optimised fermichem to tg. (#3306)
* Reaction rates, pH, purity and more! Brings a heavily improved, less explosive and optimised fermichem to tg.

* a

Co-authored-by: Thalpy <33956696+Thalpy@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-12 00:04:39 +00:00
SkyratBot
2d58d386ef [MIRROR] Migrate some docs from the GitHub wiki into the repository (#2027)
* Merge pull request #55268 from AutomaticFrenzy/patch/docs-from-github-wiki

Migrate some docs from the GitHub wiki into the repository

* Migrate some docs from the GitHub wiki into the repository

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
2020-12-03 17:16:02 +00:00
SkyratBot
384d439381 [MIRROR] Fixes chem and addiction scans, null checks for addiction_list (#1826)
* Fixes chem and addiction scans, null checks for addiction_list (#55105)

So #54797 changed addiction_list to instantiate as a null instead of a list. Turns out a few things relied on the list existing!
Things like health analyser/medical kiosk chem and addiction scans broke, and smokers would no longer get addicted!
Made a few places check if addiction_list is null before continuing.

(Lemon's note, refactored some code to make it cleaner/removed some unneeded loop typechecks)

* Fixes chem and addiction scans, null checks for addiction_list

Co-authored-by: prodirus <44090982+prodirus@users.noreply.github.com>
2020-11-25 13:56:15 +01:00
SkyratBot
8094701f6e [MIRROR] Fix runtime when assessing the threat level of mobs. (#1436)
* Fix runtime when assessing the threat level of mobs. (#54532)

[00:49:39] Runtime in human.dm, line 607: Cannot read 0.fields

find_record can return FALSE. The ? operator is for null values, not falsey values.

Switches the return to null instead of FALSE if find_record fails to find a record.

* Fix runtime when assessing the threat level of mobs.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2020-10-23 09:51:23 +02:00
SkyratBot
31b66e8a00 [MIRROR] 514 compatibility meme (#1341)
* 514 will mine bitcoin in alternate realities to make you rich while you turn spacemen sideways (#54408)

I swear I already removed this meme once. If it was going to happen it would've happened.

* 514 compatibility meme

Co-authored-by: vuonojenmustaturska <naksu@youzen.ext.b2.fi>
2020-10-17 01:16:04 +01:00
SkyratBot
2bfdfbb910 [MIRROR] Change signature of BINARY_INSERT to require the full type path, add test (#611)
* Change signature of BINARY_INSERT to require the full type path, add test (#53217)

BINARY_INSERT used to only take typepaths like/this. Now, it expects them to be /like/this, to be more consistent with ther est of the code.

Adds documentation to COMPTYPE.

Adds a test for BINARY_INSERT.

* Change signature of BINARY_INSERT to require the full type path, add test

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-09-02 03:07:17 +02:00
SkyratBot
cd0d700a85 [MIRROR] Mecha refactor 2020 (#579)
* Mecha refactor 2020

* Update effects.dm

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2020-09-02 02:16:51 +02:00
jdawg1290
62676e72a8 Force LF line endings with gitattributes and convert repo (#52266)
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
2020-07-16 03:02:40 +03:00
Rohesie
30ca02afb5 movespeed_modification unlawful list modification fix (#50135)
* copy

* Spooky suggestion
2020-03-25 17:34:35 +08:00
Rohesie
e36475e1f4 Slowdown fixes and tweaks (#50095)
* Slowdowns

* Highlander fix
2020-03-21 17:01:34 +01:00
vuonojenmustaturska
40657c9ccd removes a bunch of unused/bad helpers (#48969)
* a commit

* Update code/controllers/subsystem/persistence.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* Update code/__HELPERS/text.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* Update advance.dm

* Update security_officer.dm

* Update text.dm

* Update unsorted.dm

Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
2020-01-28 16:22:20 +01:00
Emmett Gaines
d86321a64c Updates BINARY_INSERT to be a bit more flexible (#48831)
Makes use of the do while(FALSE) trick to give it its own context and makes it possible for the inserted value to be different from the compared value so #48747 can use it.
2020-01-23 13:00:45 +13:00
skoglol
4f24cfaa7d Fixes more input sort runtimes (#47957)
* Fixes another sorting runtiming.

* sortNames copy list, another wrong sort.
2019-11-28 19:38:57 +01:00
spookydonut
138c52d0e3 Update some oldcode (#47630)
This is some of the oldest surviving code in the codebase, churchname 
used a global static and wasn't even used anywhere.
2019-11-09 09:37:50 -08:00
Emmett Gaines
766b935fef Add compile compatibility with 513, upgrade Travis (#47137)
This does all the code changes to allow 513 testing, once this all 
seems about correct it should be merged even if the servers aren't 
using 513.

All changes will be made in a backwards compatible way so that this 
whole process should be harmless.
2019-10-18 23:37:03 -07:00
Akrilla
9ca37e9169 Contract rerolls and general enhancements (#45703)
* refactor wip

* rerolling and qol

* space not valid

* travis be nice

* comment?

* new tablet sprites

* Start on uplink screen

* new suit sprite

* paper

* merge conflict

* Auto stash before merge of "contract-reroll" and "tgstation/master"
2019-08-10 02:11:11 -07:00
Tad Hardesty
0f0604575f Add return type annotations to some procs 2019-06-25 23:03:38 -07:00
coiax
755a9e4fb3 Uplink pens now need two separate rotations to unlock (#41843)
cl coiax
add: Uplink pens now require two seperate rotations to unlock. This also
applies to failsafe codes.
/cl

With only 359 combinations on an uplink pen, it's crackable given a
small amount of time. With two, it's now 92,981 combinations, which
is more secure than PDA uplink codes (899 * 26 = 23,374).
2019-01-02 01:03:42 +13:00
kevinz000
4116f7ec79 Techwebs Backend Refactor - Removes references from techwebs and uses IDs instead (#40596)
Yeah yeah I know no opening too many WIP PRs but this one's [ready] and I want to make sure any furthur techweb development doesn't keep using the old reference system which will make refactoring it harder, and this makes it easier for coders to do stuff in theory (at least for me), standardizes getting a node/design, and makes stuff actually GC properly.
2018-10-06 07:52:07 +13:00
Tad Hardesty
5ffd85bf91 Parse non-strings in lists in maps (#39786)
* Parse non-strings in lists in maps

* Fix 'listening' var
2018-08-24 12:39:05 +03:00
Time-Green
aba162f350 Medical Machinery: Organ Harvester (#39064)
Adds an organ harvester. It's a machine. A human goes in, and the machine starts removing organs and limbs and ejects them right next to the machine. The process can be stopped at any time by either disabling power or prying it open.

The machine does not work if the subject has clothes or appears alive. The health scan can be disabled by emagging, but they'll still need to be naked.

It consists of 4 micro-manipulators, each tier making it faster, but it shouldn't ever really go below 2.4 seconds for every iteration, barring magic fuckery


It's basically a slower acting gibber, but it preserves all limbs and organs.
Useful in conjunction with either a limb grower, bounties, extra food, organ replacement or for something yet to come
2018-07-20 11:30:55 +12:00
ninjanomnom
d32d2869c0 Adds looping timers
and a requested binary search insert macro
2018-07-12 20:23:56 -04:00
AnturK
1572321137 Adds make_associative helper. 2018-06-23 22:22:05 +02:00
vuonojenmustaturska
d335a0fd05 Make typecache checks twice as fast, stop using single-type typecaches where appropriate (#38075) 2018-05-28 16:31:30 -07:00
Tad Hardesty
255f89945a Fix 512-only code in recent conveyor belt fix (#36722)
* Fix 512-only code in recent conveyor belt fix

* Fix 511 troubles in a more broad way
2018-03-29 12:41:41 +03:00
kevinz000
ca10fa6d7a Spell Cards (#36147)
Adds spell cards. They're a wizard spell that shoots a burst of 5 semi-accurate homing cards.
Projectiles now have a homing framework, complete with some variant of simulated inaccuracy.
The said wizard spell will make use of a new mob component, that allows that mob to select targets by moving their cursor near them. It will give a visual and lock onto the nearest mob to the cursor, allowing the homing projectiles to target on the locked on mob/object.
Removes colliding variable from projectiles - We never used it after Bump was refactored to Collide.
Images soon when I get the lockon datum-components to work.
2018-03-23 09:39:26 +13:00
Emmett Gaines
25080ff2c4 defines math (#33498) 2017-12-17 11:02:11 -05:00
Jordan Brown
384a1134a1 Move up the lazy macros 2017-12-04 11:00:54 -05:00
Jordan Brown
055d0021bb Speeds up some list helpers 2017-12-04 10:37:30 -05:00
Emmett Gaines
7c69cdcb8a Revert math (#33059)
* Revert "all this wrapping and it's not even christmas (#33035)"

This reverts commit faaf151580.

* Revert "fuck me for forgetting to graph this one"

This reverts commit 45d7acea2f.

* Revert "defines math"

This reverts commit 2817a1737b.
2017-11-23 20:59:52 -05:00
ninjanomnom
2817a1737b defines math 2017-11-22 17:36:58 -05:00
MrStonedOne
7060428b66 The choice is not mine 2017-10-16 23:54:54 -07:00
MrStonedOne
4148446044 Removing 210mb of wasted memory usage 2017-10-16 23:38:56 -07:00
Tad Hardesty
7739312a9c Fix dangling #elseif in list helpers 2017-09-27 16:59:51 -07:00
Mike Long
0eef60e841 Refactors roundstart centcom threat report. (#30241)
* Refactors rounstart centcom threat report.

* Changes a .Add() to a +=

* Fixes merge.

* Another fix from the merge.  Whoops.

* Removes slashes from sandbox report.
2017-09-13 11:45:57 -04:00
Jordan Brown
d144c88fb5 Annihilates the colons! (#29812) 2017-08-15 12:49:35 -03:00
oranges
5440cfca28 Merge pull request #29697 from Xhuis/the_daily_pr
Rewrites incorrect documentation for the pickweight() proc
2017-08-06 20:09:18 +12:00
Fox-McCloud
c24c9b3ba0 even cheaper 2017-08-04 16:47:49 -04:00
Xhuis
3ca90bbb5a Makes some documentation for pickweight more clear 2017-08-03 17:05:34 -04:00
oranges
edd6299183 split typecache filters into two procs
Apparently I can't stop myself fucking this up so lets do it this way
2017-07-19 10:04:35 +00:00