Commit Graph

12 Commits

Author SHA1 Message Date
SkyratBot
bf3af56598 [MIRROR] fix flashing white spheres when attacking items with light sources and light spheres on inventory/action buttons (#7576)
* fix flashing white spheres when attacking items with light sources and light spheres on inventory/action buttons (#60756)

* fix white sphere bug

* fix overlay lighting creating lights in inventory and action button

* fix flashing white spheres when attacking items with light sources and light spheres on inventory/action buttons

Co-authored-by: Couls <coul422@gmail.com>
2021-08-15 22:51:14 +01:00
SkyratBot
d796323a3f [MIRROR] Fixes an underlay movable lighting runtime (#7087)
* Fixes an underlay movable lighting runtime (#60336)

* Fixes an underlay movable lighting runtime

Co-authored-by: Rohesie <rohesie@gmail.com>
2021-07-26 15:45:15 +01:00
SkyratBot
52a8891f7a [MIRROR] Changes overlay lighting vis contents objs -> underlays (#6985)
* Changes overlay lighting vis contents objs -> underlays (#60239)

Previously what it would do is create up to three objects; a cone, a lighting image and a holder
Then whenever the lighting image was placed into the holders vis contents and the holder would be teleported several times when the parent would to turn or move, and the cone would be spun when the parent spun

Instead of doing that it now just translates a single overlay every time that something is updated

* Mirror!

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Co-authored-by: Funce <funce.973@gmail.com>
2021-07-19 20:43:33 +12:00
SkyratBot
14355e3442 [MIRROR] Fixes losing dynamic luminosity on ChangeTurf() (#6936)
* Fixes losing dynamic luminosity on ChangeTurf()

* Mirror!

Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Funce <funce.973@gmail.com>
2021-07-19 16:45:52 +12:00
SkyratBot
5387f7e1b7 [MIRROR] Fixes the light eater not eating lights people are holding. (#4518)
* Fixes lights on people (#58000)

- Fixes light eaters not putting out lights on people.

* Fixes the light eater not eating lights people are holding.

Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
2021-03-29 22:36:42 +01:00
SkyratBot
7e646af235 [MIRROR] Makes overlay lighting flags actually respond to attaching/detaching lights (#3554)
* Makes overlay lighting flags actually respond to attaching/detaching lights (#57058)

Fixes overlay lighting components not handling attaching/detaching lights.

* Makes overlay lighting flags actually respond to attaching/detaching lights

Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
2021-02-21 13:59:24 +00:00
SkyratBot
63de7b4b0d [MIRROR] Refactors the Light Eater and gives it some flavortext. Some minor behavior changes included. (#3415)
* Refactors the Light Eater and gives it some flavortext. Some minor behavior changes included. (#55551)

Converts the effects of the nightmares light eater into a component and a couple elements
Adds some flavor text to the light eater
Makes the effects of the nightmare's light eater dispel if the armblade is destroyed
Probably a net increase in code quality
More flavortext
The nightmare's light eater effect can be dispelled if you are willing to sacrifice the armblade

* Refactors the Light Eater and gives it some flavortext. Some minor behavior changes included.

Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
2021-02-16 00:45:39 +00:00
SkyratBot
c487c73f39 [MIRROR] Grep for space indentation (#1969)
* Grep for space indentation

* aa

* Update species.dm

* Update species.dm

* Update maps.dm

* Update examine.dm

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2020-12-01 12:26:41 +01:00
SkyratBot
be16d05f08 [MIRROR] Fixes foods crafted from glowing ingredients having incorrect light_overlay (#1592)
* Fixes foods crafted from glowing ingredients having incorrect light_overlay (#54768)

Fixes #54699

Grown foods used in crafting recipes are moved into the contents of the item they are used to craft.

Any grown food with a lighting component was never properly attached to their parent as part of crafting and thus the grown food itself would glow from the containing item instead of the containing item's loc or turf, including when in the user's hand or backpack as per the above issue report.

This PR creates a new signal sent to atoms that are used as part of crafting recipes.

It then makes lightning components register this signal with their parents. If their parents are "consumed" (ie moved into the newly crafted item's contents) during crafting, the signal handler proc re-registers the signal with the newly crafted item and sets the newly crafted item as the attached parent for that lighting overlay component. This now means that crafting using objects with lighting components is now fully supported including when you craft with objects that were crafted with objects with lightning components

* Fixes foods crafted from glowing ingredients having incorrect light_overlay

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
2020-11-07 00:32:56 +00:00
SkyratBot
0de8ba9c1c [MIRROR] Fixes gunlight runtime related to overlay lighting (#1481)
* Fixes gunlight runtime related to overlay lighting (#54614)

Also fixes lights not updating once the holder changes.

* Fixes gunlight runtime related to overlay lighting

Co-authored-by: Azarak <azarak10@gmail.com>
2020-10-27 09:39:08 +01:00
SkyratBot
3b623b8b67 [MIRROR] [READY]Directional lighting component + light system (#1474)
* Directional lighting component + light system (#54520)

Adds in a new type for the lighting system, the directional one. It piggybacks on the overlay lighting to create a directional effect + adds a nice visual cone mask to make the effect feel really directional.
Also: made the static light system respect the light_on variable.

It feels really nice to shine AT things you're looking at with flashlights and the such, it makes maintenance scouring much more immersive too.
Adds more paranoia as you dont see light behind yourself when you've got a flashlight. Plus makes ambushes more fun

* [READY]Directional lighting component + light system

Co-authored-by: Azarak <azarak10@gmail.com>
2020-10-26 09:13:47 +01:00
SkyratBot
0b65cc596b [MIRROR] Overlay lighting component (#469)
* Overlay lighting component (#52413)

Sparks no longer lag, projectile beams move super smoothly, same with mobs and whatnot. This also allows for easy expansion into directional lights, field-of-view, wee-woo rotating lights or whatever.

It does have a downside: things right-clicked or checked through the alt+click tab will show the light overlay:


This is a BYOND limitation, very well worth it IMO.

🆑
add: Smooth movable lighting system implemented. Projectiles, sparks, thrown flashlights or moving mobs with lights should be much smoother and less laggy.
balance: Light sources no longer stack in range, though they still do in intensity.
/🆑

* Overlay lighting component

Co-authored-by: Rohesie <rohesie@gmail.com>
2020-08-23 20:17:12 +02:00