* Give admins the ability to put a popup notice for players in tickets (#61010)
Admins can now give players a popup if they are not responding to tickets.
Popup is cleared when player replies or ticket is resolved/closed.
As more and more of the chat screen is made irrelevant, new players read it less and less.
This means that a lot of new players are ignoring ahelps, which is something I've encountered myself.
* Give admins the ability to put a popup notice for players in tickets
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* removes some uses of var in world (#60407)
Co-authored-by: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
* removes some uses of var in world
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Watermelon914 <37270891+Watermelon914@ users.noreply.github.com>
* Fixes an adminPM dead end eating replies (#55127)
If you tried to reply to an admin that had deadminned while you were typing you would get an error and your message was eaten. Now sends to MessageNoRecipient if theres an open ticket, or prints a warning and the message in chat if there isn't.
* Fixes an adminPM dead end eating replies
Co-authored-by: skoglol <33292112+kriskog@users.noreply.github.com>
* tgchat: Hotfixes, Message Annotations (#52947)
This PR changes the message pipeline a little bit to support list-based messages, which can be annotated with custom data. Function signature of to_chat was slightly changed as well:
// Plain text message
to_chat(client,
type = MESSAGE_TYPE_INFO,
text = "foo")
// HTML message
to_chat(client,
type = MESSAGE_TYPE_INFO,
html = "<span class='notice'>foo</span>")
Old to_chat format is still supported, but handle_whitespace, trailing_newline and confidential flags have no effect. confidential flag could still be revived though, if there is enough merit in it, for example to filter out confidential messages when saving a chat log.
The reason for using /list and not /datum, is because lists are plain faster, and there are minimal data transformations - these lists are fed directly to json_encode and sent to tgchat.
Plain text messages do not need to be HTML-escaped, which makes them safer and more performant than HTML messages. Plain text messages can be made interactive (or formatted with CSS) by custom-handling them in javscript based on message type and annotations.
It would be impossible to annotate every single message in the game (at the moment of writing, there are 9447 to_chat calls in the code), but it could be done selectively, for only those messages that are hard to classify by span classes (and there are still A LOT of them).
Please annotate more messages. Thank you.
Fixes#52943Fixes#52908Fixes#52816
Changelog
cl
add: tgchat: Unread message count is now smarter and won't increase on other tabs if you have already read the same message in the active tab.
add: tgchat: Admin PMs are now properly annotated and can be filtered into separate tabs.
fix: tgchat: Fix: Highlighted message overlay no longer blocks clicks. Clicking a highlighted (F) link should work as it should.
fix: tgui: Fixed NTOS bluescreen due to calling .includes() on a stylesheet href which could be null on certain browsers.
code: tgchat: Chat schema bumped to version 5. All chat-related settings were reset to avoid breakage.
/cl
* tgchat: Hotfixes, Message Annotations
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
* demos (ported from yogstation)
rustg update + write with no format
use external hook for logging
use proper log vars
fix + clarifying comment
don't start the log
release build of rust-g
fix something caught by the lint
Update code/__DEFINES/subsystems.dm
Co-Authored-By: Jordan Brown <Cyberboss@users.noreply.github.com>
Update code/controllers/subsystem/demo.dm
Co-Authored-By: JJRcop <jrubcop@gmail.com>
Update code/controllers/subsystem/demo.dm
Co-Authored-By: JJRcop <jrubcop@gmail.com>
moves hooks out of a dedicated file
len = 0 to Cut(), remove semicolons
untyped loop
* updated rust_g
* 513 updates
* Unicode support Part 2 -- copytext()
This is the transition of all copytext() calls to be unicode aware and also some nearby calls in the same functions. Most things are just replacing copytext() with copytext_char() as a terrible character limiter but a few others were slightly more involved.
I replaced a ton of
````
var/something = sanitize(input())
something = copytext(something, 1, MAX_MESSAGE_LEN)
````
with a single stripped_input() call. stripped_input() already calls html_encode(), trim(), and some other sanitization so there shouldn't be any major issues there.
This is still VERY rough btw; DNA is a mess, the status displays are complete ass, there's a copytext() in code\datums\shuttles.dm that I'm not sure what to do with, and I didn't touch anything in the tools folder. I haven't tested this much at all yet, I only got it to compile earlier this morning. There's also likely to be weird bugs until I get around to fixing length(), findtext(), and the rest of the string procs.
* Makes the code functional
* Assume color hex strings are always # followed by ascii.
Properly encodes and decodes the stuff in mob_helpers.dm which fixes some issues there.
* Removes ninjaspeak since it's unused
* DB ticket procs
* Schema changes for DB tickets
* Schema version update
* Fixes requested by Jordie
* SQL updates
Adds a recipient column
* Still one dangling issue where this DOESN'T WORK
* Alright, this should work
* Requested SQL fixes
* Rogue changes
* less bad defaults
* utf8 for the utf8 gods
* aaaaaa
* Update tgstation_schema_prefixed.sql
* Update tgstation_schema.sql
* Update database_changelog.txt
Co-authored-by: Jordie <4343468+Jordie0608@users.noreply.github.com>
* fuck you whoever made the last icon it was garbage
* ticket log fixes
* ticket log fixes
* changes colors from hardcode per line to a define
* some nicer darkmode colors
* asay and ooc name default fixes
* fuck you appveyer build again
* slight brightening of the default font color
* properly fixes tip of the round being hard to read
* better darkmode v1
* ever better colors
* slightly improved tip color + fixed scrolly bug
* updates skin.dmf as well as some small color tweaks
* slightly tweaked more readable info and admin shit
* span_class fix
* merges ooc fixes
* whoops
* MC and ticket screen fix
* no default darkmode
* skin fixes
* more obnoxious adminpm
* more obnoxious adminshit
* skin revert to ensure proper light theme.
* prevents weirdness with default whiteness
* Adds toggleable darkmode to the game! (Use the toggle darkmode verb if you want to use light mode)
* Removes a random linechange
* Undo unintentional changes
* Changes some forced font tags to use spans, which won't break darkmode.
* Fixes up some problems I found while testing
Darkmode is no longer default (this caused some issues with people getting a broken chat)
* Darkmode sucks less now
* Darkmode button now works again
* wip
* wip2
* makes code actually compile on 511 + fixes
* versioning
* s
* adds python conversion script, schema change and removes 'force ' from item_used_for_combat
* fix to compile
* forgot to actually commit this
* Configuration datum refactor
* More WIP
* New easier on the eyes format
* More WIP
* Finished config.txt
* Fucktons more WIP
* The end of conversion draws near...
* Add all this shit
* Done converting entries finally
* Hunting down compile errors
* More WIP
* MORE CONVERSIONS
* More WIP
* More WIP
* Oh shit only 90 errors this time!
* IT COMPILES!!!
* Fixes world start runtimes
* TGS3
* Fix line endings
* Enable 16-bit long topics
* Cleans up topic socket usage
* Reduces and refines the IRC status throttle
* Increase the CP status delay to a reasonable amount
* Fixes the testmerge command not having a keyword
* Clean up rebooting a bit
* Get error codes from windows when symlinking fails
* Clean up world announces
* Aborting compilation will kill the DD process
* Add support for changing the project name
* Removes the log page
* Add support for compile cancellation
* Version bumps and docs
* Add merge-pr repo CL command
* Fixes DM cancel command's help message
* Refactor command line to show better formatted help text
* Corrects a typo
* Multi-key game options must be manually edited
* Moving of the server installation from the control panel
* Fix a bug with server moving
* Corrects webclient disposal syntax
* Service now handles the PR Json the game uses properly
* PR listing command for CL
* Fixes reversed testmerge and update help entries
* Windows scheduling to help avoid reboot crashes
* Generalization of chat infastructure
* Brings a file name in line with everything else
* Shutdown exceptions no longer keep the service online
* Enable provider switching on the backend. More thread safety
* Support for switching, password encryption and defaults.
* Removes boilerplate on log writing
* Discord integration
* Update the installer dependencies
* Version bump
* Adds support for getting the latest byond version
* Fixes issue with not being able to set discord channels
* Fix being able to reconnect if chat is disabled
* Extra validation for interface types
* Add the Chat page for the control panel
* Various cleanup
* Set read ACL on the data directory
* Remove redundant namespace usage
* Fixes some buttons not updating the server page
* Future proof against upcoming removal of repo data directory
* Normalize Main declaration
* Update the IRC library
* Enables CTCP
* Removes useless hack
* Logging + enable IRC private messages
* Jobs config
* And finally the maps config
* Save the last config panel visited
* Not gonna use these
* Minor formatting cleanup
* Fixes the chat page not refereshing after clicking reconnect
* Fixes server page not initializing correctly
* Repo now defaults to tgstation github when not found
* Revert "Set read ACL on the data directory"
This reverts commit 15b0021ec51532bca14690a884caa81e811fbc46.
* Design the admin config page
* Prep format the repo's admin_ranks.txt
* Add a negative permissions field
* IRC now RFC quits before disconnecting
* Turns out that fixed the disconnect lag
* Updates the admin ranks config api to work for us
* Done with this config shit
* @optimumtact
* Fix this
* Fix the .wxs
* Try to get md5/sha1 working.
* Add FCIV to appveyor
* Generalize the command class
* Revert "Generalize the command class"
This reverts commit 5c61f6df58d66f0fea4170c8aee0cd5beaa99b5d.
* ITS THE FUCKING SEX NUMBER!!!!
* Final touches
* No THESE are the final touches
* Do not advertise
* Revert "Do not advertise"
This reverts commit f64281d486f9ca27e39f19635ab4deacb2d7e1ac.
* Hopefully the last version bump for long time
* Fix line endings
* Fix default dbconfig.txt
* Fix Discord not checking the right admin channel
* Fix discord listening on ALL channels instead of configured ones
* Package the discord fixes for @JamieH
* Format the testmerge data a little better
* Apply 7 character clamping of commit strings
* Fold admin hard reboot into regular reboot list
* Backward ahelp compatibility with the adminbus bot
* Removes an unecessary semicolon
* Fix stray merge conflict in the config
* Fix Newtonsoft being included by the commandline
* Improve byond update logging
* Chat cleanup
* Fixes some setup non-errors from being displayed
* Repository no longer counts being busy as being valid
* Repository no longer valid while cloning
* Fixes a nudge socket change issue
* Frontend cleanup
* Fixes CanStart race condition
* Fixes compile cancel delays
* Various fixes
* More fixes
* Better readme
* More readme
* Fix a config command description
* Add missing repo status command
* Never delete the backups
* Log the compiles
* More logging
* Stuff
* A thing happened, but I'm not sure what
* Tiny
* INB4 second squash
* Version bump
* Shallow clones should speed things up
* Regular clones
* This is how it's set on travis
* Fix this dupe
* Add backup tag support to backend and command line
* Add some missing repo commands, fix GetHead. Fix reset on branches
* Remove the interfaces for commit and push
* Remove that generate changelog checkbox
* Yeah, that's a misunderstanding
* Make changelog pushing a config, with no way to enable for now
* Add Reset and Recompile option
* Update readme
* Repo page cleanup
* Fixed NudgePort message possible repeating
Fixed Reset and Recompile option always being visible
* Fixed compilation copy not overwriting files
Fixed compiler trying to unecessarily delete the whole A/B folder
Improved game folder initialization speed
* Selectively stage the html folder
* Make the restriction a config
* Switch to using LibGit2Sharp+SSH
* WIP SSH support
* Removes some success chat messages
* Make repo authentication purely file based
* Quick IRC fix
* Should all work in theory...
* More fine grained
* Remove the username thing
* Use the right default email for tgstation-server
* Update the readme
* That's worthy of a version bump
* Speling
* Makes it do as the readme says
* Fix testmerge list not having a scrollbar
* Trying out commit message based deployment [TGSDeploy]
* Whoops
* Testing
* Better
* Version Bump [TGSDeploy]
* Need to set the var at parent scope [TGSDeploy]
* Use the commit message
* Try this [TGSDeploy]
* Try just this
* This maybe? [TGSDeploy]
* >like [TGSDeploy]
* Wildcard, bitches [TGSDeploy]
* Saner title [TGSDeploy]
* Readme update
* This should loin ya
* Fix it [TGSDeploy]
* Readme, cleanup, and doc updates
* Improve DD crash handling
* Version bump [TGSDeploy]
* TGS3 Config Changes
* Line endings
* Map config code change
* Missed a few
* Security and Visibility selectors for the Server page
* Fixes OCD
* Fax it
* Fixes
* Version bump [TGSDeploy]
* eh
* The word comment has lost it's meaning to me
* This is a terrible name but whatever
* Support config changes
* This is part of the code so it belongs with the code
* ExportService now has a return value
* Copying of the logs dir during compile for #27674
* Version bump [TGSDeploy]
* Removes some uneedful
* Moves daemon config to BYOND folder, much safer
* Fix a config comment translation miss
* Fix project settings issue
* Fix config apply button not showing up after repo clone
* Fix anchoring for Backup Tags: label
* Version Bump [TGSDeploy]
* Nudge port only listens while server is running
* Fix some instances of the control panel crashing when the service stops
* Add start menu shortcuts
* Remove the actual server
* Remove appveyor
* Fix gitignore
* And this
* Readd HTTPS_Get for now
* Readd legacy support
* Fix
* Fix this stuff
* Last thing
* Line endings
* Final touches
* Dat newline
* More stuff
* Where'd that go?
* Real final touches
