About The Pull Request
Stuff that should logically require you to actually be metabolizing the reagent now requires a liver, or the reagent to not need one.
Some reagents have been granted self consuming status, like holy water, since their effects are not tied to the metabolism.
Fixes#44650Fixes#43024 since there should be no real way to mitigate the constant toxin damage now
Why It's Good For The Game
Less exploits with livers, more consistency in mechanics.
Changelog
cl XDTM
fix: Viral healing symptoms that are tied to reagents now also require a functioning liver to work.
tweak: Holy water, Pyrosium, Cryostilane, Napalm and Phlogiston no longer need a liver to have their effects.
/cl
cl Naksu
code: reagent IDs have been removed in favor using reagent typepaths where applicable
fix: mechas, borg hyposprays etc no longer display internal reagent ids to the player
/cl
* Gives each quirk a medical record, cleans up subjects into patients.
* Update code/datums/traits/good.dm
adds a period I missed
Co-Authored-By: loser <loser@nonagon.host>
* Dumps medical quirk string into medical "Notes"
* Implements bgobandit's suggestions
* ~Comma, comma, comma, comma, comma, commits from Cobby~
Also I missed an A.
Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
* Initial poking around
* adds a message to let you know the examine proc'ed
* converts time to minutes
* removes old on_process() code
* Nests procs under if(!appears_dead)
* nests blocks under src != user
I came to the conclusion that quirks that put you on a death timer are
dumb and boring, one such reason being they make you unable to go AFK for
any length of time but also aren't interesting to manage other than
lugging around whatever medicine you need to survive every round.
Blood loss now stops just above a survivable threshold, meaning when left
untreated even the smallest of wounds is potentially lethal, hence it's
still 2 points. Watch out for paper cuts.
Renamed just to make it a bit shorter and less spooky.
* nice.
* They exist to cease.
* "They've got eyes inside my head!"
* frick
* unstable insanity
* Just try taking this bull by the horns. (eyeballs)
* It's a thankless job, and you'll probably die in an explosion. But the pay is pretty good.
* "The best denials are simply that: a beginning and end unchanged, a dream with no memory."
* fixes the dme
🆑
add: Adds the Paraplegic quirk for -3 points. You start with unhealable leg paralysis
(persists through cloning), and have a wheelchair to move around the station.
/🆑
This is really popular for some reason.
This required a surprising amount of small code tweaks for it to "feel"
right in edge cases like being a job that had items in their hands or
joining on the arrivals shuttle.
Justification for -3 points: You move REALLY slowly, in a game that's
about generally running from security/the guy with the esword. And if
you die and get cloned and don't have your chair, you move even slower.
* drug quirks
* more work on junkie trait
* more druggie work
* work pls
* make the junkie trait actually fucking work and not runtime
* fix the smoker quirk
* fix capitlization on the reagent containers
* refactored
* less shitcode
* fix errors
* add meth and crank since it's 0.5u
* fix dupe chem + fix addictions list being loaded with null
* relapse mechanic
* have addiction applied on spawn again
* remember to compile kids
* some logic error corrections
* fix another logic error resulting in relapses never triggering
* fix the logic error that I thought I fixed to begin with but accidentally made worse
* I really have the fucking dumb right now.
* reset the addiction when it's readded
* better syntax for list addition
Co-Authored-By: actioninja <actioninja@gmail.com>
* suggested changes
* better new syntax
Co-Authored-By: actioninja <actioninja@gmail.com>
* turf var
* correct syntax error
* renamed vars
* announce proc instead of hacky logic
* clearer logic refactor
* increment operator
Co-Authored-By: actioninja <actioninja@gmail.com>
* make it actually compile
* no null patrol
* fix accessory spawning
* fix runtime from the reagent list being full of instances apparently
* buff pill contents so they actually satisfy addiction
* adds cigars to the smoker spawn pool
* I think this is what cyber means?
🆑 coiax
add: Players with the Spiritual quirk now spawn with a pack of candles
and a box of matches, for better communion with their chosen power, and
get a mood boost while near a holy person (generally the chaplain).
/🆑
Makes Spiritual not just a quirk that literally requires admin
approval to pay off. Have some free candles, talk to the chaplain to
cheer up, and maybe you'll be able to gang together to convince the gods
to give you an angry bloodcrawling duck.
cl Floyd / Qustinnus
tweak: You now have to be naked to get the nice shower moodlet, if you shower with clothes you get a bad moodie
add: Hygiene, you slowly become dirty over time, the more covered in blood you are the faster you will lose hygiene. When you are too dirty you will have a stink overlay. (Hygiene doesn't affect mood currently) It also spawns miasma slowly if you smell like shit.
add: adds NEET and neat traits. NEET's get 20 bucks social welfare extra and like being unhygienic, while neat people dislike being unhygienic and like being hygienic
/cl
This doesn't affect mood so plssss dont strawman in this PR about how I'm forcing you to shower or die or whatever
This PR is mostly visual and will allow for people to judge others for literaly being smelly as hell.
also NEET and neat traits which interact with being smelly. (neat likes hygiene, dislikes lack of it. NEETs like lack of hygiene and get some social welfare (20 bucks))
* newquirks
* revert
* hypersensitive/light drinker
* this is a commit
* may as well
* increments + fix
* i never liked math anyway
* I really dont like math
cl XDTM
add: Added the Vegetarian quirk, which costs 0 points and makes you dislike meat.
/cl
Because why not? Also, it could give a reason for the chef to prepare vegetarian dishes instead of the usual stuff.
cl coiax
add: Any talented Musician can now use any instrument to lift
spirits, and ease burdens. They can now also use the space piano and minimog
to grant people the Good Music buffs, just like a handheld instrument.
/cl
A living mob with TRAIT_MUSICIAN will now apply the Good Music
status effect to everyone who can hear the music. The buff will
now apply even to players who have disabled instrument sounds.
The Good Music status effect lasts for 6 seconds after the
musician stops playing.
Added STATUS_EFFECT_REFRESH that just refreshes the duration
of a status effect, rather than instancing a new one.
cl coiax
add: Heirlooms are no longer named "Cherry family bag of dice", but
rather their heirloom status can be determined by the owner on examine.
/cl
Because names are inherent to an object when anyone looks at it, I feel
it can be somewhat confusing that you can tell that this screwdriver
is a precious family heirloom just because of its name, rather than
because of the significance that someone holds it.
Only the owner of the heirloom receives the special examine text; so I'm sure this could probably be used to bluff ownership of something non-standard, if and when heirlooms become more exotic.
Heirlooms still work in the same way though, mood bonus from holding, mood penalty if you don't have it.
🆑 coiax
add: Adds the Physically Obstructive negative quirk. A person with this
quirk can't swap places with other people when moving, akin to someone
always being in non-help intent.
/🆑
Adds the TRAIT_NOMOBSWAP to accomplish this.
Blindfolds don't actually need to inherit anything from sunglasses, from what I
can see, unless there's some bad type checking somewhere in the code that I'm
not aware of.
Exploit is: cloth makes blindfold + medHUD -> medHUD sunglasses -> remove
medHUD, regular sunglasses.
* fixes 2 minor blindness quirk bugs (fuck u cyberboss)
* commit 2 fix
* doneeroni
Here u go
* let's do it
Co-Authored-By: Militaires <ahmedosama2001@gmail.com>
