Commit Graph
95574 Commits
Author SHA1 Message Date
CheshifyandGitHub 89f8bf88da Evidence Storage Is Now An Area (#70983)
## About The Pull Request
Fixes https://github.com/tgstation/tgstation/issues/70959
Gives each map Evidence Storage, which each has an APC
Icebox

![image](https://user-images.githubusercontent.com/73589390/199290179-5c6da142-5668-42e7-a607-69914f83c212.png)
Deltastation

![image](https://user-images.githubusercontent.com/73589390/199290219-1f3ed72b-b534-434e-9071-26b2d722ea97.png)
Metastation

![image](https://user-images.githubusercontent.com/73589390/199290336-2e74588c-33ac-496c-b225-052ad5cad523.png)
Tramstation

![image](https://user-images.githubusercontent.com/73589390/199290380-07f47828-6e45-4994-b88f-efca5b1ff80e.png)
Kilostation

![image](https://user-images.githubusercontent.com/73589390/199290430-1553826f-3e51-4dd3-9224-37b49c9b33e4.png)
## Why It's Good For The Game
Probably good for stations to have a consistent evidence room. Breaks up
the big block that is security.
## Changelog
🆑
fix: All maps have a consistent Evidence room.
imageadd: Ddds an icon for the Evidence Storage area
/🆑
2022-11-04 01:00:29 -07:00
588779256e Surgery computers tell which tool to use. (#70973)
## About The Pull Request


![image](https://user-images.githubusercontent.com/105025397/199194075-d1a3b42a-5c2e-4a02-84d1-84b4be2b601b.png)

All surgery step names, displayed in the surgical computer, will now
show which tool to use for that step in parentheses. In cases where
multiple tools have a 100% success chance, all are listed; if no tool
has a 100% chance then the "correct" one is shown.

Surgery computers will never display "alternate" tools for surgeries
(those with a lower success chance), but this shouldn't be a problem.
Surgical computers are _usually_ in places with surgical tools at hand,
and NanoTrasen wouldn't want to encourage doing brain surgery with a
screwdriver. Y'know, probably.
## Why It's Good For The Game

Firstly, this change is particularly helpful to new players. If you have
little experience with surgery, it's not always clear which tool you're
meant to use for which step. This is especially true for some of the
odder surgeries - if you didn't already know, it's not clear at all that
"brainwash" means "use a hemostat". While there are certainly guides on
the wiki, it's nice to have as much information provided in-game as
possible.

Secondly, this change brings consistency. A _small_ number of surgical
steps (healing broken bones, namely) already do this! I see no reason
why this shouldn't be extended to the remaining surgical steps,
especially because it's not particularly obtrusive to the surgery
computer interface.
## Changelog
🆑
qol: Made surgical computers tell you what tool to use for the current
surgical step.
/🆑

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-11-04 01:00:12 -07:00
orange man f137db6b2d Automatic changelog for PR #70471 [ci skip] 2022-11-04 20:53:31 +13:00
GoblinBackwardsandGitHub f7e82e49c9 Changes HFR corner to use 4-way icons (#71029)
## About The Pull Request
Changes the HFR corner icon and some of the code so that it uses 4-way
icons. Fixes #64729.

The way the icon is currently set up, the cardinal directions are
completely blank and the icons are on the intercardinals only. Because
of this, using the chameleon projector on a HFR corner means you'll be
completely invisible since the player faces cardinals but the HFR corner
doesn't have cardinal sprites.
## Changelog
🆑
fix: fixed an exploit that let you go completely invisible by scanning a
HFR corner with a chameleon projector
/🆑
2022-11-04 00:53:15 -07:00
RhialsandGitHub 7a671b657f The Shuttle Loan event can now roll multiple times per round (#70819)
## About The Pull Request

The Shuttle Loan event can now roll multiple times (up to 3) per round.
When a loan is offered, the event cannot roll again until the current
offer is accepted. If an admin forces the event, the current loan offer
will be replaced by the new one. A specific type of loan offer will not
appear more than once per round under normal circumstances.

## Why It's Good For The Game

I think the Shuttle Loan event is really neat. It's presents Cargo with
the option to take on risk and reap the rewards, with some opportunities
for things to go very very wrong. There are twice as many loan offers as
there were when this event was introduced nine years ago, with more
potentially on the way (wink wink nudge nudge). I don't think it should
be constrained to just one per round any longer.

## Changelog

🆑
balance: The Shuttle Loan event no longer only rolls once per round.
/🆑
2022-11-04 00:51:53 -07:00
VexingRavenandGitHub aead1310af Fixes issues with printing posters from the library management computer (#70471)
## About The Pull Request
Posters are kind of insane and they require that the poster item have
either a poster_type defined in the type or that you pass the structure
version of the poster to /new() otherwise they don't work. The weird
thing is that the structure needs to be in the contents of the item too,
or it again won't work (it won't remove the poster from your hands when
placing it). I fixed it so all you need to do is pass the structure
version of the poster to /new() on the item and it will move the
structure to the contents of the item if needed. It's still a bit insane
but it's better than it was and it fixed the bug.

Also SSLibrary.printable_posters was grabbing the directional mapping
helper of the random poster and so when you printed it and placed it,
you'd get confusing results. I made a quick fix to stop that from
happening.

## Why It's Good For The Game

Bug fixes are generally good things.
Fixes #70382
Fixes #66504


## Changelog

🆑 VexingRaven
fix: Fixed posters printed from the library console staying in your hand
when you place them
fix: Fixed Random Official Poster printed from the library console
always placing the west-facing variant no matter where you place it
/🆑
2022-11-04 00:47:03 -07:00
orange man c7df113c36 Automatic changelog for PR #71022 [ci skip] 2022-11-04 17:53:12 +13:00
IamgoofballandGitHub befeda6a5d Janitors and Shaft Miners start with the ExperTrak Skill Tracker preinstalled on their PDAs. (#71022)
see https://tgstation13.org/phpBB/viewtopic.php?f=10&t=32695
2022-11-03 23:52:33 -05:00
orange man 4e7eb943ac Automatic changelog for PR #71025 [ci skip] 2022-11-04 17:51:59 +13:00
lizardqueenlexiandGitHub b877ded787 Placed a GeneDrobe in MetaStation genetics. (#71025)
MetaStation is the only map that was missing a GeneDrobe in its Genetics lab. I've placed one there.
2022-11-03 23:51:35 -05:00
Changelogs c66004e1e1 Automatic changelog compile [ci skip] 2022-11-04 00:26:28 +00:00
LemonInTheDarkandGitHub e442a655ab Saves 2 seconds off init by inlining the bumpclick element (#71008)
## About The Pull Request

It was also a tad yorked so I fixed that bit
bump_click did very little in this case, and while the modularity is
nice, the hotness of minerals made this totally untenable
2022-11-03 16:05:45 -07:00
orange man d5c18b347c Automatic changelog for PR #71005 [ci skip] 2022-11-04 11:56:42 +13:00
TastyfishandGitHub c0840fc131 Adds a game option to toggle the MultiZ parallax effect for a player (#71005)
Adds a game option, similar to Ambient Occlusion, to toggle MultiZ
scaling, ie the MultiZ parallax effect, which I'm calling it in the
option since that's more clear.

I mainly am curious if this is the cause of significant lag on icebox,
or if it's just the use of a huge number of planes in general.

I don't experience any client lag locally (I'm guessing lemon doesn't
either) so **I mainly intend this to be Test Merged** for people to find
out if the the actual plane.transform being set is the cause.
2022-11-03 17:56:22 -05:00
orange man 2aef3e6aaa Automatic changelog for PR #71010 [ci skip] 2022-11-04 10:52:42 +13:00
TimandGitHub 15821b43dc [NO GBP] Fix zombie tongue to only apply to infectious species (#71010)
Zombie tongue speech modifier should only be applying to the infectious zombies species.
2022-11-03 16:52:19 -05:00
MrMelbertandGitHub fc7c967ac5 Funny merge skew from banana (#71039)
When a food feature PR and a food refactor come together, and get merged
without re-running checks, something very funny happens.

A merge skew. 

Edible component uses inherent component so this is fine.
2022-11-03 21:37:24 +00:00
orange man c7845e3df3 Automatic changelog for PR #70409 [ci skip] 2022-11-04 09:45:23 +13:00
MrMelbertandGitHub 1ac4a67c27 Chefs can now kiss food they make to make it with love. (And a lot of cooking refactoring) (#70409)
About The Pull Request

    Adds a skillchip to the chef's vendor. This vendor allows the chef to kiss their food to deliver a chef's kiss.
        Chef's kissing your food will add the "love" reagent to the food, which makes people much happier when they eat it. Be careful, overdosing on love can cause heart attacks.

    Refactors microwaving.
        Separates microwaving out of the edible component and makes it its own element, like grillable and bakeable.
        Also removes some magic numbers from microwave code.

    Code improvements all around baking and grilling code.

    Refactors edible component inheritance.
        Inheriting the edible component is now a viable way to cleanly add food types, flags, and callbacks. This makes it much much easier to change the values of an edible item without adding hacky signals / procs / getcomponent.

Why It's Good For The Game

Emergent chef gameplay.
Being able to further enhance your food with mood buffs.
Better code.
Changelog

cl Melbert
add: Chefs can now make food with love. They can purchase a skillchip from their vendor which enhances their kiss emote. Using your kiss on food you create will add a special reagent to it which makes it nicer.
refactor: Separated Microwavable from the Edible component, refactored microwave act to accompany this
refactor: Refactored how grilled items are generated
refactor: Refactored how silver slime food items are generated
refactor: Refactored how edible items inherit new edible statuses
code: Removed some magic numbers from microwaves
code: General code improvements for grillable / bakeable / etc
/cl
2022-11-04 09:45:01 +13:00
orange man 901c541c85 Automatic changelog for PR #70997 [ci skip] 2022-11-04 08:53:39 +13:00
GoblinBackwardsandGitHub a2bcc71706 Makes the Space Ninja modsuit module buttons pinned by default (#70997)
## About The Pull Request
Makes space ninjas spawn with their modsuit action buttons already
pinned
## Why It's Good For The Game
The radial menu isn't really practical for abilities you're going to be
using mid-combat, the throwing star dispenser is especially bad since
it's basically impossible to use at the rate it comes off cooldown if
you don't have it pinned.
People shouldn't need to know how to pin the modules or to go through
the UI pinning each of them just for the antag to be playable.
## Changelog
🆑
qol: Space Ninja now has their MODsuit module buttons pinned by default
/🆑
2022-11-03 20:53:10 +01:00
orange man af0f38be64 Automatic changelog for PR #71003 [ci skip] 2022-11-04 03:38:05 +13:00
FikouandGitHub 34739b4565 Ash Drake attacks work again. (#71003)
Ash drakes check if Trigger worked before doing the meteors after a fire breath, or the fire breath and meteors after a swoop. Turns out, Trigger leads to PreActivate, which leads to Activate, which never returns TRUE. So we make it return TRUE for the stuff in the folder.
2022-11-03 10:37:39 -04:00
orange man 022e58b6ab Automatic changelog for PR #70773 [ci skip] 2022-11-04 03:33:29 +13:00
ShizCalevandGitHub 6536b01a18 [MDB IGNORE] Clothing var cleanup (#70773)
Riot helmets and justice helmets are now in a /toggeable subtype.
Also cleans up a lot of vars around clothes in general.
2022-11-03 10:32:50 -04:00
orange man ec543a568a Automatic changelog for PR #70996 [ci skip] 2022-11-04 03:30:36 +13:00
FikouandGitHub a6f9323985 smal fixes to mechpad (#70996)
prevents starting the beeping sounds multiple times
makes beeping sounds work (they ran their check but the condition needed for it only starts in the next line)
plays a sound when it starts the launching process
sets the mech direction to south when it launches
2022-11-03 10:30:13 -04:00
orange man be9b6990b8 Automatic changelog for PR #70995 [ci skip] 2022-11-03 16:01:50 +13:00
FikouandGitHub f1ed979a98 fixes throw click cooldown not applying (#70995)
#62749 made it so throw click cooldown would only activate if throw_item returned TRUE.
throw_item never returns anything so it just broke the whole thing. this fixes that
2022-11-02 22:01:25 -05:00
san7890andGitHub b6a801a888 Fixes Raw Turf in Tramstation + Patches Lint for Raw Turf (#70998) 2022-11-02 19:53:31 -07:00
Changelogs f0d15da0c6 Automatic changelog compile [ci skip] 2022-11-03 00:25:47 +00:00
orange man 687115d012 Automatic changelog for PR #71013 [ci skip] 2022-11-03 08:40:29 +13:00
ZergspowerandGitHub eacc3087d7 Fixes the errant line in the template decal (#71013)
Not entirely sure when it happened but at some point a line was added to the default angle of the 'end' decal linebox
2022-11-02 14:40:06 -05:00
orange man 73741c900c Automatic changelog for PR #70956 [ci skip] 2022-11-03 08:32:19 +13:00
antropodandGitHub 372227bc56 Fix assemblies not pick-upable after detaching from chemical grenade (#70956)
Assemblies (signallers, mousetraps, timers, etc.) can be picked up again after detaching from chemical grenade
2022-11-02 14:31:52 -05:00
orange man 3279023bc9 Automatic changelog for PR #70957 [ci skip] 2022-11-03 08:31:04 +13:00
GoblinBackwardsandGitHub 384497d330 Makes tanks drop if ejected when not adjacent (#70957)
Makes atmos machines drop their tanks on their tile when eject is
pressed if the user isn't adjacent to it.
2022-11-02 14:30:29 -05:00
orange man 372a1c6d32 Automatic changelog for PR #70981 [ci skip] 2022-11-03 08:30:17 +13:00
CheshifyandGitHub 92cfd680fd Tram SM Displays (#70981)
There were two displays on each part of the SM so I just changed it so
that there'd be one on the diagonal for easy viewing.
The actual position of the displays is marked by the white box on the
image below
2022-11-02 14:29:55 -05:00
orange man 98d3488c0b Automatic changelog for PR #70977 [ci skip] 2022-11-03 08:29:25 +13:00
CheshifyandGitHub 123049370f Icebox Maint-Door Shift (#70977)
Wow this door is blocking this window in a really weird and awkward way!

This looks much better! All I did was move the door to the right, adjust
the areas to make sense, and move the trash spawner.
2022-11-02 14:29:05 -05:00
orange man a95dc04c54 Automatic changelog for PR #70980 [ci skip] 2022-11-03 08:27:32 +13:00
CheshifyandGitHub 92134e8d66 Meta Wall Change (#70980)
Look at this. Two walls connected diagonally with nothing else. This is
NOT up to standard.

I adjust the wall, newscaster, and area to be in perfect unison,
removing the blatant crime that is diagonal walls.

But the poor vending machine! I cannot remove it, it is put next to it's
brother in the library, and the beacon spawner is moved to compensate.
2022-11-02 14:26:52 -05:00
30db65d5e0 Removes another bad string macro (#70871)
Fellas please we *just* got TG compiling in OpenDream and you go and
break it again with a new string macro that doesn't work.


![image](https://user-images.githubusercontent.com/5714543/198751671-cfa3070a-e5c7-4f06-8989-020f3ec2b2dc.png)

Co-authored-by: ZeWaka <zewakagamer@gmail.com>
2022-11-02 14:24:58 -05:00
ike709andGitHub 17cd840aa2 Renames a duplicate proc arg (#70872)
BYOND silently errors with duplicate proc arg names:
https://www.byond.com/forum/post/2737322

I don't think this actually affects the behavior in this case but
leaving it as a footgun is probably a bad idea.
2022-11-02 14:24:28 -05:00
FinancialGooseandGitHub e49e165482 Bed war: add pillow weaponry and pillowman juggernaut suit (#69977)
* Add pillows you can hit someone you hate with it until they collaspe from exhaustion. The pillow can be made with cloth
* Adds a Pillow juggernaut suit, this suit allows you to automatically hit people with a pillow when you bump into them. It can be made from pillows and duct tape via the crafting menu
* Adds a bumpattack component, this can be added to any item and allows the user to auto attack on bump with a target, used for the juggernaut suit.
* Adds a Pillow hat an alternative to the paperbag hat, also made from duct tape and pillow. Very fashionable!
add: Clown/mime pillows
* The beds in dorm now come properly equipped with a pillow
2022-11-02 13:05:50 -04:00
orange man b588d1a2c9 Automatic changelog for PR #70937 [ci skip] 2022-11-02 17:51:21 +13:00
TomandGitHub f6feee8901 Tear juice makes you cry on touch instead of ingestion (#70937)
## About The Pull Request

Changes the requirements for crying from being exposed to tear juice
from ingestion to touch.

## Why It's Good For The Game

Spam crying whenever you eat food with onions in is funny-ish but
doesn't really make sense.
What *doubly* doesn't make sense is that wearing glasses while eating
food with onions in stops you from crying.
Now, you can eat onions all you like. Cutting them will still make you
cry, though.

## Changelog
🆑
fix: Eating food with onions in will no longer make you cry.
/🆑
2022-11-01 21:49:34 -07:00
orange man 26d90775d2 Automatic changelog for PR #70963 [ci skip] 2022-11-02 17:34:09 +13:00
lizardqueenlexiandGitHub 57b1c69307 Fixed an infinitely-printing log message about pipenets. (#70963)
## About The Pull Request

A slight logging error resulted in a specific warning about pipenets
never being suppressed, instead continually printing the message that
states that further messages will be suppressed. This was caused by the
limit on pipenet warnings being decremented in the wrong place. This
oversight has been corrected.
## Why It's Good For The Game


![image](https://user-images.githubusercontent.com/105025397/199134575-ce47f47c-6796-4478-8478-19087308bfd8.png)

This is really annoying to scroll through.
## Changelog
🆑
fix: Properly suppressed a message about suppressing messages.
/🆑
2022-11-01 21:30:33 -07:00