No more rod form in the wizard's den. This applies whether you are a
wizard or whether you somehow ended up in the den and are not a wizard,
which I don't know how that would happen, but if you did.
* deletes any touch spells if the wizard refunds the spell in question
* moves touch removal code to on_lose
* makes pkp suggestions
* adds message feedback
About The Pull Request
Converts every single usage of playsound's vary parameter to use the boolean define instead of 1 or 0. I'm tired of people copypasting the incorrect usage.
Also changes a couple of places where a list was picked from instead of using get_sfx internal calls
This was done via regex:
(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\)) to match 1
(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\)) to match 0
full sed commands:
/(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\))/\1TRUE\2/ 1 to TRUE
/(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\))/\1FALSE\2/ 0 to FALSE
I'm not very good with regex and these could probably be optimized, but they worked.
Why It's Good For The Game
Code usability
About The Pull Request
Corrects the time-stop incantation from "TOKI WO TOMARE" to "TOKI YO TOMARE" as per how Japanese works and also because thats what the reference actually says.
im honestly just doing this so that i could figure out how github even works
Changelog
cl
spellcheck: Wizards now properly reference DIO when stopping time.
/cl
#43978 messed up some of the logic in Network Invasion, causing it to
not work after standing still instead of the other way around. This
fixes that.
Also puts Sensory Shock, added in #44436, properly in the Hivemind
Abilities panel instead of the Spells panel which happened due to it
no longer being a child of spell/targeted_hive.
About The Pull Request
Adds two new mime spells to the game. Both work like the invisible wall, i.e. they spawn an invisible item for a limited amount of time:
Invisible Chair: Summons a chair and has the mime sit in it. Perfect for crowded shuttles or staying put.
Invisible Box: Everyone's favorite stock mime routine! The mime summons a box (invisible to everyone but him, although you do get the message once spawned) that can store small items. When it disappears, the items are dropped.
To prevent massively overpowered mimes, the mime gets a spellbook at roundstart from which he can choose only one out of the three mime spells.
Why It's Good For The Game
The mime doesn't get nearly as much cool stuff as the clown, and these are pretty common pantomime routines to riff off.
Changelog
cl
add: After receiving many complaints about mimes who never pantomime, Nanotrasen has liquidated its mime personnel and hired new mimes who know more routines.
add: The mime gets the choice of two new spells: Invisible Chair and Invisible Box. They work much like the Invisible Wall spell does and disappear after a short span of time. The invisible chair can be buckled to like usual chairs; the box works like a standard inventory box item.
tweak: Mime spells are now granted via a spellbook that starts out in the mime's inventory. Mimes can choose one of these three.
/cl
* De-linkifies names in deadchat_broadcast(), makes deadsay css class default too
* Makes the source argument come after message, since it is optional
* Removes excess </span>
* fixes reclaim on dead hiveminds
* adds exnendo hand min range var
* replaces hive warp with telekinetic hands, no inhand sprites added yet
* changes hive_shock to sensory effects, no sleep
* syntax fix
* adds new curse variant
* sensory overload power modifier, heart attack replaced with necropolis curse variant
* hivedrain removes stam dmg
* does curse subtype in more sane way
* changes circadian sleep to knockdown
* spell path and icon path changes
* shock channel, pin weaker on hives, cooldown changes
* telekinetic hand inhand sprites
* adds message to teople surrounding mind contol victim on cancel
* hivemind icon changes
* nightmare changes
* removes stun on mc end
* hivemind forcewall lasts longer
* prevents negative power values on shock
* chages nightmare duration and effect
* hive shock changes
* userdanger message on mind control end so people see it
* fixes merge
* removes control change
* removes unneeded var
* typo
* fixes me commiting the wrong shit
* syntax fix
About The Pull Request
Purification of a soulstone (hitting it with a bible as noncult) no longer destroys the stone, and releases a spirit. Instead, it purifies the stone, which is crew friendly and has a new sprite. Said stones can be placed into construct shells to create purified angelic constructs, which are easily distinguishable from cult/wizard constructs.
Why It's Good For The Game
Crew finding and using construct shells to create stealthy anti-cult constructs sucks. This PR would get rid of this shitty gameplay, and adds some new flavor to the whole cult/anti-cult dynamic.
Changelog
cl weeeeesoda
add: You can now purify soulstones! This can be done by any crew member using a bible on one.
add: Purified constructs can be created by using a purifed soulstone on a construct shell. Amongst their normal abilities, purified constructs can dispel cult runes by clicking on them.
del: Ability to place chaplains soulstone or mining soulstones in construct shells
imageadd: angelplasm, angelic sprites, purifed sprites
/cl
About The Pull Request
Was fairly shocked to find out hiveminds never took tinfoil hat protection in account, so decided to implement the factor in the game mode. Might have overdone it and probably erroneously changed a couple logics while getting rid of some really indented passages that could easily early return.
So what's said on the tin, this is lot more preferable than clunky is_type() checks on headwear anyway.
Also expanded tinfoil protection to hivemind and (non-revenant) telepathy.
Why It's Good For The Game
Let us remember the "purpose" of tinfoil hats.
Changelog
cl
code: Merged tinfoil hat kind of protection into the anti_magic component.
add: Tinfoil hats can also be warped up from excessive dampening of mindray/though control/psicotronic anomalies, or by simply being microwaved in an oven, and become useless.
add: Immortality Talisman and Paranormal Hardsuit helmets now come with tinfoil protection too (minus the paranoia and limited charges).
balance: Rebalanced many hivemind effects to be dampened/delayed by tinfoil shielding. Bruteforced Assimilate Vessel, One mind and Awake Vessel abilities will consume more tinfoil charges compared to others.
balance: Genetics/Slime/Alien Telepathy and Slime Link are now stopped by tinfoil protection.
/cl
* Fixes shapeshift health adjustment
* Fixes gross whitespace
* adds forced to shapeshift damage
* Brainloss does not have a forced parameter
* Cleans up some missed named arguments
* Adds to overrides
* More forced
* Re-arranged so 0 damage forced calls do nothing
* Forced for silicon changes
