Commit Graph

2943 Commits

Author SHA1 Message Date
vuonojenmustaturska
fb45b7a017 Turns trait accessors into defines, fixes some bugs (#43820)
It's free performance.
2019-05-06 19:44:05 -04:00
81Denton
546592529c Adds confirmation popup to undelaying round end (#43780)
* Adds confirmation popup to undelaying round end

* Popup lists current delay reason
2019-05-02 12:17:48 -04:00
Tad Hardesty
9183a6f66b Clean up workaround for fixed compiler bug (#43698) 2019-04-29 10:59:28 +02:00
William Wallace
a944c2a362 Ghosts can analyze gas mixes and some new objects can be analyzed (#43502)
* Ghosts can analyze gas mixes and some new objects can be analyzed

* Replace show_air_status_to with atmosanalyzer_scan
2019-04-16 21:46:36 +12:00
JJRcop
1cf1df847c [READY] Adds selector lists to SDQL (#43383)
* [SDQL2] Adds selector arrays

* SDQL2 documentation spec updated slightly

* SDQL2 selector array docs + tweaks

If a single list is the only result of a MAP statement,
meaning objs.len == 1, AND it's a list, it will unwrap
the result from its containing list and return it directly.

The selector array logic keeps track of the state of the query
when it starts the first Search. It won't change the state back
to Execute until the top-level is reached, which sets a var
to keep track.

* SDQL2 MAP change from objs.len to length(objs)

* [SDQL2] Reverts MAP list unwrap

* [SDQL] Move (expr) from expr, unary_expr to var

This should result in the same functionality but instead of expressions and unary_expressions processing sub expressions, variables do
This means that expression->value->variable is now completely recursable

* [SDQL2] Update selector list documentation
2019-04-15 09:22:30 +02:00
Tad Hardesty
bbef4190f8 Fix runtime when lightning smiting non-humans (#43537) 2019-04-08 15:54:32 -04:00
Tad Hardesty
9c9cc9110a Improve cancellability of Run Weather admin verb (#43528) 2019-04-08 15:53:44 -04:00
nervere
d04fd9417c removes unused secrets panel button, fixes a button in the global player panel (#43427)
* fixes secrets topic check_antagonist

* removes code related to check_antagonist topic that doesn't work or does nothing

* changes the name of the button in the secrets panel

* removes old secrets panel topic check_antagonist

* player panel antag button no longer relies on secrets topic

* player panel antag button no longer relies on secrets topic

* readds something i shouldnt have removed
2019-04-03 18:21:26 +02:00
ShizCalev
d1c3ac84ba allows byond members to bypass pop cap (#43458)
* allows byond members to bypass pop cap

* fix

* new line
2019-04-03 10:20:03 -04:00
nervere
80ff869077 Fixes for asay, asay darkmode, and asay when custom asay colors enabled (#43422)
About The Pull Request

Fixes several annoying and unintentional things about asay.
Fixes #43370
Changelog

cl Nervere
fix: Default color for when custom asay colors is not enabled is now orange, not red.
fix: Asay is now properly bolded in lightmode.
fix: Asay is now properly bolded in darkmode.
tweak: Default color for when custom asay colors is enabled is now orange, not black.
/cl

closes #43370
2019-04-03 10:51:24 +13:00
Kyle Spier-Swenson
759b2cd436 Made mode selection better (#43334)
Now you can set the mode after the round starts, to be saved as the
default for next round and on

Otherwise you can now choose rather or not the mode change is for the
current round only or saved as the new default mode.
2019-03-27 16:53:12 -07:00
Rob Bailey
ceca1e605e [READY] Yet more darkmode tweaks and fixes (#43306)
* fuck you whoever made the last icon it was garbage

* ticket log fixes

* ticket log fixes

* changes colors from hardcode per line to a define

* some nicer darkmode colors

* asay and ooc name default fixes

* fuck you appveyer build again

* slight brightening of the default font color

* properly fixes tip of the round being hard to read
2019-03-25 20:49:59 +13:00
ShizCalev
93c9fb4cd3 Fix admin follow runtime (#43282)
Fixed a minor runtime caused by admins clicking a follow link while in
the lobby.
2019-03-23 22:50:50 -07:00
ShizCalev
ac9dd6bc09 Remove small text formatting from investigate log (#43273)
there's no reason for it.
2019-03-23 22:50:18 -07:00
Jordan Brown
ac99808e05 Merge pull request #43287 from tgstation/MrStonedOne-webedit-420
On second thought; lets just let the extreme popcap be what it is.
2019-03-23 16:27:51 -04:00
ShizCalev
192a5333c3 Automatic deadminning (#42780)
* does the thing

* cleanup

* unbroke deadminning

param broke the verb somehow? honk.

* correct prefs

* more robust handling

* corrected return, cleanup
2019-03-23 10:46:35 +01:00
Kyle Spier-Swenson
7e2531a924 On second thought, lets just have extreme popcap be what it is
Last pr, i changed it from always looking at living player count, to only looking at living player count in certain situations. These situations came up often enough that it was subverting the intent of the extreme popcap and in some cases allowing 15 players extra on bagil.

It still exempts anybody currently in the round (even dead) reconnecting after disconnecting, except people who observed from lobby.
2019-03-22 20:26:22 -07:00
ShizCalev
5d60f2d568 Merge pull request #43215 from AutomaticFrenzy/patch/throw-exception
Replace 'throw EXCEPTION' with CRASH or WARNING
2019-03-21 23:57:27 -04:00
ShizCalev
1f6008fd4c Merge pull request #43234 from tgstation/MrStonedOne-patch-4
Exempts current players from the extreme pop cap
2019-03-21 23:50:36 -04:00
Rob Bailey
930e9dc501 [READY] Darkmode fixes (#43252)
* better darkmode v1

* ever better colors

* slightly improved tip color + fixed scrolly bug

* updates skin.dmf as well as some small color tweaks

* slightly tweaked more readable info and admin shit

* span_class fix

* merges ooc fixes

* whoops

* MC and ticket screen fix

* no default darkmode

* skin fixes

* more obnoxious adminpm

* more obnoxious adminshit

* skin revert to ensure proper light theme.

* prevents weirdness with default whiteness
2019-03-22 08:56:17 +13:00
Kyle Spier-Swenson
050554dda6 Update IsBanned.dm 2019-03-20 15:20:05 -07:00
Kmc2000
6b6537cccd Adds toggleable darkmode to the game! (#43072)
* Adds toggleable darkmode to the game! (Use the toggle darkmode verb if you want to use light mode)

* Removes a random linechange

* Undo unintentional changes

* Changes some forced font tags to use spans, which won't break darkmode.

* Fixes up some problems I found while testing
Darkmode is no longer default (this caused some issues with people getting a broken chat)

* Darkmode sucks less now

* Darkmode button now works again
2019-03-21 11:02:41 +13:00
Kyle Spier-Swenson
799d45af99 Exempts current players from the extreme pop cap
This will exempt anybody who was once joined into the round, this means people who were assigned at round start or latejoined. even if they died, got gibbed, suicided, or ghosted. This does not exempt people who observed from lobby.
2019-03-20 14:41:48 -07:00
Kyle Spier-Swenson
bf52e95723 If both the extreme and hard caps are active, extreme popcap applies to connected players, not living players. (#43181)
* If both the extreme and hard caps are active, extreme popcap applies to connected players, not living players.

I also have it using the connected players, and not the living players, if the amount of living players can not increase (queue active, entering disabled, round hasn't started, etc).
I also have it allowing the connection if the hard cap is active but has not been hit.

* Redundant if check

* So it occurs to me that IsBanned() gets called by byond on connected players sometimes.
2019-03-21 09:09:11 +13:00
Tad Hardesty
570a4da33e Replace 'throw EXCEPTION' with CRASH or WARNING 2019-03-19 23:09:24 -07:00
ShizCalev
85be0e5804 Fix stealthmin adminpm issue (#43167) 2019-03-19 14:17:27 -07:00
MrStonedOne
186f6c8ddd dbstickybans: Qdeleting queries, misc fixes, Query select proc for executing mutiple queries at once... 2019-03-16 00:23:40 -07:00
MrStonedOne
de220da1e9 Fix compile after rebase 2019-03-16 00:23:40 -07:00
MrStonedOne
54f5e57880 Fixes and improvements 2019-03-16 00:23:39 -07:00
MrStonedOne
81e9150f43 allow ip/cid tracking 2019-03-16 00:23:39 -07:00
MrStonedOne
f0f40bda51 Fixes and improvements. Hub password changes
Uses lazy access on inner lists (had to make lazy access work on inner lists @cyberboss you won't like this but lazyaccess is useless if you can't use it on inner lists)
Byond only does full stickyban matching when the server has a valid hub password set or compiled in, so now we have to remove it during init.
2019-03-16 00:23:38 -07:00
MrStonedOne
214c0de655 Adds automatic importing of older legacy stickybans 2019-03-16 00:23:38 -07:00
MrStonedOne
03f1eb2f2b Some fixes. 2019-03-16 00:23:38 -07:00
MrStonedOne
2e757683ab Database backed stickybans
Supports disabling stickybans for a round, exempting a key from matching a stickyban, and it now also detects rogue stickybans before anybody currently connected even gets disconnected. (new matches trigger a 5 second sleep and abort enforcement if enough other new matches happen in that timeframe)
2019-03-16 00:23:37 -07:00
Tad Hardesty
1433e48eba Fix some proc calls with bad keyword arguments 2019-03-09 12:56:19 -08:00
JJRcop
8748e6d83e Internet midi respects start and end times (#43021)
* Play Internet Sound respects start time
For example, adding &t=400 to youtube links.
Doesn't try to parse the start time, youtube-dl does that for us already. Will probably work on most sites not just youtube.

* [Play Internet Sound] now supports end time too

Switched event handler for start to loadeddata from canplay

loadeddata fires when the first frame is available
this is quicker and more consistent than canplay, which tries
to predict at least a few moments of playability being
available before it fires

* [Internet Sound] music_extra_data now starts null
2019-03-08 10:51:04 -05:00
Menshin
7f9e50c33b Fixes advanced proc calls not working + various code cleaning (#42952)
* Fixes advanced proc calls not working + various code cleaning

* Reverted Destroy() call protection.
2019-03-08 11:33:57 +01:00
ShizCalev
27e8dde837 Merge pull request #43037 from AnturK/missingticketlog
Adds missing logging for admin tickets.
2019-03-08 04:32:37 -05:00
Jordie
6c65780c36 fix some faulty last conn logic (#42984) 2019-03-07 11:03:09 +01:00
AnturK
70f97d34e1 Adds missing logging for admin tickets. 2019-03-06 11:39:09 +01:00
Jordie
49292a20e9 Merge pull request #42861 from tgstation/MrStonedOne-patch-1
Bans now only default to banning ip if a permaban.
2019-02-25 21:15:01 +11:00
Tad Hardesty
3756bbf900 Move GLOBAL_PROTECT statements after their globals 2019-02-21 20:59:41 -08:00
Tad Hardesty
396101e3a1 Fix some incorrect list/ type annotations 2019-02-20 19:54:23 -08:00
Kyle Spier-Swenson
297fe59a0c Update sql_ban_system.dm 2019-02-20 18:21:13 -08:00
Kyle Spier-Swenson
3c10853a7d Bans now only default to banning ip if a permaban.
CID defaults to always checked.

Use IP and CID from last connection now defaults to enabled unless all the default checked values are provided. 

Use IP and CID from last connection now only fills in checked values, rather then forcing both IP and CID.

Use IP and CID from last connection no longer triggers an error if the user can not be found, instead asking the banning admin if the want to continue (same behavior as when this happens without that option checked).

The main reason behind this is that your avg 1 to 2 day ban shouldn't impact everybody on the same network, especially when it comes to colleges and shared internet. The old system worked such that ip bans were only possible on perma server bans, this still gives full flexibility.
2019-02-20 16:18:40 -08:00
81Denton
0195ce430f Add cancel button to ahelp and asay popup (#42835) 2019-02-18 19:58:36 -08:00
ShizCalev
c56869fe0a Fix incorrect var passed to admin makeAI AIize (#42677)
Second param is for the client.
2019-02-05 17:56:35 -08:00
oranges
2b9c04c6ec Merge pull request #42562 from Jordie0608/idontrememberwhythecidcolumnisavarcharsoimnotsureifthatshouldbechangedornot
Banning panel fixes
2019-02-03 22:36:23 +13:00
oranges
cd05d64bcf Species types sources refactor (#42523)
There is now a bitflag that controls all the ways a species can be
selected from the different methods of changing species, xeno spawn,
pride mirror, magic mirror etc.

The soviet and capitalist golems are no longer selectable from the pride
or magic mirrors (just the badmin one)

interesting thing I found, androids and synths (including military
synth) are acheivable via xeno extracts!
2019-02-03 20:33:11 +11:00
Jordie0608
1ed5dc7b95 fixes for non-ckey ban messages and dropping admins on server bans 2019-01-28 22:04:28 +11:00