Commit Graph

11 Commits

Author SHA1 Message Date
SkyratBot
db6f8e646f [MIRROR] Combine roundstart intercept and security level announcements [MDB IGNORE] (#25759)
* Combine roundstart intercept and security level announcements (#80475)

## About The Pull Request

At roundstart when the intercept report is sent, two announcements are
created at the same time. It's loud and overlaps. This combines them
into a single announcement.

Before:

![image](https://github.com/tgstation/tgstation/assets/83487515/024e783a-65d9-4c28-8850-f114b1f020ad)

After:

![image](https://github.com/tgstation/tgstation/assets/83487515/7272f82f-23b4-4e90-99a2-1b590c7d56cf)

## Why It's Good For The Game

Two Centcom or any other announcements playing at the same time
(especially with two different sound files) can be annoying and the
sounds distort each other.

## Changelog

🆑 LT3
qol: Roundstart intercept report and security level announcements are
combined into a single announcement
/🆑

* Combine roundstart intercept and security level announcements

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
2023-12-21 01:24:56 +00:00
SkyratBot
ca931ecdc6 [MIRROR] Improved nightshift check on security level change [MDB IGNORE] (#24695)
* Improved nightshift check on security level change (#79369)

## About The Pull Request

Modifies the security level change proc to only fire the nightshift
subsystem if the subsystem is running, and if a lighting change is
required. If a lighting change is required, nightshift has its next fire
set 7 seconds after, so announcements and sounds don't stack.

## Why It's Good For The Game

Nightshift is only updated when required, eliminating nuisance
announcements when levels unrelated to red/delta are selected.

## Changelog

🆑 LT3
code: Changing security levels will only trigger the nightshift
subsystem if lighting changes are required
/🆑

* Improved nightshift check on security level change

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
2023-10-31 10:24:12 -07:00
SkyratBot
b0fe14e526 [MIRROR] Adds Custom Announcement Dividers [MDB IGNORE] (#24471)
* Adds Custom Announcement Dividers

* Skyrat custom announcements

---------

Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
2023-10-20 14:42:09 -07:00
SkyratBot
466d7a5081 [MIRROR] Emergency shuttle is aware of security level [MDB IGNORE] (#23678)
* Emergency shuttle is aware of security level (#78271)

## About The Pull Request

The emergency shuttle maintains its security level coefficient and does
the calculation instead of outside procs that aren't aware of what alert
it was when the shuttle was first called.

If the shuttle auto-call timer should be capped at the current security
level timer, that can be done in a different PR.

## Why It's Good For The Game

Fixes https://github.com/tgstation/tgstation/issues/78159

## Changelog

🆑 LT3
fix: Emergency shuttle should correctly scale timer up/down when
changing security levels
/🆑

* Emergency shuttle is aware of security level

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
2023-09-13 15:44:24 -07:00
SkyratBot
a00cad0164 [MIRROR] Clean up subsystem Initialize(), require an explicit result returned, give a formal way to fail (for SSlua) [MDB IGNORE] (#16248)
* Clean up subsystem Initialize(), require an explicit result returned, give a formal way to fail (for SSlua)

* [PR for MIRROR PR] Changes for 16248 (#16277)

* Merge skyrat changes, update SR SS's, and remove lobby_eye

* Apply suggestions from code review

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Update modular_skyrat/modules/autotransfer/code/autotransfer.dm

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* restore lobby_cam for now

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

Co-authored-by: Tastyfish <crazychris32@gmail.com>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-09-24 17:32:40 -04:00
SkyratBot
f73c2edb39 [MIRROR] Fixes login() runtime when players connect before SSsecurity_level finishes initializing [MDB IGNORE] (#15704)
* Fixes login() runtime when players connect before SSsecurity_level finishes initializing (#69152)

Fixes login() runtime when players connect before SSsecurity_level finished initializing

* Fixes login() runtime when players connect before SSsecurity_level finishes initializing

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
2022-08-19 12:32:49 +01:00
SkyratBot
ca20cbb5a1 [MIRROR] Fixes security level alerts playing the incorrect sounds [MDB IGNORE] (#15116)
* Fixes security level alerts playing the incorrect sounds

* Fixes the merge conflict

* Slightly improves the code on our end, adds the documentation that we were now missing

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: GoldenAlpharex <jerego1234@hotmail.com>
2022-07-23 16:26:40 -04:00
SkyratBot
0b7aa724b6 [MIRROR] Tweaks response provided by sssecurity_level during initialization [MDB IGNORE] (#14999)
* Tweaks response provided by sssecurity_level during initialization (#68500)

* Tweaks response provided by sssecurity_level during initialization

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
2022-07-18 08:41:38 -07:00
SkyratBot
ea83b1444c [MIRROR] Fixes world status runtiming during initialize [MDB IGNORE] (#14939)
* Fixes world status runtiming during initialize

* Update world.dm

resolve a code conflict

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
2022-07-17 14:34:57 -04:00
SkyratBot
48ac7b572d [MIRROR] Security Level Datums [MDB IGNORE] (#14504)
* Security Level Datums

* wew

* Update security_level_datums.dm

Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
2022-06-25 02:04:50 +01:00
SkyratBot
187119d985 [MIRROR] Security Level subsystem (#4809)
* Security Level subsystem

* aaa

Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2021-04-11 00:11:52 +01:00