* Fixes projectiles facing north if ricocheting, deflected or homing (#85216)
## About The Pull Request
It **turns** out that `TurnTo` doesn't re**turn** `Turn`, but the angle
(number, not matrix) it's **turn**ed to (used nowhere in the code), and
`transform` is built-in variable that default to an identity matrix if
set to an invalid value (anything but another matrix)
The only thing keeping the projectiles facing the right direction when
fired up to one of the aforementioned situations was another `Turn` call
(not `turnTo`) called on `projectile/fire`, which I apparently didn't
fully grasp the redundancy of (if there were no such issue to begin
with) at the time.
This PR also cleans up and rearranges the related code a little,
including a fallback that was never reached because the projectile
`Angle` variable is never null (unless something theorically fucky wucky
happens with projectile code but that'd be an even bigger issue).
## Why It's Good For The Game
Fixing an old issue caused by the author of this PR in #80599, me.
## Changelog
🆑
fix: Fixes projectiles facing north if ricocheting, deflected or homing
/🆑
* Fixes projectiles facing north if ricocheting, deflected or homing
---------
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Implements rgb2num, uses it to replace all our manual rgb reading. Redoes HSV management (#81182)
[Converts all manual extraction of rbg with rgb2num. It's just
better](ae798eabd5)
[Yanks out old HSV management, replaces it with list
stuff](4997e86051)
There's this old lummy era clunky code that passed HSV as text
We can now cleanly replace it with passing hsv as lists from a rgb2hsv
proc
So let's just do that.
Also, cleans up spraytan code (and ethereal lighting)
Code better
* Refactors fire overlays once again to make it not get stuck so often (#81367)
Maybe finally fixes#77701
A big reason why this kept happening is because fire uses standing
overlays. But fire isn't managed by mobs anymore. Meaning in some
situations, fire can cease to exist but the overlay can still be on the
mob. So it gets stuck.
So like, why use standing overlays anymore? We can just hook
`update_overlays` signal.
Isn't that neat.
🆑 Melbert
refactor: Fire effects get added to mobs in a different way now. Maybe
it will get stuck less. Report any oddities.
/🆑
* Fix Flaky Failure From Fire (#81399)
## About The Pull Request
Closes#81396 , Closes#81391 , Closes#81403, Closes#81402
I don't know why but I thought this proc was only called once, when the
mob entered the turf. That was silly.
And going back at it, I'm not entirely sure why I tied
`TRAIT_NO_EXTINGUISH` to the element anyways, rather than the lava like
it originally was.
While going back over this, I cleaned up the proc a bit.
## Changelog
Not necessary
* There we go?
* Bruh moment
---------
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* Color matrix defines for filters and identity (#80320)
This PR converts the procs `color_matrix_identity`,
`color_matrix_lightness` and `color_matrix_contrast` into
defines/macros. Also adds in defines for common color matrix filters.
I don't like how `color_matrix_identity` is a one-line proc with no arg.
Also these help people identify the sort of color matrix filter is being
used.
* Color matrix defines for filters and identity
---------
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Adds a unit test for client colours. (#77484)
## About The Pull Request
I'm adding a unit test for the sanity of client colours, ancient datums
which I had refactored a long time ago. This also affects the
`color_to_full_rgba_matrix()` proc, which I had also worked on.
## Why It's Good For The Game
Ever since that aforementioned years old refactor, there have always
been a few issues with client colours.
The most annoying one being the monochromacy client color lingering even
after the blindness status effect is ok.
It's unlikely this will fix that. However, this should clear a few other
runtimes with the feature.
## Changelog
N/A.
* Adds a unit test for client colours.
---------
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* [Ready] Makes the admin-only high frequency blade !FUN! and adds it to the spellbook (#63861)
* makes the vibro sword fun
* AND IT WILL COME LIKE A FLOOD OF PAIN
* POURING DOWN ON ME
* AND IT WILL NOT LET UP
* UNTIL THE END IS HERE
* AND IT WILL COME THROUGH THE DARKEST DAY
* IN MY FINAL HOUR
* AND IT WILL NEVER REST UNTIL THE CLOUDS ARE CLEAR
* only love is with us now
* something warm and pure
* find the peace within ourselves
* no need for a cure
* MAKING WHOLE THE FABRIC OF SOCIETY
* COLLECTIVE CONSCIOUSNESS CONTROLLED AS YOU WILL SEE
* MIND CONTROL
* WOOOOOOOOOOOOOOOOOOOO
* YEAAAAAAAH
Co-authored-by: Urumasi <Urumasi@ email.cz>
* decompose that matrix bitch ass
* sord
* you will die
Co-authored-by: Urumasi <Urumasi@ email.cz>
* [Ready] Makes the admin-only high frequency blade !FUN! and adds it to the spellbook
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Urumasi <Urumasi@ email.cz>
* Merge pull request #53976 from nicbn/something-refactor
Makes cameras process transforms instead of reading mob angles
* Makes cameras process transforms instead of reading mob angles
Co-authored-by: nemvar <47324920+nemvar@users.noreply.github.com>
Several of the greps were missing the `-P` switch which caused them to
fail to match things. The EOL grep also wasn't working right so I
replaced it with the one I added to TGMC.
* Skewium: It'll fuck you up.
Adds some matrix helpers for dealing with skews
Adds Skewium, it's like rotatium, but for skews instead of rotation, it's horrible
* switches back to boxstation from runtimestation
Better comments explaining the purpose of everything
Better name scheme: color_matrix_foo() instead of just color_foo()
Contrast was completely wrong. Total derpage, formula is now right
A few examples of interesting and useful matrices. And by "a few" I mean 3, but whatever
Addition and multiplication
Single-axis rotations
color_matrix2color_hex and color_hex2color_matrix in case anybody wants to convert back and forth for whatever reason
All values within the matrix are rounded to the thousandths place to cut down on floating point error and 1.000000001 type values
Contrast, saturation, brightness, and rotation. Still need to do multiplication, addition, and negation, but this is a start.
Here's the testing snippet I used to play around with these: http://pastebin.com/BgBtmhMN
* returns a turf closer to the center in even multiples of world.icon_size (64,128, etc.)
* Handles irregular (non-world.icon_size sized objects) better
* Now handles Matrix X/Y shifts
* Orbit is now less reliant on Animate(), for most ghosts this means 36 calls to Animate, vs the previous INFINITE, for those of you with potato computers, this should ease the pain and crashing.
* Orbits can now be something different to circles!
* Ghosts Byond Members can now choose between orbits! (Circle, Triangle, Square, Hexagon)
Spent casings ejected from firearms will spin as they 'tumble' towards the ground.
Improved sprites for shotgun shells
Improved sprite for bullet projectile.
Cloakers still don't work well. The fix is probably just finding a proc that runs on equip/uequip/when bagged/when dropped. Fuck that. Ninjas work. Things that are cloaked fade to the cloaked alpha, it's pretty cool.
The "lying down" icon_states for everything you could equip are all now unnecessary. They aren't removed yet though.
The dmi changes are to make xenos all face upward so when they turn, they're lying down rather than facing south and looking like they're doing a handstand. They're not terribly good when facing the wrong way. I expect WJohnson to have a fix for this by New Year's.
Comments aren't changed. The overlays_standing list is still around because overlays is not a normal list, and BYOND's normal list functions are worth the extra cost of keeping a spare list of images.
