Commit Graph

430 Commits

Author SHA1 Message Date
lessthanthree
6ce0d4d76c bubber edits 2024-11-14 15:47:07 -08:00
Kingsley-95
eb9d658baa Banana Slippers (#2323)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
The Slipers (the single p is purposeful). 

A new clothing item takes a similar role to a bola. When thrown, if
aiming at either leg, it will try to knock off the shoes of whoever is
it, then, equip onto them. Once equipped, they will be unable to take a
step without being slipped. Additonally, if they are slipped, anybody
who walks over them will ALSO be slipped. And the item itself is
slippery. Because they are banana shoes, get it?

Finally, if hit with these banana boots, the wearer is unable to remove
them, someone will need to strip them off.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
More variety in trouble making tools that isnt another shoot shoot bang
bang.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing
https://youtu.be/jyodCikoiXw
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
<details>
<summary>Screenshots/Videos</summary>

</details>

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
add: Slipers, a new traitor item which can be bought from the uplink
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
2024-11-12 22:28:25 +00:00
Alexis
6b82dc3de6 Adds a new emote: Bonk (#2251)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Have you ever wanted to bonk someone on the head? Well now you can with
the [*bonk emote](https://www.youtube.com/watch?v=C0XF57pK67g). Just aim
at someone's head and hit them with the hand. I'd advise against doing
it to borgs or synthetics though.. that sounds painful.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
More variety of emotes.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing
It compiled and ran on my end without any runtimes or errors. Everything
has been tested to work.
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
<details>
<summary>Screenshots/Videos</summary>


https://github.com/user-attachments/assets/8e1ca604-4bd5-4300-adf6-23b194eea623


</details>

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
add: added a bonk emote
sound: added the coconut hit 01 sound effect to the code
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-11-12 08:44:57 +00:00
Shadow-Quill
2de20db146 Fixes pinwheel hats (#2390)
## About The Pull Request

Changes a line of code to a parent call.
Also adds animation states for the item itself.

## Why It's Good For The Game

Whee.

## Proof Of Testing

Tested locally, works.

## Changelog

🆑
fix: Re-greased all pinwheel hats in the sector. Happy spinning!
image: Added animation sprites for the hat icon. Twice the spin!
/🆑
2024-11-12 08:16:04 +00:00
Swift
c6ab1e362a Phasic strilka ammo no longer printable (#2394)
## About The Pull Request

Title

## Why It's Good For The Game

There's no reason people should be running around with it

## Proof Of Testing

I didn't test it

## Changelog


🆑
del: Phasic strilka ammo is no longer printable.
/🆑
2024-11-10 19:23:20 -07:00
Alexis
9ea7b9fda3 Fixes DNA Vault genes being saveable (#2377)
## About The Pull Request
As the title says, fixes
https://github.com/Bubberstation/Bubberstation/issues/2359.
## Why It's Good For The Game
The DNA vault genes being abused to power game is objectively bad for
the game.
## Proof Of Testing
It compiled, ran, and I was unable to save a DNA vault gene to the
console when testing on a localhost.
## Changelog
🆑
fix: fixed DNA Vault genes being able to be saved on a gene console
/🆑
2024-11-10 20:42:34 +00:00
Alexis
fb86569908 Adds the colored glasses to loadouts (#2373)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Per [this
suggestion](https://discord.com/channels/1059199070016655462/1071095123145924679/1302584237416779897),
adds the colored glasses to the loadout.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
More variety for loadout gear is always good, plus as it stood the item
was unobtainable.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing
They showed up in the loadout menu when I tested it on a localhost.
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->


## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
add: added the colored glasses to the loadout
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-11-10 10:18:40 +00:00
BurgerLUA
8b244b25c2 Adds a new snout option for lizards along with a horn option. (#2370)
## About The Pull Request

Adds a new snout option for lizards along with a horn option.
Specifically, "Full Stubby" horns, and "Full and Thick" snout.

## Why It's Good For The Game

:)

## Proof Of Testing

It just works.

## Changelog

🆑 BurgerBB
add: Adds a new snout option for lizards along with a horn option.
/🆑
2024-11-10 10:02:51 +00:00
Waterpig
938fb581f5 Malf AI RCD blowup only targets station RCDs (#2374)
## About The Pull Request

See name. Also fixes some needlessly heavy code

closes #2268

## Why It's Good For The Game

Tarkon and Dauntless getting exploded because of something they do not
need to care about is stupid.

## Proof Of Testing

Seemingly worked fine

## Changelog

🆑
balance: AI RCD explosion ability can no longer take out nonstation RCDs
/🆑
2024-11-09 11:25:23 +00:00
Waterpig
1a7d805bb6 Brings back the old sombrero (#2358)
## About The Pull Request

Reintroduces the sombrero to the vendors and adds it to the loadout.


![image](https://github.com/user-attachments/assets/2449b383-fb3f-4eec-9289-c86e10ff2e36)

As beautiful as the day we lost it. Also makes it not hide hair

closes #2355

## Why It's Good For The Game

Cool item to add to char design, and keeps you from dying on
moonstation!

## Proof Of Testing

<details>
<summary>Screenshots/Videos</summary>


![image](https://github.com/user-attachments/assets/bd563ff7-78a6-4fed-8400-31e5406ceadd)

</details>

## Changelog

🆑
add: Sombreros return to clothes vendors and loadouts
qol: Sombreros no longer make you bald
/🆑
2024-11-09 00:17:49 +00:00
Lasshy KorshBot
fc9c77261f Adds Hemoglobin Iced Tea, a drink for hemophages (#2343)
## About The Pull Request

I play hemophages sometimes and we're constantly low on blood unless
we're bugging genetics or medical or the bar. So just how synths have a
welding fuel drink, I'm making hemos a blood drink. Sprite by me.


## Why It's Good For The Game

This is great for hemos, bloodsuckers, and in a pinch when someone is
low on blood, I suppose.

## Proof Of Testing

Took a dumb little video:


https://github.com/user-attachments/assets/13bedf27-a630-4467-b85d-1c7d6cc5d05e

summary>Screenshots/Videos</summary>


## Changelog

🆑
add: Added sprite for blood_tea
add: Added vending machine option for blood_tea
/🆑


---------

Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-11-08 22:08:04 +01:00
Waterpig
d19bf6c1cd Makes loadout renamed items able to be examined when worn (#2349)
## About The Pull Request

When an item is renamed due to loadout settings, it shows up as
clickable on the examine of the person wearing it.


![image](https://github.com/user-attachments/assets/3134b0de-6a23-4037-8d8f-92e22bb74456)

Clicking this link then makes the user examine this item further


![image](https://github.com/user-attachments/assets/6dad0d75-d363-47d6-9f98-9ab9107acee7)

## Why It's Good For The Game

Allows people's neat loadout item descriptions to be visible from an
examine without any stripping needed. This means more reason to
customize these items.

## Proof Of Testing

See above

## Changelog

🆑
add: Loadout renamed/redescribed items can be examined when worn.
/🆑

---------

Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
2024-11-08 19:53:23 +00:00
Midiwidi
728a4b2505 Added science bag to SciDrobe (#2372)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Very tiny PR. Adds the science bag to the SciDrobe.

## Why It's Good For The Game

There are only 2 science bags in xeno. If they both get lost, you can't
really do Xeno anymore. I mean you CAN, but it really sucks.

## Proof Of Testing

Ran the Runtime Station. Spawned a SciDrobe. Science bag is in there.

</details>

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑 Midiwidi
add: Added science bag to SciDrobe
🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
2024-11-08 12:24:34 -05:00
Waterpig
2c5c136d73 adds suspicious protogen plush (#2352)
## About The Pull Request

Adds another plush, this time requested by Vanilla. Available from
loadout.


![image](https://github.com/user-attachments/assets/56b6f893-183a-4e54-baf6-1a112db04c19)

## Why It's Good For The Game

Cool extra plushie

## Proof Of Testing

See above

## Changelog

🆑
add: Suspicious protogen plushie
/🆑
2024-11-08 06:13:56 +00:00
Waterpig
12f61ac2ae Fix varnames and spelling in physgun and phystool (#2361)
## About The Pull Request

I was recently bugfixing these and discovered how bad the english on
these is. How this passed review is beyond me.

## Why It's Good For The Game

Spellcheck good

## Proof Of Testing

Varname changes, should be fine

## Changelog

N/A
2024-11-07 23:05:59 +00:00
Adrian16199
9527399e10 Digi-zombies, attempt numbero 2 (#2259)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
I fucked up the first time, will try again. 
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
Its basicly a fix to something that I failed to do and i feel shame for
it.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing

![image](https://github.com/user-attachments/assets/2bb0ac5d-96c1-4c10-998a-db6e21244979)

<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
<details>
<summary>Screenshots/Videos</summary>

</details>

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑

fix: Made HFZ actualy be able to have digitigraded legs for real this
time.

/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
2024-11-07 17:44:20 +00:00
Return
15ad95552c Nerfs the Default slightly (#2353)
## About The Pull Request
This makes the Default roll less mundane events, to 9 from 18. Mundane
events would run every 10 minutes, and do things like give diseases,
cause scrubber overflows, and more. These are important events, but
should be less common.

## Why It's Good For The Game
Less mundane event spam. I did this on the Chill previously and it had a
significant positive impact.

## Changelog

🆑 ReturnToZender
balance: Default Andy will spawn mundane events half as frequently.
/🆑

---------

Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-11-07 13:40:18 +01:00
Waterpig
b8f00860e4 Afterattack fixes (#2350)
## About The Pull Request

See name, I'm actually going through with it and doing it.

## Why It's Good For The Game

Fixes broken item interactions

closes #2253
closes #2204

## Proof Of Testing

Worked on my device (So far)

## Changelog

🆑
fix: Phystool and Physgun work correctly again
fix: Clockcult slabs can examine again
fix: Compostbin is now handled correctly
fix: Robohand checks for robohand again
/🆑
2024-11-07 09:42:41 +01:00
nevimer
b93fc1bb83 Patches a bug with adding vetted users. (#2200)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

bugfix, speedmerge?

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
bugs are not good

## Proof Of Testing

<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
fix: vetted list now doesn't wipe the admin who added field on reload
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
2024-11-06 11:39:02 +00:00
xXPawnStarrXx
81c7ccb60e Limbgrown bodies. (#1842)
## About The Pull Request

The limbgrower was an often underutilised item, it was only really
useful for bounties, because most medical staff never checked if their
~~victim~~ patient was a body purist or not. They'd just jam them full
of parts and off they go. This allows an easier method (if not more
expensive) to getting corses for body transfers. I have also added blank
brains for the niche reason of RSD phylacteries for those who were
completely gibbed or dusted to be able to return to the round.

Made it so that hopefully; Ghosts can be added to the round via soul
phylacteries. If we can have golems, ashwalker eggs, cyborgs and such
that accept ghosts and can allow players to add ghosts to the round,
soulcatchers shouldn't be so restrictive.

EDIT: As per request, I have removed monkeydone too, so the recipe will
no longer be available.

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game

Miners who get gibbed, dusted or just trapped deep in lava.
Genetics gets to keep their monkeys.
Coroners have more to do, by printing, preserving and prepping corpses
for revival.
More uses for the limbgrower and less CBT of restraining a feral
monkeyman.


## Proof Of Testing


![image](https://github.com/user-attachments/assets/7edacc4f-82be-4f8c-8460-97fa022dd62a)


## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
add: Added blanks to the limbgrower, for soul/brain transfer.
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-11-06 11:07:55 +00:00
Arturlang
48ebc3ca8a removes the second wound healing in bloodsucker organ healing (#2205)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
I'm dumb and didn't see the second near-identical one.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
It's uselessly healing wounds a second time for no reason
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing
it compiles
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

no CL

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
2024-11-05 23:25:57 +00:00
xXPawnStarrXx
948bbe9419 Adds clarity to prisoner bounties. (#2313)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

In short, all this does is change the lines of text when you examine
your ID card or insert it into the console. Because they were vague as
all hell before.

## Why It's Good For The Game

Stops this... What bounty is this? I made ten like this unaware it does
not display the name.

![image](https://github.com/user-attachments/assets/a4aa1ac6-202c-4a27-86bd-bfadebd93b3a)


## Proof Of Testing

<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
<details>
<summary>Screenshots/Videos</summary>


![image](https://github.com/user-attachments/assets/9a03b03c-0f58-4638-bfd9-60efef25e9fc)


</details>

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
spellcheck: made prisoner bounties list what you're after rather than
"fruit" or "flowers"
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
2024-11-05 22:26:03 +00:00
Arturlang
77e3f8bcfa Prevent ventrue bloodsuckers from self-softlocking by choosing a revenge vassal (#2218)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
If a ghoul 's first vassal is set to be a ghoul vassal, they can be
rendered unable to level due to not being able to get a favorite vassal
due to lack of ghoul slots
Also changes ghoulization to ghouling, something that i had asked to be
done
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
Ghoulization doesn't make any sense as a word, also preventing softlocks
is good
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing
The ghouling prevention part is thoroughly tested ingame
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
add: You are now prevented from making a revenge vassal as a ventrue
bloodsucker if you do not have any ghoul slots free to prevent softlocks
add: Changes ghoulization used in bloodsuckers words to ghouling
fix: Ghoul antag panels now work again
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
2024-11-05 21:57:07 +00:00
Kingsley-95
95ba7767ec Adding Jackal tail (#2311)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Taking a tail from another server and porting it over here

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

Adding new tail sprites

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->


## Why It's Good For The Game
More customization, more fun
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing


![image](https://github.com/user-attachments/assets/ff4616c3-c16c-4492-a741-a3fa9ab68044)

![image](https://github.com/user-attachments/assets/a3fc1878-6301-4e49-a294-ded519811b08)

![image](https://github.com/user-attachments/assets/bae55883-9d2a-4a93-a763-e7ee7ebdfdcd)

![image](https://github.com/user-attachments/assets/a29916d2-7947-44c7-8d3b-26fbb19bd6d4)

![image](https://github.com/user-attachments/assets/461664b9-576a-4284-a929-9bf42855eabe)


<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
<details>
<summary>Screenshots/Videos</summary>
Set above for screenshots of the new customization option. Was mainly
using this to start learning the code base and see if I could get my
development environment set up. Things are looking good on that end
</details>

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
add: Black-Backed Jackal tail
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
2024-11-02 21:05:22 +00:00
Alexis
6d5674be07 Adds a toggle credits preference (#2320)
## About The Pull Request
As the title says, it's found in the Gameplay section of game
preferences.

## Why It's Good For The Game
I've seen a lot of people asking for it, plus it doesn't immediately
cover your screen if you have it off, so you can continue whatever you
were doing without getting your screen covered by it.

## Proof Of Testing
It compiled and ran on local host

## Changelog

🆑
qol: you can now toggle seeing end credits in preferences
/🆑

Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-11-02 21:01:05 +00:00
Roxy
52c8a43d33 Fix storyteller null event runtime (#2319) 2024-11-02 13:32:43 -06:00
Jinshee
f02e0f7584 Gecko Tail! (my branch was out of date) (#2309)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

yeah i https://github.com/Bubberstation/Bubberstation/pull/2300

## Why It's Good For The Game

## Proof Of Testing

check last pr

## Changelog

🆑
add: New gecko tail!
/🆑

Co-authored-by: Jinshee <manastra2536@gmail.com>
Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
2024-11-01 16:50:27 +00:00
Return
01af986153 Buffs the Chill (#2290)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
This PR makes the Chill fire mundane events less frequently, as well as
crew antags less frequently. (from every 40m to every hour)
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
The Chill currently doesn't feel significantly different from the
Default, only having a difference in Mundane events, which ultimately
aren't the most significant actor.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing
WE DO IT LIVE
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑 ReturnToZender
bal: Makes the Chill spawn antags less frequently, and spawn less
events.
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-10-31 08:23:50 +00:00
Arturlang
877552fb25 Gives the sol weakness quirk users some leeway again vs being burnt to death (#2260)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Gives hemophages back some leeway vs burns
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
Somehow in the pull this was somehow changed? I'm not sure how as I
can't figure out it in the git diff
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing
uhh, it compiles?
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
fix: Hemophages are now set alight at 397.6 blood again
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
2024-10-30 10:15:13 -07:00
Waterpig
bef2713b56 Adds the annoying cat plush (#2296)
## About The Pull Request

Adds a silly plush that combusts upon being touched by other plushies.
Available in loadouts.


![image](https://github.com/user-attachments/assets/473a8899-6299-4ecd-8743-e9d7853caf19)

## Why It's Good For The Game

I was asked to add this 

## Proof Of Testing

See above

## Changelog

🆑
add: New annoying cat plush for Kurzaen, available in loadouts
/🆑

---------

Co-authored-by: Odairu <39929315+Odairu@users.noreply.github.com>
2024-10-30 08:52:39 +00:00
LT3
1cd7eda66c Fixes *meow and *purr emotes (and other emote third person keys) (#2278)
## About The Pull Request

MEOW MEOW MEOW

Fixes meow and purr after TG added pet emotes. Also fixes a bunch of
third person keys used incorrectly.

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game

MEOW

## Proof Of Testing


https://github.com/user-attachments/assets/313f0141-56fd-43e1-9133-44c462b6c05f

## Changelog

🆑 LT3
fix: Fixed meow and purr emotes playing the pet line instead of the
emote line
/🆑
2024-10-28 21:52:20 +00:00
GyrPhlymBaBumble
0e4e2e8811 Adding Science Haydee (#2262)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

These changes add 1 new cyborg frame for the research/science Module.
This involved updating robot_defines, uploading the files, and adding
the robot to robot_model.dm

This was tested on a private server, and it all seemed to work properly.
The borg does not have resting animations, but does have open cover
sprites.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game

This adds an additional Haydee borg to further round out the jobs
players who want to use this model type can use, [based on my earlier
PR](https://github.com/Bubberstation/Bubberstation/pull/1826). It is
just a reskin, and allows those who want to use a more 'attractive' borg
model to do so.
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing

![image](https://github.com/user-attachments/assets/5d74ec23-d1a7-4f4d-a83c-b169e4fd2ef8)

<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑 Flvffi
add: 1 Haydee borg skin for the Research role
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
2024-10-27 21:35:44 +00:00
Lasshy KorshBot
505ae89a48 Adds *yip and *yipyip (#2254)
yip yip!

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

It adds *yip and *yipyip, because I want the kobolds to make NOISE.

## Proof Of Testing



https://github.com/user-attachments/assets/d7baa626-656e-4a46-b300-d2314fdc8796


https://github.com/user-attachments/assets/acff25e6-5061-486e-86b8-d385b92debee





## Changelog

🆑
add: *yip
add: *yipyip
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
2024-10-27 02:59:15 +00:00
Alexis
0866418027 Adds a GAGS miniskirt to the loadout (#2269)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
As the title says
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
Currently the ONLY way to get a miniskirt is to steal a security
miniskirt from a SecDrobe, this makes it so you can get a (non-armoured)
one in the loadout as anyone, plus it's recolourable!
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing

<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
<details>
<summary>Screenshots/Videos</summary>


![image](https://github.com/user-attachments/assets/f398400d-abd4-4332-a67e-a7031d3a7516)


![image](https://github.com/user-attachments/assets/f585e98b-9c7b-4ee7-9871-3ff59bc56611)

</details>

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
add: added a GAGSified miniskirt to the loadout menu
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
2024-10-27 00:27:50 +00:00
LT3
dd02f7c015 halloween: a 2spooky update (#2211)
## About The Pull Request

A little package of Halloween goodies and fixes.

- Meteor wave adjustments
- - Adds Halloween candy meteors (and later, potentially Christmas and
Easter)
- - Adjusts timings, giving more time to set up shields for threatening
events, faster start when there's no time to order shields
- - Clips the long meteor alert announcement sound to a better length
- Fixes holiday event spawns, making them Storyteller compatible and
properly trigger at round start
- Extends the Halloween holiday datum to two weeks (not applicable to
Halloween races)
- Adds a bunch of tile variations so that we aren't staring at the same
pattern for a month straight

## Why It's Good For The Game

Adds some more flavour for a holiday that is kinda lacking for something
that runs for more than a few days.

## Changelog

🆑 LT3
add: Halloween candy meteors
fix: Halloween, Easter, and Valentines Day events correctly trigger at
roundstart
image: More Halloween holiday tile patterns
sound: Reduced length of meteor alert warning sound
balance: Adjusted warning time for meteor waves depending on intensity
/🆑

---------

Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
Co-authored-by: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
2024-10-26 00:36:41 +02:00
Waterpig
668cfb918b Merge branch 'master' into upstream-24-10b 2024-10-25 23:27:13 +02:00
Waterpig
138be45f92 upstream-24-10b 2024-10-25 23:25:17 +02:00
nikothedude
86c1d1c1a3 Yet again, fixes naga footsteps (#2250)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Closes https://github.com/Bubberstation/Bubberstation/issues/2245

We need to make sure the args match human args.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game

bugs bad

<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing

<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->
<details>
<summary>Screenshots/Videos</summary>


https://github.com/user-attachments/assets/8c6684de-e7da-4b58-848c-1e312e4efb6a

</details>

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
fix: Nagas no longer play human footsteps
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
2024-10-25 19:55:06 +00:00
LT3
2c40305fe7 Company imports medical balance (#2222)
## About The Pull Request

Split off from https://github.com/Bubberstation/Bubberstation/pull/2125
with just the medical portion of the balancing.

## Why It's Good For The Game

Makes the price of the packs better align with the cost of production
and the vending machine prices.

## Proof Of Testing

We've TM'd it a bunch.

## Changelog

🆑 LT3
balance: Balanced company imports DeForest Medical section
/🆑
2024-10-21 23:03:08 +00:00
Majkl-J
ff590ce7b4 getting it to compile 2024-10-20 04:26:59 -07:00
Arturlang
b91f49ea0b fixes blood level gain (#2217)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
I am dumb and nobody checks my code, and unconditionally trusts me.
Fixes blood thickening point gain
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
Bloodsuckers can't level past 3
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing
Tested ingame
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
fix: Bloodsuckers now get blood thickening points
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->
2024-10-18 21:44:35 +02:00
Arturlang
b0a8283f03 removes the malus for blood level gain for drinking from ghouls/vassals (#2210)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Removes the malus for blood level gain for drinking from ghouls/vassals,
as it's just unnecesary as feed already prevents from drinking too much
from non-unique people.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
It's a big too tough and kind of punishes for making ghouls/vassals,
which I don't want
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing
Compiles
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
balance: Drinking from ghouls/vassals as a bloodsucker is no longer is
1/4th less effective than drinking from non ghouls/vassals
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-10-17 05:41:58 +00:00
Bangle
119322ed27 More Alternate Job Names! (#2202)
## About The Pull Request

We already have a boat-load; why not more?

**Blueshield:**
- Command Protection Officer

**Detective:**
- CID Officer

**Nanotrasen Representative:**
- Corporate Consultant

**Security Officer:**
- Security Specialist
- Defense Contractor

**Shaft Miner:**
- Dredger
- Contract Miner

I have not tested this. It _shouldn't_ have issues, given it's just a
few more alt-job names, all properly formatted.

## Why It's Good For The Game

It gives players more options as far as who they feel they're playing
as. I know there's a Security Union, for example, that may want to be
represented differently.

## Changelog

🆑 Bangle
spellcheck: Added some alt titles
/🆑

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
2024-10-15 16:23:45 -07:00
sippykot
5d6119ac9e add surgical medkit to cargo (#2195)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Adds surgical medkit to cargo goodies
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
Items you can only get at roundstart are bad, ackshually
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing
i ran it, it works, it's a really simple change
<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
add: you can buy the surgical medkit in cargo now

/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
2024-10-12 20:49:22 +00:00
LT3
996aa5a740 Replace modular medsecHUD with TG version (#2192)
## About The Pull Request

TG now has the medsecHUD upstream, removes the modular Bubber version.
Instead applies the bluesec SR icons to the variants.
Adds the medic vest/labcoat to the orderly garment bag
Reduces the amount of full spare Orderly gear sets from 2 to 1.

## Why It's Good For The Game
- Code/item duplication
- Orderly drip

## Proof Of Testing


![image](https://github.com/user-attachments/assets/d92fffd9-e0c2-4b27-b189-690276c84160)

## Changelog

🆑 LT3
code: Bubber medsecHUD replaced with TG version
add: Medic labcoat/vest added to Orderly garment bag
/🆑
2024-10-12 20:37:48 +00:00
Odairu
4a00176533 [modular] Adds a silicon manager PDA app similar to the Job manager app the HoP gets (#1933)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Allows for the prioritizing of silicon jobs (AI/Cyborg) so they show up
on the join menu, you cannot add or close slots, and it can be
downloaded and used as long as you have Robotics Access on your ID
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

<!-- Please make sure to actually test your PRs. If you have not tested
your PR mention it. -->

## Why It's Good For The Game
Every other job can be prioritized, these two should be able to be as
well
<!-- Argue for the merits of your changes and how they benefit the game,
especially if they are controversial and/or far reaching. If you can't
actually explain WHY what you are doing will improve the game, then it
probably isn't good for the game in the first place. -->

## Proof Of Testing

![image](https://github.com/user-attachments/assets/33b1aaa0-e2a4-416f-87e2-f08c37aef861)

![image](https://github.com/user-attachments/assets/393e1548-dda0-4a41-a299-b4c51501a08b)

<!-- Compile and run your code locally. Make sure it works. This is the
place to show off your changes! We are not responsible for testing your
features. -->

## Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
mark your PRs to prevent unnecessary GBP loss. You can read up on GBP
and its effects on PRs in the tgstation guides for contributors. Please
note that maintainers freely reserve the right to remove and add tags
should they deem it appropriate. You can attempt to finagle the system
all you want, but it's best to shoot for clear communication right off
the bat. -->

🆑
add: adds silicon manager pda app
/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: projectkepler-RU <99981766+projectkepler-ru@users.noreply.github.com>
Co-authored-by: LT3 <83487515+lessthnthree@users.noreply.github.com>
2024-10-12 18:20:11 +00:00
Otome
02ca23eaf0 Lizard Gas Redux - Now with Ghost Role (#2188)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Remodels the interior of Lavaland and Icemoon Lizard Gas and adds a
ghost role to all three stations!
That's right! The space one has a spawner too!
Lizard gas gets its own uniform!
<details>
<summary>Full change list</summary>

- A locker with a pipe rifle and hunter rounds, as well as flatpack
machines so you can actually survive.

- A bathroom!

- Adjusted stock to more fit a gas station

- Lizard Gas has a purple uniform to match the plasma fueling station!
(with digitigrade leg variant)
</details>

<details>
<summary>Visual comparisons</summary>

- Lavalands Gas Station

![lavalandcomparison](https://github.com/user-attachments/assets/e34c8c19-d1fd-42c0-a4d4-b2a5b628a1c3)

- Icemoon Gas Station

![icemooncomparison](https://github.com/user-attachments/assets/0957b5f4-122d-4b48-b512-e20dad1bea21)

- Space Gas Station

![spacecomparison](https://github.com/user-attachments/assets/e0c4a503-f2bd-4985-b429-22b3ba95f361)

</details>

## Why It's Good For The Game

Was made for a suggestion by Gearsin on discord.

https://discord.com/channels/1059199070016655462/1071095123145924679/1292324881962373191

## Proof Of Testing


![2024-10-07_16-15-40](https://github.com/user-attachments/assets/2014e1b1-ab0e-4ff4-b137-d556e3d8fa55)

![dreamseeker_2024-10-07_16-43-16](https://github.com/user-attachments/assets/947ee1c8-deb0-4d3b-9332-d91648c55607)

## Changelog

🆑
add: Lizard Gas can actually be staffed now!
/🆑

---------

Co-authored-by: The Sharkening <95130227+StrangeWeirdKitten@users.noreply.github.com>
2024-10-11 23:56:19 +00:00
Bangle
99ba3fd1da Bangle Sprites & ONE Laser Sound (#2173)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
An effort to diversify and enhance the sprites of Sec weaponry. See
[this](https://github.com/Skyrat-SS13/Skyrat-tg/pull/23424#issuecomment-1722751802)
for my extensive reasoning and breakdown of _why_ I believe this to be
the correct course of action.

To clarify what's changed:

1. The Marksman Rifle
2. The LMG
3. The Carbine
4. The Battle Rifle
5. The Sindano
6. The Renoster


![372653181-71647083-077c-4c57-848c-dcfddba96161](https://github.com/user-attachments/assets/f1ceff9c-ff57-42bd-82de-19e3b0a89187)


I have not tested this PR. **Through faith alone**, the sprites will
prevail.

## Why It's Good For The Game
Because the original sprites all had the same silhouette and
color-scheme and were in need of significant change.

## Proof Of Testing
I did no testing. Reference this:

![image](https://github.com/user-attachments/assets/0aea935c-294b-4b64-887c-c987199a37a0)

![Sprite-0003](https://github.com/user-attachments/assets/681b7e6d-0d2b-42e2-b1e4-59cf72332473)


## Changelog
This bounces off of
[this.](https://github.com/Bubberstation/Bubberstation/pull/2168).

Finally added carbine sprite.

🆑 Bangle

image: added/modified/removed some icons or images

/🆑

<!-- Both 🆑's are required for the changelog to work! You can put
your name to the right of the first 🆑 if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-10-11 17:47:21 -06:00
Mitryll
9cdd674b2d Adds *squeal and *tailthump (#2187)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

Adds two emotes, squeal and tailthump. Mainly meant for lizards but
they're just fun sounds in general. Sounds graciously "borrowed" from
Shiptest.

## Why It's Good For The Game

*tailthump(x99)

## Proof Of Testing

See attached video. Compiles and runs.

## Changelog

🆑
add: Added *squeal emote
add: Added *tailthump emote
sound: Added sounds for *squeal and *tailthump
/🆑

https://github.com/user-attachments/assets/bbf86a72-2de7-4447-a6d2-afb25006cb2d

---------

Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-10-11 00:10:42 +02:00
Cursor
0077be5e32 [Ready][Until ANOTHER FUCKIMNG MERGE CREATES CONFLICTS GOD FUCK] Reflavors a lot of Bloodsucker stuff to be more in line with it's source (#2104)
## About The Pull Request

Title.

## Why It's Good For The Game

My love of VTM cannot stand things such as 'blah-sucker', 'vassels' or
'archive of the kindred'.

The Blah-Sucker language has been renamed to Enochian, reflecting the
First City of Vampires, Enoch, in the land of Nod east of Eden where the
Dark Father Caine was exiled from.

(Front facing) mentions of vassels have been replaced with the accurate
Ghoul. They drink vitae to establish a bond with their master, not
blood, vampires do not produce blood, they drink vitae.

The Archive of the Kindred has been replaced with the Book of Nod. Well,
a version of it. Cainites are protective of the hidden knowledge kept
within and would be unhappy with the mortals (you) having a copy.

Objectives have been re-written to mention lore aspects.

## Proof Of Testing

🆑
spellcheck: Various Bloodsucker things have been renamed after the
Inconnu paid a visit.
/🆑

---------

Co-authored-by: Waterpig <wtryoutube@seznam.cz>
Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
2024-10-10 14:05:24 -06:00