Commit Graph

7149 Commits

Author SHA1 Message Date
Iamgoofball
aebd156a43 CARGONIA THE FREE: The Quartermaster is now a head of staff. (#67518)
* The Quartermaster is officially a head of staff, with new accesses, a silver ID, ect ect.
* The HoP lost their cargo-related equipment and access, including the Vault monitor, and frequency.
2022-06-07 21:38:02 -04:00
Tim
cdf0a3c58a Add hallucinogen poison to frog attacks (#67572)
* Add frog hallucingen effects

* Add frog to venomous code comment
2022-06-07 21:34:23 -04:00
BeeSting12
cd54482972 Fixes grammar error in embed code (#67589)
Fixes grammar error
2022-06-07 19:33:27 -04:00
Tastyfish
3f3d337d7b Massive plumbing layer/placement improvements (#66602)
* Massive duct improvements

* last minute fixes/additions to plumbing layer fixes

* letter, loop, and early return fixes

* early continues

* color comments

* reaction chamber colors

* rcd tweaks

* Update code/datums/components/plumbing/reaction_chamber.dm

* Update code/datums/components/plumbing/reaction_chamber.dm

* Update code/datums/components/plumbing/_plumbing.dm

* Update code/datums/components/plumbing/_plumbing.dm

* remove unused var, better duct restacking

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
2022-06-07 19:30:18 -04:00
John Willard
1fcb7fec67 Material holding machines can't connect to ore silos on different z levels (#66953)
The station's ore silo can't connect to machines that are off the station z-level anymore. This doesn't affect multi-z stations.
Also includes ore silo code improvement because I was unhappy with it.
2022-06-07 11:24:38 -07:00
Tim
8576db2f32 Add Russian Roulette memories and moods events (#66051)
About The Pull Request

This adds memories to a nearby audience if someone is playing Russian Roulette with a loaded gun. The person who wins or loses also gains a positive or negative mood event that is long lasting. All of these events only trigger if the person playing is targeting a lethal area.
Why It's Good For The Game

Being able to add Russian Roulette to engravings would be pretty cool.
Changelog

cl
qol: Playing Russian Roulette with lethal intent now creates a mood event for the user and is engrained in any nearby peoples memories. The more bullets the better the memory and mood boost.
/cl
2022-06-07 21:25:11 +12:00
Tim
f06d735a52 All AI Lawsets are rebalanced, can be researched, appear in config, and random spawners for AI upload. (#66854)
This formally adds the new AI lawsets from #66636 into the game. Every lawset can
be researched, appears in config, and random spawners.
2022-06-06 22:54:29 -07:00
Son-of-Space
3dd6524ea7 [MDB IGNORE] Big Access Tweaks and Organization (#67512)
* Reorganizes some of the access and jobs access code for readability.
* Engineers get access to minisat and tcomms, atmos techs get it on skeleton crew.
* Service jobs that used to have morgue access without reason (bartender/botanist/hop) had it moved to skeleton crew.
* RD lost access to Mining, Mining station, and Medbay (holdover from Genetics), but gained Construction access to easily access the AI.
* Roboticist has had their skeleton crew access to ordnance revoked to align with the geneticist's skeleton crew access
* Miners no longer have SHIPPING access (renamed from Mail Sorting)
* The HoS and Paramedics have proper access to the basics in each department again
* Minisats across all maps now require Minisat access to access.
* Secure tech storage now once again requires both Command and Tech storage access again.
2022-06-07 00:46:05 -04:00
Jolly
2da4f98da5 Ports the Flower Garland from JollyStation (#67468)
* pick 12 flowers and regret your decisions

* Update code/modules/clothing/head/garlands.dm

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/clothing/head/garlands.dm

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/clothing/head/garlands.dm

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* Update code/modules/clothing/head/garlands.dm

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>

* grammar

* sanity mood event

* willards review

Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
2022-06-05 23:40:24 -04:00
Tim
59e61bc840 [NO GBP] Fix illiterate quirk bugs (#67473)
* Add trait literate to defines

* Add TRAIT_LITERATE to global vars

* Add is_literate proc to check for literate trait

* Remove is_literate proc from human

* Remove is_literate proc from silicon

* Add TRAIT_LITERATE to silicons

* Add TRAIT_LITERATE to drones

* Add TRAIT_LITERATE to abudctors

* Revert last commit

* Add TRAIT_LITERATE to abductors

* Add TRAIT_LITERATE to androids

* Add TRAIT_LITERATE to dullahan

* Add TRAIT_LITERATE to species

* Add TRAIT_LITERATE to flypeople

* Add TRAIT_LITERATE to golems

* Add TRAIT_LITERATE to humans

* Add TRAIT_LITERATE to jellypeople

* Add TRAIT_LITERATE to lizards

* Add TRAIT_ILLITERATE to monkeys

* Add TRAIT_LITERATE to mothmen

* Add TRAIT_LITERATE to mushpeople

* Add TRAIT_LITERATE to plasmamen

* Add TRAIT_LITERATE to podpeople

* Add TRAIT_LITERATE to shadowpeople

* Add TRAIT_LITERATE to skeletons

* Add TRAIT_LITERATE to snail species

* Add TRAIT_LITERATE to vampires

* Add TRAIT_LITERATE to zombies

* Add TRAIT_LITERATE to clever mutation

* Comment out TRAIT_LITERATE for monkeys

* Comment out TRAIT_LITERATE for ashwalkers

* Fix illiterate mobs reading tablet messages

* Update traits.dm
2022-06-05 23:38:50 -04:00
Iamgoofball
2719af0f05 Fixes centcom announcements referring to icebox as a station in orbit (#67528)
Fixes #67467
2022-06-05 20:51:23 +01:00
MrMelbert
3c69d9e898 Ensures cinematics really go away when they're done. (#67332)
* Ensures cinematics really go away in all scenarios
2022-06-05 21:12:31 +02:00
dragomagol
6370761692 Move more silicon-relevant logs to silicon logs (#67340)
Moves a bunch of logs that were silicon-related but logged to game.log to silicon.log.
2022-06-04 19:50:41 +01:00
Son-of-Space
c78268f7f3 Departmental Officers now have access to most of their department (#67275)
This pull request equalizes the access that departmental security is given for their department, giving departmental security officers access to all areas in the department which aren't head-specific. For example, the engineering security officer wouldn't have access to the tech storage room or the ce's office, but does have access to tcomms, engine equipment etc.

This is done so that all departmental security officers are equally enabled to respond to issues in their department and have the access that a basic member of the department would have. Currently, cargo officers are able to respond to any issue not in the vault or QMs office, but officers in science could only respond to issues in the science hallway, research room, or circuit room, and are unable to respond to issues in any other place in the department.

I believe that the reason for the above is that when new accesses have been added to departments, they neglected to add these areas for departmental security officers.

Upon further research, for things like virology or xenobio, it feels like keeping security officers out was intended, so I'll label this both a fix and a balance change.

Departmental security officers should be able to reliably respond to security issues in the department. While some areas like virology and xenobiology were deliberately separated from being accessible by security officers previously, I believe it is an antiquated design crutch that does not properly reflect the modern ways that antagonists work, and certainly doesn't reflect the standards that are currently set for officers.

Giving officers these accesses make departmental assignments something with genuine utility instead of something that gives you an armband and enables officers to feel/be felt like a part of their designated department.

These changes also make sure that departmental assignments are treated equally and have equal utility, making it easier to collectively change the feel of departmental security in the future.
2022-06-03 13:10:07 -06:00
SmArtKar
305aa1e478 Fixes statue simplemob teleport not working and 3 other spells not appearing (#67105)
* Fixes statue simplemob not being able to teleport, and their 3 spells they're supposed to have.
* Also repaths statues to netherworld mobs, to reduce copy paste code.
2022-06-03 04:56:47 -04:00
robbertapir
12b5e39731 Fixes a check doing the opposite of what it was supposed to do (#67439)
fixes a check

Co-authored-by: robbertapir <robbertapir@airmail.cc>
2022-06-02 11:48:35 -04:00
MrMelbert
1ffab33745 Minor buffs for Heretic focuses / equipment and the Void Cloak. (#67263)
* Heretic focus changes, turns it into an Element
* Buffs Void cloak, letting it hold more and hold more kinds of items
* Makes eldritch potions small sized (before: normal)
* Adds more explanations to some descriptions.
2022-06-02 00:46:09 -04:00
Ryll Ryll
771eadacc9 Fixes pellet cloud wounding where I just broke it (#67424)
I was stupid in #67331 (9431c92f70) and forgot an initial() around an un-instantiated projectile var call. This puts it in so wounding checks don't runtime. I have actually tested that this works

Pellet clouds work properly
2022-06-01 20:04:28 -07:00
GoldenAlpharex
1c7635f077 Fixes the stasis ripple not playing in a loop and the unusually-slow stasis bed lying down animation (#67403)
* Fixes the stasis ripple not playing and the slow stasis bed lying down animation

* Actually makes the ripple start after the lying down animation is over
2022-06-01 18:22:29 -07:00
MrMelbert
b7eace2fad Adds Cargorilla (#67003)
* Adds cargorilla

* working cargorilla

* Tweaks to control + jobs and stuff

* Sleep

* Probably don't leave in debug

* el sanity

* el change them to use globals, el refactor

* Does this fix it?

* Ah, okay

* el copypaste

* el mapload vars

* ready to ship
2022-06-01 19:41:46 -04:00
ArcaneMusic
c24ff68629 Adds steam vents to maintenance, adds some flavor to maintenance. (#66915)
* Steam Vent Challenge (Do not meme)

* Fixes icebox, I think

* Changes to how smoke behaves appears to have removed the need for the opacity setting on the vent. Sounds.

* Mapmerge sama please

* Adds signal system, crafting recipe, and some basic crafting organization.

* Potential fix

* Apply suggestions from code review

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>

* makes changes thanks anturk

Co-authored-by: Seth Scherer <supernovaa41@gmx.com>
2022-06-01 23:07:50 +02:00
Fikou
ee3ab47e01 Adds the Ninja MODsuit (#67220)
Why It's Good For The Game

Ninja code is pretty bad, I think it's best to move away into nice modular stuff instead.
Changelog

cl Fikou, PositiveEntropy, Nerevar, InfraRedBaron
refactor: the ninja space suit is now a modsuit
fix: fixes dash beams not working
/cl
2022-06-01 09:25:27 +12:00
Wallem
12204f2943 GAGS-ifies ties, and removes inherent ties from some outfits. (#67053)
Removes the inherent ties from most civilian outfits with a single-color tie baked into them.
2022-05-30 22:02:25 -07:00
Kapu1178
6d470992cb This tail refactor turned into an organ refactor. Funny how that works. (#67017)
* Fuck you (refactors ur tails)

* Errors

* Wow. Pain.

* Fixes up probably everything

* finish up here

* Fixes hard del maybe

* original owner hard del

* garbage collection runtime

* suck my peen byond

* Mapped tails

* motherfucker.

* motherrfucker. again.

* Whooopppppsie

* yeah bad idea

* Turns out external organs literally just sat in nullspace forever if their parent was deleted, and didnt Remove() themselves, causing harddels.

* So anyways I repathed all organs

* Fixes

* really.

* unit test... test

* unit test-test but it passes linters this time because im a moh-ron

* I've lost track of what im doing at this point

* Hopefully fixes hard del?

* meh

* Update code/datums/dna.dm

* things n stuff

* repath from master pull
2022-05-30 21:18:34 -07:00
Ryll Ryll
9431c92f70 Caps projectile armor at 90%, armor now applies to pellet cloud wounding (#67331) 2022-05-30 13:45:15 -07:00
Urumasi
10c698abba Add new H.E.C.K. suit GAGS sprite, recolorable via spray can (#67217)
imageadd: The H.E.C.K. suit has a new sprite. (by Meyhazah)
add: You can now use a spray can to completely recolor the H.E.C.K. suit.
2022-05-30 15:36:20 -04:00
tralezab
6d8485f0db When AI rolls "Unique AI" station trait, upload modules won't be available until research, and research requires more points. (#66633)
Rolling unique AI station traits removes boards from map and changes research costs of other lawsets.
2022-05-30 20:55:51 +02:00
MrMelbert
e17f2c6d68 Fixes Nullwave Vibrato triggering a chaplain's own antimagic. Also genericizes musical sect code slightly. (#67266)
Goes through and genericizes sect music effects slightly. As it stood pretty much all of them were copy+pastes of one another, with some minor changes, so making them one unified thing is cleaner.
2022-05-29 19:33:50 -07:00
Ghilker
9596a1ad2e removes atmos history (#67317)
Removes one unused global list and removes the other one that was used only 3 times.
2022-05-27 10:13:42 -04:00
Ryll Ryll
6d3095b5c8 Continues removing unnecessary species names of bodyparts in visible messages (#67254)
* removes some more unnecessary species mentions from bodypart messages
2022-05-27 10:09:27 -04:00
Andrew
3bb3785e86 OldStation Biolab and misc changes. (#67167) 2022-05-26 13:33:09 -07:00
Fikou
ccbd002c61 Security modsuit update (#67131) 2022-05-26 12:24:06 -07:00
Mooshimi
6680675447 lattice is walkable on chasm (#67294) 2022-05-26 12:56:00 -04:00
magatsuchi
f98d965a5d fixes small zparallax bug (#67244)
fixes an issue where if you attempted to regain control of your initial body after possessing another body it caused a stack trace due to MOB_LOGIN signal not being unregistered

(This was tsu's fault, introduced in a9d8be4d16)
2022-05-25 04:24:33 -07:00
san7890
2fc8e9e5ce Hoop, Shoot, Ball. A New Emergency Shuttle For All. (#67061)
* Hoop, Shoot, Ball. A New Emergency Shuttle For All.

Heya there,

Given the recent hype around basketball (no idea what that's about), I decided to try my hand at making a new emergency shuttle built around a full(ish) scale replication of a basketball stadium! Check it out!

Pretty nifty, eh? I'm fond of it. I spent a while doing the decalling, and I found it to be rather fun. Do keep in mind that the rest of the shuttle is rather "shitty" but it's social commentary don't worry about it.
2022-05-24 17:03:57 -07:00
SmArtKar
4cfefad2f8 [NO GBP]Fixes stopping, dropping and rolling not extinguishing your clothing (#67096)
* Resisting out of fire now makes your clothes stop being on fire, too.
2022-05-23 23:50:26 -04:00
Tim
0c5b3ac1fd New illiterate quirk (#66648)
* New illiterate quirk that makes a person unable to read or write. This applies to books, PDAs, paper, computers, and other electronics.
* New brain trauma dyslexia that makes you illiterate until fixed.
* Ashlizards are now illiterate as a default starting trait. The mining shuttle computer has been updated to compensate illiterate mobs randomly smashing buttons that causes a shuttle launch.

Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
2022-05-23 20:06:52 -04:00
Jolly
cfc2330528 [MDB IGNORE] More /area/ typepath organization and cleanup (#67107)
This further continues what I did in b4fb8f3ed1 (but instead of just stations, its now every (most) applicable area in the game
2022-05-23 13:01:19 -06:00
Iamgoofball
6a08c3b626 Silver slime food is now toxic(causes disgust when eaten), as it's not real food. (#67181)
Silver slime food is now toxic, as it's not real food.
2022-05-23 04:04:59 -04:00
MrMelbert
e2e658db41 Refactors and sorts Nuclear Bombs and Cinematics. Fixes and unit tests nuke cinematics, and re-adds a missing malf ai cinematic. (#67144) 2022-05-21 22:49:06 -07:00
Iamgoofball
470ea1705a Fixes the exploit allowing you to stack up absurd mood bonuses using the Holodeck pet garden. Petting 10 animals no longer counts as individual mood bonuses, and will instead replace eachother. (#67178)
Fixes the exploit allowing you to stack up absurd mood bonuses using the Holodeck pet garden
2022-05-21 20:16:08 -04:00
san7890
77b8bab481 Makes Cultist Summoning Nar'Sie An Important Announcement (#67143)
Hey there,

I first noticed this about three months, but I was pretty pleased about it since I was a cultist. I decided that today I should

Fix #Issue

It just makes it an important message, so that it will indeed reveal the location that the cult is summoned, and won't be muffled by that good-for-nothing potato-chip-eating centcom intern.
2022-05-21 10:33:02 -04:00
Ghilker
47215b4de0 fixes sm shards dusting when wrenching (#67155) 2022-05-21 10:29:05 -04:00
Mothblocks
e9d0498432 Adds Puzzgrid smite to trap enemy gamers in a fiendishly hard puzzle (#66855)
* Puzzgrids
2022-05-21 10:31:55 +02:00
Fikou
3042676e8d Proximity monitors now work on stuff that was created inside it (#67136) 2022-05-20 14:46:43 -05:00
Tim
20e4add487 Change healing by sleeping to be affected by sanity, darkness (or blindfold), and earmuffs. (#65713)
About The Pull Request

Depending on the mob's sanity level, it can have a positive or negative boost to healing effects while sleeping. Sleeping in darkness, wearing a blindfold, and using earmuffs also counts as a healing bonus. Beauty sleep is very important for 2D spessmen.
Why It's Good For The Game

This is a small gameplay change that rewards players for keeping their sanity at good levels. Also depression has also been linked with impeding wound healing in real life. The placebo effect on peoples minds is strenuously documented and I think it would be cool to see it in the game.
Changelog

cl
expansion: Healing by sleeping is now affected by sanity, sleeping in darkness (or using a blindfold), and using earmuffs. The healing from sleeping in a bed was slightly decreased.
/cl
2022-05-20 21:12:02 +12:00
LemonInTheDark
7e9ff85f2a [NO GBP] Jetpack and spacedrift: Fixes and niceties (#66628)
* Jetpack and spacedrift: Fixes and niceties

Ok so when I ported spacemovement onto movement loop,
I neglected to port this behavior that existed to support jetpacks.

Basically, if something that lets you move while spacedrifing
completes a move while you're spacedrifting, the
drift should "disable" to let it complete, and then later restart.

I neglected to add support for that, so that's what this does.

There's some other stuff going on here, mostly things to let jetpacks
ignore some of drift's extra behavior, since when a jetpack is not on
stablized, we want both to coexist.

It's a bit of a mess, I'm sorry about that.

Oh and at temporal's suggestion I've moved the visual_delay set from
newtonian move to an istype on the drift component, that was a good
idea, thanks quiet

* Makes dropping a pull while drifting carry the momentum into the pulled thing\

* Adds some extra context to Process_Spacemove, fixes a bunch of stupid
space bugs

It used to be, if you called Process_Spacemove with a direction, it
assumed you were an "action", so a client or mob trying to move in a
direction.

Unfortuantely for it, I needed to be able to use direction to make mob
pull drifting work. So we now actually pass in a second variable
called continuous_move, which tracks if this Process_Spacemove is on
behalf of a continuous move or not

In addition to this, I've added logic to bumping "off" someone to
prevent backbumping if that makes sense, since the bump is in the form
of a newtonian move that's run before the thing that's bumping actually
moves, we need some way to exclude it from holding the other object in
place.

* Adds a jetpack component, uses it to unify all three versions of
jetpacking

I hate you fikou
There were three copies of the same behavior, which made it hard to fix
stuff. Let's just componentize it

* Fixes jetpacks stabalizing even without fuel

This is mildly hacky. The real fix is to do this with events, but I
really don't wanna bend my brain like that. This'll do

* Ensures turn_off always has a user)

* Shut pu

* Bulky drags no longer effect your movespeed in space, fixing a consistency issue between them and all other forms of drags

* Removes some redundant code, cleans up some messy stuff

* Removes redundant safety checking from jetpack code

* see above

* Removes redundant signals
2022-05-20 00:54:00 -07:00
Son-of-Space
8440d20981 [MDB IGNORE] Reformats Access IDs for accessibility and futureproofing (#67002)
* [DRAFT] Reformats Access IDs for accessibility and futureproofing

* replaced all the old defines and IDs everywhere

* replaced ID integers with strings, cleaned up a couple tram helpers

* replaces req_access_txt with req_access and fixes a few of my mistakes

Co-authored-by: san7890 <the@san7890.com>
2022-05-20 02:43:02 -04:00
SmArtKar
63363f969f Fixes solid plasma breaking into plasmaglass shards (#67098) 2022-05-19 17:52:18 -05:00
Rhials
9c3607eaf1 Godmode now prevents radstorms from irradiating you. (#67081)
Having godmode toggled will now prevent you from being mutated by a radstorm
2022-05-19 10:11:45 -04:00