Commit Graph

1243 Commits

Author SHA1 Message Date
SkyratBot
70fe7d1f86 [MIRROR] Dynamic now plays a part in controlling random event antagonists (#3685)
* Dynamic now plays a part in controlling random event antagonists

* Update _event.dm

* Update spider_infestation.dm

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: KathrinBailey <53862927+KathrinBailey@users.noreply.github.com>
2021-02-27 12:35:25 +00:00
SkyratBot
c0aeb77777 [MIRROR] brand_intelligence no longer makes explosions which make holes in station (#3665)
* Update brand_intelligence.dm (#57038)

brand_intelligence event no longer has 30% prob of making an hull breaking explosion and destoying the machine when converting them to rogue vending machines which means there is 30% more vending machines that get turned into rogue ones aka all the ones that got hit with the vending machine virus

Blowing a hole in the station shouldn't be a sideffect of another event, and I don't wanna make mappers think about this stuff when placing vending machines -Lemon

* brand_intelligence no longer makes explosions which make holes in station

Co-authored-by: Tlaltecuhtli <33834933+Tlaltecuhtli@users.noreply.github.com>
2021-02-26 14:05:51 +00:00
SkyratBot
4c6d9438eb [MIRROR] small grammar fix on shuttle catastrophe (#3549)
* small grammar fix on shuttle catastrophe (#57052)

* small grammar fix on shuttle catastrophe

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
2021-02-20 23:19:16 +00:00
SkyratBot
d0dc199815 [MIRROR] /mob/living/proc/Life(delta_time) (#3509)
* /mob/living/proc/Life(delta_time)

* a

Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-19 16:55:52 +00:00
SkyratBot
18eca27569 [MIRROR] update_appearance (#3508)
* update_appearance

* a

* a

Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-19 16:08:09 +00:00
SkyratBot
efd745021e [MIRROR] Shuttle Insurance! (#3505)
* Shuttle Insurance! (#57025)

Co-authored-by: spessbro <51048066+spessbro@ users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* Shuttle Insurance!

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: spessbro <51048066+spessbro@ users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
2021-02-19 13:07:47 +00:00
NotRanged
5e67d1cd37 [Non-modular] Buffs blob. (#3073)
* Buff

* Points

* Spore buff, min pop

* Broken file

* DME fix

* Balance tweak, automated distress call

* Earlier announcement

* Announcement override

* Nerfs lategame

* Blobbernaut weakening

* Blobbernaut weakening

* Small changes to blobber

* Mistake

Co-authored-by: Ranged <nickvanderkroon@gmail.com>
2021-02-18 21:24:51 +00:00
SkyratBot
43febe3145 [MIRROR] Converts many proc overrides to properly use list/modifiers, lots of other smaller things (#3433)
* Converts many proc overrides to properly use list/modifiers, lots of other smaller things

* Update human_defense.dm

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-17 14:18:21 +00:00
SkyratBot
679bff1671 [MIRROR] Adds more admin memery and deadchat_control options to immovable rods. (#3418)
* Adds more admin memery and deadchat_control options to immovable rods. (#56888)

Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* Adds more admin memery and deadchat_control options to immovable rods.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
2021-02-16 00:13:31 +00:00
SkyratBot
b332b46b65 [MIRROR] Remove hideous inline tab indentation, and bans it in contributing guidelines (#3394)
* Remove hideous inline tab indentation, and bans it in contributing guidelines

* a

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-15 15:32:02 +00:00
SkyratBot
a765e5b0db [MIRROR] Pirates are split into three different ghastly crews! (#3395)
* Pirates are split into three different ghastly crews! (#56264)

Co-authored-by: DeAndre <robustness13@ hotmail.com>
Co-authored-by: itseasytosee <55666666+itseasytosee@ users.noreply.github.com>
Co-authored-by: tgstation-server <tgstation-server@ tgstation13.org>
Co-authored-by: Aleksej Komarov <stylemistake@ gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>

* Pirates are split into three different ghastly crews!

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: DeAndre <robustness13@ hotmail.com>
Co-authored-by: itseasytosee <55666666+itseasytosee@ users.noreply.github.com>
Co-authored-by: tgstation-server <tgstation-server@ tgstation13.org>
Co-authored-by: Aleksej Komarov <stylemistake@ gmail.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
2021-02-15 13:32:35 +00:00
SkyratBot
8007eb1578 [MIRROR] Refactors sharpness to use a bitfield (#3301)
* Refactors sharpness to use a bitfield (#56817)

Refactors sharpness to use bitfield instead of bitflags in case someone wants to add more types of sharp things, or unique behaviour with them

* Refactors sharpness to use a bitfield

* Update bullets.dm

Co-authored-by: Sparkezel <53384660+Sparkezel@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-11 23:57:06 +00:00
SkyratBot
3957bfd6b2 [MIRROR] The immovable rod is now crazy fast, is overpowered broken and doesn't afraid of anything. (#3289)
* The immovable rod is now crazy fast, is overpowered broken and doesn't afraid of anything. (#56794)

Co-authored-by: Mothblocks <35135081+Jared-Fogle@ users.noreply.github.com>

* The immovable rod is now crazy fast, is overpowered broken and doesn't afraid of anything.

Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: Mothblocks <35135081+Jared-Fogle@ users.noreply.github.com>
2021-02-11 13:13:01 +01:00
SkyratBot
cc67a133e5 [MIRROR] [READY] Adds station traits: Small modifiers that can randomly be chosen each round (#3132)
* [READY] Adds station traits: Small modifiers that can randomly be chosen each round

* conflicts

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-08 23:07:24 +00:00
SkyratBot
e83e1b7d41 Standardizes area paths and area-based nomenclature (#3125)
Co-authored-by: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-08 22:59:05 +00:00
SkyratBot
e890b1282b [MIRROR] Replaces intents with combat mode (#3063)
* Replaces intents with combat mode

* updates

* a

* Update living_defense.dm

* https://github.com/tgstation/tgstation/pull/56638/files

* gunsafety!

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
2021-02-05 16:58:16 +01:00
SkyratBot
7e97a1a5ae [MIRROR] Fixes space vines dying instantly to gas movement (#3052)
* Fixes space vines dying instantly to gas movement (#56567)

I mistakenly copied over space vine code in #55604, and assumed that the default mutation had some sort of cutoff for heat. I was wrong.

Fixes #56552

* Fixes space vines dying instantly to gas movement

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
2021-02-03 22:32:48 +00:00
Useroth
ede6b32def Modernizes Admin Only Wizard Event, Department Revolt (#56061) (#2923)
Co-authored-by: Mothblocks <35135081+Jared-Fogle@users.noreply.github.com>

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Jared-Fogle@users.noreply.github.com>
2021-01-28 03:09:29 +01:00
SkyratBot
0c7322f47b [MIRROR] Improvements to Anon Names + Refactoring + Wizard Academy theme and event (#2853)
* Improvements to Anon Names + Refactoring + Wizard Academy theme and event (#55935)

Co-authored-by: Rohesie <rohesie@ gmail.com>

* Improvements to Anon Names + Refactoring + Wizard Academy theme and event

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@ gmail.com>
2021-01-24 03:02:10 +00:00
KathrinBailey
c3c49c1229 [Ready] [Fully Modular] Xenomorph Balancing - Buffs & Speeding Tickets (#2180)
* Xenomorph balancing, take one.

Changes the speed of xenomorphs, especially the Queen, to be much faster. Hunters now have half the speed.
All Xenomorphs have a health buff, some more than others. Damage has increased for xenomorphs to make them more deadly, as melee armour makes xenomorphs laughably ineffective.
Hunters and sentinels hit faster, making hit and run less effective. Praetorians and Queens are now much more intimidating, but attack slower.

* Update xenomorph_balance.dm

* Praetorian & Queen health nealth. Alien Infestation now spawns 2-3 Larva.
2021-01-18 19:24:07 +00:00
SkyratBot
63adea0ebb [MIRROR] [READY] A victory for revolutionaries will no longer end the round on dynamic, instead no new security and command will be allowed to join (#2653)
* [READY] A victory for revolutionaries will no longer end the round on dynamic, instead no new security and command will be allowed to join (#55956)

Currently, a victory for revoutionaries leads to the round abruptly ending on dynamic. This has been replaced by all revolutionaries being deconverted, and no new security or command positions being available.

Also attempts to unionize (pun intended) copy and paste code in the round start and late join revolutionary rulesets into being handled under the revolutionary team instead.

* [READY] A victory for revolutionaries will no longer end the round on dynamic, instead no new security and command will be allowed to join

Co-authored-by: Mothblocks <35135081+Jared-Fogle@users.noreply.github.com>
2021-01-12 06:50:49 +01:00
SkyratBot
f11b0f173e [MIRROR] Tweak the RD's suplexing ability into a skillchip (#2620)
* Tweak the RD's suplexing ability into a skillchip (#55870)

Although this doesn't change the power level of the Research Director,
it's important to rework "job title" checks into traits or something
similar.

Moving job title specific behaviour out of checks by job name and into
traits means there's more flexibility to trigger behaviour. If an admin
feels the station really needs the ability, they can var edit it in, or
spawn the chip.

* Tweak the RD's suplexing ability into a skillchip

Co-authored-by: coiax <yellowbounder@gmail.com>
2021-01-10 23:07:26 +01:00
SkyratBot
f79e91462c [MIRROR] LINDA Reforged (#2573)
* LINDA Reforged

* Update airlock.dm

* Update biohazard_blob_controller.dm

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2021-01-08 18:52:35 +01:00
SkyratBot
21907289f2 [MIRROR] Reworks the brand intelligence event with AI controller datums (#2545)
* Reworks the brand intelligence event with AI controller datums (#55778)

These felt like another good test-case for ai controllers that someone could easily grasp, this makes it so that we can use the actual vending machine instead of a fake mimic mob. In theory you could even still use the vending machine, if you like living on the edge ofcourse.

The vendors now try to move towards you, and try to dive on top of you to squish you.

* Reworks the brand intelligence event with AI controller datums

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
2021-01-07 23:17:16 +01:00
Azarak
fbe0c08cc2 Lowers down and disables some events (#2438)
* a

* Update spider_infestation.dm

* Update blob.dm

* Update spontaneous_appendicitis.dm

* Update spider_infestation.dm
2021-01-05 15:09:00 +00:00
Useroth
5dcc3c4774 Increased minimal population for the spider infestation event. (#2319)
* Increased minimal population for the spider infestation event.

* Oops.

* code autoformatting made a needless whitespace change
2020-12-25 18:21:39 +00:00
SkyratBot
6355c9917e [MIRROR] Export scanner doesn't need to link + old bounty code is gone (#2197)
* Export scanner doesn't need to link + old bounty code is gone (#55504)

Removes the Export scanner's need to link with a console and cleans up the old bounty code

* Export scanner doesn't need to link + old bounty code is gone

Co-authored-by: spessbro <51048066+spessbro@users.noreply.github.com>
2020-12-17 08:02:12 +01:00
SkyratBot
64cb64aae3 [MIRROR] Replace direct poi_list manipulation with element (#2117)
* Replace direct poi_list manipulation with element (#55416)

Replaces GLOB.poi_list |= src and GLOB.poi_list -= src with an element that handles it directly.

More consistent code, especially when a lot of code couldn't decide how to add/remove (some |=, some -=, some .Remove, etc).

* Replace direct poi_list manipulation with element

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-12-11 00:26:00 +00:00
Useroth
17dc487897 Update alien_infestation.dm (#2104) 2020-12-10 06:00:35 +01:00
SkyratBot
2913364658 [MIRROR] Kills oldfood, Puts newfood on top. (#2041)
* Kills oldfood, Puts newfood on top. (#55160)

Slays the last of old-food, making new-food the new normal.

Co-authored-by: MrMelbert <kmelbert4@ gmail.com>
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@ users.noreply.github.com>

* Kills oldfood, Puts newfood on top.

* Update collars.dm

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: MrMelbert <kmelbert4@ gmail.com>
Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@ users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2020-12-04 16:46:26 +01:00
SkyratBot
c487c73f39 [MIRROR] Grep for space indentation (#1969)
* Grep for space indentation

* aa

* Update species.dm

* Update species.dm

* Update maps.dm

* Update examine.dm

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2020-12-01 12:26:41 +01:00
Azarak
cc8e47ef15 aa (#1885) 2020-11-29 15:04:05 -06:00
SkyratBot
a92fdde30e [MIRROR] Remove duplicate definitions of /obj/effect/ex_act, explicitly noop it (#1904)
* Remove duplicate definitions of /obj/effect/ex_act, explicitly noop it (#55076)

/obj/effect/ex_act had several different re-definitions to make it a noop. The original definition would randomly delete it, which is bad news when a lot of /obj/effects are just that--effects, that shouldn't be blown up.

The ones that actually do want to be blown up (like decals) already have their own implementations. The one in place was never ran, and nobody had problems with it.

* Remove duplicate definitions of /obj/effect/ex_act, explicitly noop it

Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com>
2020-11-28 12:59:11 +01:00
SkyratBot
18bdebef43 Merge type variable fixes and unit test (#1867)
Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-11-27 07:46:43 +00:00
SkyratBot
b7fd99428b [MIRROR] shuttle catastrophe now cant trigger if it already happened (#1795)
* shuttle catastrophe now cant trigger if it already happened (#55114)

Shuttle catastrophe now cant trigger if it already happened

* shuttle catastrophe now cant trigger if it already happened

Co-authored-by: Fikou <piotrbryla@onet.pl>
2020-11-23 22:35:58 +00:00
SkyratBot
89a8cb991a [MIRROR] moves misc food to newfood code (#1725)
* moves misc food to newfood code (#54788)

misc food is now using newfood code

* moves misc food to newfood code

Co-authored-by: Qustinnus <Floydje123@hotmail.com>
2020-11-19 07:21:23 +01:00
SkyratBot
5adb2790a0 [MIRROR] Spider Rework (#1667)
* Spider Rework

* Update giant_spider.dm

Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2020-11-11 18:32:13 +01:00
SkyratBot
6a915d7ccc [MIRROR] [READY] Space Ninja Rework (#1611)
* [READY] Space Ninja Rework (#53492)

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Revert "Automatic changelog compile [ci skip]"

This reverts commit 48a63defa644ec9826ee5eb1736e5158d2a636d4.

* Revert "Automatic changelog compile [ci skip]"

This reverts commit cb68f4988edd9d841c4203eecee2067a49ce75c5.

* Revert "Revert "Automatic changelog compile [ci skip]""

This reverts commit e6e1f1ef53ee6611c334efcae6ca7c102edaf351.

* Revert "Revert "Automatic changelog compile [ci skip]""

This reverts commit 1782210527b9819772c0781122bec35b7979bf7d.

* Update changelog.html

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Move suit_initialization into better location

* Clean up cost check

* Clean up net using

* Clean up Ninja Star

* Clean Up Ninja Stealth

* Clean Up Sword Recall

* Move the event file

* Re-Merge the Changes

* Get your ninja code out of my human.dm

* Move the event into events folder and clean it up

* Can the old space ninja antagonist file

* Roll in the shiny new bad boy

* Get rid of actions/ninja.dm and move its info into respective ability files

* Update one_click_antag with new ninja

* Move proc out of ninja code into proper location

* Update the dme properly this time

* Update code/modules/ninja/suit/ninja_equipment_actions/ninja_suit_initialisation.dm

Co-authored-by: Fikou <piotrbryla@ onet.pl>

* Update code/modules/ninja/suit/gloves.dm

Co-authored-by: Fikou <piotrbryla@ onet.pl>

* Update the antagonist file

* Update ninjaDrainAct

* Re-Add MGS Voice Lines

* Up the Katana Damage Back Up to 30

* Attempting a Risky Manuever

* Adjusting some numbers to fit the delta time PR

* Fix Var Names and do a return ..()

* Remove Unused Defines, Update qdels to QDEL_NULLs

* Update code/modules/antagonists/space_ninja/space_ninja.dm

Co-authored-by: Rohesie <rohesie@ gmail.com>

* Update code/modules/antagonists/space_ninja/space_ninja.dm

Co-authored-by: Rohesie <rohesie@ gmail.com>

* Update code/modules/events/space_ninja.dm

Co-authored-by: Rohesie <rohesie@ gmail.com>

* Update code/modules/ninja/energy_katana.dm

Co-authored-by: Rohesie <rohesie@ gmail.com>

* Update code/modules/ninja/ninja_explosive.dm

Co-authored-by: Rohesie <rohesie@ gmail.com>

* Update code/modules/ninja/suit/ninja_equipment_actions/energy_net_nets.dm

Co-authored-by: Rohesie <rohesie@ gmail.com>

* Remove Unnecessary Condition Checks

* I'll show you what A stands for!

* Turn some things into defines

* Remove is_ninja()

* Gives the SN roles on Antag Gain, not on event spawn

* Clean up mind/key code to be efficient and modern

* Have Deactivated Suit Gloves use default black sprite

* Add the new clothing sprites

* Add new inventory sprites for alternate sprites

* Get Rid of These Again

* Re-add suit changes

* Implement all the suggestions for the antag file

* And then everything else

* Updating the Weight for purpose of testmerge

* Balance Updates

* Update the Objective Definitions

* Remove Now Unreachable Cyborg Interaction Code

* Get That Shit Out of My Forest

* Re-Add Cowl Wearing Sprite

* Re-Add Cowl Inventory Sprite

* Adapt to the new thing?.thing changes

* Re-add New Katana Inhand Sprites

* Re-Add glove's shock but have it do knockdown instead

* Get rid of the these stupid changelog changes

* Update sounds

* Re-add New Mask Sprite

* Re-update katana inventory sprite

* Revert Event Weight

* Update code/modules/ninja/suit/ninja_equipment_actions/energy_net_nets.dm

Co-authored-by: girl <11748095+ExcessiveUseOfCobblestone@ users.noreply.github.com>

* Re-Add Dynamic Ninja

* Revert Changelog thing

* Update Mob Sprites

* Add files via upload

Co-authored-by: Changelogs <action@ github.com>
Co-authored-by: Fikou <piotrbryla@ onet.pl>
Co-authored-by: Rohesie <rohesie@ gmail.com>
Co-authored-by: girl <11748095+ExcessiveUseOfCobblestone@ users.noreply.github.com>

* [READY] Space Ninja Rework

Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com>
Co-authored-by: Changelogs <action@ github.com>
Co-authored-by: Fikou <piotrbryla@ onet.pl>
Co-authored-by: Rohesie <rohesie@ gmail.com>
Co-authored-by: girl <11748095+ExcessiveUseOfCobblestone@ users.noreply.github.com>
2020-11-07 15:43:32 +00:00
SkyratBot
ea84bd036c [MIRROR] [READY] Swarmer QOL and Balance Update (#1554)
* [READY] Swarmer QOL and Balance Update

* Update swarmer.dm

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Azarak <azarak10@gmail.com>
2020-11-05 00:32:30 +00:00
Azarak
2dbcac40e3 Update _event.dm (#1569) 2020-11-04 22:56:06 +00:00
SkyratBot
0f737f3b1d [MIRROR] Fixes various immovable rod bugs, adds logging (#1568)
* Fixes various immovable rod bugs (#54770)

* Fixes various immovable rod bugs, adds logging

Co-authored-by: skoglol <33292112+kriskog@users.noreply.github.com>
2020-11-04 14:53:11 +01:00
SkyratBot
dfd6a07dd7 [MIRROR] Removes an event that no longer actually does anything. (#1566)
* Removes an event that no longer holds relevance. (#54759)

Would definitely like to see dead bounty code get cleaned, but this is a step in the right direction.

* Removes an event that no longer actually does anything.

Co-authored-by: necromanceranne <40847847+necromanceranne@users.noreply.github.com>
2020-11-04 00:33:14 +00:00
SkyratBot
9991c55f96 [MIRROR] Fix shuttle_catastrophe shuttle replacing. (#1546)
* Merge pull request #54661 from Dennok/patch-1

Fix shuttle_catastrophe shuttle replacing.

* Fix shuttle_catastrophe shuttle replacing.

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
2020-11-02 18:47:17 +01:00
SkyratBot
431171ec25 [MIRROR] Crystal monsters sprites (#1505)
* new spritesss (#54528)

New sprites for the crystal invasion mobs

* Crystal monsters sprites

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
2020-10-30 02:27:43 +00:00
SkyratBot
b3cd29d2d2 [MIRROR] SSeconomy/var/bank_accounts is now an association list of account identifiers and datums for O(1) performance (#1363)
* SSeconomy/var/bank_accounts is now an association list of account identifiers and datums for O(1) performance (#54430)

Title. Also added some precautions to bank_account/new() and the crab17 gear.
The fact the majority of functions pertinent to the bank_accounts list was O(n) disquieted me.

* SSeconomy/var/bank_accounts is now an association list of account identifiers and datums for O(1) performance

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
2020-10-19 01:35:05 +01:00
SkyratBot
b8d9874c27 [MIRROR] Converts all A && A.B into A?.B (#1292)
* Converts A && A.B into A?.B (#54342)

Implements the ?. operator, replacing code like A && A.B with A?.B

BYOND Ref:
When reading A?.B, it's equivalent to A && A.B except that A is only evaluated once, even if it's a complex expression like a proc call.

* Converts all A && A.B into A?.B

Co-authored-by: ZeWaka <zewakagamer@gmail.com>
2020-10-13 23:19:25 +02:00
SkyratBot
2b8e5bfa2a [MIRROR] Re-enables ghost role events (#1265)
* Re-enables ghost role events (#54307)

Basically, a messed-up bitflag check has been stopping all event ghostroles from spawning for the last two months (outside of dynamic mode).

* Re-enables ghost role events

Co-authored-by: Yenwodyah <yenwodyah@gmail.com>
2020-10-12 23:17:03 +02:00
SkyratBot
896b72018c [MIRROR] Space Dragon QOL and Additional Features (#1246)
* Space Dragon QOL and Additional Features

* fix.

Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
2020-10-11 21:35:56 +01:00
Azarak
eb8b6e204c lowers events frequency (#1118) 2020-10-04 23:45:58 +01:00
Azarak
e8a01f265c Comments out wisdom cow, brain trauma events, add timer to meteor event, changes event weights (#1099)
* ebents

* weh
2020-10-01 21:03:19 +01:00