* fixes ghosts not being included in get_hearers_in_view(), AGAIN! (#60297)
thanks to shaps for reporting this
turns out mob/dead/Initialize() doesnt call parent, and mobs are made hearing sensitive in mob/Initialize(), so ghosts yet again werent included in get_hearers_in_view(). now they are!
now actually tested this time by attacking pun pun then ghosting, on master the red attack text doesnt show for ghosts in view but now it does
with the first pr the issue was because when target was a mob, view() only includes what the mob can see, so i made it always use a turf like it was previously. but the refactor done in the same pr meant that ghosts didnt become hearing sensitive so whoops
* fixes ghosts not being included in get_hearers_in_view(), again!
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
* Fixes admin observer special radio keys double sanitizing input (#60039)
Moves /mob/dead/observer/say() message sanitize code to after the special admin radio keys logic that will also sanitize.
Changes an if else chain to a switch statement,
* Fixes admin observer special radio keys double sanitizing input
Co-authored-by: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
* fixes a connect_loc runtime related to abstract_move (#59969)
* fixes a connect_loc runtime related to abstract_move
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
* Drastic Lag Mitigation Subsystem: SSlag_switch (#59717)
Requested by oranges and inspired by the upcoming event. A new subsyetem, non-processing (for now), aimed at providing some toggle switches that can be flipped as a last ditch effort to save some CPU cycles by sacrificing some non-critical mechanics. Below you can see each individual toggle.
Screenshot of the admin panel:
image
Surely there are more opportunities for toggles I missed, but adding new ones is not very difficult at all.
Why It's Good For The Game
Better performance during extreme pop, I hope.
Changelog
cl
code: Introduces the Lag Switch subsystem for when a smoother experience is worth trading a few bells and whistles for. Performance enhancement measures can be togged by admins with the Show Lag Switches admin verb or enabled automatically at a pop amount set via config.
config: Added a new config var: number/auto_lag_switch_pop
* Drastic Lag Mitigation Subsystem: SSlag_switch
* mirrored the changes to the modular file
Co-authored-by: Wayland-Smithy <64715958+Wayland-Smithy@users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
* Admin QOL: Adds a speech prefix for ghosted admins to talk through their linked body (#59762)
One of the more annoying parts of sending in a centcom official or ERT as an admin is the fact that sometimes you need to keep in touch with them- especially when you're supporting a response team with multiple people, and sending them headset messages one-by-one or using command reports won't cut it. In these cases, I spawn myself in at centcom (or use the body I made for briefing) and talk on the Centcom radio freq, but this sucks because while you're in the body, you can't watch what they're doing because you're not a ghost!
So this PR adds a special speech prefix for admin ghosts, :j, which tries to relay your chat message to your linked body if one exists, instead of sending it to deadchat.
* Admin QOL: Adds a speech prefix for ghosted admins to talk through their linked body
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
* AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
* Ads
* dddd
* a
* a
* a
* Update uniform_digi.dmi
* Update uniform_digi.dmi
* Update uniform_digi.dmi
* Some random new potted plants!
* a
* Update flora.dm
* a
* fixes
* a
* a
* e
* Adds Neon Carpet (#59140)
Adds a couple varieties of neon carpet.
Makes decals care about their plane in addition to their layer.
* 0
* A
* a
Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* added three new hair gradients, a pair of shorter fades and a spiky wave (#59545)
imageadd: Three new hair gradients, a pair of shorter fades and a spiky wave.
* Adds some additional hair gradient styles
Co-authored-by: Thunder12345 <Thunder12345@users.noreply.github.com>
* Detaches Anonymous themes and Triple AI from SSTicker (+ more anonymous themes and content) (#59373)
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
* Detaches Anonymous themes and Triple AI from SSTicker (+ more anonymous themes and content)
* Mirror!
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com>
Co-authored-by: Funce <funce.973@gmail.com>
* Prevent players who get booted back to the lobby on shiftstart from getting broken antag status on latejoin (#59377)
* Prevent players who get booted back to the lobby on shiftstart from getting broken antag status on latejoin
* Mirrored
* oop
Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Co-authored-by: Funce <funce.973@gmail.com>
* fixes issue with ghosts being able to affect the world, oversight from the crossed refactor (#59010)
* as anything in _SendSignal
* Revert "as anything in _SendSignal"
This reverts commit 350c4b33d975d25003afb2cab2458a3026676559.
* ghosts can no longer affect the world (hopefully)
* fixes issue with ghosts being able to affect the world, oversight from the crossed refactor
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
* Tidy HTML folder (#58761)
This PR aims to make the HTML folder a little more organized, as well as remove a few unused files.
Why It's Good For The Game
Doesn't change anything for the player, however makes the files more organized.
* Tidy HTML folder
Co-authored-by: Celotajs <81999976+celotajstg@users.noreply.github.com>
* (code bounty) refactors all uses of Crossed() and Uncrossed() into signals sent to loc, tracked by connect_loc
* WHEW THAT WAS EASY
* Update ammo.dm
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* Prevent negative open positions in crew manifest (#58300)
* Resolve open position issues in crew manifest
* Use the classes helper for multiple classes
Co-authored-by: celotajstg <celotajstg@ users.noreply.github.com>
* Prevent negative open positions in crew manifest
Co-authored-by: celotajstg <81999976+celotajstg@users.noreply.github.com>
Co-authored-by: celotajstg <celotajstg@ users.noreply.github.com>
* Layer overhaul (#57915)
## About The Pull Request
Changes up some layer and plane defines for no particular reason lol
## Why It's Good For The Game
Planes actually override layers, and layers control ordering within planes. A lot of the usage of plane and layer was wholly unnecessary. This refactor helps future maintainability while also being needed staging for _future features._
* Layer overhaul
* aaaaaaaaa
a
Co-authored-by: Rob Bailey <actioninja@gmail.com>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* Highlander + Summon Guns and Magic now uses signals to equip new crewmembers (#57817)
* Highlander + Summon Guns and Magic now uses signals to equip new crewmembers
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* Observers can now use emojis at the start of messages without the risk of triggering admin commands. (#57433)
Added a client.holder check to the line about radio extensions for admin chat and deadchat commands. It means common observers can finally spam dchat with plushie emoji. Admin observers still have to deadmin before using emojis safely, until someone takes the time to refactor saycode mods so these admin commands only acept the comma prefix (luckily, observer/get_message_mods() doesn't trim the message).
* Non-admin observers can now use emoji that start with d or p at the beginning of a message without admin command warnings.
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
* Partial revert of datum poll creation, fixes duplicated irv votes (#57462)
* Partial revert of datum poll creation + stops duplicated votes from being trusted from clients
Reverts the part of jordies poll refactor that allowed a duplicated vote in the db to make it back on the client's vote screen.
Also fixes the code that would allowed duplicated votes to be passed from the client. (not from jordie's poll refactor pr.)
The race condition still exists, thats harder to fix, counting code handles this correctly
* Update poll.dm
* Update poll.dm
* Partial revert of datum poll creation, fixes duplicated irv votes
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
* Allows ghosts to start messages with asterisks in deadchat again (#57159)
#56519 had noble goals in trying to make emote code more robust for
ghosts, but in doing so it undid #47144, which was made to allow people
to start messages with asterisks in deadchat without getting hassled by
the game thinking you're emoting. This re-limits the emote checker to
the only two emotes ghosts have ever had, *spin and *flip.
* Allows ghosts to start messages with asterisks in deadchat again
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
* New flight potion wing sprites for moths (#56412)
Wing sprites are courtesy of Papaporo Paprito over on Fulpstation!
This PR adds a second sprite for flight potion wings for moths.
A new system is implemented to make this possible, using radial menus.
* New flight potion wing sprites for moths
* Update species.dm
Co-authored-by: Jack7D1 <59462654+Jack7D1@users.noreply.github.com>
Co-authored-by: Gandalf2k15 <jzo123@hotmail.com>
Co-authored-by: Azarak <azarak10@gmail.com>
