About The Pull Request
Welders didn't actually consume fuel if their attack deleted an object. This was first noticed when welding space vines, in that the welder didn't consume any fuel to do so. Further testing showed that this was the case for any object that gets destroyed on hit, including APCs, Air Alarms, Girders etc.
Problem was that the code for actually consuming fuel after an attack is in the afterattack proc which doesn't actually get called if the target is QDELETED. PR moves that code to the attack proc, along with (regrettably) implementing attack_obj too. This feels hacky and reeks of duplicate code, so if anyone has a better option for how I could implement this fix I'm all ears.
Why It's Good For The Game
Fixes unintentional behavior
Changelog
cl
fix: Welders now consume fuel when they destroy an object
/cl
* Makes all combat involved visible_messages in species.dm ignore user and adds a new to_chat-message for user alone.
* Adds personal combat messages to martial arts.
* Adds personal combat messages to most things, like monkeys, aliens, humanoids and silicons.
* Fixed message to bite src, not self
* Fixed message to attack src, not self
* Changes wording on miss-messages.
* Adds audible messages to visible_messages. Also adds few missing to_chats.
I added these stack_traces to check how much work would needed so these
can be safely removed. Apparently it's way more work than I and
probably anyone else would be willing to do. Lots of data is already
collected so if someone wants to improve the situation, you can check
the logs for it.
About The Pull Request
Converts every single usage of playsound's vary parameter to use the boolean define instead of 1 or 0. I'm tired of people copypasting the incorrect usage.
Also changes a couple of places where a list was picked from instead of using get_sfx internal calls
This was done via regex:
(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\)) to match 1
(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\)) to match 0
full sed commands:
/(playsound\(.+,.+,.+, ?)1( ?\)| ?,.+\))/\1TRUE\2/ 1 to TRUE
/(playsound\(.+,.+,.+, ?)0( ?\)| ?,.+\))/\1FALSE\2/ 0 to FALSE
I'm not very good with regex and these could probably be optimized, but they worked.
Why It's Good For The Game
Code usability
About The Pull Request
Adds cancel buttons to input boxes that didn't have them before.
Why It's Good For The Game
Good UX.
Changelog
cl
add: More cancel buttons.
/cl
About The Pull Request
Some mutation changes
Laser eyes and TK now use signals.
species_allowed now uses less lists.
Adds a message when you shoot with laser eyes.
Why It's Good For The Game
New and improved. Click code should be as straight forward as possible.
Changelog
cl
tweak: Laser eyes now generate a message when shot.
code: Cleaned up mutation code.
/cl
* adds "you" to some combat visible_messages.
* more you-messages and attack verbs to present tense.
* small fixes
* more additions and small fixes
* few message tweaks
* Fixes a typo and few other wordings.
* This turns butchering into something that resembles a component.
* Changes how the recycler works.
It no longer uses butchering in disgusting ways.
* I guess this works? It's not pretty though.
* How the fuck...
Removes the get_organ_target proc because I'm to lazy to fully
refactor laser eyes. It is embarrassing that we have a proc like this
in the code. Also makes mob code less cursed, one proc at the time.
* 1/4 done? maybe?
* more
* stuff
* incremental stuff
* stuff
* stuff & things
* mostly done but not yet
* stuffing
* stuffing 2: electric boogaloo
* Git Commit and the Kingdom of the Crystal Skull
* make it actually compile
* found more stuff
* fixes
* fix AI laws appearing out of order
* fix windows
* should be the remaining stuff
* this time for real
* i guess it should compile too
* fix sechuds
cl
add: Added support for a widescreen toggle, actual widescreen will require a config change.
tweak: Auto-fit view is now the default. This will only apply to new players.
/cl
* Initial overhaul work and some fixes.
Running into a bug with getting healthanalyzer variables to pass.
Signed-off-by: RaveRadbury <risforradbury@gmail.com>
* Fixes some typos, shortens a message
* Update pai.dm
* Prevents pAI OS from coming up in other windows.
* Moved around some camera stuff, trying to fix lost pAI zoom
* Fixes pAI zoom, adds camera flash
* PAI buttons grey out if they need software first
* Better greying out of buttons in PAI
* Removes unimplemented HUD stuff
* Should make pAI Host Scan require being held (like DNA check)
* Includes host scan as a greyed out hud
* Improved button loop
* Fixes pda icon off-set
* Fixed inconsistent indentation
* Replaces outdated and innacurate checks for scans
Thanks to Cobblestone for the help
* Refactor pAI hud button grey out
* Changes browse to browser
* cleans up the code, gets rid of an error
* Removes indent from #undef
* Removes an unneeded text-align:right
* blob refactor
* blobtype -> blobstrain
* fixes, chemical -> strain
* only /mob/living experience Life, blobs and other cameras can process if they need to
also other fixes
* call_life goes out
* ispath thing
* Adds shift click to _onclick/pai.dm
* Restores all mouse hotkeys
Turns out pAI's have a lot of stuff disabled on another level, so.
* includes timeout checks
* Removed statuses that pAI don't experience
* Calls the parent
* Fresh start
Wow this has been an adventure. Hopefully this works and I can start rebuilding this PR.
* Functional build
Lacks software integration, costs, purchase enabling, etc.
* Removes pAI Action HUD
Also changes some frame data on icons, slowing them.
* adds check for pAI in newscaster.dm
* tweak job title for consistency
* capitalization
* correctly types pai in newscaster.dm
Co-Authored-By: RaveRadbury <3204033+RaveRadbury@users.noreply.github.com>
* adds in wire fix PR vars to hopefully fix it all
* reset pai.dm to hopefully fix this replace issue.
* That didn't fix anything. Reverting.
* One more time, taken from upstream master.
* put the newscaster stuff back into pai.dm
* Re-adds job title for newscaster
