Commit Graph

1183 Commits

Author SHA1 Message Date
MrPerson
ff3f84ab81 Replaces /image with /mutable_appearance, where appropriate (#26518)
In cases where you're creating an image to use as an overlay, it makes more sense to use a mutable_appearance if you can. The image will create a static appearance for not just the image but also each intermediate step if you change vars along the way. The mutable appearance avoids this unnecessary and expensive process. The only situation that requires an image instead of a mutable_appearance is if the overlay is supposed to be directional. MA's ignore direction while images don't. I dunno why, probably another BYOND-ism.

I added a convenience function, mutable_appearance(), designed to emulate image(). Also went ahead and set the default plane of /mutable_appearance to FLOAT_PLANE because it's fucking 0 by default.

Several overlays that were image() calls were changed to just text strings when I could. overlays += "string" has the same result as overlays += image(icon, "string") and saves a proc call.
2017-04-25 12:15:16 +02:00
Cyberboss
e266551346 Merge branch 'master' into ITKEEPSHAPPENING 2017-04-25 01:13:14 -04:00
Leo
4a174be3a3 Merge pull request #26465 from Cyberboss/patch-53
Fixes Advanced Proc Call
2017-04-24 12:05:03 -03:00
Cyberboss
7ddea10cd7 Exploit whack-a-mole 2017-04-23 21:16:10 -04:00
Cruix
f0a8ca68db Changed alternate appearances to /datum/atom_hud s (#26289)
* Changed alternate appearances to  /datum/hud s

* Added hashset behavior to the /datum/data_hud/var/hudusers list
2017-04-23 20:25:52 +02:00
Cyberboss
352752d029 Fixes Advanced Proc Call 2017-04-22 21:26:07 -04:00
Cyberboss
34a1b30a42 Fix current_ticket.initiator not being set when a client relogs 2017-04-20 15:21:45 -04:00
Cyberboss
5d61c5b64e AHelp improvements (#26092)
* Ahelp refactor

* Same ticket nagging

* Remie review

* Dead code

* Require tickets for PMs + other fixes

* Remove full monty redundancy

* Stylesheet

* Listings refresh

* Add ban logs to tickets

* Tickets can stay associated after reconnect

* Don't show active disconnected tickets in the main list

* Ticket titles

* More beautiful + fixes

* Needful

* IC issues close the ticket, feedback, and other stuff

* Move shit around

* IC issue -> resolve. Inline with the meaning of resolve. Documentation

* Classic style + fixes

* Width

* Formatting

* Whoops

* Formatting

* That top note

* That cream

* Pure vanilla

* move to status panel

* Fix the listing

* Sleep checks

* Stay frosty

* Allows close/resolve of disconnected players

* Ban logging will work if the player logs out.

* Sorted closed and resolved lists

* Fixes

* IRC commands

* More feedback

* Small fix

* Unfix

* Just witnessed a memetide of tickets

* Make the timer unique for good measure

* Fix

* Make it use QDEL_LIST

* Fix

* colorful

* Fix

* No more name prompt

* Retitling

* Fix

* Fix

* < CANT CODE

* Phrasing

* The better

* Better linking and stuff

* Language

* Bluh

* This may have broke things, let's back up

* Ticket reopening

* Admin panel verb for viewing a ticket list

* Slightly better refreshing

* Improve reject and IC issue wording

* Log client disconnects and reconnects

* Hopefully fixes the same issue issue

* This should be here

* Almost a terrible idea

* More feedback

* Better timing

* Better timing and logging

* Adding notes

* Improves teleport logging

* saddest commit in history

* Fix feedback counters for reopened tickets

* Fixed
2017-04-19 18:54:26 +02:00
Cyberboss
eb399829bc Removes a colon (#26353) 2017-04-19 10:30:47 -04:00
Cyberboss
3c3f7d3b60 Refactors dbcon into a subsystem (#26134)
* Refactors dbcon into a subsystem

* Swear I got that already...
2017-04-17 15:18:17 +10:00
Cyberboss
6a9fa3d35a Adds a proc to check if the current thread is from an admin advanced proc call (#26191)
* Admin proc call guards

* Adds a db warning

* Better this way

* leftover

* )=

* Fix

* Wew

* Better runtime handling

* Make callback use it if var_edited
2017-04-15 11:24:35 -06:00
oranges
cd847d77d8 Merge pull request #26099 from Cyberboss/ShuffleFix
Corrects incorrect shuffles
2017-04-13 11:09:04 +12:00
Cyberboss
a1403bc424 [s] Moves sensitive data out of GLOB (#26039)
* Moves sensitive data out of GLOB

* Make it a real boy

* Whoops
2017-04-12 19:53:13 +02:00
Cyberboss
a8cc3cd6c2 [s] Fixes datum var hiding (#26027)
* .

* Buildmode

* SDQL global. now refers to GLOB

@kevinz000

* Another SDQL thing

* Fix
2017-04-12 11:20:46 +12:00
Cyberboss
fa39d8bfe1 Corrects incorrect shuffles 2017-04-11 09:32:13 -04:00
Joan Lung
49e7f7e5b1 Improves admin verb logging 2017-04-09 19:00:52 -04:00
Lzimann
d40760ad71 Fix conflicts 2017-04-07 09:12:36 -03:00
Cyberboss
9e1ef0ffe2 Global variable wrappers (#25325)
* Add the system for managed global variables

* Travis ban old globals

* So you CAN inline proccall, that's neat

* Fix that

* master.dm

* Remove the hack procs

* Move InitGlobals to the proper spot

* configuration.dm

* Fix the missing pre-slash

* clockcult.dm

* This is probably for the best

* Doy

* Fix shit

* Rest of the DEFINES tree

* Fix

* Use global. for access

* Update find_references_in_globals

Always hated that proc

Whoever made it must've bee a r e a l idiot...

* __HELPERS tree

* Move global initialization to master.

Fix the declaration

* database.dm

* Dat newline

* I said DECLARATIVE order!

* Here's something you can chew on @Iamgoofball

* game_modes.dm

* Fix this

* genetics.dm

* flavor_misc.dm

* More stuff

* Do it mso's way. Keep the controllers as global

* Make master actually see it

* Fix

* Finish _globalvars/lists

* Finish the rest of the _globalvars tree

* This is weird

* Migrate the controllers

* SLOTH -> GLOB

* Lighting globals

* round_start_time -> ticker

* PAI card list -> pai SS

* record_id_num -> static

* Diseases list -> SSdisease

* More disease globals to the SS

* More disease stuff

* Emote list

* Better and better

* Bluh

* So much stuff

* Ahh

* Wires

* dview

* station_areas

* Teleportlocs

* blood_splatter_icons

* Stuff and such

* More stuff

* RAD IO

* More stuff and such

* Blob shit

* Changeling stuff

* Add "Balance" to changelogs

* Balance for changelog compiler + Auto Tagging

* Update the PR template

* hivemind_bank

* Bip

* sacrificed

* Good shit

* Better define

* More cult shit

* Devil shit

* Gang shit

* > borers

Fix shit

* Rename the define

* Nuke

* Objectives

* Sandbox

* Multiverse sword

* Announce systems

* Stuff and such

* TC con

* Airlock

* doppllllerrrrrr

* holopads

* Shut up byond you inconsistent fuck

* Sneaky fuck

* Burp

* Bip

* Fixnshit

* Port without regard

* askdlfjs;

* asdfjasoidojfi

* Protected globals and more

* SO MANY

* ajsimkvahsaoisd

* akfdsiaopwimfeoiwafaw

* gsdfigjosidjfgiosdg

* AHHHHHHHHHHHHHHHHHHHHHHH!!!!!

* facerolll

* ASDFASDFASDF

* Removes the unused parts of dmm_suite

* WIP

* Fix quote

* asdfjauwfnkjs

* afwlunhskjfda

* asfjlaiwuefhaf

* SO CLOSE

* wwwweeeeeewwwww

* agdgmoewranwg

* HOLY MOTHER OF FUCK AND THATS JUST HALF THE JOB?!?

* Fix syntax errors

* 100 errors

* Another 100

* So many...

* Ugh

* More shit

* kilme

* Stuuuuuufffff

* ajrgmrlshio;djfa;sdkl

* jkbhkhjbmjvjmh

* soi soi soi

* butt

* TODAY WE LEARNED THAT GLOBAL AND STATIC ARE THE EXACT SAME FUCKING THING

* lllllllllllllllllllllllllllllllllllllllllll

* afsdijfiawhnflnjhnwsdfs

* yugykihlugk,kj

* time to go

* STUFFF!!!

* AAAAAAAAAAAAAAAAAHHHHHHHHHHHHHHHHHHHHHHHHHHH!!!!!!!!!!!!!!!!!!!!!!!

* ngoaijdjlfkamsdlkf

* Break time

* aufjsdklfalsjfi

* CONTROL KAY AND PRAY

* IT COMPILEELEELELAKLJFKLDAFJLKFDJLADKJHFLJKAJGAHIEJALDFJ!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

* Goteem

* Fix testing mode

* This does not belong in this PR

* Convert it to a controller

* Eh, fuck this option

* Revert controllerization Ill do it some other time

* Fix

* Working controllerization

* FOR THE LOVE OF CHRIST PROTECT THE LOGS

* Protect admins and deadmins

* Use the inbuilt proc
2017-04-06 23:26:13 -06:00
Lzimann
3a20f37034 Fixes chaplains not being able to assign their deity/religion plus some minor refactor of the religion subsystem 2017-04-06 23:44:13 -03:00
Cyberboss
e658b32b49 Removes the silent parameter from toggle_antag_hud (#25947) 2017-04-06 21:50:07 -03:00
Cyberboss
5bbf370ad0 Fixes Deadminning keeping the AntagHUD on (#25847) 2017-04-06 14:19:19 -03:00
Cyberboss
7863c536ce Adds cancellation for ERT creation (#25907)
* Fixes #15145

* Update one_click_antag.dm
2017-04-06 09:03:42 -06:00
kevinz000
2bab78ed75 [READY]Removes the runtime stop from SDQL2, adds a catcher for them to show, and total operations counter (#25597)
* Update SDQL_2.dm

* runtime catcher
2017-04-05 15:48:22 +02:00
Cyberboss
78ee754da3 Merge upstream 2017-04-01 23:38:37 -04:00
Cyberboss
1c03305a12 Fixes a runtime with the individual logging panel (#25691) 2017-04-01 21:39:45 -03:00
Cyberboss
5646c736c8 Merge upstream 2017-03-30 19:18:59 -04:00
coiax
000e923a87 Autoimplanters renamed to autosurgeons; nuke op autosurgeon fix (#25549)
* Autoimplanters renamed to autosurgeons; nuke op autosurgeon fix

Fixes #24443.

🆑 coiax
add: Autoimplanters have been renamed to autosurgeons. Currently only
the CMO and nuclear operatives have access to autosurgeons. What is the
CMO hiding?
fix: All upgraded organs for purchase by nuclear operatives now actually
come in an autosurgeon, for speed of surgery.
/🆑

- Autosurgeons now insert any type of organ put in
- Replaced organs are dropped on the floor by default, and if told not
to, will GC, rather than just disappearing through lack of references
- Makes autosurgeons have a `starting_organ` type, where it'll make an
internal organ to be dispensed.
- Autosurgeons now change their name depending on their internal organ
- Nuke ops now just buy the autoimplanter with the organ already inside
it.

* Fixes naming and sprite
2017-03-30 22:09:35 +13:00
Cyberboss
69558f7196 Merge branch 'master' into TiredOfTheInconsistency 2017-03-28 09:23:27 -04:00
kevinz000
7f5a6b71cd Admin sound channel tweaks (#25537)
* Update playsound.dm

* Update sound.dm

* Update sound.dm

* Update playsound.dm
2017-03-28 13:37:19 +02:00
Cyberboss
05e1ef69e1 Merge upstream 2017-03-27 09:32:08 -04:00
kevinz000
6ed5e98bcf Makes Ratvar more powerful than the admins (#25440)
* Update possess.dm

* Update possess.dm

* Update objs.dm

* Update ratvar_the_clockwork_justicar.dm

* Update singularity.dm

* Update possess.dm

* Update objs.dm

* Update objs.dm

* Update objs.dm

* Update possess.dm
2017-03-26 21:35:24 +02:00
Cyberboss
db99403313 Merge branch 'master' into TiredOfTheInconsistency 2017-03-23 09:21:20 -04:00
Cyberboss
71deca2374 SSmachine -> SSmachines 2017-03-22 11:38:35 -04:00
Cyberboss
73fa1e61f8 SSevent -> SSevents 2017-03-22 11:26:01 -04:00
Cyberboss
d0bfbc3e13 Rename ticker to SSticker 2017-03-22 10:48:25 -04:00
Lzimann
77122af265 Replaces BSA with smite and adds BSA to smite 2017-03-21 23:23:08 -03:00
Cheridan
711aa1c98b Merge pull request #25298 from lzimann/loglink
Adds a link to individual logs to ahelps/prays
2017-03-21 12:12:46 -05:00
Lzimann
1cc61d07a6 Adds the link to (?) button, changes adminhelp to use the proper define 2017-03-21 13:52:08 -03:00
Leo
0c97f42d63 Adds a cancel verb when choosing whether a command report is public or not (#25295) 2017-03-21 15:41:49 +01:00
Leo
149a6d0618 Individual logs are now displayed on a desc order (#25302) 2017-03-21 23:36:55 +13:00
coiax
67ffcb10cc Debug admin verb: Pump Random Event (#25202)
Forces the event subsystem to make a new random event when it next
fires. (Most of the time this will be space dust.)

Used for testing the random event systems.
2017-03-20 17:46:00 -03:00
Cyberboss
b639f0c99e Fixes admin latejoin disabling (#25041)
* Fixes admin latejoin disabling

* Fix alerts
2017-03-16 17:06:52 -04:00
peoplearestrange
7d2b95759a Buildmode full title window path fix (#25125)
Full tile windows built from Buildmode Basic were pointed at an old path. Changes this to match the new one.
🆑 
fix: Fixed buildmodes full tile window to be correct path
/🆑
2017-03-16 20:25:04 +13:00
kevinz000
3156b3c5e6 [READY]More SDQL stuff from /vg/ (#24970)
* sdql3

* wups
2017-03-16 20:24:10 +13:00
coiax
f096307c20 Generates messages when xeno eggs are delivered (#24852)
* Generates messages when xeno eggs are delivered

🆑 coiax
add: The egg spawner on Metastation will generate a station message and
inform the admins if an egg is spawned. (It's only a two percent chance,
but live in hope.)
/🆑

Metastation has a 2% egg spawner. If it picks the xeno egg, it does so
silently, telling no one. Now it informs the station and also admins and
the game log.

To reiterate, this behaviour is already in the map, I'm just generating
logging and messages. If admins want to simulate this, they can spawn a
`/obj/effect/spawner/xeno_egg_delivery` in any location they like.

* Xeno delivery makes a command report instead

I also refactored command report to avoid the duplication of the SECRET
COMMAND REPORT announcement.
2017-03-13 21:58:20 +13:00
Lzimann
2d59366ae4 More fixes to incorrectly changed outputs(mainly files) 2017-03-10 13:33:03 -03:00
Lzimann
3dd6722c07 Fix conflict 2017-03-10 01:39:22 -03:00
Lzimann
5a618297ce Replaces the default output with the to_chat wrapper. 2017-03-10 01:32:05 -03:00
Cyberboss
e48564d941 Arrivals Ferry (#24694)
* Highlight docking ports in TESTING

* Buckle arrivals to their seats

* Fixes shuttle/Initialize not calling the base

* Arrivals docking

* Use forceMove so the shuttle effect starts

* Forgot this check

* Fixes

* Needful

* Fix this shit

* Line endings?

* Double check, fix sound

* Remove empty if

* Fucking lists

* Fix parallax and ghosts

* Ghost fix

* GHOST

* Fix shit

* Fix parallax + config

* I lied slightly

* Hyperspace sound refactor

* Finish fixing the maps + doors

* Fix the sound not playing

* Consoles + area fix

* Updates default config

* Fix line endings

* Safety checks

* Damage checks

* This should be down here

* Clean some stuff up

* Fix a few things on Delta and Omega

* Delete the useless air alarm on Pubby's shuttle

* Fixes #24727

* Always the fucking line endings

* Fix this negative check

* LINE ENDINGS!!!!!

* Revert to master

* Redo the changes

* Fix the sound not repeating

* Readds the shuttle door

* Fix people disabling latejoins
2017-03-10 14:19:34 +13:00
Cyberboss
a55f36ebe9 Moves cross_address/allowed to the config. Merges the protected config into the regular. (#24584)
* Moves cross_address/allowed to the config

* Protect it against modifications

* I'll do you one better

* Merge in the protected configuration
2017-03-10 11:10:08 +13:00