Timber did an oopsie in #57850 and made it so rods with a specific target (AKA any spawned by admins either through the trigger event button or the admin smite) quit out of their creation before they started listening for clonging things. Possibly this was partly intended, in case you wanted to spawn a rod that would only hit whatever you designated as your target and nothing else, but this current setup doesn't hit the target either soo something needs fixing.
@Timberpoes let me know what you think and if you were intending for a soft rod option that would only hit the target.
Fixes: #57888
* Ice cream rework WIP
* I'm done!
* i'll deal with my verbose engrish at a later date. I'm dead tired.
* linter aaaaaa
* Take a bite!
* FINALLY, A COMPONENT!
* ghost macro.
* Review, typos, beheading of a lame comsig.
* Typo. Now I'm self-obliged to test it again.
* It works.
* Defines the interrogation room as unique area and not 4 different var-edits
* Fixes the gaping hole in the wall
* We added a new map at the very end.
* Blaseball
* Committing the changes
* Rebuilds the deltastation setup in case it's actually breaking something...
* vendor
* more
* fex
* reeee
* WIP vendors
* BIGGERING AND FIGURING MORE BIGGERING
* CAPITALYSM!!
* ops
* tank refilling
* not working yet
* sprites and construction
* some stuff
* docs
* maps
* requested changes
* more changes
* change
Co-authored-by: tralezab <spamqetuo2@gmail.com>
* heat pump rework
* f
* efficiency
* powe
* powermess
* better math
* math and enviroment equation
* freezers connected to waste pipenet and co2 recircled in waste
* smol
* rotate danger
* upgrades
* minor tweaks
* requested changes
About The Pull Request
Currently admins can't access the ticket logs for Resolved, Disconnected, Closed and Active tickets due to an early return that will block these from being opened in 100% of circumstances.
Clicking on the Active/Disconnected/Closed/Resolved tickets would have behaviour handled by /datum/admin_help_tickets/proc/BrowseTickets() which was reached through Click() calls.
image
When we call .Click() from topic calls, we provide a null var for the control parameter.
This then leads through to /client/Click() where #57084 added a bunch of if(!control) checks supposedly ported from TGMC (or at least Fikou couldn't explain why we changed that).
I can't find a single instance of us using this locally, it appears it's always passed through to Byond. Byond docs at http://www.byond.com/docs/ref/#/client/proc/Click describe it as control - the name of the skin control involved
I can't see any reason to early return if control is a FALSE-y value. This check is what was blocking access to the admin_help_tickets datum.
In testing, removing these checks restored previous functionality.
Why It's Good For The Game
Admins less triggered.
Changelog
🆑
fix: Admins can once again open the stat panels to look at active, disconnected, closed and resolved tickets.
/🆑
Me again, moved wintercoats code from suit/miscellaneous into suit/wintercoat
24 wintercoats, likely something that might get new ones added in the future since some jobs still don't have theirs and I might move their icon files to their own file too to make it easier for future additions once this is added.
Moved some lines around, added a small tag before each suit because it was hard to read where one start and the other ends, yadda yadda yadda...
Now do you think this is over? Nooooo... I started to move this around because I, as Atmostech, want to hold a gas analyzer in the exo slot, like those guys at science (And medical for some reason???) can!!
Might need some rebalancing on what each can hold but that is for later.
So, turns out when assigning values to crates, a good number of the "large object" crates all have multiples of their export, and that didn't get assessed when giving them their current values. As it is currently, you can make infinite credits by ordering some select crates. This adjusts their prices to make them not do the bad, and work in-line with similar crates that sell lower than their buy value.
Also, fixes an issue with liquid tanks having a component of their sell value not tied to the defined, which was completely glossed over in the price rework, and is now scaled to the correct current value.(500 cr crates -> 200 cr crates).
Removes the "Space-American" and similar tags from customer bot names.
The robots have unique sprites and sounds, and themed names and chat lines. These tags aren't really necessary and pretty much just ruin the joke by telling the punchline.
Also, "Space-<Earth Country>" is dumb.
* fullauto component
* eh
* h
* brap
* it works!
* FUCK SHITUP
* dumbass
* l6
* oops
* GOD
* THE LAST 10% OF A PROJECT IS 90% OF THE WORK
* slopwer projecitles, replaces the tesla gun
* heavy
* minigun
* minigun stuff
* runtime fixes, pointer icon
* nuh uh
* makes modifeirs things
* nerf this
* yes
* aghh
* agh
* real high intensity changes here
Co-authored-by: Ryll-Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Makes tanks use obj_integrity instead of their own snowflaked version.
Makes tanks check for exploding when they are destroyed, rather than once every process.
Makes tanks always leak their gases when they are deconstructed.
Removes the ability for tanks to seal themselves back up over time.
Makes the bomb spawner actually produce functional bombs.
Removes the extraneous syndicate bomb spawner subtype.
Miscellaneous code improvements to tanks, bomb spawners, and the blastcannon.
Fixes the explosives compressor doubling the power of any bomb you put in it.
The changes to tank rupturing behavior shouldn't effect most tritium fueled TTVs including the 50K recipe. Toxins players don't need to worry about suddenly being incapable of getting points or refining anomaly cores. They should only really effect singlecaps, but I don't know enough about singlecaps to know what recipes I should test. I have confirmation that at least one mix is not effected by this.
The self-sealing properties of tanks have been removed. I'm not sure what the purpose of it was, I have heard that it was used to enable hand-portable plasmaflooding, but I'm not familiar with the practice.
As it turns out, the basic bomb spawners were broken on master! I have made the bombs they produce maxcap instead of just spring a leak. Since they maxcap by default now I have removed the syndicate subtype used to spawn the TTV produced by the cuban pete arcade game and replaced it with the normal timer subtype. Since none of the bomb spawner subtypes were used for anything else this shouldn't have any effect on the game.
On a similar note, I have discovered that the maxcap recipe on the wiki stopped working at some point since it was written. I will replace it with a functioning set of instructions.
Less snowflake code.
Bomb spawners are actually functional now.
Slightly better code.
The explosives compressor accurately reflects the power of the bomb you put into it.
Security officers will now be paired up together in the same department, across departments. This means that, instead of 4 officers being split across 4 departments, there'll now be 2 groups of 2.
Late-join officers will be put into any department with only 1 officer. If none exist, the least populous department will be chosen, with their preference having priority.
Updates the maps to have more spawns for departmental officers. Delta previously had none, and now has some. Fixed a bug where MetaStation's security departmental officer was a supply one instead.
Removes the "random" departmental preference. All security officers are now given a department. The "none" preference still exists, but just to show that you don't care which department you're put into.
Updates the config to comment out SEC_START_BRIG. This is what the configuration was already on live servers.
This is something that should likely be test merged, but it mucks with savefiles. Luckily, the only damage it does is changing random departments to none, so if a TM is reverted, only that will have to be changed.
Clears out two deprecated explosions systems (explosion ids and explosion levels)
Refactors a bunch of contents_explosions procs to be maybe slightly faster.
Cleans up a bunch of ex_act code.
Slightly cleaner code
A few less unused vars on /atom and /turf
* Fixes a harddel caused by the FUCKING MACHINE VAR WHAT THE FU-
* Fixes a tram related harddel, the proc that removed things from the riders list worked on stuff passed in by Uncrossed, but failed with the qdeleting signal. I've made a wrapper proc to better support these things, added signal handlers, and removed an if check that hid nulls (If it's breaking I need to know)
About The Pull Request
Fixes#57446
yeah not my best moment, holodeck currently sets SSatoms to add every call to InitAtom() to a list and then give it back to the holodeck console (it actually goes through map_template/holodeck to do it but whatever). However it turns out atom/New() calls InitAtom too, so if an atom is created while SSatoms is still creating the list to give to the holodeck then that atom is added to the list regardless of whether or not its actually from the holodeck template.
Now theres an extra argument to InitAtom that tells it whether its spawned directly from a map template (ie, its part of the input list of uninitialized atoms that InitializeAtoms was given) or otherwise the output list that the holodeck uses is populated by calling GetAllContents on all atom/movables spawned directly from the template.
also renamed some vars in initTemplateBounds because it was hard to reason what it was doing and made it use as anything
also note that loading a map template with returns_created_atoms = TRUE will no longer track atoms that arent in the map file but are spawned directly onto a turf, currently nothing does this with the holodeck (which is the only map template that has this feature)
by the way this bug is my fault
Why It's Good For The Game
incredibly incredibly unlucky new players dont deserve to be deleted just because they didnt spawn in the holodeck
Changelog
🆑
fix: the holodeck is no longer so powerful that it can destroy anything and everything that dares to start existing while it's busy loading programs
/🆑
About The Pull Request
Adds a function to Siliconnect in which you can tap a borg using a mobile device that is currently running the software, and it will download the borg's logs. These logs list events such as being locked or unlocked, taken offline and being restored, and the process of being emagged. Borg logs will now list the emag user's name as a new user.
Downloading the logs is done by right-clicking the borg while the software is open and active. This will "tap" the borg with the device, initiating the log transfer automatically. The transfer will take eight seconds to complete, requiring you and the borg to stay adjacent the entire time, and the borg will get a large red text alert about the upload when it starts. The logs are also not stored permanently on the device, and will be lost if the app is closed.
This PR also introduces the tap() proc for modular computer programs, and adds functionality the the computers to call it when right-clicking with the tablet as a tool. Should the app use the tap in a meaningful way (such as starting a borg log download), it will return TRUE, and the computer will end the secondary attack chain.
Currently, this requires using a tablet or laptop with Siliconnect, as you cannot tap with a console. Someday I hope to add an additional hardware option for consoles in the form of a wireless hand scanner to replicate tapping.
Why It's Good For The Game
Adds a neat way to "diagnose" a borg acting oddly, assuming you have a way to keep them still. Allows one to view if the borg has been emagged, by whom, what SiliConnect messages the borg has received, the number of law changes that have been made, as well as some other (somewhat fluff) information relating to taking damage and getting upgrades.
Changelog
🆑
add: You can now download a cyborg's internal logs by right-clicking them with a mobile device running SiliConnect. Take a look if one is acting a bit strange, you might find something interesting.
add: Borg integrity (health) is now roughly shown in SiliConnect, under "Condition".
/🆑
To Do:
Fix the to_chat not being sent to the borg when a log transfer breaks due to distance
Add some sort of text feedback when tapping an atom with a device, or viewing one being tapped.
Possibly restrict syndicate borgs from having their logs viewed by SiliConnect (and likewise with station borgs and Roboverlord) Changed my mind on this, will implement later if we find it's needed.
Change the log area of the window to expand naturally rather than use a fixed height
image
I'm not super deadset on the emag user's name being listed. It seems like a neat function unique to having a tablet running Siliconnect (as most of the other info is already available through other means), and one can always pop the brain out for a re-borg and demand the name anyway.
About The Pull Request
REM was changed from 1 to 0.5, so there were a few unintended side effects from that. It also fixes this:
image
And sets the hands to fire on a timer so the effects are shorter but more intense, as well as having the lag compensator actually work.
This doesn't fix the smoke/foam effects which I will fix after this because that's non specific to helbital.
Why It's Good For The Game
Fixes bugs and restores intended functionality.
Changelog
🆑
fix: fixes helgrasp's lag compensator and text
qol: Sets helgrasp to fire faster but last shorter
/🆑
About The Pull Request
In https://github.com/tgstation/tgstation/pull/57010/files#diff-08a9c12575e75bb692c000da3f7eea30c0340da26171c5c788fd2b17afef92b5 Floyd did an undocumented change to Mulebot behaviour.
He moved crushing from the /human/Crossed level to mulebot/Cross.
The problem is:
image
Cross (and Crossed) are called when some other object Crosses us, not when we Cross some other object.
This meant that... Well... Walking into a mulebot was deadly. Buckling to a mulebot was deadly.
lGrnThJEWG
And being buckled to a mulebot that ended up moving was deadly multiplied by the number of times the mulebot moved.
QJNXqBHZ8m
Also why can you push mulebots when things are buckled to it? That seems like an oversight.
I added new signals to the atom/movable/...Cross... series of procs that are sent from the thing crossing our AM. The thing crossing our AM can then listen for that signal on itself, and it now knows when it's crossing something! BOOM! CRUSH TIME!
I've also added a check to /mob/living/proc/PushAM to prevent pushing an AM buckled to a thing when you wouldn't be able to pull them. This check also takes into account if you'd just have the raw movement force to push the thing they're buckled to as well. This should put a stop to being able to push mulebots around when they have mobs buckled to them.
Also, you can swap places with active Mulebots. This is probably not intended. I've added TRAIT_NOMOBSWAP to them.
The end result? Mulebots that just work.
And don't worry, you can still crawl under them.
Why It's Good For The Game
Feex.
Changelog
🆑
fix: Mulebots no longer murder people just because that person dared to bump into them.
/🆑
This PR allows the HFR to use different gasmixes as fuel, these will be able to produce different gases based on the power level.
The UI will have all the specifics for the different mixes
These gas mixes also change some variables and energy releases
Increased filtering amount to meed demands
Removes the toasted sandwich. There is now a cheese sandwich, and a grilled cheese sandwich. The cheese sandwich is made through the crafting menu under sandwiches from two slices of cheese and two slices of bread. The grilled cheese sandwich is made by putting a cheese sandwich on the griddle in the same way that you would make a steak.
Reworks the main handlier for impurities and adds it to the add_reagent proc instead. Adds an option to bypass the purity splitting too. This reduces the amount of add_reagent calls and will prevent any unintended on_mob_add() and delete calls for reagents that are removed from splitting.
Fixes smoke, foam and cigarette issues too - since they used copy_to isntead of trans_to.
It's baaaaad. Very bad. There are way better ways to do this but I
don't honestly have the capacity to do them. The sprite states are all
fucked up, it's an odd case of something not being snowflake enough in
the right places, the goddamn thing breaks if you drop it... For fuck's
sake, Ryll tried to fix it and even they couldn't. No, fuck it, get rid
of it, we'll rewrite it later.
There was around 440 icons in the helmet file, around 70ish were
plasmaman helmets so I'm moving them to their own file to make things
cleaner.
Also moved the basic plasmaman envirosuit together with the civilian
ones since it's basically the assistant one, better than in the middle
of miscellaneous uniforms.
