The check for incapacitated is normally done in the click proc since
that way it's checked on all of attack_hand, attackby, etc.. The
keybinding uses attack_hand instead of the click proc because it would
go through as a shift click and examine the item instead of grabbing
it if the click proc was used.
Removes the get_organ_target proc because I'm to lazy to fully
refactor laser eyes. It is embarrassing that we have a proc like this
in the code. Also makes mob code less cursed, one proc at the time.
Fixes a bug with human where sometimes the armor from the wrong
bodypart gets used when they get attacked.
Bugs bad. Also, armor code is highly cursed.
* Payment generation rework and no repeated target
* Blacklist
* Remove pod explosion
* contractor baton
* darker highlight
* Slight increase for the higher paying contracts
* Victims get healing injected to bring them out of soft crit/crit
* pod send fix
* Text changes
* More text tweaks
* New baton - custom sprite/sound
* Better sound - fixes
* Stutter
* text
* classic_baton rework
* attack silicons still, and only show charging for new baton
* Properly attack/stun silicons where appropriate
* . list
About The Pull Request
I ended up just rewriting propagation logic entirely. This needs a bit of cleanup but this is a really high priority fix.
Actually tested this time. I can confirm for sure this is working in all situations that were previously broken.
Closes#44940Closes#44936Closes#44935Closes#44929
Why It's Good For The Game
I fucked up bad
Changelog
cl
fix: cables now actually function again (I'm so sorry)
/cl
In advance of eventually adding SpacemanDMM's linter to Travis, fix everything it can currently detect.
Some lists, including global lists, are given types so that L[i].foo expressions can be checked.
Some procs are given a new form of return type annotation so that DuplicateObject(O).forceMove()-type invocations can be checked.
Open to syntax suggestions on the return type annotations, and on whether the preprocessor strategy makes sense.
Return type syntax is currently roughly:
<typepath> | <paramname>([_])*(.type)?
About The Pull Request
Overhauls the gui for the Research Sever controller (see below), and adds a bit more info about each server. Allows the RD, or anyone with related access, to shut off servers and thus disable point generation (emag to bypass access restriction). Adds temperature readout for each server, for fluff and possibly future relevance. Servers are listed as "Offline" if they are under EMP effects or have no power. Servers now have a random four-digit hex number following their name, to help tell them apart.
Adds a full list of all research history in a table below the server readout on the server controller, sorted with the newest on top. Lists the name of tech, cost, name of the researcher, and the location they researched from.
Adds in code to mark servers without power as not working. This seems like an unnoticed bug, to be honest.
Animates the working server sprite, and adds a disabled and powered-off sprite.
The "research_log" list variable for /datum/techweb is commented as being meant for IC use, and was being updated already, but as far as I can tell was never used anywhere. So I have re-organized it a bit to feed the prior-mentioned table of research history.
Why It's Good For The Game
Gives the RD a light bit more control over research, allows them to cut off passive point generation if people piss them off, and gives purpose to the server controller console.
Changelog
cl
add: The R&D Server Controller console now lists the entire research history, including names of people who researched each item and locations it was done from.
add: The R&D Server Controller console can now be used to disable the servers if someone makes the RD upset.
fix: Fixed the R&D servers working without power.
imageadd: R&D server sprites are now slightly animated, and new sprites have been added for when the server is disabled or off.
/cl
It's a pain when you are a janitor and the crew starts losing limbs in
the hallway and you can't quick grab them with the trashbag. The head
bodypart overwrites it to bulky so this doesn't change it.
Now picks from a bigger list for each level, for a bit of variety and
to avoid all random diseases sharing the same cure.
Makes the higher levels harder than previously, while adding a more
consistent increase in difficulty of getting a hold of virus cures.
List is now:
1 - Copper, Silver, Iodine, Iron, Carbon
2 - Potassium, Ethanol, Lithium, Silicon, Bromine
3 - Table salt, Sugar, Orange juice, Tomato juice, Milk
4 - Spaceacillin, Saline-glucose solution, Epinephrine, Charcoal
5 - Oil, Synaptizine, Mannitol, Space drugs, Cryptobiolin
6 - Phenol, Inacusiate, Oculine, Antihol
7 - Leporazine, Mindbreaker toxin, Corazone
8 - Pax, Happiness, Ephedrine
9 - Lipolicide, Salicyclic acid
10 - Haloperidol, Aranesp, Diphenhydramine
11 - Modafinil, Anacea
Level 1 and 2 have simple chems, some can be gotten through grinding
stuff.
3 has kitchen/bar/hydro stuff
4 has stuff easily found in medbay or medbay vendors
5 has three chem drugs
6 has five chem drugs
7 has slightly harder drugs
8 is drug themed, has drawbacks
9 is a bit harder again
10 are worse, has fairly bad drawbacks so eat sparingly.
11 are hard to make, anacea has chem purging and some slight tox
damage.
Will need a wiki update.
Why It's Good For The Game
Makes high virus resistance more favorable, and creates some need for
some obscure chems.
About The Pull Request
You can stamp eggs with a clown stamp, similar to how you can use a crayon on them (the rainbow crayon is taken, so I just went with what bedsheets do) to create one of several kinds of clown egg. The eggs are functionally no different than the colored eggs we already have, just clowny.
Thanks to Pugnacious-Gnome for the sprites.
Why It's Good For The Game
Clown eggs are a real clowning tradition that has existed for decades. If West of Loathing has them we should have them too. Honk.
Changelog
cl bandit
add: Nanotrasen's clowns have begun to preserve their images by stamping eggs with their NT-issued clown stamps. This is fine and normal.
/cl
* Night Vision HUDs are more light sensitive.
flash_protect is now -1
* NVGs are now more light sensitive.
flash_protect is now -1
* Thermals are more light sensitive.
flash_protect has been set to -1 for all thermal glasses, considering they give night vision.
AIs now get an alert and sound effect just like what other mobs get
from a defib (and used to get from cloning). I used the same sound
effect because it's recognizable in that it means being brought back
to life.
Currently AIs don't get notified at all when they get revived, and the
best hope for whoever revives them is that they happen to check their
body to see if anything changed (or if someone calls out over common
and the AI player sees it).
Allows admins to see when vessels have been awoken and also lists
their objective in the game log.
Fixed bug where hivemind vessel awakening would not be logged.
Fixed bug where awoken hivemind vessel objectives would not be logged.
Slightly modified the deadchat text for awakening.
Signed-off-by: Space Prius <bubba041102@gmail.com>
Fixes medbay intercoms
DoNUT
Delta rad collectors
no free loot, bad powergamer
more duplicate pipes
even more duplicate garbage
I've about had it with these fucking duplicates
donut pipe fix pt2
I added empty boxes to cargo, I decided to follow the restriction
stated in the file and set the price to 700, but my original intention
was to have it be 500 so it isn't a completely horrible loss to the
QM, which a more experienced contributed can do if they like. Allows
Cargo to store bulk items easily after they inevitably sold every
crate in the station.
Removes the useless split by value lists. Updates savefile after
removing invalid quirks. I'd prefer usual savefile validation but quirk
lists are built pretty late. Other solution would be hooking all prefs
to after quirk SS initializes, this seems less intrusive if ugly but
I'm open to alternative suggestions.
The chef's compartment and any future compartments of this type are
moved to the top of the interface.
It is time to unleash the awesome power of the free market and
cultivate a spirit of entrepreneurship. By placing the chef's
compartment on top of the subsidized swill provided by tyrannical
pseudo-governmental entity know as Nanotrasen, we can promote the
commerce of those possessing a mind undulled by the poison known as
socialism. God Bless the USA
* vomi/tg/oose
* fuck
* cleaning up icons
* action button time
* seperating if checks
* makes goose hungry
* untested
* last change
* new additions
* qucikfix
* fug
Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>
* fugg
Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>
* fix the fucky wuckies
* ninja spent a full hour of their life spoonfeednig me on how to make an untyped proc
* FUCKING INDENTS
* whoever made that comment in turf.dm is a buffoon
* does more things
* adds return things
* appease ninja
* makes maintainers happy
* last fix maybe
* adds more fun
* makes more maintainers happy
* balance
* it can now be loose
* goose_satiated
* fuck
* ok maybe 170 is too much for a max
* Update code/modules/mob/living/simple_animal/hostile/goose.dm
Co-Authored-By: spookydonut <github@spooksoftware.com>
* Update code/modules/mob/living/simple_animal/hostile/goose.dm
Co-Authored-By: spookydonut <github@spooksoftware.com>
* Update code/modules/mob/living/simple_animal/hostile/goose.dm
Co-Authored-By: spookydonut <github@spooksoftware.com>
* Update code/modules/mob/living/simple_animal/hostile/goose.dm
Co-Authored-By: spookydonut <github@spooksoftware.com>
* Update code/modules/mob/living/simple_animal/hostile/goose.dm
Co-Authored-By: spookydonut <github@spooksoftware.com>
* woops
* Revert "Update code/modules/mob/living/simple_animal/hostile/goose.dm"
This reverts commit 9f45c26721550d5991240b82dcddf01be81ccd3b.
* Revert "Update code/modules/mob/living/simple_animal/hostile/goose.dm"
This reverts commit 0fe63392f608114a4f82e59644dd4b46599032ff.
* Revert "Update code/modules/mob/living/simple_animal/hostile/goose.dm"
This reverts commit 4117e196b8093ad0a966d54dff43887d623c8f74.
* Revert "Update code/modules/mob/living/simple_animal/hostile/goose.dm"
This reverts commit 8bfbb977cba7bb1eda83532bc8a3865373e4f019.
* Update code/modules/mob/living/simple_animal/hostile/goose.dm
Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>
* Update code/modules/mob/living/simple_animal/hostile/goose.dm
Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>
* Update goose.dm
* i hope this doesnt cause more merge conflicts
* Revert "i hope this doesnt cause more merge conflicts"
This reverts commit 842e1a8a851c45c1d94fb0720d0995a5dd2c7083.
* test
* ok maybe this time
* please god work this time
* please god work this time
* FATHER INTO YOUR HANDS I COMMEND MY SPIRIT
* shortening typecheck
Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>
* does
* WHY HAVE YOU FORSAKEN ME
* IN YOUR EYES FORSAKEN ME
* IN YOUR THOUGHTS FORSAKEN ME
* as it turns out getting the turf twice wasnt necessary
* Notify System
* V2
* Adds a hint
* Stoned fixes round 1
* Use grammar wells I can
* This didnt work
* I wish you could test on TGS without committing
* Jordie fixes round 1
* oops
* This took way longer than it should have taken
* Adds in endnotify for serverops
* Spacing
About The Pull Request
Same premise as #44712 but using a simple regex replace and also on the client side
Closes#44712
I was gonna PR it to #44712 but half way through I realized I had already replaced nearly all of bobbah's changes, and after I was finished the branches shared nothing.
Why It's Good For The Game
The delta is way smaller and simpler
Should solve the DoS concerns without needing a limit on bad chats because it's not a loop it's on the client side
Changelog
cl JJRcop and Bobbahbrown
tweak: When attempting to say a blocked word in character you will be notified which ones were blocked.
/cl
About The Pull Request
Stuff that should logically require you to actually be metabolizing the reagent now requires a liver, or the reagent to not need one.
Some reagents have been granted self consuming status, like holy water, since their effects are not tied to the metabolism.
Fixes#44650Fixes#43024 since there should be no real way to mitigate the constant toxin damage now
Why It's Good For The Game
Less exploits with livers, more consistency in mechanics.
Changelog
cl XDTM
fix: Viral healing symptoms that are tied to reagents now also require a functioning liver to work.
tweak: Holy water, Pyrosium, Cryostilane, Napalm and Phlogiston no longer need a liver to have their effects.
/cl
This makes lavaland atmos random per round. You won't get eternally burning hell worlds or vacuums but it's nice for a bit of variety.
Admins can edit the gas mixture for all of lavaland at once if they want to ruin some miners' day.
image
cl
add: Lavaland atmos is no longer a preset gas mixture and varies per round
tweak: Bonfire minimum oxygen content has been reduced
/cl
About The Pull Request
Adds department skirts to all related lockers/vendors
Why It's Good For The Game
Skirts good
Changelog
cl
add: added department skirts
fix: fixed secskirt dixel
/cl
About The Pull Request
Gives the specialist space suit supplied in the contract kit it's own custom sprite. Sorry about quality, compression seems to mess it up a bit.
When first assigning yourself to the tablet too, a greeting soundclip will play.
Sprite
Why It's Good For The Game
Laying down the foundation for it's own antag type.
Changelog
cl
add: Contract kit's specialist space suit now has its custom sprite.
add: Assigning to tablet now plays greeting soundclip.
/cl
