Commit Graph

10434 Commits

Author SHA1 Message Date
MrMelbert
b59cc135ab Moving around while non-existent will not give you a message saying you're buckled to the concept of non-existence (#70483)
* Being removed from existence no longer provides strange feedback messages

* Immortality talisman, too
2022-10-19 20:26:20 -04:00
LemonInTheDark
a625fc8038 Cleans up the fallout from plane cube (#70235)
* Cleans up the fallout from plane cube

Alright.
Makes cleaning bubbles respect planes
Adds support for updating overlays on move, fixing an issue with pointing at items
Adds better error messages for failing to provide args for mutable_appearance()
Fixes a bug where string overlays were not respecting insertion order

* Adds documentation for offset spokesman and offset_const

* Better stack trace

* Removes some redundant uses of cached MAs

At this scale, attempting to cache MAs like this has 0 impact on anything
And just makes things more messy then they need to be

* ensures fullscreen objects START offset, so things are always proper

* ensures chatmessages always have the right offset

* fixes compile

* whoops, the above lighting plane should actually be ABOVE the lighting plane

* fixes compile, also cleans up the fire overlay a tad

* Adds a unit test for plane masters that are shrunk by multiz being double shrunk

This is slightly hacky because of how I'm handing the plane master
group, but it's not THAT bad, and gives me some real good coverage

* Properly targets the seethrough plane at the game world plate. This fixes unit tests, and also just makes more sense

* whoops

* oh

* adds datum support for allocate(), cleans up a harddel from testing

* Makes camera chunks index at 1, and also makes them support non powers of two sizes, since that was unneeded

* fixes runtime in allocate
2022-10-20 09:00:02 +13:00
LemonInTheDark
cd3a778915 PKP Mind Virus: Glorfing Cigs edition (#69904)
* PKP Mind Virus: Glorfing Cigs edition

If you glorf while smoking you'll get the cig stuck in your throat, leaving you unable to breath, speak, or eat. Based off the sort of cig you have a random delay before you vomit up the cig. (Pipes last forever don't philoso-larp kids). Other players can help you by using the help action on you while you're hurt, which leads to something imitating the himelich manuver, a broken chest, and a vomited up blockage. Other forms of vomiting will work too, if that's even applicable.

Oh I fixed a bug in vomit code. Because paralyzing you forces you to the ground, thus changing your dir, paralyzing vomits always went down. This is cringe, easy fix tho.

Ah and I added some extra functionality to sound loops too. You can set them to pick and take from the provided list, then refilling it once it's empty. This keeps some variety while preventing the risk of repeat sounds

Oh and I added some new signals. Some misc ones, for force say and a different kind of help then the existing one, which I renamed. One for breathing, which I used to clean up leroxin. I was planning to hook this but didn't need to in the end.

One for vomiting too. and eating. Also added a way to update looping timer delays. Forgot about that, I also added variable delay for sound loops, because I thought it sounded better here.

Features audio courtesy of our very own san7890, and the quake jump sound.
2022-10-19 06:34:45 -04:00
dopamiin0
d74f164499 Prevents chaplain's backpack from noclipping better than a Gmod admin. (#70503) 2022-10-19 00:50:21 -07:00
san7890
2878345ebb Swaps sleep() to use SECONDS define, changes some sleep(1) to sleep(1 TICKS) (#70452) 2022-10-18 21:25:23 -07:00
texan-down-under
fedcbcbb18 Able to clean storage items with soap (#70575)
Co-authored-by: etherware-novice <candy@notarealaddr.com>
Co-authored-by: Candycaneannihalator <candycane@thisisnotarealaddr.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-19 01:52:40 +00:00
Rhials
132508632b Adds the Command Intercom, kills off the varedited freerange intercoms on some maps. (#70287)
* Command intercoms now have a unique sprite and are standardized on all maps.
* Also prevents freerange intercoms from accessing syndicate radio.
2022-10-18 19:06:39 -04:00
YakumoChen
f4d0902f5f You cannot plant c4 on observers (#70595)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Aki Ito <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>
2022-10-18 06:57:11 +00:00
Profakos
e16bdc0b52 Goodie lockbox contents can no longer go missing (#70572)
Adds a trait that blocks the manifest error that removes items
2022-10-17 08:52:43 -07:00
Paxilmaniac
7082880bf3 Stairs DLC: Buildable stairs, material datum staircases, fall up a staircase (#70504)
Adds a few new types of stairs, and makes stairs buildable within rounds.
Also removes the terminator sprite variation for stairs, because its basically unused and really not needed with plane cube multiz.
2022-10-17 16:23:37 +02:00
Jackraxxus
311bd90ac9 Makes Delta Station EVA Toolbelt Actually A Toolbelt And Also The Ashwalker Ruin and Also Makes It More Obvious That The Base Type Of Belt Is Not A Toolbelt (#70548)
* Fixes Deltastation EVA and Ashwalker's belts not being actual toolbelts.
* Gives the base belt type a unique name and description to stand out from actual toolbelts.
2022-10-16 21:44:15 -04:00
Yaroslav Nurkov
943e6fba3b Back reason to withdrawal in ntpay. Remove all about commission (#70549)
* NTPay app now properly logs the user taking credits out of their own account again.
2022-10-16 21:40:59 -04:00
lnGoror
7c1df93b58 Fixes missing sabre sheath bug and adds new inhand sprites (#70459)
Fixes missing sprite bug and adds new inhand sprites for sabre sheath
2022-10-15 14:16:09 -04:00
Tim
823ba2a8f0 Add hotkeys, screentips, and sounds for flashlights (#70383)
* Adds screentips to flashlights, and makes Right-Click immediately turn it on if done with an empty hand.
* Also gives glowsticks and flares different sounds so they differentiate more from flashlights and eachother.
2022-10-15 00:00:40 -04:00
Tastyfish
8239bc9ced Stops people from removing infinite power cell from combat defib (#70494)
* Stops people from removing infinite power cell from combat defib

* cleanups

* balloon alert
2022-10-14 15:45:38 -04:00
Profakos
de5ef27d12 Fixes displayed advanced manipulator requirements (#70455)
* Base_name is null in the children of manipulator

* Properly does the fix for machine frames
2022-10-12 23:21:54 -04:00
ShizCalev
3362f2c88a Makes flashers actually flash again! (#70438)
* Makes flashers actually flash again!

* Typo

* Update code/game/machinery/flasher.dm

* review

* Update wall_mounted.dm
2022-10-12 20:58:53 +00:00
John Willard
41ca4962db Moves cleaning to an atom proc to afterattack signal (#70239)
* Hopefully fixes Cleaning

* Cleaning off window blood is now handled by the Window itself
* Cleanbots now have an advanced mop built into them, I am hoping in the future we can make cleanbots have their mops taken off, but I'm not good at spriting so it isn't a thing yet.
* Adds a pre_clean_callback to replace the should_clean arg (mostly)
* Removes the atom cleaning proc, replaces it with a signal for afterattack on a cleaning tool.

* Fixes and improvements

* adds a new define that allows pre_clean_callback to cancel cleaning entirely, used for mops to check for being wet or attacking buckets and such.
* Fixes cleanbots not properly working, removing their mop and just registering for a signal that bots send instead.
* Changes cleaner component to take proximity into account, that way we don't have to check it on each item's individual afterattacks, that way we don't have to call parent at the end either.
* Improves check_allowed_items a little bit because I hated how it was used for soap.

* Update cleaner.dm

* reviews
2022-10-12 11:22:04 +02:00
GoblinBackwards
1c886d4324 Fixes mail changing existing nuke codes (#70435)
* Fixes mail changing existing nuke codes

* Fixes runtime if created without a self destruct

* Fix indent on admin message

* Makes default nuke code a define

* Rename define + autodoc

* Update code/game/objects/items/mail.dm

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-11 22:57:09 -04:00
ShizCalev
c137b2f270 Fixes shields inhands (#70395)
Fixes #70377

Stobe shield has been broken for.... hell I don't even know how long lmao

cl ShizCalev
fix: Fixed some missing shield inhand icons.
fix: The strobe shield's inhand icon now plays the flashing animation when triggered again.
fix: The strobe shield will no longer blind the person holding it when it deflects a blow.
fix: The light from the strobe shield's flash no longer appears in your held inventory slot.
fix: Fixed the east facing left-handed strobe shield sprite being misaligned by two pixels.
/cl
2022-10-12 14:39:59 +13:00
ShizCalev
159f5fd33f Allows you to change the blade color of toy swords with a screwdriver (#70376)
Requires #70364

cl ShizCalev
qol: You can now change the color of toy energy swords with a screwdriver!
/cl
2022-10-12 14:39:36 +13:00
ShizCalev
39810b265c Fixes baseball bat throwing qdeleted things runtime (#70333)
Attacking stuff can destroy it (ie beepsky) if they have low enough health.

The following runtime has occurred 1 time(s).
runtime error: Qdeleted thing being thrown around.
proc name: throw at (/atom/movable/proc/throw_at)
  source file: atoms_movable.dm,1132
  usr: Harold McKormack (as Adam Karl... (/mob/living/carbon/human)
  src: Sergeant-At-Armsky (/mob/living/simple_animal/bot/secbot/beepsky/armsky)
2022-10-12 14:38:00 +13:00
GoldenAlpharex
ed48776e7d Fixes health analyzers displaying missing lungs and missing livers on species that don't have them due to their inherent_traits (#70436) 2022-10-11 17:24:05 -07:00
ShizCalev
d6ce53a288 fixes boxcutter n a couple other inhads (#70425)
fix: Boxcutters now have inhands again.
2022-10-10 20:30:56 -07:00
MrMelbert
ced20c8e63 Converts silent to status effect + small cleanup of can_speak / can_speak_basic / IsVocal, and sign language (#69963)
* Gets rid of a lot of weird vocal checks
- unifies all vocal checks under can_speak and try_speak
- de-spaghettis a bit of sign language stuff
- introduce a silence status effect
2022-10-09 23:46:57 -04:00
John Willard
245a726ccd renames compressed matter to RCD matter (#70387)
Renames compressed matter cartridge to RCD matter cartridge, to better reflect what it actually is, making it less confusing for people who want to print it out. It's already been renamed on its design, just not the item itself.
2022-10-10 03:13:51 +00:00
Hatterhat
7ced7ec7d7 you can no longer steal your shoes from yourself just in general (#70296)
Adds a check for shoestealing that prevents people from taking their own shoes off, fixing an exploit to remove chained shoes from yourself.
2022-10-09 01:35:08 -04:00
itseasytosee
e0b706c36c Put clothing on people by clicking on them with clothing inhand + targeting correct area. (#69560)
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
2022-10-08 18:51:29 -07:00
necromanceranne
a97c68a6df Infiltrator Suit Rework: MODsuit edition (#70303)
* Reconfigures the Infiltrator armor set into the Infiltrator modsuit. Comes with a brain agony demoralizer device, and makes it literally impossible to examine you.
2022-10-08 22:05:07 +00:00
Fikou
2e5e7c6922 refactors dehydrated carps to be less shit (#70243) 2022-10-08 17:31:49 -04:00
Tastyfish
40feb0bd42 Fixes baguette examine text (#70359) 2022-10-08 01:22:18 -05:00
ShizCalev
ad87985ff2 Fixes papersack (#70341)
fix: Fixed the papersack.
2022-10-07 20:15:37 -07:00
ShizCalev
7048110298 Inhands var hardsetting (#70364) 2022-10-07 19:08:09 -07:00
Tim
52acae4cd7 Easter Egg DLC - Captain's log and WGW (#68411)
This adds two easter eggs that have been apart of SS13 lore since the game was created:

    Captain's Log - Broken tape recorder that (spawns on the derelict station)
    Woody's Got Wood - Used spellbook that makes a person go temporary blind if they read it (spawns in curators forbidden knowledge bookcase)

Why It's Good For The Game

These have been apart of SS13 lore for a long time. It would be cool to have some "official" easter eggs for players to discover.
Changelog

cl
add: Add mail goodies for curator. (random books)
add: Adds easter egg - Captain's Log. Tape recorder that spawns on derelict station.
add: Adds easter egg - Woody's Got Wood. Will rarely appear as a mail goodie for curator.
/cl
2022-10-08 10:47:56 +13:00
Twaticus
c7dde06668 [MDB Ignore]Hats DMI split (#70060)
Splits head dmi into separate files for both mob and obj icons. Kept similar to suit split categorization + some more. New files include beanie, bio, chaplain, costume, cowboy, default, hats(softcaps, fedoras, head caps, generic hats), helmet(helmets and other armored headgear/hoods), spacehelm, utility(hardhats, mostly work related hats), wizard.
Moves animal/pet head sitting icons to 1 folder, pets_head.dmi
Renames PAI head sitting icon file to pai_head.dmi
2022-10-06 21:37:06 -07:00
Iamgoofball
32db39bd3d Reverts undocumented 5 credit tax on withdrawing money from your bank account. (#70363) 2022-10-06 23:18:24 +00:00
axietheaxolotl
0d0c8dfcf2 1 AM Leather Jackets (#70284)
* yeah

* yea
2022-10-06 02:51:35 -03:00
John Willard
422accbe4e [MDB IGNORE] Shuttle engines part 2: Engines are now machines (#69793)
* Makes engines machines instead of structures

* Updates the maps

* Fixes boards and anchoring

* Removes 2 unused engine types

Router was actually used a total of once, so I just replaced it with propulsion.
I think cutting down on these useless engine types that make no difference in-game would be a nice first step to adding more functionalities to them.

* Don't use power (since shuttles dont have)

Shuttles don't have APCs, instead they just have infinite power, so I'm removing their power usage for now. I'm hoping this can be removed when unique mechanics are added to engines, because I would like them to make use of power like other machines.

* re-organizes vars

* deletes deleted dm file

* Slightly improves cargo selling code

* Renames the updatepaths

* Removes in_wall engines

I hate this stupid engine it sucks it's useless it's used solely for the tram it provides nothing of benefit to the server
replaces them with regular engines
2022-10-05 21:51:38 -04:00
GrimsonGrime
53c7b85918 New Knucklebones crate (#70211)
* Adds a new 'Knucklebone' crate to the Cargo console under Service's "Costume & Toys" section, which comes with a crayon, 19 dices, and a paper explaining how Knucklebone works.
2022-10-05 19:27:44 -04:00
Yaroslav Nurkov
04ca99d7e9 NT Pay app. Money send on distance, transaction log! (#70108)
* base

* reasons

* GetToken proc, with a many remarks

* Add a way to change reason in transfer_money proc. Add a reasons.

* Reason to use the app. Commission. Standard application.

* Apply suggestions from code review - Tralezab

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>

* Tralezab & jlsnow301 advices. New format(everywhere)

* Nanotrasen

* Refactor TGUI(not me:( ). Fix useless capitalize

* Update code/modules/economy/account.dm

* Trans transforms in transaction

* coMmission. little autodoc mistalke. Translation != Transaction

* oops

* Merge Conflict

* ...

* back feats

* mistakes bye!

* ну да

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
2022-10-05 18:25:38 -04:00
YusufEmirKoroglu
bd12e19692 Adds bot launch pad (#70267)
* Adds botpad and remote

* Update botlaunchpad.dm

* Update code/modules/research/designs/misc_designs.dm

Fikou's suggested change

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>

* converted chat messages to balloon alerts

* simplified ballon alerts and added 2 new ones

* adds a clicking sound effect to controller

* Typo

* removed a duplicate ballon alert

* last tweaks to balloon alerts

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>

* Update code/game/objects/items/botpad_remote.dm

Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>

* Update code/game/objects/items/botpad_remote.dm

Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>

* Update code/game/objects/items/botpad_remote.dm

Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>

* requested changes

* parent calling

* test

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>

* Update code/game/objects/items/botpad_remote.dm

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>

* Update botpad_remote.dm

* Update botlaunchpad.dm

* Update botlaunchpad.dm

* Update botlaunchpad.dm

* Update botpad_remote.dm

* Update machine_designs.dm

* changed the research category

* Update code/game/machinery/botlaunchpad.dm

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>
Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
2022-10-04 17:20:54 +00:00
ShizCalev
1a32f60cf4 [ready] adds unit test for missing inhand icons. fixes a bunch of missing inhand icons (#70037)
fix: Fixed a bunch of missing inhand icons.
fix: Fixed cables in electrical toolboxes not randomizing their colors.
fix: Fixed the wrong colored icon showing when trying to make cable cuffs out of cables.
fix: The collectable SWAT helmet is now using the proper icon again!
refactor: Pipecleaners and power cables now share a unified color system, so they're once again available in ALL the same colors.
imageadd: Updated the screwdriver belt overlay to represent the newer sprite.
imageadd: Added a bunch of new inhand icons. Special thanks to Twaticus for doing the helmets! <3
fix: Wirecutters now have an icon when inside a belt again!
admin: Added a new omnitool subtype that allows you to spawn all items in a typepath!
fix: Explorer gaskmasks now properly reflect their adjusted state when held.
fix: Fixed balaclavas having the wrong icon when pulled up.
fix: Fixed the base energy sword (admin spawn only) being invisible.
fix: The rainbow energy sword is now a little bit more rainbowy!
fix: Fixed an tk exploit with orange handcuffed shoes.
fix: The traitor outfit in the select equipment panel is now actually functional!
2022-10-04 10:20:24 -07:00
itseasytosee
c675ad0907 Return of the NOSTOMACH trait (#70230)
* a regretable decision

* Apply suggestions from code review

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
2022-10-04 05:09:13 +00:00
Tim
29227aab52 Mail Quirk Goodies DLC - Package Bonanza (#70091)
* Add mail goodies for neutral quirks

* todo later... hur hur hur

* Add mail goodies for quirks

* Move money goodie to random spawner effect

* Add more goodies to positive quirks

* Add more mail goodies for negative quirks

* Add pajama clothing to heavy sleeper mail goodies

* Ad fedora to mail goodies for gamer quirk

* Add trenchcoat to monochromatic quirk mail goodies

* Add mail goodies to all remaining quirks

* Fix linter error

* Add candle box to spirtual quirk mail

* Clean up code for mail goodies

* Rebalance generic goodies mail weight

* Add mail goodies quirk code comments

* Add more noir items for monochromatic

* Add 3 new random spawners icons

* Add nightcaps to heavy sleeper mail goodies

* Fix plushies random spawner to work correctly

* Add code comment explaining quirk weight value
2022-10-04 01:02:38 -04:00
Fikou
d20549f8b1 removes the big oxygen tanks from erts (#70246) 2022-10-04 00:47:16 -04:00
Jacquerel
9bd751dc84 The clown box can now eat you again. (#70249)
* The clown box can now eat you again.

* Update code/game/objects/items/storage/boxes/job_boxes.dm

Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
2022-10-04 04:11:15 +00:00
Tim
f5f6b26e2d Fix xeno hivemind talk causing hissing sound (#69844)
* Fix xeno hivemind talk causing hissing sound

* Fix dullahan speech arg

Add message_range and saymode to say arguments

Add new say args to other say procs

Add new say args to other say procs

* Revert "Fix dullahan speech arg"

This reverts commit abff2bec1a03c1270b2896faa547c465e046ad78.

* Fix speech_args to be list

* Refactor hulk speech signal handler

* Revert "Revert "Fix dullahan speech arg""

This reverts commit 58997930096ef6b7fa8a1c79395595e61db954c6.

* Change filterproof to be null like other say procs

* Remove unused COMSIG_MOB_SAY defines

* Readd defines for COMSIGH_MOB_SAY
2022-10-03 23:10:45 -04:00
Mickyan
677a933820 Fixed grammar for being handcuffed while unconscious (#70265)
handcuff text
2022-10-03 22:21:39 -04:00
Tom
a0e03c56f8 removes jammer from glob on destroy (#70225) 2022-10-03 14:50:05 -05:00
Fikou
9dddcb6f48 makes radios use paths instead of new (#70252)
* makes radios initialize in Initialize instead of init()
2022-10-03 09:46:02 +02:00