* Fix spammable logging in grenades (#58781)
Adds an early return in chem grenade wires if the grenade is not secure
* Fix logging in chemical grenades
Co-authored-by: Maurukas <66576896+Maurukas@users.noreply.github.com>
* Allow for proper damage / blood spatters on GAGS icons (#58738)
GAGS-generated clothing can now have proper blood splatters and damage (bets on this breaking some dumb interaction?)
* Allow for proper damage / blood spatters on GAGS icons
Co-authored-by: Celotajs <81999976+celotajstg@users.noreply.github.com>
* dogs now resist before fetching or harassing, to unbuckle from stuff if they need to (#58686)
fixes#58656 (Pets can move while buckled in their beds)
* dogs now resist before fetching or harassing, to unbuckle from stuff if they need to
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* Fixes a fuck ton more harddels (#58779)
Redoes how geese handle eating shit, it was fucking stupid and caused harddels, and while this method is technically slower in the best case, it's a fucking goose
Fixes action related harddels, I hate how they work but at least this way they won't hold refs.
Fixes the hierophont causing its beacon to harddel
Removes the M variable from megafauna actions, it was used like a typed owner and caused harddels, so I burned it
Fixes target and targets_from harddels, replaces all setters of target with LoseTarget and GiveTarget, which should help maintain behavior. I'm not sure if this breaks anything, but if it does we should fix the assumptions that code makes instead of reverting this change
Fixes more area_senstive_contents related harddels, we need to allow the mob to move before clearing out its list.
Fixes marked object harddels (I'm coming for you admin team)
Fixes a language based human harddel
Fixes managed overlay related harddels (This was just emissive blockers, but I think this is a good safety net to have. If we clear the overlay list we should clear this one as well)
Fixes bot core harddels, I hate the fact that this exists but it has no reason to know who its owner is
Adds a walk(src, 0) to simple_animal destroy, it's the best bang for the buck in terms of stopping spurious harddels. Walk related harddels aren't that expensive in the first place, since byond does the same thing I'm doing here, but this makes finding mob harddels easier, so let's go with it
I fixed another source of part harddels, I hate fullupgrade so much
Fixes all the sound loop harddels
* Fixes a fuck ton more harddels
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* Fixes bitwise flag negation errors. (#58870)
These have been in the codebase for many years. Love, ZeWaka
* Fixes bitwise flag negation errors
Co-authored-by: ZeWaka <zewakagamer@gmail.com>
* Component readme file now links to the Signals, Components, and Elements HackMD page instead of the forum (which links to the hackmd page now anyways) (#58876)
* Component readme file now links to the Signals, Components, and Elements HackMD page instead of the forum (which links to the hackmd page now anyways)
Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
* Convert PDAs to GAGS (#58844)
* Convert PDAs to GAGS
* Leave the clown PDA as it was
Co-authored-by: celotajstg <celotajstg@ users.noreply.github.com>
* Convert PDAs to GAGS
Co-authored-by: Celotajs <81999976+celotajstg@users.noreply.github.com>
Co-authored-by: celotajstg <celotajstg@ users.noreply.github.com>
* Adds new wrinkles to monkey brains (#58631)
This does a variety of improvements to monkey ai that I got drawn into after fixing a relatively simple bug with monkeys and guns. This pr is in support of #58565 so that in the rare chance pun pun gets a gun, they know how to use it. Previously #16630 made it so monkeys could use guns but semi-recently that was broken. Now that's fixed and in addition some other monkey ai capabilities were enhanced, read the changelog for the full list.
* Adds new wrinkles to monkey brains
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
* fixes stuff made with bronze sheets deconstructing into tiles or not being able to make bronze golems (#58708)
* fixes poopy bronze tiles sstuff
Co-authored-by: Fikou <piotrbryla@onet.pl>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* Adds support for dirs and config changing in GAGS debug menu (#58794)
Previously, the menu wouldn't show you the generation steps for icons other than the south dir icons. You can now specify which you want to see. In addition the config type itself can be changed so as to allow previewing of icons that normally are not displayed directly on the map.
Co-authored-by: Aleksej Komarov <stylemistake@ gmail.com>
* Adds support for dirs and config changing in GAGS debug menu
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
Co-authored-by: Aleksej Komarov <stylemistake@ gmail.com>
* Converts the atmos senstive component over to connect_loc (#58266)
* Makes all uses of atmos_senstive pass in mapload as context
* Converts atmos senstive to connect_loc, does some general cleanup to the element, and makes it check the state of the tile the thing is on assuming creation didn't happen as a part of map loading
* Updates connect loc to match the new arg list
* Converts the atmos senstive component over to connect_loc
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* Changes a sentence written in first person to second person (#58789)
* Changes a sentence written in first person to second person
Co-authored-by: itseasytosee <55666666+itseasytosee@users.noreply.github.com>
* Fixes gunboots shooting the wearer (#58651)
For whatever reason, gunboots could immediately shoot the person wearing them when they fired. This obviously isn't ideal, so this fixes that. Once the bullet has ricocheted off something, of course, they're once again fair game to be hit. This also kills the projectile_shooter component because it was pointless
Fixes: #58242 (Bullets fired from gunboots hit the wearer)
As if the trail of people trying to kill you for wearing this isn't bad enough, you don't need the shoes themselves doing you in
* Fixes gunboots shooting the wearer
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
* The shivering symptom now actually chills you like it says it does instead of heating you up (#58181)
* ice ice baby
* broader species compatibility
* are you HAPPY NOW?
* should make the code compile
* Apply suggestions from code review
Co-authored-by: Aki Ito <11748095+ExcessiveUseOfCobblestone@ users.noreply.github.com>
* The shivering symptom now actually chills you like it says it does instead of heating you up
Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com>
Co-authored-by: Aki Ito <11748095+ExcessiveUseOfCobblestone@ users.noreply.github.com>
* woops (#58757)
I was an idiot in #57797 and forgot to make the rune wizards can buy to add shield charges to their shielded hardsuits actually delete after being used, allowing you to use one rune infinitely. Oops! This PR fixes that.
No more invincible wizards
* Fixes infinite wiz shielded hardsuit charges
Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
* Makes the explosive compressor and blastcannon actually use the TTVs they're given + the explosion changes to support that. (#58015)
* Adds explosion SFX to the blastcannon and explosive compressor
- Extracts the explosion SFX and screenshake proc from the SSexplosions explosion handling proc and lets the explosive compressor and blastcannon use it.
* Miscellaneous changes
- Adds defines for the internal explosion arglist keys
- Reverses the values of the explosion severity defines
- Changes almost everything that uses `/proc/explosion` to use named arguments
- Removes a whole bunch of argname = 0 in explosion calls.
* Removes named callback arguments.
* Changes the explosion signals to just use the arguments list
Adds a simple framework to let objects respond to explosions occurring inside of them.
Changes a whole bunch of explosions to use the object being exploded as the origin of the explosion rather than the turf the object is on.
Makes the explosive compressor and blastcannon actually use the TTVs they are given.
Adds support for things responding to internal explosions.
Less snowflake code for the explosive compressor and blastcannon calculating bomb range.*
Less confusing explosion severity defines.
Less opaque explosion arguments
*does not guarantee that the solution to letting them actually use the TTV is any less snowflake.
* Makes the explosive compressor and blastcannon actually use the TTVs they're given + the explosion changes to support that.
Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com>
* Make mindbreaker cure RDS (#58671)
Currently, mindbreaker toxin is supposed to suppress hallucinations, but the reagent itself still applies hallucination to the user which is counted towards handling hallucinations before it gets purged by the quirk.
It's annoying that the one thing advertised that should fix hallucinations with RDS doesn't work.
* Fix mindbreaker toxin not completely stopping Reality Dissociation Syndrome
Co-authored-by: Urumasi <Urumasi@email.cz>
* Add Show Hiddenprints action to VV on atoms (#58657)
This displays the hiddenprint log from /datum/component/forensics in a simple to view form, sorted by last touch. I didn't make it fancy, it's very bare bones.
I could have refactored hiddenprints to use lists in lists, which would make getting data out a lot easier, but I worry about the additional memory overhead on every atom that gets touched, so I left it as strings in lists. I did reformat it a little bit, however, to make it simpler to sort, and it looks a little nicer. Namely moving the timestamp in front of the name.
It can help a lot in admin investigations on whodunnit. Right now they have to look at the forensics component, and that's if they even know about it. This way it is discoverable by using the VV tool.
* Add Show Hiddenprints action to VV on atoms
Co-authored-by: Jonathan Rubenstein <jrubcop@gmail.com>
* Fixes GAGS generated icons having no width or height value (#58567)
* Fixes GAGS generated icons having no width or height value
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
* Full Auto Update: no crit firing, no spamclicking, more autofire, more balance
* aaa
* Update fullauto.dm
* aaaaa
Co-authored-by: Fikou <piotrbryla@onet.pl>
Co-authored-by: Gandalf <jzo123@hotmail.com>
* High-danger plants like deathnettles now require botanical gloves to hold instead of any glove type (#58503)
* High-danger plants like deathnettles now require botanical gloves to hold instead of any glove type
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* Renames GAS to GAGS (#58488)
* Renames GAS to GAGS
* Adds a hypen to Auto-Generated
Co-authored-by: Fikou <piotrbryla@ onet.pl>
Co-authored-by: Fikou <piotrbryla@ onet.pl>
* Renames GAS to GAGS
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
Co-authored-by: Fikou <piotrbryla@ onet.pl>
* Converts screwdrivers to GAS (#58453)
* Basic GAS setup
* Compile fix
* Fixes, inhands, belt icons
* New procs
* New version of GAGS
* Inhand for subtypes
* Typo fix
* Converts screwdrivers to GAS
Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com>
* Accidentally swapped the two (#58515)
* Swaps the layer and result columns in the greyscale debug menu
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
* Fixes pop restricted uplink items not properly unlocking (#58542)
Makes it so if you become a traitor when specific items are pop locked, they will update accordingly as the population increases.
* Fixes pop restricted uplink items not properly unlocking
Co-authored-by: Seth Scherer <supernovaa41@protonmail.com>
