Commit Graph

2190 Commits

Author SHA1 Message Date
oranges
37cd6e41f6 Merge pull request #26775 from Cyberboss/patch-63
Fixes atom spawning
2017-05-02 09:11:09 +12:00
Joan Lung
c6ed089214 Merge pull request #26779 from Thunder12345/revert-26739-patch-72
Revert "You can no longer queue up ahelps by queing up prompts"
2017-05-01 16:10:08 -04:00
Thunder12345
a7c10b052c Revert "Fixes Ahelp queing (#26739)"
This reverts commit 0c1620d32c.
2017-05-01 20:58:38 +01:00
Cyberboss
574c3dd19b Fixes atom spawning 2017-05-01 14:43:17 -04:00
Cyberboss
9d0185c023 Allows admins to pass parameters to New() (#26613)
* /proc/print_single_line(list/L)

* Admin datum/New parameters

* Fixes
2017-05-01 11:55:58 -06:00
Cyberboss
0c1620d32c Fixes Ahelp queing (#26739) 2017-05-01 10:37:39 -06:00
Leo
89e60cb88f Changes a lot of ticker and ticker.mode checks to SSticker.hasRoundStarted (#26720) 2017-04-30 23:35:13 +02:00
Leo
1250a1ff75 Merge pull request #26713 from Cyberboss/patch-69
[s] SDQL security patches
2017-04-30 13:30:27 -03:00
kevinz000
f7cf00cf66 Update admin_investigate.dm 2017-04-30 07:55:27 -07:00
Cyberboss
4a49086849 Patches SDQL exploits that can return world ref (#26689) 2017-04-29 23:59:03 +02:00
Leo
4bf5910e8e Merge pull request #26676 from Cyberboss/patch-56
Fix SDQL vars again
2017-04-29 18:35:36 -03:00
Cyberboss
0e0943837a Fixed Dsay always causing a disk read (#26685) 2017-04-29 12:23:39 -04:00
Cyberboss
e935f3e557 Patches potential SDQL permissions elevation 2017-04-29 11:43:24 -04:00
Cyberboss
7227868597 Option for admins to show a song's title (#26204)
* Option for admins to show a song's title

* Bluh
2017-04-29 14:01:57 +12:00
coiax
3a577221d0 Adds new debug verb for highlighting roundstart ATs (#26492)
* Adds new debug verb for highlighting roundstart ATs

Debug -> Debug Verbs enable
then
Mapping -> Show roundstart AT markers

Will highlight AT turfs, for easier location and comprehension rather
than looking at the list of coords. List of coords still works fine
though.
2017-04-28 12:58:34 -03:00
Cyberboss
520bcbdfe6 Fix SDQL vars again 2017-04-28 10:29:16 -04:00
oranges
fc114f57d5 Merge pull request #26657 from tgstation/lzimann-patch-1
Fixes ircadminwho making the wrong list check
2017-04-28 10:55:42 +12:00
Cyberboss
34e0e61e19 Adds a delete verb to the vv_drop_down (#26187) 2017-04-27 19:09:43 -03:00
Leo
faa51503b0 Fixes ircadminwho making the wrong list check 2017-04-27 18:35:36 -03:00
Leo
8ba163926b Merge pull request #26607 from Cyberboss/patch-64
Fixes SDQL global procs
2017-04-27 11:12:58 -03:00
oranges
a30bbbd173 Merge pull request #26524 from Cyberboss/SDQLRevert
Admin proc calls are now serialized per admin
2017-04-27 10:14:11 +12:00
Cyberboss
6c6fc719ec Refactors roundstart checks slightly (#26131)
* Refactors roundstart checks slightly

* Fix
2017-04-27 10:05:40 +12:00
Cyberboss
729010bbb2 Unorphans the blackbox (#26129)
Moved sql_poll_population from server_maint to this new SS. Moved few remaining server_maint tasks to SSping and deleted it.
2017-04-27 10:04:57 +12:00
Cyberboss
5ace376e4a Initialize Refactor (#25981)
Shouldn't break anything, stops warning spam, logs errors qdel style at the end of the game.

Initialize now expects a hint to be returned, one of:
INITIALIZE_HINT_NORMAL - Does nothing, returned by the root proc
INITIALIZE_HINT_LATELOAD - Call atom/proc/LateInitialize
INITIALIZE_HINT_QDEL - Calls qdel on the atom

LateInitialize currently defaults to the old re-calling behavior so there should be no issues with that.
Things that didn't return a hint or fucked up somehow will be logged less loudly than they were before

No more world start warnings!
2017-04-27 09:02:29 +12:00
Cyberboss
02ff34b14f Fixes SDQL global procs 2017-04-26 09:52:04 -04:00
MrPerson
ff3f84ab81 Replaces /image with /mutable_appearance, where appropriate (#26518)
In cases where you're creating an image to use as an overlay, it makes more sense to use a mutable_appearance if you can. The image will create a static appearance for not just the image but also each intermediate step if you change vars along the way. The mutable appearance avoids this unnecessary and expensive process. The only situation that requires an image instead of a mutable_appearance is if the overlay is supposed to be directional. MA's ignore direction while images don't. I dunno why, probably another BYOND-ism.

I added a convenience function, mutable_appearance(), designed to emulate image(). Also went ahead and set the default plane of /mutable_appearance to FLOAT_PLANE because it's fucking 0 by default.

Several overlays that were image() calls were changed to just text strings when I could. overlays += "string" has the same result as overlays += image(icon, "string") and saves a proc call.
2017-04-25 12:15:16 +02:00
Cyberboss
e266551346 Merge branch 'master' into ITKEEPSHAPPENING 2017-04-25 01:13:14 -04:00
oranges
7f2b0d0b05 Merge pull request #26397 from coiax/stops-easter-loot
Fixes easter eggs spawning during non-easter; SSevent now inits before SSticker
2017-04-25 11:06:28 +12:00
Leo
e8dc7b2323 Merge pull request #26485 from Cyberboss/patch-56
Renames "Hard Reset" to "Reboot World"
2017-04-24 16:23:43 -03:00
Cyberboss
d2ca283bf0 Merge branch 'master' into SDQLRevert 2017-04-24 11:06:36 -04:00
Leo
4a174be3a3 Merge pull request #26465 from Cyberboss/patch-53
Fixes Advanced Proc Call
2017-04-24 12:05:03 -03:00
Cyberboss
423891d2f2 Admin proc calls are now serialized per admin 2017-04-24 10:01:11 -04:00
Cyberboss
7ddea10cd7 Exploit whack-a-mole 2017-04-23 21:16:10 -04:00
Cruix
f0a8ca68db Changed alternate appearances to /datum/atom_hud s (#26289)
* Changed alternate appearances to  /datum/hud s

* Added hashset behavior to the /datum/data_hud/var/hudusers list
2017-04-23 20:25:52 +02:00
Cyberboss
9b36a65730 Renames some incorrect terminology 2017-04-23 10:09:08 -04:00
oranges
88310bb299 Merge pull request #26454 from tgstation/lzimann-roguetag
Removes rogue bold tag in player panel
2017-04-23 22:15:40 +12:00
Leo
21d65bc2fe Merge pull request #26410 from Cyberboss/FixesTicketReconnection
Fix current_ticket.initiator not being set when a client relogs
2017-04-22 22:55:07 -03:00
Cyberboss
352752d029 Fixes Advanced Proc Call 2017-04-22 21:26:07 -04:00
Leo
7dfc3cfe13 Removes rogue bold tag 2017-04-22 18:54:33 -03:00
Jack Edge
5d5f99e062 While we're here, regenerate station names on holidays 2017-04-22 22:08:31 +01:00
Joan Lung
6be64ff969 Secrets panel logging is better (#26418) 2017-04-22 09:07:27 -03:00
Cyberboss
34a1b30a42 Fix current_ticket.initiator not being set when a client relogs 2017-04-20 15:21:45 -04:00
Cyberboss
5d61c5b64e AHelp improvements (#26092)
* Ahelp refactor

* Same ticket nagging

* Remie review

* Dead code

* Require tickets for PMs + other fixes

* Remove full monty redundancy

* Stylesheet

* Listings refresh

* Add ban logs to tickets

* Tickets can stay associated after reconnect

* Don't show active disconnected tickets in the main list

* Ticket titles

* More beautiful + fixes

* Needful

* IC issues close the ticket, feedback, and other stuff

* Move shit around

* IC issue -> resolve. Inline with the meaning of resolve. Documentation

* Classic style + fixes

* Width

* Formatting

* Whoops

* Formatting

* That top note

* That cream

* Pure vanilla

* move to status panel

* Fix the listing

* Sleep checks

* Stay frosty

* Allows close/resolve of disconnected players

* Ban logging will work if the player logs out.

* Sorted closed and resolved lists

* Fixes

* IRC commands

* More feedback

* Small fix

* Unfix

* Just witnessed a memetide of tickets

* Make the timer unique for good measure

* Fix

* Make it use QDEL_LIST

* Fix

* colorful

* Fix

* No more name prompt

* Retitling

* Fix

* Fix

* < CANT CODE

* Phrasing

* The better

* Better linking and stuff

* Language

* Bluh

* This may have broke things, let's back up

* Ticket reopening

* Admin panel verb for viewing a ticket list

* Slightly better refreshing

* Improve reject and IC issue wording

* Log client disconnects and reconnects

* Hopefully fixes the same issue issue

* This should be here

* Almost a terrible idea

* More feedback

* Better timing

* Better timing and logging

* Adding notes

* Improves teleport logging

* saddest commit in history

* Fix feedback counters for reopened tickets

* Fixed
2017-04-19 18:54:26 +02:00
Cyberboss
eb399829bc Removes a colon (#26353) 2017-04-19 10:30:47 -04:00
Leo
d46d9ffb2a Adds a link to individual logs on the player panel and moves the other one (#26341)
* Adds a link to individual logs on the player panel and moves the other one

* Fixes tgstation.dme and removes the other button from the show_player_panel verb
2017-04-19 13:03:51 +02:00
Cyberboss
3c3f7d3b60 Refactors dbcon into a subsystem (#26134)
* Refactors dbcon into a subsystem

* Swear I got that already...
2017-04-17 15:18:17 +10:00
Cyberboss
6a9fa3d35a Adds a proc to check if the current thread is from an admin advanced proc call (#26191)
* Admin proc call guards

* Adds a db warning

* Better this way

* leftover

* )=

* Fix

* Wew

* Better runtime handling

* Make callback use it if var_edited
2017-04-15 11:24:35 -06:00
oranges
cd847d77d8 Merge pull request #26099 from Cyberboss/ShuffleFix
Corrects incorrect shuffles
2017-04-13 11:09:04 +12:00
Cyberboss
a1403bc424 [s] Moves sensitive data out of GLOB (#26039)
* Moves sensitive data out of GLOB

* Make it a real boy

* Whoops
2017-04-12 19:53:13 +02:00
Cyberboss
a8cc3cd6c2 [s] Fixes datum var hiding (#26027)
* .

* Buildmode

* SDQL global. now refers to GLOB

@kevinz000

* Another SDQL thing

* Fix
2017-04-12 11:20:46 +12:00