Commit Graph

4468 Commits

Author SHA1 Message Date
FloranOtten
8a9d268665 Add pod shuttle, an admin-only evac shuttle made of two pods (#43380)
This shuttle is perfect for punishing the entire crew, or making them
battle to the death over who gets a seat.
2019-03-30 14:29:25 -07:00
AnturK
1dbcaf78a1 Adds simple framework for learnable crafting recipes (#43296)
* Adds simple framework for learnable crafting recipes

* whoops

* Moves teach/check functions to mind

* Code golf

* I just moved these around but fine.

Co-Authored-By: AnturK <AnturK@users.noreply.github.com>
2019-03-29 11:55:29 -04:00
Tad Hardesty
6fe3cd6da3 Fix server startup not actually logging testmerge commits (#43372) 2019-03-28 01:55:12 -04:00
PKPenguin321
8b8fee0ab5 X-Ray Balance (#43340)
X-Ray vision can no longer be obtained via a random gene sequence at
roundstart. X-Ray now has 35 instability, up from 25. A new gene,
thermal vision, has been added to genetics. You can create X-Ray vision
by mixing Thermal Vision and Radioactive together.

Requiring the gene to be mixed:
- Further timegates it
- Reduces the odds that it will be available in a given round of n length
- Means that you will NOT be able to circumvent the instability, as you
  will never have the gene naturally

Bumping the instability:
- Means X-Ray now takes up a whole 1/3rd of your instability by itself
- Is a serious decision, since you can not circumvent the instability
  (see above)

Thermal vision is just a strictly worse xray
2019-03-27 22:18:20 -07:00
Menshin
84a930d52b Fix Janitor ERT preview and leader role spawning (#43320)
Fixes Janitor ERT runtime on Create Antag preview and ERT leader (heavy)
spawning nude.
2019-03-25 23:39:39 -07:00
Tlaltecuhtli
85c1485bab [ready] beepsky smash change (#43228)
* 1

* 2

* 3

* temp

* r

* rogue space

* e

* e

Co-Authored-By: Tlaltecuhtli <33834933+Tlaltecuhtli@users.noreply.github.com>

* restarts appveyor
2019-03-25 12:03:51 -04:00
AnturK
bbbf712e94 Adds beetlejuice component. (#43192)
* Adds beetlejuice component.

* NAMEOF is horrible.

* Okay, this var name is better

* regex
2019-03-25 11:17:09 -04:00
Rob Bailey
ceca1e605e [READY] Yet more darkmode tweaks and fixes (#43306)
* fuck you whoever made the last icon it was garbage

* ticket log fixes

* ticket log fixes

* changes colors from hardcode per line to a define

* some nicer darkmode colors

* asay and ooc name default fixes

* fuck you appveyer build again

* slight brightening of the default font color

* properly fixes tip of the round being hard to read
2019-03-25 20:49:59 +13:00
oranges
3ed23dfda8 Merge pull request #43277 from AutomaticFrenzy/patch/forcegive
Fix broken force_give call in hardset_dna
2019-03-25 20:19:40 +13:00
Tad Hardesty
216cd9a139 Fix broken force_give call in hardset_dna 2019-03-22 11:15:09 -07:00
ShizCalev
01ee32329f [s] Fixes vents not logging the signal sender (#43272)
* [s] Fixes vents not logging the signal sender

* removed unused proc
2019-03-22 11:49:56 -04:00
ShizCalev
03607834c0 Merge pull request #43236 from anconfuzedrock/bad_back
Adds bad back quirk (makes bags give you a bad mood)
2019-03-21 23:59:02 -04:00
ShizCalev
eff95b7364 Body modification panel will now only show limbs valid for modification (#43214) 2019-03-21 12:31:34 -07:00
anconfuzedrock
303d45287a does whatever mood_quirk = true does 2019-03-20 23:35:14 -04:00
anconfuzedrock
8465e881a2 adds backpain quirk 2019-03-20 18:04:32 -04:00
PKPenguin321
31b1460b61 Ensures people do not spasm out of closed chambers (#43198)
* ensures people do not spasm out of chambers

* Apply review

Co-Authored-By: PKPenguin321 <pkpenguin321.git@gmail.com>
2019-03-20 14:35:30 -04:00
Time-Green
c731285891 New snail sprite and fixes (#43132)
* snail sprite update and fixes

* fixes snail cure

* Fixes blood
2019-03-20 11:03:14 -04:00
AnturK
b7c77a7183 Fixes spawners menu (#43193) 2019-03-20 10:56:40 -04:00
Jordan Brown
feff549c55 Merge pull request #43180 from tgstation/MrStonedOne-patch-2
Add pop cap info to status topic
2019-03-19 20:06:07 -04:00
ShizCalev
1987833bbb Merge pull request #43134 from Time-Green/awasdasdasda
Adds functionality to let some mutations transfer on cloning
2019-03-19 12:32:37 -04:00
Kyle Spier-Swenson
71d840b57d Add pop cap info to status topic
The banners are currently using hard coded numbers. We could change that.
2019-03-18 17:39:06 -07:00
Tad Hardesty
40cfebf2b0 Add some additional type annotations to lists (#43087) 2019-03-17 12:18:23 +01:00
oranges
5451cef5e9 Merge pull request #43029 from AutomaticFrenzy/patch/procpath
Add a type annotation to represent proc paths
2019-03-17 23:23:23 +13:00
Time-Green
fd03ef81c5 Lets mutations transfer on cloning 2019-03-15 13:48:24 +01:00
oranges
2365f53e6d Merge pull request #43102 from AutomaticFrenzy/patch/kwarg-overrides
Fix some proc overrides missing their parent's kwargs
2019-03-14 15:10:06 +13:00
AnturK
cbcbc28ac0 Fixes dna runtime. (#43094) 2019-03-12 16:04:16 -04:00
Tad Hardesty
197a311fd9 Fix some proc overrides missing their parent's kwargs 2019-03-11 21:15:26 -07:00
ShizCalev
3249c4cfed Merge pull request #43076 from AutomaticFrenzy/patch/kwarg-calls
Fix several incorrect keyword argument calls
2019-03-11 22:44:02 -04:00
Tad Hardesty
6b1cb3dfaf Remove unnecessary vars[] use in VV code (#43080) 2019-03-11 11:42:43 -04:00
Tad Hardesty
2c567b1542 Rename updating_stamina kwarg to update_health uniformly 2019-03-09 13:02:57 -08:00
Tad Hardesty
1433e48eba Fix some proc calls with bad keyword arguments 2019-03-09 12:56:19 -08:00
tralezab
9e4856d55d [READY] dilutes the staff of chaos pool with some more bolts (#42719)
* staves

* projectiles

* sapped event

* last of the staves (need to sprite and get sounds)

* last of the projectiles

* Squash is a single-use plant in Plants vs. Zombies and returns as a premium plant in Plants vs. Zombies 2.

* removes staff of cooperation, adds fly magic status effect

* a couple things with flight + tweaks

* removes old bolts/staves, finishes and adds parts of the new set

* fixes

* fetching + flying fixes, added chill and wipe

* and done

* cobblestone's review
2019-03-08 08:24:57 -05:00
ShizCalev
62f141ae3e Merge pull request #43020 from TerraGS/virus-fix
Fixes voice change symptom bug
2019-03-08 03:24:00 -05:00
ShizCalev
75be9026eb Merge pull request #42978 from pubby/viro
Important virus fixes
2019-03-07 09:57:33 -05:00
Tad Hardesty
990e2c7bc2 Fix a few junk type annotations (#42985) 2019-03-07 10:58:05 +01:00
tralezab
0a51e7e1b9 [PROBABLY READY? REVIEW WITH SCRUTINY] New event: Fugitives (#42554)
* fugitives

* lets make this a bit cleaner

* cultists and the beginnings of security detail, lots of wip

* wip security

* WALDO (and some more work on yalp, of course)

* adding antagonist teams for both hunter and fugitives, roundend report beginnings

* this whole file is shit, but hopefully a little better

* it compiles (+ space police)

* some more work

* S.E.L.F. fluff

* grammar and icon fixes

* lets finish yalp elor, give it the justice it deserves

* moves hunter spawns to ship pods + russians P1

* moves hunter spawns to ship pods + russians P2

* fugitives and hunters now recognize eachother

* hunter spawning finished(?)

* missed this

* ATH's review

* runtime fixed, added yalp's transport ability

* anturk's review

* makes hunter.dm better trust me

* oopsies

* INVOKE_ASYNC

* russian ship + finally a (bad) sprite for the capture machine

* step > pixel, thanks travis

* mooshroom review p1

* mooshroom review p2

* improper use of /improper

* waldo's radio doesn't stick, police id

* candidate picking is more flexible + minor things
2019-03-06 10:17:46 -05:00
Tad Hardesty
2bc2e7fe31 Add a type annotation to represent proc paths 2019-03-05 21:09:12 -08:00
oranges
0267bce949 Turns out a bunch of components do not properly transfer because of (#42691)
one of three things.

    1. They don't use RegisterWithParent or UnregisterFromParent to unregister
       and register signals

    2. They use callbacks which refer to a source object, which is usually deleted
       on transfer, or lost in some manner, or simply makes no sense at all to be
       transferred

    3. the component was never designed to be transferred at all

TransferComponents gave no shits about any of this and just blindly transferred
all components, if they were actually capable of it or not.

I only noticed this because it was causing chairs to break as they would not register signals
and verbs correctly for rotation after being picked up and then placed down, and a player
reported that issue via ahelp.

Luckily we caught it before the rot got anywhere, only chairs and the shuttle subystem
tend to use this proc (Shuttle uses it on turfs), can you imagine if everything was using
this LMAO

Which is good because it's more dangerous than a loaded gun

I have added a can_transfer var, that is true when a component is valid to
actually transfer, which means the dev has actually thought about what happens when
you take the parent object away and swap it for another and all the crazy that is entailed
by this

I have done my best to audit what components are actually
transferable, but things are basically a hot mess (Thanks @Cyberboss )

The following components required edits:
Forensics:
did not register/deregister the clean_act signal properly, did not checkblood on new parent

Rotation:
did not use RegisterWithParent or UnregisterFromParent, turned out
to not be transferable anyway due to having callbacks that can be
passed in to the parent with unknown sources that we can't feasibly
reuse (i.e if you're transferred from a chair to a bed, your old rotation
call backs are no longer valid). Turns out the use case it was for (just chairs)
didn't need it anyway, so I just made it non valid for transfer.

Wet Floor:
Honestly this one is just a hot mess, it should be a subtype of the slippery
component with the extra wet turf handling.

As it is it basically manages a slippery component on top of it's own extra
functionality, so that's a major code smell.

I added registration/unregistration of the signals, and made it's pretransfer
remove the slippery component and the posttransfer add it back (via update_flags)

Components that seem transferable without issues
mirage_border
orbiter
decal
spill
storage (I hope to earth)
2019-03-05 20:27:29 +01:00
TerraGS
261ea2818e Fixes voice change symptom bug 2019-03-05 12:06:02 -06:00
pubby
56137444e8 Remove stat change 2019-03-03 09:48:17 -06:00
pubby
0c1ba0e177 Fix beard growth (ATH1909) 2019-03-03 09:47:56 -06:00
Militaires
5ff56fb39e Correct CQC help instructions (#42980) 2019-03-02 13:57:24 -08:00
pubby
34cc294cea Buff undead viruses 2019-03-02 06:30:25 -06:00
pubby
0a9893b8a8 Fix cough clobbering spread_flags 2019-03-02 06:22:09 -06:00
pubby
0fc075badb Reduce beard speed 2019-03-02 06:21:48 -06:00
pubby
01f8f8ea55 Allow dead people to get dead viruses 2019-03-02 06:21:06 -06:00
Jordie
34a6197169 Merge pull request #42959 from SouDescolado/Runtimes-fix
Fixes spawner menu runtime
2019-03-02 22:43:42 +11:00
pubby
04d0105f97 Fix beard virus 2019-03-02 05:17:45 -06:00
Time-Green
ad1dd38655 Adds snailpeople as a rare genetic meltdown effect (#42889)
Meant to be part of #42864 , but got a little big so I'll add it to wichever gets merged last.
[Snailcrawl demonstration](https://youtu.be/IL7WFpfRo4c)

PROS

- Gets snailcrawl, wich makes them greatly faster and gives them a lube trail

- Their blood is spacelube

- They get a cool armored nodrop snail shell

- They don't slip

CONS

- Very slow

- Punch is pathetic

- Tttaaalllkkk llliiikkkeee ttthhhiiisss

- Extremely vulnerable to salt

- Can't wear glasses

Adds gastrolisis, wich is pretty much [this](https://www.youtube.com/watch?v=lFbPi8o0OEU) spongebob episode where they slowly turn into snails

You can also get gastrolisis by random_reagent_id, so maintpills and botany

🆑
add: Adds snailpeople as a rare genetics accident.
sprite: Snailshell sprites by nickvr628
/🆑
Snailshell sprites by @nickvr628

Why: It's a silly gimmicky race and it's a rare occurence. Also extremely highly requested for some reason
2019-03-02 09:40:56 +13:00
Kamparauta
8789c1d7e3 Changes the PAI loudnessBooster to a piano_synth, allows choosing of instrument. (#42910) 2019-03-01 13:50:16 +01:00