* Refactors speech impeding effects (drunken slurring / suttering) into status effects. Adds heretic slurring in addition to the existing cult slurring. Removes 4 vars from /living in return, which slightly optimizes Life() (wink)
* fex
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
* [Ready] Hilbert Research Facility remap feat. tram (#66082)
* reworks hilbert's hotel ruin
* warooio
* you can now run multiple trams on the same z at the same time, trams are linked by id
* fuck
* sure
* you are a simulacra
* FUG
* dock
* [Ready] Hilbert Research Facility remap feat. tram
* Update mapping_fluff.dm
* Update gordon_freeman.dm
* fixes
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com>
* Refactor and improve antimagic to be more robust (#64124)
This refactors the antimagic component to use and have bitflags, documentation, defines, code comments, named arguments, and renames variable names for clarity.
- /obj/effect/proc_holder/spell/aoe_turf/conjure/creature/cult is not used anywhere and has been removed
- /obj/effect/proc_holder/spell/targeted/turf_teleport/blink/cult is not used anywhere and has been removed
- New sound effects are played when magic is blocked. Depending on the type of magic being used it will be either:
- Equipping antimagic now properly updates the magic buttons
- Any magic being blocked or restricting casting now displays a message
- MAGIC_RESISTANCE_MIND now properly blocks telepathy effects
- Removes blood splatter when fireball is blocked
- Magic projectiles for staff of locker no longer spawn lockers when blocked by antimagic
- Fire breath is no longer blocked by antimagic
- Spellcards are now blocked by antimagic
Any antimagic on a mob blocks that magic type from being casted. (certain spells such as mime abilities completely ignore antimagic)
- Foilhats prevent someone from casting mind magic (telepathy, mindswap, etc.)
- Bibles, ritual Totems, nullrods, holymelons, and TRAIT_HOLY prevent someone from casting unholy magic (cult spells, etc.)
- Nullrods, ritual totem, and holymelons prevent someone from casting wizard magic (fireball, magic missile, etc.)
- Immorality talismans, berserker suits, and TRAIT_ANTIMAGIC prevents all types of magic (except stuff like mime abilities)
- Touch of Madness and Mindswap is now blocked with MAGIC_RESISTANCE and MAGIC_RESISTANCE_MIND
- Voice of god is now blocked with MAGIC_RESISTANCE_HOLY and MAGIC_RESISTANCE_MIND
* Refactor and improve antimagic to be more robust
* Update tiedshoes.dm
Co-authored-by: Tim <timothymtorres@gmail.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
* Fish refactor. (#65785)
Refactors fish into proper paths.
Removes aquarium behaviour intermediary datums.
Moves fish functionality out of aquarium content component.
Fixes flopping animation resetting on dropping.
Simplifies everything. There should be no player facing changes.
The animate signal is kinda weak method of solving the animate queue issue but it seemed least intrusive to me.
Open to any better ideas.
* Fish refactor.
* Update fishing.dm
* Update fishing.dm
Co-authored-by: AnturK <AnturK@users.noreply.github.com>
Co-authored-by: SkyratBot <skyratcommunity@gmail.com>
* begone, vile palette (redo red scrubs)
* begone, sprite issues! (redo one of the sec-sunglasses)
* begone, unused sprites/items!
* (same as last)
* makes more sense
* no more skirts
* no longer needed
* re-does the security vendor overrides better
* adds old alts of sec gear (for admims/mappers)
* emissives fun!!
* secmed gives me aneurisms
* digi-tize
* commits the cardinal sin
* also fix some palettes while im here
* these are broken anyways
* oops
* Revert "these are broken anyways"
This reverts commit 4941f14b3141e7e78cae1a88908d40a597c3af9d.
* missing icons + reskin fix + adjust fix + blue cap variant
* reskin woes
* i hate medic
* begone, redsec
* iconsss
* Apply suggestions from code review that I did so I can see my changes better
* icon fixes
* removes redundant HoS Formal Suits
* i hate maps
* sec medic kiiinda better
* fix eror
* tgu===
* conflict fix 2
* woo woo woo fix3
* what a silly funny little typo
* red to redsec, easy to search
* fuck you CDO
* i need to stop trying to sprite
* goodbye redsec vendors!!
* one spray of red-away
* bye red! (sprites nyi so not bye yet)
* conflict fix
* few more redsec killings
* what do i even say about this its literally peter griffin
* bye red bye red bye red
* Apply suggestions from code review
* repair icons
* Apply suggestions from code review
* i forgor
* Adds proper sound effects to attacks against flora (#65508)
* Adds proper sound effects to attacking flora
* Normalises all the sounds to make them as loud as possible and the same volume
* named arguments
* Adds proper sound effects to attacks against flora
Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com>
* DeltaStation's Recreation Area Rework, (LUNG CANCER EDITION) (#65588)
* DeltaStation's Recreation Area Rework, (LUNG CANCER EDITION)
Co-authored-by: san7890 <34697715+san7890@users.noreply.github.com>
* replaces the punching bag sprite, removing fitness.dmi (#65492)
Replaces the punching bag sprite, removing fitness.dmi
* replaces the punching bag sprite, removing fitness.dmi
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
* New in-wall engine sprites (#64839)
adds new variants for each sized engine to look like they are in walls (basically cut down sprites with their density set to false (because they dont take up the full tiles, especially the huge engines are 3x3 but only take up 1x3, they must have no density or they block way more than they should))
before: dumb looking gap
image
after: nice clean engine (and box trams are soul filled, also, trams kinda too small to really get any sort of diagnal design working)
image
showcase of each sized thruster:
image
added new structures that act like walls but arent turfs, and can only be used (and can be used!) on trams!
comes with 3 types, iron, plastitanium, and titanium. supports more types being added if you want but these are basically all that a tram needs to use:
Untitled.1.mp4
also removed a duplicated APC in a maint on tram, and removed cycle helpers from random maint airlocks that arent actually meant to cycle (they are solo)
Why It's Good For The Game
engines are kinda too bulky and organically shaped so they dont really fit some designs such as tram as a good example, in wall designs allow you to add thrusters onto any shaped ship easily without worrying about ensuring the walls around them being shaped right, as it appears to have the bulk of the engine merged inside the wall
Changelog
cl Nari Harimoto
imageadd: New thruster sprites to allow for in-wall designs
fix: removed cycle helpers from 2 random tram maint airlocks that arent meant to cycle (solo airlocks) and a duplicated APC in tram maint
expansion: the tram now has new walls! they are structures that function like walls so as to be built on the tram, create and deconstruct via the new tram girder (screwdriver on the girder to deconstruct, there is no displaced version ie wrench)
/cl
* New in-wall engine sprites
Co-authored-by: 小月猫 <alina.r.starkova@gmail.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
* New weight machine sprites and names (#65335)
imageadd: New sprites for the weight machines.
* New weight machine sprites
Co-authored-by: Tastyfish <crazychris32@gmail.com>
* Tool act superpack 2 (#64428)
About The Pull Request
Continuation of #64375, extracting tool behavior from attackby() and moving it into discrete _act procs. This is about as many files as I had in the last version, as I still want this to be reviewable.
As before, I've tested everything in game and it works as it previously did.
Why It's Good For The Game
The more code moved out of attackby, the more modular things become.
Changelog
cl
refactor: Moves more tool behavior out of attackby().
/cl
* Tool act superpack 2
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
* Medical Revamp: Resprites and Jumpsuit/Under Changes (#65236)
New sprites for the CMO's turtleneck/skirtleneck, paramedic jumpsuit/jumpskirt, virologist jumpsuit/jumpskirt, and chemist jumpsuit/jumpskirt
* Medical Revamp: Resprites and Jumpsuit/Under Changes
* fix
Co-authored-by: axietheaxolotl <86872535+axietheaxolotl@users.noreply.github.com>
Co-authored-by: jjpark-kb <55967837+jjpark-kb@users.noreply.github.com>
* Restores old monkey knockdowns (monkey nerf) (#65080)
Monkey knockdown used to be on Crossed until it was made an AI here: 55238
Now it instead uses COMSIG_ATOM_ENTERED, which only takes into account walking over the monkey. Something that you can't do unless you are non-dense or they are lying on the floor, in which case you aren't even knocking them down?
Now it uses COMSIG_MOVABLE_CROSS instead so it's how it used to be, actually functional and useful.
* Restores old monkey knockdowns (monkey nerf)
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* Change hydroponics tray and chem dispenser AltClick behavior to be used by RMB (#64939)
* Change hydroponics tray and chem dispenser AltClick behavior to be used by RMB
Co-authored-by: Tim <timothymtorres@gmail.com>
* Fixes being able to create walls out of sheets that arent linked to a material (#65063)
* Fixes being able to create walls out of sheets that arent linked to a material
Co-authored-by: SMOSMOSMOSMOSMO <95004236+SmoSmoSmoSmok@users.noreply.github.com>
* Adds some contextual screentips to botany related things (#64954)
* Adds some contextual screentips to botany related things
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
