Commit Graph

113731 Commits

Author SHA1 Message Date
Ghom
f5825f7e48 Fish feed to the Library vending machine, rescue hook to the mining order console (and paramed heirloom) (#87110)
Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
2024-10-12 19:39:51 +00:00
Jordan Dominion
3c30e5676b Option to Offload non-technical PR discussion to a Discord Thread (#86068)
This was discussed in #maintainerbus on the Discord.
@tgstation/commit-access

Result of this PR: 

- Add the `Discord Discussion` label to the PR. 
- The bot will create the thread, link it in the PR, and lock the PR.
Slowmode set to 1 minute. Auto-archive duration set to max of 1 week.
- The thread will be archived if the PR is merged or closed, unarchived
if it's reopened.
- You can also set a join link for the Discord to appear in the GitHub
comment. I'll be setting it to our official link at
https://tgstation13.org/phpBB/viewforum.php?f=60


![image](https://github.com/user-attachments/assets/2cdbe762-2339-4467-8b80-d1bf939b43e4)


![image](https://github.com/user-attachments/assets/b5cb25a4-18ee-40a0-a3eb-c36cf38ca8dc)
Let the bikeshed commence
2024-10-12 12:08:59 -07:00
tgstation-ci[bot]
26f9d63ebd Automatic changelog for PR #87145 [ci skip] 2024-10-12 18:49:37 +00:00
grungussuss
1fa9958633 All chainsaws can behead (#87145) 2024-10-12 20:49:17 +02:00
tgstation-ci[bot]
f89e9f3690 Automatic changelog for PR #87154 [ci skip] 2024-10-12 17:58:51 +00:00
Ghom
3b444ffd72 DNA Infusers now check for a datum trait instead of whether non-living objects are edible and have the GORE food type. (#87154) 2024-10-12 19:58:23 +02:00
tgstation-ci[bot]
eb593b0e79 Automatic changelog for PR #87102 [ci skip] 2024-10-12 16:57:22 +00:00
Striders13
e378b00328 Removes gas mask fov, pepperspray now applies tint to masks until washed off (#87102)
## About The Pull Request
Gas masks and all their subtypes no longer have fov.
Using pepperspray on gas mask wearer applies 1 tint per 5u of spray. At
3 tint the wearer becomes fully blind.
If you wanna use the mask again you'll have to wash off the pepperspray
from it using soap or shower.

## Why It's Good For The Game
Gas mask assistants are peak soul and removing it was a terrible
disaster. FoV is too annoying to ever deal with, so it ends up with gas
masks never being worn. Gas filter doesn't make up for it whatsoever,
it's only use is shoving cigarettes in it to look cool. This PR makes it
so pepperspray/tear gas is still useful against mask wearers, albeit
less efficient.
2024-10-12 11:56:59 -05:00
tgstation-ci[bot]
68e1465dae Automatic changelog for PR #87143 [ci skip] 2024-10-12 15:16:05 +00:00
Jerry
6639857bce Better ghost tray scan (#87143)
## About The Pull Request

Partially improves:
* #46002 

Previously, the ghost's "t-ray view" acted as a toggle, even though the
scan only occurred once. This PR changes it to function as an action
rather than a toggle, removing the need to press the button twice.

While the ideal solution would be for the t-ray scan to work on the
process tick, my attempt to give ghosts their own t-ray scanner and to
toggle it on upon using the verb did not work as expected because the
scanner didn't recognize the ghost as its holder (`mob/viewer` in the
code).

This update serves as an improvement to the current behaviour, but in
the future, the t-ray scan verb should function like a normal t-ray
scanner, instead of just a one-time scan.
## Why It's Good For The Game

Improves the t-ray verb, before it acted as a toggle even though it only
worked once upon toggling on. Improves user experience using this verb.
## Changelog
🆑
fix: the ghost "t-ray view" no longer requires a double press to
activate a second time.
qol: renamed "t-ray view" to "t-ray scan" for clarity.
/🆑
2024-10-12 17:15:45 +02:00
FlufflesTheDog
f106b8f65b Fix automatic map votes requiring manual map voting config (#87164)
## About The Pull Request
flags the automatic, end of round map votes as `forced`, as they were
previously.
## Why It's Good For The Game
democracy is mandatory in this household
## Changelog
not player facing
2024-10-12 15:35:29 +02:00
tgstation-ci[bot]
59f698f7cf Automatic changelog for PR #87183 [ci skip] 2024-10-12 13:16:30 +00:00
SmArtKar
bd37221d6f Changes incorrect override in untie shoes spell (#87183)
## About The Pull Request

Closes #87181

## Changelog
🆑
fix: Untie shoes should have its cooldown increased correctly when
casting it from a long distance
/🆑
2024-10-12 15:16:09 +02:00
tgstation-ci[bot]
49fa6603db Automatic changelog for PR #87158 [ci skip] 2024-10-12 13:15:53 +00:00
YakumoChen
afd4932249 Proofreads nebula virologist fax (#87158)
## About The Pull Request

Centcom forced an intern to run the spell-checker for faxes sent to
stations working within a radioactive nebula

## Why It's Good For The Game

spell good

## Changelog

🆑
spellcheck: Proofreads some faxes sent during radioactive nebulae
/🆑
2024-10-12 15:15:31 +02:00
tgstation-ci[bot]
abe52df346 Automatic changelog for PR #87160 [ci skip] 2024-10-12 12:53:51 +00:00
Ben10Omintrix
08ebaa1626 fixes ashdrake arena attack not clearing out lavaland walls (#87160)
## About The Pull Request
this was changed a few weeks back but wasnt actually intentional.

## Why It's Good For The Game
fixes ashdrake arena attack not clearing out lavaland walls

## Changelog
🆑
fix: fixes ashdrake arena attack not clearing out lavaland walls
/🆑
2024-10-12 14:53:30 +02:00
tgstation-ci[bot]
cde641ffdc Automatic changelog for PR #87168 [ci skip] 2024-10-12 12:41:42 +00:00
grungussuss
58daf1bac4 snore fix [no gbp] (#87168)
## About The Pull Request

![image](https://github.com/user-attachments/assets/1844f400-114f-4710-b27f-0651e7a536d5)
## Changelog
🆑 grungussuss
fix: snore emote works properly now
/🆑
2024-10-12 14:41:19 +02:00
tgstation-ci[bot]
0a0d4142a4 Automatic changelog for PR #87126 [ci skip] 2024-10-12 12:35:54 +00:00
grungussuss
a3a91f4d03 pet emotes, pet bonus adjustment (#87126)
## About The Pull Request
- pet bonus element now works by getting an emote fed into it.
- all pets who had pet bonus emotes now have it as a proper emote they
can use if controlled by a player.
## Why It's Good For The Game
- standardises pet bonus so it's easier to give more behaviors to
petting, like sounds :3
- allows basic mobs controlled by players to use the emote at will,
which will allow them to react to situations more with emotes.
## Changelog
🆑 grungussuss
add: a lot of basic mobs and pets got new emotes
refactor: emotes triggered by petting pets work differently now, please
report any oddities with these behaviors.
sound: new emotes for basic mobs got sounds
/🆑
2024-10-12 12:35:35 +00:00
tgstation-ci[bot]
993d6dd8a0 Automatic changelog for PR #87086 [ci skip] 2024-10-12 10:55:53 +00:00
SmArtKar
91e14ba363 Plasmaman Species Refactor | Jesus Christ This Hurts Edition (#87086)
## About The Pull Request
Completely refactors plasmaman code by moving their self-ignition code
to limbs via a component and making suits handle their extinguishing
code by themselves. This means that if someone gets a plasmaman limb
attached to them, they'll need to seal it off from oxygen or it will
ignite!

## Why It's Good For The Game

Plasmaman code is really bad and we've been trying to move away from
species specific code and make them just limb and organ containers
Closes #52649

## Changelog
🆑
fix: Plasmaman space suit internal extinguisher works and can be
refilled now
refactor: Refactored plasmamen self-ignition to be limb-side instead of
being handled by their species
/🆑
2024-10-12 12:55:33 +02:00
tgstation-ci[bot]
757219794b Automatic changelog compile [ci skip] 2024-10-12 00:24:47 +00:00
tgstation-ci[bot]
f4334c2cc7 Automatic changelog for PR #87163 [ci skip] 2024-10-11 23:57:04 +00:00
FlufflesTheDog
ffc9c63a22 Fix mopping on multi-z stations (#87163)
## About The Pull Request
Mops and similar should check the true plane instead of whatever plane
things end up at after being offset by z levels.
Fixes https://github.com/NovaSector/NovaSector/issues/4465
## Why It's Good For The Game
clean up this mess right now, before the ants show up
## Changelog
🆑
fix: Mops and similar work properly on multi-z stations
/🆑
2024-10-12 01:56:45 +02:00
tgstation-ci[bot]
b9d20c8eed Automatic changelog for PR #87151 [ci skip] 2024-10-11 21:13:25 +00:00
grungussuss
f29559af3b reagent container sloshing hot fix [no gbp] (#87151)
## About The Pull Request
a lot of things that shouldn't slosh are `reagent_container`s, let's fix
that by making the behavior defined on `reagent_container/cup` instead.
if you know of more items that shouldn't slosh pls tell me I'll include
them in this fix

## Why It's Good For The Game
some stuff shouldn't slosh, a lot actually.
2024-10-11 21:09:25 +00:00
tgstation-ci[bot]
62813e5df2 Automatic changelog for PR #87150 [ci skip] 2024-10-11 18:32:34 +00:00
MrMelbert
c26ea16c4f Fix dead bees not being their proper bee self (#87150)
## About The Pull Request

Fixes #87147

Whomever refactored bees null'd the beegent before spawning the corpse,
and we pass the bee by ref into corpse init to grab beegent

## Changelog

🆑 Melbert
fix: Dead bees maintain their color and reagents
/🆑
2024-10-11 21:23:02 +03:00
tgstation-ci[bot]
ab20e64395 Automatic changelog for PR #86288 [ci skip] 2024-10-11 17:47:30 +00:00
Fazzie
234af8c74a [TGC] Rebalances the entire card game. (#86288)
## About The Pull Request

Rebalances the entire dang TGC.

## Why It's Good For The Game

This game is a mess and needs several, several rounds of cleanup. 
To put in perspective:

- The how to play page in the wiki is horrible. It refers to equipment
cards as "item cards", to battlefield cards as "department cards", etc.
It is unclear on many of the game mechanics (do creatures come into play
tapped or not, is there a max mana, etc) and in general does not do a
good job at teaching the game.
- The cards were wildly unbalanced. The mana curve was all over the
place; Reeducation, a spot removal card, was 2(!!!) mana, Clown was a 2
mana 2/4 with taunt on a format where 1 drop vanillas are 2/2, the
numbers were all over the place.
- Some of the cards were downright nonsensical. The miner card is 4 mana
and its effect lets it tapp itself and pay 2 mana (a very, very big
cost) to draw a card and either discard it or put it on the bottom of
the deck..? Why would you spend 6 mana to do nothing..? What? The
Scientist card also was nonsensical, having a high cost, terrible stats
and a situational and low payoff ability.
- The game has no long term plan. As people keep adding more cards,
what's the plan to prevent power creep? Unintended gamebreaking combos?
Ruling nightmares? There are 0 limits to your deckbuilding other than 40
cards 3 max of each card.

This batch of changes fixes a number of these problems. Namely, it
completely rebalances, tweaks the numbers and/or completely changes
every single card in the game. This is to set a reasonable power curve
for the earlygame (turns 1 to 3), with finer tuning of the 4+ mana cards
coming later as we figure the game out more and hopefully persistency
comes. It sets a workable basis for us to build atop on.

Also! I completely remade the card subtypes (not to be confused with
byond subtypes). The idea is you can only run 3 different subtypes in
your deck when persistency comes, to prevent power creep, unintended
combos and allowing for greater flexibility for contributors going
forward. These types of restrictions help keep the game mantainable and
scaleable for the long term.

Also, I changed Mana to be Plasma because we're not Hearstones and
Plasma is literally the mcguffin of the entire setting. Come on, guys!
Cargo was already even the ramping subtype, it was right there!

Hackmd with a lot of these changes:
https://hackmd.io/@kNRZ9uxhShS3s2N9scOXxQ/SyEirnos0

## Changelog
🆑
balance: [TGC] Rebalances nearly every card in the game.
balance: [TGC] Several keywords had their effects modified.
fix: [TGC] Black Gaia is no longer an "Artifact", Fryer no longer
mentions tapping it.
spellcheck: [TGC] Replaced "Tap this card:" with just "Tap:" alongside
other wording improvements
spellcheck: [TGC] Mana has been replaced with Plasma. This is a
completely cosmetic change.
refactor: [TGC] Merged many, many redudant card subtypes (the mechanic,
not the byond code stuff) into more comprehensive ones.
/🆑

---------

Co-authored-by: Pepsilawn <reisenrui@gmail.com>
Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
2024-10-11 10:47:06 -07:00
tgstation-ci[bot]
f96abf364a Automatic changelog for PR #87142 [ci skip] 2024-10-11 16:28:27 +00:00
SmArtKar
28bbca59b5 [NO GBP] Prevents walls from slowing your drifting down when you're moving in the same direction as your pressed movement key (#87142)
## About The Pull Request

Oopsie, this prevents walls from slowing your drift down if you're
pressing a movement key and moving in your intended direction

## Why It's Good For The Game
Smoother movement when you're moving near a wall with a jetpack or
tether or whatever really

## Changelog
🆑
qol: Jetpack movement near walls should be much smoother
/🆑
2024-10-11 18:00:36 +02:00
tgstation-ci[bot]
eadb72fe75 Automatic changelog for PR #87100 [ci skip] 2024-10-11 09:57:49 +00:00
Cruix
a9d0fce8c8 Fixed Chameleon clothing not updating your sprite in some cases (#87100)
## About The Pull Request

Whenever you equip or unequip a piece of clothing (or change the
appearance of a chameleon item while wearing it), the game checks to see
if your sprite needs to update the parts of your body that are obscured
by that clothing. However, it only actually updates your sprite if the
item covers a part of your body that is relevant to your sprite. If you
equip an item that hides a part of your body (such as a chameleon helmet
set to something that hides your hair), then transform that item into a
form that no longer covers anything, it will see that the item covers
nothing important and skip trying to update your appearance.

Removing this check will cause update_body() calls to occur slightly
more often, but in the cases where it actually shouldn't update, the
sprite update code will detect that the rendering key for each limb has
not changed and exit without making any sprite changes, so the
performance hit will be minimal.

Similar situation with face-covering chameleon items and sec huds: You
could equip a face-covering chameleon item to make your sec hud arrest
status disappear, change the item to something that does not cover your
face, and then remove it, and your sec hud arrest status would not
update.

## Why It's Good For The Game


## Changelog

🆑
fix: Fixed chameleon clothing sometimes making you bald or hiding other
parts of your sprite.
/🆑

Fixes #83570
2024-10-11 11:52:17 +02:00
tgstation-ci[bot]
6046439d31 Automatic changelog for PR #87099 [ci skip] 2024-10-11 05:16:32 +00:00
EEASAS
b754ee5edb adds plasma to wawastation xenobio (#87099) 2024-10-11 07:13:21 +02:00
tgstation-ci[bot]
4e6e5bed16 Automatic changelog compile [ci skip] 2024-10-11 00:31:55 +00:00
tgstation-ci[bot]
04f913c034 Automatic changelog for PR #87131 [ci skip] 2024-10-11 00:09:34 +00:00
MrMelbert
d266ee9b88 Reverts a check added in [NO GBP] Fixes drone toolbox issues, fixes clothing unequipping, unit test (#87131)
## About The Pull Request

Fixes #87129

[This
change](https://github.com/tgstation/tgstation/pull/87073/files#diff-c8ab5fbc20de60e202b839834b039649cbb69a1c4b99b27a5e467f3889442ccd)
added in #87073, passing `invdrop = FALSE` to `doUnEquip`, breaks the
behavior of unequipping dropping your items. Because that's what
`invdrop` does. If you pass it as `FALSE` it prevents other items from
dropping off the mob, intended for like, outfit use / "quick swapping"
an item out

So I reverted it. Drone tools still seem to work I guess. @SyncIt21 

## Changelog

🆑 Melbert
fix: Fixes stuff staying on your body after removing your clothes
/🆑
2024-10-11 13:06:13 +13:00
tgstation-ci[bot]
e0bd06cdd0 Automatic changelog for PR #87132 [ci skip] 2024-10-10 22:09:23 +00:00
DATA
de065cf801 Fixes server hop not fading the screen to black (#87132)
## About The Pull Request

Fixes #29496 ... probably? I can't actually test this on a localhost but
it SHOULD work now

## Changelog

🆑
fix: Server Hopping should fade your screen into black, as it should.
/🆑
2024-10-11 00:09:03 +02:00
tgstation-ci[bot]
58c9bf421b Automatic changelog for PR #87148 [ci skip] 2024-10-10 19:45:48 +00:00
MrMelbert
566306d75b Fix double injections (#87148) 2024-10-10 19:45:21 +00:00
tgstation-ci[bot]
3975f4a460 Automatic changelog for PR #87046 [ci skip] 2024-10-10 19:42:50 +00:00
grungussuss
0dcbaa5ba5 removes a few varedits (#87046)
Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
2024-10-10 19:33:45 +00:00
tgstation-ci[bot]
76e2cf05a8 Automatic changelog for PR #87113 [ci skip] 2024-10-10 19:22:24 +00:00
EnterTheJake
0a1e241b03 Fixes Dark Matter singularity getting stuck on other z levels. (#87113)
Co-authored-by: Xander3359 <66163761+Xander3359@users.noreply.github.com>
Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
2024-10-10 21:15:05 +02:00
tgstation-ci[bot]
ee8eee1f6e Automatic changelog for PR #87107 [ci skip] 2024-10-10 18:38:01 +00:00