mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-22 06:56:31 +00:00
f5825f7e4897cc9f5cc1eb8129c436a38d4594de
183 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
3c30e5676b |
Option to Offload non-technical PR discussion to a Discord Thread (#86068)
This was discussed in #maintainerbus on the Discord. @tgstation/commit-access Result of this PR: - Add the `Discord Discussion` label to the PR. - The bot will create the thread, link it in the PR, and lock the PR. Slowmode set to 1 minute. Auto-archive duration set to max of 1 week. - The thread will be archived if the PR is merged or closed, unarchived if it's reopened. - You can also set a join link for the Discord to appear in the GitHub comment. I'll be setting it to our official link at https://tgstation13.org/phpBB/viewforum.php?f=60   Let the bikeshed commence |
||
|
|
366d874a95 |
Build(deps): Bump JamesIves/github-pages-deploy-action from 4.6.4 to 4.6.8 (#86988)
Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.4 to 4.6.8. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jamesives/github-pages-deploy-action/releases">JamesIves/github-pages-deploy-action's releases</a>.</em></p> <blockquote> <h2>v4.6.8</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h3>Bug Fixes 🐝</h3> <ul> <li>fix: 🐛 Added the temp deployment directory created by the action to the git safe directory list. This resolves an issue in certain circumstances where the deployment would fail depending on the types of files moved around by the workflow - <a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1694">#1694</a>.</li> <li>fix: Resolved a rare deployment error where the action would complain that <code>origin/${branch_name} is not a commit and a branch cannot be created from it</code>. The action will continue to attempt to track the origin branch, but if this step fails, it will create a new untracked branch to continue the deployment from. - <a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1689">#1689</a>.</li> </ul> <h3>Testing 🧪</h3> <ul> <li>test: 🧪 Improved the integration test suite so it now runs immediately post-release to ensure that any issues do no longer in the major version tag (<code>ie @v4</code>). This was done to combat problems raised by <a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1697">#1697</a>.</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.8">https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.8</a></p> <h2>v4.6.7</h2> <h2>What's Changed</h2> <h3>Bug Fixes 🐝</h3> <ul> <li>fix: resolved an issue where <code>main.js</code> was not found in the v4 major tag.</li> </ul> <h2>v4.6.6</h2> <h2>What's Changed</h2> <h3>Bug Fixes 🐝</h3> <ul> <li>revert: reverts a prior change that unsets safe directories to prevent dubious ownership, this change will be re-visited later.</li> </ul> <h2>v4.6.5</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h2>What's Changed</h2> <h3>Bug Fixes 🐝</h3> <ul> <li>fix: resolved an issue where the full working directory was not properly getting added to the safe directory list, preventing deployments in certain circumstances.</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.5">https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.5</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
5f0094fd97 |
Vendored Node checksum is now validated (#86997)
Hey you. Yes you. Have you ever experienced Access Denied when trying to compile the codebase for seemingly no reason? Tried to fix it and gave up? Its because Windows sucks ass and node will corrupt when you run it if closed improperly. Well now the build scripts verify that its not corrupt! |
||
|
|
05ea6b91f8 |
Build(deps): Bump actions/setup-dotnet from 2 to 4 (#86801)
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 2 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-dotnet/releases">actions/setup-dotnet's releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <h2>What's Changed</h2> <p>In the scope of this release, the version of the Node.js runtime was updated to 20. The majority of dependencies were updated to the latest versions. From now on, the code for the setup-dotnet will run on Node.js 20 instead of Node.js 16.</p> <p><strong>Breaking changes</strong></p> <ul> <li>Update Node.js runtime to version 20 by <a href="https://github.com/harithavattikuti"><code>@harithavattikuti</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/issues/484">#484</a></li> <li>Sequential version install fix by <a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/433">actions/setup-dotnet#433</a> In setup-dotnet@v3, the dotnet executable was overwritten during each action run, sometimes leading to failures if the executable was still in use. This issue was resolved in setup-dotnet@v4 by introducing an additional install-script run that installs the LTS version of the dotnet executable and utilizes it for all subsequent dotnet installations. The actual download is performed only once per workflow by the initial install-script run. To use older versions, utilize global.json. For more details, refer to the <a href="https://github.com/actions/setup-dotnet?tab=readme-ov-file#usage">documentation</a>.</li> </ul> <p><strong>Non-breaking changes</strong></p> <ul> <li>Refactor installer by <a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/432">actions/setup-dotnet#432</a></li> <li>Allow json comments by <a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/431">actions/setup-dotnet#431</a></li> <li>Update fast-xml-parser and dotnet installer scripts by <a href="https://github.com/IvanZosimov"><code>@IvanZosimov</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/437">actions/setup-dotnet#437</a></li> <li>Update dependencies by <a href="https://github.com/IvanZosimov"><code>@IvanZosimov</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/440">actions/setup-dotnet#440</a></li> <li>Bump word-wrap from 1.2.3 to 1.2.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/444">actions/setup-dotnet#444</a></li> <li>Update installers by <a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/462">actions/setup-dotnet#462</a></li> <li>Update semver by <a href="https://github.com/dmitry-shibanov"><code>@dmitry-shibanov</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/468">actions/setup-dotnet#468</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/HarithaVattikuti"><code>@HarithaVattikuti</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-dotnet/pull/484">actions/setup-dotnet#484</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-dotnet/compare/v3...v4.0.0">https://github.com/actions/setup-dotnet/compare/v3...v4.0.0</a></p> <h2>v3.2.0</h2> <h2>What's Changed</h2> <p>In scope of this minor release, the ability to cache the NuGet <code>global-packages</code> folder was added in <a href="https://redirect.github.com/actions/setup-dotnet/pull/303">actions/setup-dotnet#303</a> by <a href="https://github.com/nogic1008"><code>@nogic1008</code></a></p> <p>For caching, the action uses the <a href="https://github.com/actions/toolkit/tree/main/packages/cache"><code>@toolkit/cache</code></a> library under the hood, which in turn allows getting rid of configuring the <a href="https://github.com/actions/cache"><code>@actions/cache</code></a> action separately.</p> <p>Such input parameters as <code>cache</code> and <code>cache-dependency-path</code> were added. The <code>cache</code> input is optional, and caching is turned off by default, <code>cache-dependency-path</code> is used to specify the path to a dependency file - <code>packages.lock.json</code>.</p> <p><strong>Example of use-case:</strong></p> <pre lang="yaml"><code>- uses: actions/setup-dotnet@v3 with: dotnet-version: 6.x cache: true cache-dependency-path: subdir/packages.lock.json </code></pre> <p>More details can be found in the <a href="https://github.com/actions/setup-dotnet#caching-nuget-packages">action's documentation</a>.</p> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-dotnet/compare/v3...v3.2.0">https://github.com/actions/setup-dotnet/compare/v3...v3.2.0</a></p> <h2>v3.1.0</h2> <h2>What's Changed</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
e93e920ef5 |
Build(deps): Bump robinraju/release-downloader from 1.9 to 1.11 (#86806)
Bumps [robinraju/release-downloader](https://github.com/robinraju/release-downloader) from 1.9 to 1.11. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/robinraju/release-downloader/releases">robinraju/release-downloader's releases</a>.</em></p> <blockquote> <h2>Release Downloader v1.11</h2> <h2>What's Changed</h2> <ul> <li>Fix <code>No assets found in release</code> error by <a href="https://github.com/robinraju"><code>@robinraju</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/722">robinraju/release-downloader#722</a></li> <li>Update project config and dependencies by <a href="https://github.com/robinraju"><code>@robinraju</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/723">robinraju/release-downloader#723</a></li> <li>Bump <code>@types/tar</code> from 6.1.12 to 6.1.13 in the npm-development group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/724">robinraju/release-downloader#724</a></li> <li>Bump the npm-development group with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/725">robinraju/release-downloader#725</a></li> <li>Bump the npm-development group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/730">robinraju/release-downloader#730</a></li> <li>Bump tar from 7.0.1 to 7.1.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/727">robinraju/release-downloader#727</a></li> <li>Bump the npm-development group across 1 directory with 7 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/742">robinraju/release-downloader#742</a></li> <li>Bump braces from 3.0.2 to 3.0.3 in the npm_and_yarn group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/737">robinraju/release-downloader#737</a></li> <li>Bump tar from 7.1.0 to 7.4.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/741">robinraju/release-downloader#741</a></li> <li>Bump typed-rest-client from 1.8.11 to 2.0.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/744">robinraju/release-downloader#744</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/robinraju/release-downloader/compare/v1.10...v1.11">https://github.com/robinraju/release-downloader/compare/v1.10...v1.11</a></p> <h2>Release Downloader v1.10</h2> <h2>What's Changed</h2> <ul> <li>Update README.md by <a href="https://github.com/robinraju"><code>@robinraju</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/680">robinraju/release-downloader#680</a></li> <li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/687">robinraju/release-downloader#687</a></li> <li>Bump actions/setup-node from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/686">robinraju/release-downloader#686</a></li> <li>Bump nock from 13.3.8 to 13.5.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/685">robinraju/release-downloader#685</a></li> <li>Bump <code>@types/node</code> from 20.11.8 to 20.11.10 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/682">robinraju/release-downloader#682</a></li> <li>Bump typescript from 5.0.4 to 5.3.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/683">robinraju/release-downloader#683</a></li> <li>Bump <code>@vercel/ncc</code> from 0.36.1 to 0.38.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/684">robinraju/release-downloader#684</a></li> <li>Bump eslint-plugin-prettier from 5.0.1 to 5.1.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/681">robinraju/release-downloader#681</a></li> <li>fix: change zip library to fix garbled extract file under node 20 by <a href="https://github.com/jackie-linz"><code>@jackie-linz</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/707">robinraju/release-downloader#707</a></li> <li>Fix tests on windows, and package bundled js by <a href="https://github.com/robinraju"><code>@robinraju</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/710">robinraju/release-downloader#710</a></li> <li>Bump undici from 5.27.2 to 5.28.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/705">robinraju/release-downloader#705</a></li> <li>Bump tar from 6.2.0 to 6.2.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/711">robinraju/release-downloader#711</a></li> <li>Grouped dependancy updates by <a href="https://github.com/robinraju"><code>@robinraju</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/713">robinraju/release-downloader#713</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/jackie-linz"><code>@jackie-linz</code></a> made their first contribution in <a href="https://redirect.github.com/robinraju/release-downloader/pull/707">robinraju/release-downloader#707</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/robinraju/release-downloader/compare/v1.9...v1.10">https://github.com/robinraju/release-downloader/compare/v1.9...v1.10</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
e1d37f5215 |
Build(deps): Bump actions/setup-python from 1 to 5 (#86805)
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 1 to 5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p> <blockquote> <h2>v5.0.0</h2> <h2>What's Changed</h2> <p>In scope of this release, we update node version runtime from node16 to node20 (<a href="https://redirect.github.com/actions/setup-python/pull/772">actions/setup-python#772</a>). Besides, we update dependencies to the latest versions.</p> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0">https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0</a></p> <h2>v4.8.0</h2> <h2>What's Changed</h2> <p>In scope of this release we added support for GraalPy (<a href="https://redirect.github.com/actions/setup-python/pull/694">actions/setup-python#694</a>). You can use this snippet to set up GraalPy:</p> <pre lang="yaml"><code>steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v4 with: python-version: 'graalpy-22.3' - run: python my_script.py </code></pre> <p>Besides, the release contains such changes as:</p> <ul> <li>Trim python version when reading from file by <a href="https://github.com/FerranPares"><code>@FerranPares</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/628">actions/setup-python#628</a></li> <li>Use non-deprecated versions in examples by <a href="https://github.com/jeffwidman"><code>@jeffwidman</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/724">actions/setup-python#724</a></li> <li>Change deprecation comment to past tense by <a href="https://github.com/jeffwidman"><code>@jeffwidman</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/723">actions/setup-python#723</a></li> <li>Bump <code>@babel/traverse</code> from 7.9.0 to 7.23.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/743">actions/setup-python#743</a></li> <li>advanced-usage.md: Encourage the use actions/checkout@v4 by <a href="https://github.com/cclauss"><code>@cclauss</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/729">actions/setup-python#729</a></li> <li>Examples now use checkout@v4 by <a href="https://github.com/simonw"><code>@simonw</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/738">actions/setup-python#738</a></li> <li>Update actions/checkout to v4 by <a href="https://github.com/dmitry-shibanov"><code>@dmitry-shibanov</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/761">actions/setup-python#761</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/FerranPares"><code>@FerranPares</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/628">actions/setup-python#628</a></li> <li><a href="https://github.com/timfel"><code>@timfel</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/694">actions/setup-python#694</a></li> <li><a href="https://github.com/jeffwidman"><code>@jeffwidman</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/724">actions/setup-python#724</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4...v4.8.0">https://github.com/actions/setup-python/compare/v4...v4.8.0</a></p> <h2>v4.7.1</h2> <h2>What's Changed</h2> <ul> <li>Bump word-wrap from 1.2.3 to 1.2.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/702">actions/setup-python#702</a></li> <li>Add range validation for toml files by <a href="https://github.com/dmitry-shibanov"><code>@dmitry-shibanov</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/726">actions/setup-python#726</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4...v4.7.1">https://github.com/actions/setup-python/compare/v4...v4.7.1</a></p> <h2>v4.7.0</h2> <p>In scope of this release, the support for reading python version from pyproject.toml was added (<a href="https://redirect.github.com/actions/setup-python/pull/669">actions/setup-python#669</a>).</p> <pre lang="yaml"><code> - name: Setup Python uses: actions/setup-python@v4 </tr></table> </code></pre> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
d3393ee5e9 |
Build(deps): Bump actions/stale from 4 to 9 (#86804)
Bumps [actions/stale](https://github.com/actions/stale) from 4 to 9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/stale/releases">actions/stale's releases</a>.</em></p> <blockquote> <h2>v9.0.0</h2> <h2>Breaking Changes</h2> <ol> <li>Action is now stateful: If the action ends because of <a href="https://github.com/actions/stale#operations-per-run">operations-per-run</a> then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.</li> <li>Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.</li> </ol> <h2>What Else Changed</h2> <ol> <li>Performance optimization that removes unnecessary API calls by <a href="https://github.com/dsame"><code>@dsame</code></a> <a href="https://redirect.github.com/actions/stale/pull/1033/">#1033</a> fixes <a href="https://redirect.github.com/actions/stale/issues/792">#792</a></li> <li>Logs displaying current github API rate limit by <a href="https://github.com/dsame"><code>@dsame</code></a> <a href="https://redirect.github.com/actions/stale/pull/1032">#1032</a> addresses <a href="https://redirect.github.com/actions/stale/issues/1029">#1029</a></li> </ol> <p>For more information, please read the <a href="https://github.com/actions/stale#readme">action documentation</a> and its <a href="https://github.com/actions/stale#statefulness">section about statefulness</a></p> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/jmeridth"><code>@jmeridth</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/984">actions/stale#984</a></li> <li><a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1020">actions/stale#1020</a></li> <li><a href="https://github.com/dusan-trickovic"><code>@dusan-trickovic</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1056">actions/stale#1056</a></li> <li><a href="https://github.com/aparnajyothi-y"><code>@aparnajyothi-y</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1110">actions/stale#1110</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/stale/compare/v8...v9.0.0">https://github.com/actions/stale/compare/v8...v9.0.0</a></p> <h2>v8.0.0</h2> <p>⚠️ This version contains breaking changes ⚠️</p> <h2>What's Changed</h2> <ul> <li>New option labels-to-remove-when-stale enables users to specify list of comma delimited labels that will be removed when the issue or PR becomes stale by <a href="https://github.com/panticmilos"><code>@panticmilos</code></a> <a href="https://redirect.github.com/actions/stale/issues/770">actions/stale#770</a></li> <li>Skip deleting the branch in the upstream of a forked repo by <a href="https://github.com/dsame"><code>@dsame</code></a> <a href="https://redirect.github.com/actions/stale/pull/913">actions/stale#913</a></li> <li>abort the build on the error by <a href="https://github.com/dsame"><code>@dsame</code></a> in <a href="https://redirect.github.com/actions/stale/pull/935">actions/stale#935</a></li> </ul> <h2>Breaking Changes</h2> <ul> <li>In this release we prevent scenarios when the build is not interrupted on some exceptions, which led to successful builds when they are supposed to fail</li> </ul> <h2>Example</h2> <pre lang="yaml"><code>name: 'Remove labels when the issue or PR becomes stale' on: schedule: - cron: '30 1 * * *' <p>permissions: pull-requests: write</p> <p>jobs: stale: runs-on: ubuntu-latest steps: - uses: actions/stale@v8 with: labels-to-remove-when-stale: 'label1,label2' </code></pre></p> <h2>v7.0.0</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/stale/blob/main/CHANGELOG.md">actions/stale's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h1>[7.0.0]</h1> <p>⚠️ Breaking change ⚠️</p> <ul> <li>Allow daysBeforeStale options to be float by <a href="https://github.com/irega"><code>@irega</code></a> in <a href="https://redirect.github.com/actions/stale/pull/841">actions/stale#841</a></li> <li>Use cache in check-dist.yml by <a href="https://github.com/jongwooo"><code>@jongwooo</code></a> in <a href="https://redirect.github.com/actions/stale/pull/876">actions/stale#876</a></li> <li>fix print outputs step in existing workflows by <a href="https://github.com/irega"><code>@irega</code></a> in <a href="https://redirect.github.com/actions/stale/pull/859">actions/stale#859</a></li> <li>Update issue and PR templates, add/delete workflow files by <a href="https://github.com/IvanZosimov"><code>@IvanZosimov</code></a> in <a href="https://redirect.github.com/actions/stale/pull/880">actions/stale#880</a></li> <li>Update how stale handles exempt items by <a href="https://github.com/johnsudol"><code>@johnsudol</code></a> in <a href="https://redirect.github.com/actions/stale/pull/874">actions/stale#874</a></li> </ul> <h1>[6.0.1]</h1> <p>Update <code>@actions/core</code> to v1.10.0 (<a href="https://redirect.github.com/actions/stale/pull/839">#839</a>)</p> <h1>[6.0.0]</h1> <p>⚠️ Breaking change ⚠️</p> <p>Issues/PRs default <code>close-issue-reason</code> is now <code>not_planned</code>(<a href="https://redirect.github.com/actions/stale/issues/789">#789</a>)</p> <h1>[5.1.0]</h1> <p><a href="https://redirect.github.com/actions/stale/issues/696">Don't process stale issues right after they're marked stale</a> [Add close-issue-reason option]<a href="https://redirect.github.com/actions/stale/pull/764">#764</a><a href="https://redirect.github.com/actions/stale/pull/772">#772</a> Various dependabot/dependency updates</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
ccbad770d6 |
Build(deps): Bump JamesIves/github-pages-deploy-action from 3.7.1 to 4.6.4 (#86803)
Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 3.7.1 to 4.6.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jamesives/github-pages-deploy-action/releases">JamesIves/github-pages-deploy-action's releases</a>.</em></p> <blockquote> <h2>v4.6.4</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h2>What's Changed</h2> <h3>Bug Fixes 🐝</h3> <ul> <li>fix: resolved an issue where the default config was not being applied to the non-action version of the project.</li> </ul> <h3>Build 🔧</h3> <ul> <li>build(deps): bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1639">JamesIves/github-pages-deploy-action#1639</a></li> <li>build(deps): bump the misc group across 1 directory with 6 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1642">JamesIves/github-pages-deploy-action#1642</a></li> <li>build(deps): bump the misc group across 1 directory with 8 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1648">JamesIves/github-pages-deploy-action#1648</a></li> <li>build(deps-dev): bump ts-jest from 29.2.2 to 29.2.3 in the misc group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1649">JamesIves/github-pages-deploy-action#1649</a></li> <li>build(deps): bump micromatch from 4.0.4 to 4.0.8 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1679">JamesIves/github-pages-deploy-action#1679</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.4">https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.4</a></p> <h2>v4.6.3</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h3>Build 🔧</h3> <ul> <li>Consolidated a number of build scripts to make publishing easier.</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.3">https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.3</a></p> <h2>v4.6.2</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h3>Dependencies 🤖</h3> <ul> <li>build(deps-dev): bump the misc group across 1 directory with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1602">JamesIves/github-pages-deploy-action#1602</a></li> <li>build(deps): bump codecov/codecov-action from 4.4.0 to 4.5.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1614">JamesIves/github-pages-deploy-action#1614</a></li> <li>build(deps): bump braces from 3.0.2 to 3.0.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1615">JamesIves/github-pages-deploy-action#1615</a></li> <li>build(deps-dev): bump the misc group with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1613">JamesIves/github-pages-deploy-action#1613</a></li> <li>build(deps-dev): bump the misc group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1635">JamesIves/github-pages-deploy-action#1635</a></li> <li>build(deps): bump typescript-eslint from 7.9.0 to 7.15.0 in the typescript group across 1 directory by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1634">JamesIves/github-pages-deploy-action#1634</a></li> <li>build(deps-dev): bump the eslint group across 1 directory with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1637">JamesIves/github-pages-deploy-action#1637</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/JamesIves/github-pages-deploy-action/compare/v4.6.1...v4.6.2">https://github.com/JamesIves/github-pages-deploy-action/compare/v4.6.1...v4.6.2</a></p> <h2>v4.6.1</h2> <h2>What's Changed</h2> <h3>Fixes</h3> <ul> <li>Resolved an issue where workflows were suddenly failing due to a worktree in use error. The action will now attempt to create a temp branch name if the existing branch name is already checked out by a prior to step to ensure it can occur. This issue was only occurring in a handful of workflows, and likely stemmed from a git version change on the official GitHub runners. The actual root cause is still somewhat unknown.</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
10ce23c757 |
Build(deps): Bump actions/github-script from 6 to 7 (#86802)
Bumps [actions/github-script](https://github.com/actions/github-script) from 6 to 7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/github-script/releases">actions/github-script's releases</a>.</em></p> <blockquote> <h2>v7.0.0</h2> <h2>What's Changed</h2> <ul> <li>Add base-url option by <a href="https://github.com/robandpdx"><code>@robandpdx</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/429">actions/github-script#429</a></li> <li>Expose async-function argument type by <a href="https://github.com/viktorlott"><code>@viktorlott</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/402">actions/github-script#402</a>, see for details <a href="https://github.com/actions/github-script#use-scripts-with-jsdoc-support">https://github.com/actions/github-script#use-scripts-with-jsdoc-support</a></li> <li>Update dependencies and use Node 20 by <a href="https://github.com/joshmgross"><code>@joshmgross</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/425">actions/github-script#425</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/navarroaxel"><code>@navarroaxel</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/285">actions/github-script#285</a></li> <li><a href="https://github.com/robandpdx"><code>@robandpdx</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/429">actions/github-script#429</a></li> <li><a href="https://github.com/viktorlott"><code>@viktorlott</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/402">actions/github-script#402</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github-script/compare/v6.4.1...v7.0.0">https://github.com/actions/github-script/compare/v6.4.1...v7.0.0</a></p> <h2>v6.4.1</h2> <h2>What's Changed</h2> <ul> <li>Add <code>@octokit/plugin-request-log</code>, to produce debug output for requests by <a href="https://github.com/mjpieters"><code>@mjpieters</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/358">actions/github-script#358</a></li> <li>fix input handling by <a href="https://github.com/mjpieters"><code>@mjpieters</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/357">actions/github-script#357</a></li> <li>Remove unused dependencies by <a href="https://github.com/mjpieters"><code>@mjpieters</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/356">actions/github-script#356</a></li> <li>Default debug to current runner debug state by <a href="https://github.com/mjpieters"><code>@mjpieters</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/363">actions/github-script#363</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/mjpieters"><code>@mjpieters</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/358">actions/github-script#358</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github-script/compare/v6.4.0...v6.4.1">https://github.com/actions/github-script/compare/v6.4.0...v6.4.1</a></p> <h2>v6.4.0</h2> <h2>What's Changed</h2> <ul> <li>Bump json5 from 2.1.3 to 2.2.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/319">actions/github-script#319</a></li> <li>Bump minimatch from 3.0.4 to 3.1.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/320">actions/github-script#320</a></li> <li>Add node-fetch by <a href="https://github.com/danmichaelo"><code>@danmichaelo</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/321">actions/github-script#321</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/jongwooo"><code>@jongwooo</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/313">actions/github-script#313</a></li> <li><a href="https://github.com/austinvazquez"><code>@austinvazquez</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/306">actions/github-script#306</a></li> <li><a href="https://github.com/danmichaelo"><code>@danmichaelo</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/321">actions/github-script#321</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github-script/compare/v6.3.3...v6.4.0">https://github.com/actions/github-script/compare/v6.3.3...v6.4.0</a></p> <h2>v6.3.3</h2> <h2>What's Changed</h2> <ul> <li>Update <code>@actions/glob</code> to 0.3.0 by <a href="https://github.com/nineinchnick"><code>@nineinchnick</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/279">actions/github-script#279</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/nineinchnick"><code>@nineinchnick</code></a> made their first contribution in <a href="https://redirect.github.com/actions/github-script/pull/279">actions/github-script#279</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/github-script/compare/v6.3.2...v6.3.3">https://github.com/actions/github-script/compare/v6.3.2...v6.3.3</a></p> <h2>v6.3.2</h2> <h2>What's Changed</h2> <ul> <li>Update <code>@actions/core</code> to 1.10.0 by <a href="https://github.com/rentziass"><code>@rentziass</code></a> in <a href="https://redirect.github.com/actions/github-script/pull/295">actions/github-script#295</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
72a2c53ac4 |
Fix required status checks (#86739)
TL;DR GitHub is trash https://emmer.dev/blog/skippable-github-status-checks-aren-t-really-required/ |
||
|
|
1a0af63c0e |
Revert "Revert "Replace COMFY_ORANGE_PAT with tgstation-ci[bot] app token"" (#86529)
Reverts tgstation/tgstation#86507 Perms should work now |
||
|
|
8741201fbb |
Fix "Compile All Maps" and "Run Linters" not being required status checks (#86532)
🫠
|
||
|
|
6468eb862a | Fix alternate tests checking (#86530) | ||
|
|
a82fac4c7c |
Add start and completion gates to CI (#86510)
Start gate means we only need to check `[ci skip]` once Completion gate means we need only one status check in our rulesets. |
||
|
|
b8c63da48c |
Revert "Replace COMFY_ORANGE_PAT with tgstation-ci[bot] app token" (#86507)
Reverts tgstation/tgstation#86457 This APP can't override the branch protection rules and is therefore failing to create changelogs |
||
|
|
5caa02e1f3 |
Replace COMFY_ORANGE_PAT with tgstation-ci[bot] app token (#86457)
## About The Pull Request Replaces auto commit signatures/tokens with tgstation-ci[bot]. Also fix permissions declarations for default github token. ## Why It's Good For The ~~Game~~Repo Bot user accounts are an anti-pattern. Apps are the new hotness with more granular perms. ## Changelog N/A |
||
|
|
a2d7765caf |
Post release notes in DMAPI PR body (#85723)
- Change committer to tgstation-server-ci[bot] Also denaturing DMAPI slightly so I can test. |
||
|
|
9940cfd6a3 |
Change DMAPI committer to tgstation-server-ci (#85268)
Better logo |
||
|
|
d1ccb530b2 |
Replaces Auxlua with the byondapi-based Dreamluau (#84810)
## About The Pull Request Ever since byondapi went stable, I've been meaning to create a replacement lua library that uses it instead of the auxtools-based auxlua. After so many months, I've finally got the code just about into a position where it's ready for a PR. [Click here](https://hackmd.io/@aloZJicNQrmfYgykhfFwAQ/BySAS18u0) for a guide to rewriting auxlua scripts for dreamluau syntax. ## Why It's Good For The Game Code that runs on production servers should not depend on memory hacks that are liable to break any time Dream Daemon updates. ## Changelog 🆑 admin: Admin lua scripting uses a new library that (probably) will not break when BYOND updates. /🆑 ## TODO: - [x] Convert the lua editor ui to TS - [x] Include a guide for converting scripts from auxlua syntax to dreamluau syntax |
||
|
|
225562bce5 |
Cancel CI on new commit (#83255)
## About The Pull Request This sets concurrency at the workflow level, which should provide a more concise way to eject if a new commit is entered https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency I've also added timeouts that are between 5-15 minutes per test. Default is 360 minutes without this |
||
|
|
7ca738d168 |
Fixes CI not checking warnings. (#83015)
Yeah. |
||
|
|
42c0dd0720 |
Actually Caches The BYOND Installation in CI (#82364)
## About The Pull Request
Fun fact, nothing ever hashbanged this, so we've been using the same
weeks-old cache which has been necessitating that we use the same old
versions of BYOND until someone cleaned the cache. Let's tie to
`dependencies.sh` like everything else (which we already did in #78307
(
|
||
|
|
49a53b466e |
Improves OpenDream Linting (Annotations and More) (#82029)
## About The Pull Request This PR does a few things. The main goal was to have it annotate the code like we do for `Run Dreamchecker`, which it now does. The code for this was mostly shamelessly ripped from the very same process I just mentioned, but stripped down a lot more for the task. Since I had to write a lot more code to handle the way we get warnings and the like from OpenDream, I didn't fold both into one program.   It works! Ta-da. Anyways, in order to facilitate the code annotation, we need to use a Python script. This Python script means that we need to use the bootstrap, and the bootstrap is best used with the bootstrap cache. I then realized that we should just really fold this special CI runner into the Run Linters workflow anyways, instead of having it on its own runner (since it'll cut into the number of runners we have available at a time anyways). I think it's a good way to save precious CPU cycles on our dying Earth, and the issues are now visible enough to the average coder (in the `Files Changed` tab) to where I feel pretty good about doing this. There's a bit of weirdness and jank in the Python program, but it's all done for a reason I assure you (it's always silly when stuff breaks silently and no one knows to fix it until years later). You can look an example of a failing run here: https://github.com/san7890/bruhstation/actions/runs/8303759645/job/22728427623#step:17:14 |
||
|
|
79244dc11f |
Lint with OpenDream (#81892)
## About The Pull Request Courtesy of https://github.com/ParadiseSS13/Paradise/pull/21099 and https://github.com/goonstation/goonstation/pull/18127 |
||
|
|
7f1b584bf9 |
Bumps up several GitHub actions to the Node 20 Version (#81770)
## About The Pull Request Node 16 actions are deprecated, we need to use Node 20 actions now (as noted by this handy screenshot which spams it on every CI run)  You may see https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ for more information. |
||
|
|
ed06502fb6 |
Fix flaky wizard screenshot test failure, and try to make screenshot tests run more consistently (#80631)
From https://github.com/tgstation/tgstation/pull/80542 Not exactly sure why this only fails once. My hint is that it happens when the alternate tests are skipped from this:  ...though this should still be *consistent* at least. |
||
|
|
f2f859d729 |
Update TGS Tester script for TGS6 (#80558)
Fix broken CI's |
||
|
|
9d6051de9a |
Fix alternate tests erroring when there are no alternate versions (#80287)
It wasn't exiting gracefully because of a typo? here |
||
|
|
bf94b4433b |
Fixes Rust Caching for Run Linters (#80168)
## About The Pull Request Ripgrep got updated some time ago, and that means that our cache went out of date as we had to keep doing more work to install the new dependencies that it has. This means we were eating up another **50 seconds** every time we ran Run Linters. Unfortunately, github caches will only hash to a file that exists on the repository, not anything that might exist after a tool is installed. So, in order to do this, we create a new bash file `install_ripgrep.sh` and also pin the ripgrep version. If we need to reap some new benefits or it's substantially faster (which might not be the case as ripgrep is already blazing fast), we just need to update `ci_dependencies.sh` and the cache should work for future versions without us needing to purge rust caches manually through github. You can view a successful run here https://github.com/san7890/bruhstation/actions/runs/7123029395/job/19394997831 I also did something similar for SpacemanDMM while i noticed it. |
||
|
|
b8fc9b367e |
Icon Autoslicing (#79659)
## About The Pull Request Ok so you know all the dmis we have that are made to work with the smoothing system? carpets, walls, etc. The proper way to edit those is to convert them into a png with 5 "states' it in (one for 0 connections, one for horizontal, one for vertical, one for all cardinals and one for all directions) and then modify THAT, then run it through [the cutter tool.](https://github.com/tgstation/icon-cutter) But none ever does that, because we explain it fucking nowhere. So instead, let's keep all those "base" files in the repo, alongside the configs they work with, and "cut" the pngs into dmis as a part of the build process. I wrote a guide for how to interact with this system as a spriter, you can find it [HERE](https://github.com/LemonInTheDark/tgstation/blob/slice-the-sky/icons/Cutter.md). [Adds a icon cutter build task]( |
||
|
|
71b45e54ad |
Puts all traits in the globalvars file + CI Testing (#79642)
## About The Pull Request Fixes #76349 I didn't know that people needed to add any new traits to a global list so they can be easily read in View Variables, and was pretty shocked to find out many other people didn't know it was a thing. Let's make it a thing by testing it using a new CI Python Linter to check this. But oh no-  There were about 200+ missing traits. Alright, so let's do the following: * Move trait defines to their own dedicated folder in the `_DEFINES` folder. * Split up the traits mega-file into different files, for better organization. One for the macros, one for the sources, and a few for the "trait declarations" * Run the linter a load of times and add everything to the globalvars file, removing anything that's no longer used and figuring out where the best categorization of it is. also minor code improvements. also rename all of the ones that look weird. also fix list indentations * Also alphabetize the lists because it's easy * Move everything to a new `traits_by_type` list, while keeping the admin one the way it is for the time being while we figure out a better way to show that list to admins. * Profit ## Why It's Good For The Game Mapping trait injectors will now work for any type of trait. You shouldn't add any trait via this injector though, but you're no longer limited to coders remembering to add it to that critical list you needed. Lays the framework for a better view variables experience. This work is too lengthy to presently do, but hopefully we can get this done sooner rather than later. we will need a code-accessible way to view these traits for such a framework to be implemented, so let's just do that. Future steps are to break down the mega-declarations file into a folder full of separate files by typepath, but that requires a lot of auditing. Does need to happen one day though, there's a lot of mob traits mingled with datum traits and auuugh we gotta do this later this PR is already massive. there's probably ways to game this but this catches _my_ mistakes so good luck to everyone else (it should work for 99% of everyone) ## Changelog Nothing applicable to players. However, to mappers, the mapping trait injector should always be able to add any kind of trait (which is rather good for the times when you need it). |
||
|
|
35e741abc9 |
Fixes TFE being useless after #78265 (#78433)
I thought `set +e` would still make the shell exit with an error if any command failed, I didn't think that it would just use the exit code of the last command. I am dumb, I'm an idiot and I want to cry. |
||
|
|
0e723b5bb7 |
Removes Sleep Printing Library (#78324)
## About The Pull Request #76286, which spawned it, is dead. Don't need to hang onto it anymore per moth's instructions |
||
|
|
5e1c8bdebd |
Caches Node and Python Bootstrap for GH Actions (#78307)
## About The Pull Request I was planning on doing this a lot earlier but ran into some weird roadblocks, but this time I finally did the research and it's done properly. We do a lot of useless work on every single CI run, and in the interest of saving the world's energy (by a matter of at least 10 seconds per my testing), lets stop doing so much extra work by caching both the work we do on the python bootstrap installation (we literally call it `cache` for a reason) and the Node installation by sharing it between github actions runners. Here's a random CI run on master where you can see that the `Install Tools` portion takes about 19 seconds - https://github.com/tgstation/tgstation/actions/runs/6167104927/job/16737570519 Here's the CI run I was testing with where you can see we slim it down to about 6 seconds for the `Install Tools` step, but with a second-or-so taken to restore the cache since the runner needs to download+unzip the cache. it tends to be shorter or longer by a second at times but i'm certain this is just noise - https://github.com/san7890/bruhstation/actions/runs/6167245722/job/16737919874 On average, we save about **10 seconds** a run on Run Linters, which is meant to be the fastest CI step. Future improvements would lie in making either maplint or the tgui test suite faster, but that would be a much more complicated and code-intensive task. cache go weeeee ## Changelog Nothing that concerns players. |
||
|
|
215a4269a8 |
[NO GBP] Fixes me actually breaking Run DreamChecker (#78291)
> `bash`/`sh`: By default, fail-fast behavior is enforced using `set -e` for both `sh` and `bash`. When `shell: bash` is specified, `-o pipefail` is also applied to enforce early exit from pipelines that generate a non-zero exit status. it helps when I actually read the docs |
||
|
|
a52d901bc8 |
Fix some odd vscode highlighting errors in workflow files (#78274)
## About The Pull Request few errors which were odd and annoying ## Why It's Good For The Game stealing PRs from san7890, they wanted to do this ## Changelog nothing playerfacing |
||
|
|
275b1944e9 |
Split Run Linters step into multiple steps (#78265)
## About The Pull Request Splits the big "Run Linters" step into multiple steps. Also since all of these steps are independent of eachother, I've made them all run regardless of if the job is currently failing. <details> <summary>Proof of testing:</summary> Fail in install tools, all linting steps are skipped: https://github.com/distributivgesetz/tgstation/actions/runs/6151628214/job/16692089726 Fail in Run DreamChecker, other steps continue to run: https://github.com/distributivgesetz/tgstation/actions/runs/6151664705/job/16692203569?pr=2 </details> <details> <summary>Pictured: me breaking CI for a day</summary> https://github.com/tgstation/tgstation/assets/47710522/ea12ad30-2b69-4aa3-9642-7d0818eab2d1 </details> ## Why It's Good For The Game Going through the Run Linters step has always been a slog. Finding an error is like finding a needle in a haystack. Seeing what command exactly went wrong is going to go a long way in helping people find out which linters have failed. ## Changelog nothing playerfacing |
||
|
|
b2dda940c5 |
Replace DreamAnnotate action with a python script (#78225)
## About The Pull Request This PR removes the "Annotate Lints" job step and merges it with the "Run Linters" step above. To achieve this, I wrote a python script that should be identical to the action. I even added the ability to read the output from a file to the script if we ever needed that, but I decided to have the job step pipe the output into the script instead. ## Why It's Good For The Game It always bugged me a bit that we had to check the results for a separate step if we wanted to see the linter results for dm code. I also noticed a few people getting confused as to why their CI failed on linters. Turns out that the action is just a few lines that match the dreamchecker output and reformat it to a format that GitHub can annotate code with. It's so brain dead simple that it shouldn't need to be a whole new step, and for the previous two reasons. ## Changelog not playerfacing |
||
|
|
79a12235a7 |
Include temporary library for getting sleeping procs (#77773)
@LemonInTheDark wanted this to be able to hunt down the progress bar hard dels. Code is here: https://gist.github.com/Mothblocks/06b415afd75672fb03637804435350d2 Intended to be reverted once we figure out the issue, or if we realize it's not related. This library is not stable. |
||
|
|
830c6b7f0b |
Remove merge conflict labeling workflow (#77352)
https://github.com/tgstation/tgstation/actions/workflows/conflicts.yml This thing has a like genuinely 3% success rate it's dogshit and useless |
||
|
|
3d7c9a0dae |
Bumps rust-g to 3.0.0 (#76663)
## About The Pull Request You can read more about what's introduced in the last four versions here: https://github.com/tgstation/rust-g/releases The immediate effects for us are as follows: Closes #76549 Closes #76514 Closes #76502 Closes #76490 Closes #76398 Closes #76798 Closes #76921 Closes #76934 Closes #76950 the updates to install rust_g.sh were to cut down on the copypasta code and prevent desyncs. 🆑 code: The currently operating rust-g version on a live server is posted to places like the runtime.log, in the same place where the revision information and any applicable test merges already were. /🆑 |
||
|
|
616772574e |
Ensures that all Unit Tests are ticked in _unit_tests.dm (#76404)
## About The Pull Request
Ensures we don't get a repeat of #76345 (unit test that wasn't ticked in
the `_unit_tests.dm` file, fixed in
|
||
|
|
44f88e49be |
Quietens Spaceman when debugging UNIT_TESTS locally (#75570)
The contract is removed by virtue of testing. |
||
|
|
8cd0d05ee3 |
Update emoji remover workflow for node16 (#75434)
## About The Pull Request
Bumps the emoji remover action's commit hash +1 to [the current
one](
|
||
|
|
d699d8ce74 |
Improve PR wording so maintainers don't entirely gloss over DMAPI updates (#74796)
 |
||
|
|
78c10df5d2 |
Client Compatibility Check Actually Uses Our Fork (#74514)
## About The Pull Request
In #74364 (
|
||
|
|
e0ac161029 |
Adds CI check to detect if byond starts requiring 515 clients before we want that (#74364)
todo: (i'm going to bed or i'd do them before opening the pr) fork the action over to the org ~~make this more configurable as mothblocks requested~~ ~~add this to the windows build and integration test steps (if it generates a dmb, we gonna validate its got the expected value for client compatibility)~~ ~~test 515 client required fails.~~ https://github.com/MrStonedOne/byond-client-compatibility-check --------- Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> |
||
|
|
f9d9555aaf |
Add test suite that just checks for if alternate tests pass so that we can require it instead of the specific tests (#74380)
Right now alternate tests cannot be changed without also changing the specific name of the new alternate tests, and existing PRs will be broken. This allows us to change the names without worry, as we mark *this* as required. If the tests fail, this is skipped, which does not count for a required test. |
||
|
|
98c02c8454 |
Updated elgohr/Publish-Docker-Github-Action to a supported version (v5) (#74370)
elgohr/Publish-Docker-Github-Action@master is not supported anymore |
||
|
|
ccef887efe |
Lints Against Unmanaged Local Defines (#74333)
# MAINTAINER - USE THE BUTTON THAT SAYS "MERGE MASTER" THEN SET THE PR TO AUTO-MERGE! IT'S MUCH EASIER FOR ME TO FIX THINGS BEFORE THEY SKEW RATHER THAN AFTER THE FACT. ## About The Pull Request Hey there, This took a while to do, but here's the gist: Python file now regexes every file in `/code` except for those that have some valid reason to be tacking on more global defines. Some of those reasons are simply just that I don't have the time right now (doing what you see in this PR took a few hours) to refactor and parse what should belong and what should be thrown out. For the time being though, this PR will at least _halt_ people making the mistake of not `#undef`ing any files they `#define` "locally", or within the scope of a file. Most people forget to do this and this leads to a lot of mess later on due to how many variables can be unmanaged on the global level. I've made this mistake, you've made this mistake, it's a common thing. Let's automatically check for it so it can be fixed no-stress. Scenarios this PR corrects: * Forgetting to undef a define but undeffing others. * Not undeffing any defines in your file. * Earmarking a define as a "file local" define, but not defining it. * Having a define be a "file local" define, but having it be used elsewhere. * Having a "local" define not even be in the file that it only shows up in. * Having a completely unused define* (* I kept some of these because they seemed important... Others were junked.) ## Why It's Good For The Game If you wanna use it across multiple files, no reason to not make it a global define (maybe there's a few reasons but let's assume that this is the 95% case). Let me know if you don't like how I re-arranged some of the defines and how you'd rather see it be implemented, and I'd be happy to do that. This was mostly just "eh does it need it or not" sorta stuff. I used a pretty cool way to detect if we should use the standardized GitHub "error" output, you can see the results of that here https://github.com/san7890/bruhstation/actions/runs/4549766579/jobs/8022186846#step:7:792 ## Changelog Nothing that really concerns players. (I fixed up all this stuff using vscode, no regexes beyond what you see in the python script. sorry downstreams) |